From nobody Sat Feb 7 18:20:51 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 490D73D9046 for ; Thu, 5 Feb 2026 13:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770299608; cv=none; b=LgXD7AzV7jUFyiqK/4FQ25MjRsF9T6/Rk4CNXqPOLoDSzhADXL4weXiQ/NKd1hNUfijgBQqrnIhYhuWCn4lvlzz7w9UK/ZkY+3mvpVx2urTjebaDreCL5KUW32wlmwrw+X8jxDyIOmL25Mh+eTOTUdMyk6wZW6qJKsF4yIXRnmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770299608; c=relaxed/simple; bh=eLdJY5LzD0R48n+KWjg0ZTjc8vtgnc06t8anjYdR/cE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nsLwCnvIlqBEa2dlvkh0u+eEwviK/U1YMViIvQrSVNlzISossuldB5NfecmfkCffH26ZzwVLQxI+mwkLREs2Gmj2yA4XaNqQns0JvjD6boMkaj/L1tTIxVcjG2biNvD2YU6afsSnwI9pquUr3f6G4ZOPEBADVhMDlqX+r3mOfbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cP/PgPU8; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cP/PgPU8" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-823f9f81da5so542817b3a.1 for ; Thu, 05 Feb 2026 05:53:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770299608; x=1770904408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=G67yzkdvTRO2cFHYjLbr/NtY4aKeltlmQbsZf9oJ+Ks=; b=cP/PgPU8E8CM9ZTn39fpITzeNGX06JASbSHHs6sQO+fGYH/S5KJJZXR20D/wpDjPzY AUdQ/Fu6pjdyyVow5hta255fdzMNpHV3Ad5oA+zHvr20Kvw6+P16tM2x5ppVonfRaBut L2lvihZOLV2PXw4eWahl5MzDOo43Ndb7cN3M6fqiP6D9CK9f5/M5yHaJwHFgi/sw1Wli 3cJx/UOQT6Tchb0LYA1mTG9qkJesidrrCb+3pmMdxPUcdqFUzH/YqryV9xhYUSJHLMio 0NCiQfXdsQ0cG77yWO8Zhgz1lKFWUFcB/eLfCXe0Q3FlWcMxrqFiVwdq2zjOPxqi6fcr N+yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770299608; x=1770904408; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G67yzkdvTRO2cFHYjLbr/NtY4aKeltlmQbsZf9oJ+Ks=; b=kGo58xc3td+9vX6+mYcvFZvfb1PW/g6HKQOLOqCwqYFxFM/bGbA8TLWE87yTAPqzgH gIN7fEU6NxdPJ7KIWP4GUIJzHwlamI8kUXz166mlhKCN0ejEzGpMvY1glV9ussOottMt G2u7Desl3oCxcnUYd0xowaIjN5VBdr84Za8Od7ZmlJXyjbeCmsnBxQx/5gv7h9EbtagI bslYBgSpCNPL/yxWzlTqSUy3YNFpP8ZTN8hS4ktCYlCdxIcZoF+xcZZWlLdrCiTgtOen xCMdlI850PXWd8UehrNpIO+nX0/oNK36T9LLz8Rn30QCaGXqrFNyoeZyeBvp7pSV1Fy+ nv2Q== X-Forwarded-Encrypted: i=1; AJvYcCVb3cjTsOe2QdyD60WDySuGUw/m2lV3AqMZLt6S0wT5dgzI/jJxZ+beovRXjm5JvmRT2PGN+omPMP2HkLM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8hwvwg7EGfWUxpvRyRGaDamahc9yCiBgkP/fzer4Up1rPXfCy IOFS2IReXTjXeapm9h4c6XnLYttuRV20mRnUJ7qPuietGMwMhXYPQ3qAtxmyGogYn9lFMQ== X-Gm-Gg: AZuq6aKC1DRR0R+Rpg/QPpeBUTrPP5Ej/+hPx+mgvaUlXX74WStlxhnbn/hlcRa/tOW AKPth5ZpeJc7QthjelwIQi0EnbWYX2ayPeS3vTUJcE8OFjeVQhD5crMDaALoDRqq1166qzOV+n0 F6Bsj8U5SZ4AtjcuAW1QeKI85y7/24ze7V2Y6QwDEfMWW4SS/qzrMYJOrMtGLxP4KpYw2JXeVEK jDMPe19f/g/dT4yXsg2Pnz8mn9wYRHfDGfIH+3F3FnHhIrXTPjH/8o7cBAp+Rsmj0PcS05KDKRe tmvDPy3oRRsXi75ugdzmb5VD+LELGUqjwOW4EVJhrWM/M8Wlm12ag3jYXkw75/gfrPBIXXHajbJ 24L00g0Q1TUFr8QzXKAgM80sOL5v7wVwDJ3xeedyVixcBEl1peDNniNGhhXxDAoe7AIZ0heFlEZ Sg+iEVLP2odfPpcmJ50wWIL+SnLUIllXstWU/P X-Received: by 2002:a05:6a00:1485:b0:7e8:4398:b369 with SMTP id d2e1a72fcca58-8241c68909dmr5883516b3a.60.1770299607494; Thu, 05 Feb 2026 05:53:27 -0800 (PST) Received: from DESKTOP-ILBT5MC.localdomain ([175.152.118.238]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d435128sm6016847b3a.38.2026.02.05.05.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 05:53:26 -0800 (PST) From: Qing Wong To: Andreas Gruenbacher , Bob Peterson Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, Qing Wang , syzbot+e57495fb65020ac7bca4@syzkaller.appspotmail.com Subject: [PATCH] gfs2: Fix memory leak in gfs2_make_fs_rw() Date: Thu, 5 Feb 2026 21:53:18 +0800 Message-ID: <20260205135318.5346-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Qing Wang If gfs2_quota_init() success and filesystem is withdrawn, need to cleanup by gfs2_quota_cleanup() to avoid memory leak. Reported-by: syzbot+e57495fb65020ac7bca4@syzkaller.appspotmail.com Closes: https://syzbot.org/bug?extid=3De57495fb65020ac7bca4 Tested-by: syzbot+e57495fb65020ac7bca4@syzkaller.appspotmail.com Fixes: 601ef0d52e96 ("gfs2: Force withdraw to replay journals and wait for = it to finish") Signed-off-by: Qing Wang --- fs/gfs2/super.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index f6cd907b3ec6..efa0e2452bc7 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -147,8 +147,10 @@ int gfs2_make_fs_rw(struct gfs2_sbd *sdp) } =20 error =3D gfs2_quota_init(sdp); - if (!error && gfs2_withdrawn(sdp)) - error =3D -EIO; + if (!error && gfs2_withdrawn(sdp)) { + gfs2_quota_cleanup(sdp); + return -EIO; + } if (!error) set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags); return error; --=20 2.43.0