From nobody Mon Feb 9 04:07:59 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E5C3A0B0E; Thu, 5 Feb 2026 13:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297169; cv=none; b=DzJbmqmDp+g5IoKOjEJdzsgRtL380zbxSSvFvNECnX+69eWNRMEYMyWHlUQeDOJjO2CyOrolSN5H/Fm1aSw7d3OPgdy1WDEnBBxkhdoEZX3bKNuqi2zleHV7rfzJyP2ysVHNVTKzdThwX1LpTgiLFvYl28kbCN5mQ0sXGPdfZqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297169; c=relaxed/simple; bh=/c7HVVnHddzcq8j8oLWvARrJnqprphShQiAUeRe8t+o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nKx1QL3ja6WKwV9NQH3VNRaJIYB53DEGzMhu6irtqLZFWfTBEtP9ybd7in1yd8vMhbTpx8TSB1kMZIWIRXXmTs6FFunJE0xO/6gaWD+QUYxcERfFfnEPsr2fQJ6/4xGFuRHxpFnhbqi8gRuLYQpmRC/4tEYBcOYi2Ux6y+n8v2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=SPzeiZbq; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SPzeiZbq" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614MbsKh1792231; Thu, 5 Feb 2026 13:12:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=5bUrS 2pO99877gx2Hcblau1sxSm7LFJxG5ZggOTZOXo=; b=SPzeiZbqAqkuVaxAwJOo5 Cgilw/JBYoA79Oyrx7chxHfBSsAQviuAUauhsWay69zuy761ErvVo+IIJarIqWbJ +tYHOQ9zU6vhy2vLFiSP8/kGy9Bf4R6/+uWZy5I30K7D5BrNw3zj8oyePCtiLLhW kN2z5pOIu8LT4/lmsCf0gDxJZ7WpIjBIGBxq3Dn5xD5y4oam/Ib+89coRSSXJ9+K N91Z4+qhYPdU5Q3TDPqDbDDCDYHQKeP1Zd6Uu3zCD8ds5RBK55yt2ma3IOpWtJln y+QfPR53OBOKWFbyptYnUmLROsZW14iJDCATRXR62Rgfp1xb0JzRTUqTyzEWJMu7 g== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3j8ukr0j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:42 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615BWRuD001253; Thu, 5 Feb 2026 13:12:42 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55ck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:42 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbDv038070; Thu, 5 Feb 2026 13:12:41 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-2; Thu, 05 Feb 2026 13:12:41 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Gustavo Bastos , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v5 next 1/7] iio: sca3000: reuse device pointer for devm helpers Date: Thu, 5 Feb 2026 05:12:07 -0800 Message-ID: <20260205131234.3244467-2-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-GUID: McCLQLjsV4BJIAMotUucIzHaacMsG7Qs X-Proofpoint-ORIG-GUID: McCLQLjsV4BJIAMotUucIzHaacMsG7Qs X-Authority-Analysis: v=2.4 cv=BJS+bVQG c=1 sm=1 tr=0 ts=6984974a cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=Y1h7d2OGzECVDNLjVKIA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfX8Web8d1myW2T lEyqZoFYztjZwCMV5tDWjaF6dm38h3Wp3Bm8PuQB4IELc2fLNuYg27TLkjIPiuBWvJLurdXoCEN CSH4WNAKzWugZL47LVyYTVstkfqoQTohmYLqMIpoV8GyUDmakMhly79J5YTX9QHWQtWvisF7pFv HAVVRIlgm/Wkf2gRYYNhL7LIv0k0fHr3VfpnQzQrm3ed0wjQQbEkDNVmWOgr+2oqOEP0zvp30VL p3iKMSbWq6dL4rS9ULmvbn9copeu7hZnpy4uMM0UgacW4kr5hp6Os/+T+ZkE51cLmt0ZWJt+FGx RaDA40rQncco+26VNYaKjkrVgo1xI5N2KUt+iI5WIDFckcLTETYBghS7Q/LpgGdCOgKaexHdnaB AddA/yDflCwQKtxUHp9uDhyvfgCnGNiUbWxcVs0aAxIwoThI4O5kl+1Ce+PuhzbQZ5CKOn8wSLj SAaypHAY4lcMc1898KA== Content-Type: text/plain; charset="utf-8" Cache struct device *dev and feed it to the devm helpers to simplify the probe function. No functional changes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- drivers/iio/accel/sca3000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 4a827be439a2..43373c798714 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1437,11 +1437,12 @@ static const struct iio_info sca3000_info =3D { =20 static int sca3000_probe(struct spi_device *spi) { - int ret; + struct device *dev =3D &spi->dev; struct sca3000_state *st; struct iio_dev *indio_dev; + int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -1464,8 +1465,7 @@ static int sca3000_probe(struct spi_device *spi) } indio_dev->modes =3D INDIO_DIRECT_MODE; =20 - ret =3D devm_iio_kfifo_buffer_setup(&spi->dev, indio_dev, - &sca3000_ring_setup_ops); + ret =3D devm_iio_kfifo_buffer_setup(dev, indio_dev, &sca3000_ring_setup_o= ps); if (ret) return ret; =20 --=20 2.47.3 From nobody Mon Feb 9 04:07:59 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D233A0B0E; Thu, 5 Feb 2026 13:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297173; cv=none; b=BFFSbtZuflFU1Lbc5rcDmj2KGtk5F+oHK8JqTflxim+YNkG6fBKvldoQzWE4IDf2PK/08aQyfcF2jxJuFS3uCgKpJUG6NQD+cy1VzjKHKSpdnqdgHmytVndBnF6054KUvBf6M0ODxCakJ9bJbusxGBhE6WHlATj9NKdfywnxIek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297173; c=relaxed/simple; bh=PKTSE3mYh7OcVloe0t2U9BCpsNY2T8x6IgOpbCDGueg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jyqu2E0i//hmvM8RJZ49WP9jCv8s7EGwyJut2kE20vCELemmm2/g2ybM8oEZ9w32dj9hviPlLvyP9CIETFGDP4b00q64KhNsYk5NVtswDjyOD/j6ZsTDs2hu6EMx3FkMeNOtpCc82qGr+DxzQ+JnuE/gGDMUOpmJ+RsjuI4h3Ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=SnNbETtt; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SnNbETtt" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614MhfQ11789564; Thu, 5 Feb 2026 13:12:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=FFC9F vXA6JpOGOmBvUIMQykozeECIB4FNKsq4LYaTIQ=; b=SnNbETttcoPln80u+exo9 rTpRliXLEiJt7qYHx3XzIjRfi3AgL6a6mDw0B/x08WpDr47hlH+1t4YS9764POiu AnihegQQP4yzZYiz/50fsKbVcXHog9VwjfVXRoHVHNQSZ5KRD5MBaI+o8WsMwqNu XE9JQoYB7eRTnIKZ8bE64o3if1wFbvSUq92DvbrIzooTNdkVR3uUpYKZgpwM/bNP 0P2UkJQUBUl0mZLsKl4eiRYWsQYoSrEGYhLw7wQIKhXYDVD2O85Eq8fsnSRVBz+g zEveDPuRf65VsDcVtEGrvLP2FGFlOe8nGuZq8z25SxZhsV464m8PmihbRWiIfAPH A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3j8ukr0k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:47 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615B7Oc2002721; Thu, 5 Feb 2026 13:12:46 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55dq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:46 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbDx038070; Thu, 5 Feb 2026 13:12:45 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-3; Thu, 05 Feb 2026 13:12:45 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v5 next 2/7] iio: sca3000: switch IRQ handling to devm helpers Date: Thu, 5 Feb 2026 05:12:08 -0800 Message-ID: <20260205131234.3244467-3-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-GUID: 3bxyNQQf_Rlhr1cDvFPeCQC2sWNlWZnG X-Proofpoint-ORIG-GUID: 3bxyNQQf_Rlhr1cDvFPeCQC2sWNlWZnG X-Authority-Analysis: v=2.4 cv=BJS+bVQG c=1 sm=1 tr=0 ts=6984974f cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=IpJZQVW2AAAA:8 a=yPCof4ZbAAAA:8 a=GLDwehOdoewJnJclP7YA:9 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfXzbQZ+W8MmwSz pIKBTHWmZSDLoUO/UXdj0Mtj6oqE2jRm9knV9eqpmYnRqRAdErChUO/qVjBLQr5lhOOmkkqwcIF 6IHAIE6pn3w6iQ7RVyH8KvoRSaWD/RFASI9ka1sDunsi43ogmzDmv0uJ+H0o/LLTlzuSslOiCPQ fqUGfqaww09mKkKNOfeySG3GmRs4MuW+ARZ6IJloTie+/s1aUK7p5rhnrKU7Znu+ty3uIDAawF5 f6oa1ks0iOZ81Z2gWmJjDPTdSlLDIfkkyVJXguMV7OsQ60g6dQMWDuyKHSN3ZNn1RkyQn7ofHis 8Mqxi0+BucRltI30R0zJinrahQPPKVkgau0rvt8gf/MJlz9NmVRwVjJuf6uBUNKE/lsCHLa5eb1 tUfyHpvxasTwJCNqsfBm+JxOwqef0C8BsgYt8/Q2PsJuEk6aTLJFuc2NhtP9pZmZoDe5P+lyYFn uY6o+/Q00dJ1IT44gYg== Content-Type: text/plain; charset="utf-8" Convert the threaded IRQ registration to devm_request_threaded_irq() so that the probe and remove paths can drop manual freeing of irqs. No functionality change. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Reviewed-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- drivers/iio/accel/sca3000.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 43373c798714..e270f445bb35 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1470,34 +1470,27 @@ static int sca3000_probe(struct spi_device *spi) return ret; =20 if (spi->irq) { - ret =3D request_threaded_irq(spi->irq, - NULL, - &sca3000_event_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - "sca3000", - indio_dev); + ret =3D devm_request_threaded_irq(dev, spi->irq, NULL, + &sca3000_event_handler, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "sca3000", + indio_dev); if (ret) return ret; } ret =3D sca3000_clean_setup(st); if (ret) - goto error_free_irq; + return ret; =20 ret =3D sca3000_print_rev(indio_dev); if (ret) - goto error_free_irq; + return ret; =20 ret =3D iio_device_register(indio_dev); if (ret) - goto error_free_irq; + return ret; =20 return 0; - -error_free_irq: - if (spi->irq) - free_irq(spi->irq, indio_dev); - - return ret; } =20 static int sca3000_stop_all_interrupts(struct sca3000_state *st) @@ -1527,8 +1520,6 @@ static void sca3000_remove(struct spi_device *spi) =20 /* Must ensure no interrupts can be generated after this! */ sca3000_stop_all_interrupts(st); - if (spi->irq) - free_irq(spi->irq, indio_dev); } =20 static const struct spi_device_id sca3000_id[] =3D { --=20 2.47.3 From nobody Mon Feb 9 04:07:59 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5561F3D5240; Thu, 5 Feb 2026 13:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297177; cv=none; b=LmhCjPpDF9OLPIFwSvOGEbH41B+b9WkRf9lyBuy1BmFCZT6tdpODVafnap61RA2fJNMaGWQfVVSnAO5JUVlFRYqejX09sDVWE3p+EsVqQ9tVZjZ5SLH8r/VzD78f3OSpR+o/hrmXpMin3+8vU4J0Bz/qiKSy1G4xmduch92LYBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297177; c=relaxed/simple; bh=aRHGEchsrEL+5HVeSn0ufskCcn+c2gzI3wr1TKJraTU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SVznCb9qAkE37n4RImLjsICV4nFzqXp5OhJ5zwIzjfY0rFUA9t1zmAoYD/3mMVCaYCmlc7lw8Xow9ynC/vkVC1i0HrLSHFwAPAHXasbH8gH375JBhW7r4dqJb//hcwjB/MGSbCYdHdU7TbC7z6CO6D6zI7/kc9tUP305Wdms3Ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=sgLafxXV; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="sgLafxXV" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614N8gnh2146435; Thu, 5 Feb 2026 13:12:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=9/pd2 3imdSHDCAK62OCHdfA06OkCtfpiJyqLGR/XsN0=; b=sgLafxXVibhgNVoDmLDOK Wq0fR0uDaXYg519C8bGJ8mFsU+pKeo6AwzYA/B+LFEUShhCW//vyWBm5QMCpOGnz uZuGAs8C5u7bMp9MM8uLl7adr8n1jUXp3LbM+RVn+unCS/nyis5AnRzOkKuDCH41 vk99yJtSB71F30S+KEsLBP2ZY9sxL0eTUR50juCVue6/M2IG+E7p5MGWx+xM5Pqn DcmspR3eCa+vYYxezLuHVLQZR9ZLxyABTkbkr4AyaT3iCllpNGy5zzY9kN8LCU7K ibHGVcCt3z+EN8eYxiEY2CyhpYaIUEmboXJ65Na9CnNtaKw2ccdf83UxWqhppf1u w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3k7ukj7v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:51 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615CncN6001247; Thu, 5 Feb 2026 13:12:50 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55fj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:50 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbE1038070; Thu, 5 Feb 2026 13:12:50 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-4; Thu, 05 Feb 2026 13:12:50 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v5 next 3/7] iio: sca3000: Move sca3000_stop_all_interrupts() above sca3000_probe() Date: Thu, 5 Feb 2026 05:12:09 -0800 Message-ID: <20260205131234.3244467-4-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfX5Qzxh02OoFLk wWExV8NMbgFnkTpbncC7qVbBloFMEjLus0Zjso6InoVvzmFVX56YOzskqVCnYdoIU5b90SKHjoq 7TL9DdC8YjwahN9/IwnifI1+54go4EOl3llztMAnmFRaJi5aoNkjwQbSzG4DzQ9TS/+rynNdn6z uouzXa8YdXtxcppaLvIZCpoF9FmuRtPEUx97D/Ffb2Rv1os+1lFSFVq6hGeXSLpLfxQ7EAj7WbU May2WKpBUUtMJW0RAi89I5BZ9XpOlnnLt25KayeuyL5TOcgBYzL2rgxDd6yqNIUadQqnFokfMFV AdEZGledKSLXD4g1Ehe/Pa5Qtt8mJ7YNew3DoWqeUVTUY0JCiGZWxXL8sIgUa1QutgOeRTPMhS8 2G7Gw6BajPqaxqJIFE1wQtbTKPLjLcBj/kHjS1GueptTsdVvAaQje2Z4xPDzkDYxe62QPD/KdHV QuGPZIW/JToQzyarOug== X-Proofpoint-GUID: Mu4Rx4xPG3wymO-cpN0DKVuoGkvEhNON X-Authority-Analysis: v=2.4 cv=Z7Dh3XRA c=1 sm=1 tr=0 ts=69849753 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=lATyolU4PqpKJ5i4NuAA:9 X-Proofpoint-ORIG-GUID: Mu4Rx4xPG3wymO-cpN0DKVuoGkvEhNON Content-Type: text/plain; charset="utf-8" Move sca3000_stop_all_interrupts() above sca3000_probe() without altering its logic so the next set of patches are easier to review. No functional change. Suggested-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- drivers/iio/accel/sca3000.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index e270f445bb35..53628a0ee50a 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1435,6 +1435,24 @@ static const struct iio_info sca3000_info =3D { .write_event_config =3D &sca3000_write_event_config, }; =20 +static int sca3000_stop_all_interrupts(struct sca3000_state *st) +{ + int ret; + + mutex_lock(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); + if (ret) + goto error_ret; + ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); +error_ret: + mutex_unlock(&st->lock); + return ret; +} + static int sca3000_probe(struct spi_device *spi) { struct device *dev =3D &spi->dev; @@ -1493,24 +1511,6 @@ static int sca3000_probe(struct spi_device *spi) return 0; } =20 -static int sca3000_stop_all_interrupts(struct sca3000_state *st) -{ - int ret; - - mutex_lock(&st->lock); - ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); - if (ret) - goto error_ret; - ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); -error_ret: - mutex_unlock(&st->lock); - return ret; -} - static void sca3000_remove(struct spi_device *spi) { struct iio_dev *indio_dev =3D spi_get_drvdata(spi); --=20 2.47.3 From nobody Mon Feb 9 04:07:59 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E8DC3D5256; Thu, 5 Feb 2026 13:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297186; cv=none; b=qa/i54dWOMQx0EzS+Ck/psSNEb5fdLORoOifQ7hT/7AZa6S/DZdLfn8Pzxc3TAM4wQDdGslC1DgX8/8nRFTWitANA++AsDHnAUv8/E+NOfIAjCs+1w2F4fHvfOIS/1XnNup5TzVlN+jLzbbKjNOAx0i/3a6+U+Vzfn2ePqO0F8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297186; c=relaxed/simple; bh=4zDnrqdzDpHCZ4wS99ZfZ6BE+dR4TcsTQ6RIUArG348=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bgjA7gEgObTvKGBtLs9pSbmxz+0VJLVcNycj8mIO6ElIviqNVsqqS5QyWVmpU0y/tEgSP5jL9E2qjxVi/xSd65Iq27k7aq4P/ZeMLgrDsjJocG/eubCH90cfVUS9OeuLnNQzvmBgW8Z2Bp1C0E97BJBnye6SHSO6DWAJnRWHzVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=irh7yJsg; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="irh7yJsg" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614N0ECK2453214; Thu, 5 Feb 2026 13:12:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=ciobe DaYHPYvk0AvQJsYbx3h4uoJn8Y9lcrRuMAn5mM=; b=irh7yJsgmFbJhnvcfdxQr wzAQVkHIaRYaMtVCTVQ3qC5ygHr0RvyYX9+1qkViyehUZJi18xCKMvKjhiAsXLTV kafLqF1TXb6918ZfeO5q+j1WN3V9i9XoMNYSwi170S+L6GvQVqABrXmnNSPnD2Ys Q4ZZ3HbFgEKQdoetBnHhMOa/NP2TR9iXoN3aFITooBnx2r7B7aX84/aEEHNj8RFl oeXvgV2BHkP+v9+J012AHZQWB9dl8NIKq0UQgxm9bNpJB6nHPF8s6fnOcr9Th9Pn 4zdLdNCtMMIpFUWV7ifNVi9ZzGxx8tZX/HuQjQN+B5OvhQUN3X3H1zFmtoSQNzu6 w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1au67py7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:57 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615C5t20003367; Thu, 5 Feb 2026 13:12:55 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55h0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:55 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbE3038070; Thu, 5 Feb 2026 13:12:54 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-5; Thu, 05 Feb 2026 13:12:54 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Gustavo Bastos , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v5 next 4/7] iio: sca3000: make stop_all_interrupts() return void Date: Thu, 5 Feb 2026 05:12:10 -0800 Message-ID: <20260205131234.3244467-5-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-GUID: XQ3xqDcJEpxZ8cmlcNkE5T-iehKUQK4U X-Proofpoint-ORIG-GUID: XQ3xqDcJEpxZ8cmlcNkE5T-iehKUQK4U X-Authority-Analysis: v=2.4 cv=Nf7rFmD4 c=1 sm=1 tr=0 ts=69849759 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=3J4RJRd0aDoy1oOJd4IA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfXyLzrHfnmM5dL +It8iELMLw1fJszK+11EZ6P6WqwD6nB0ywuFBmp5xn5R3spGWv3lxIuCOuXTA1fUc0jDU2kq8Pu bmAFs8NJWSuQZH5wT6zzzGCIEhmfcXsfg1QoN/uufBRzdHdzhWD/WMYkoHPCudpuNaywiQMCr9R KvQgDhcxmw78O7BA0K7cyGHGcdkjbIFD2TSF0uOMe68/JSeudc49Ct2dj2zTDR7YR22rem39Wv8 jcV0zYOs7cDNv1MFYsnQsRq7niGjWy9+h4PhHJHMYKOR8OJZIj+LXJASeDloCikj+vPgID7bs/P dqW25Qz+mQJAuK/coTSDmPCtAVO/2LLyzN+u3tf4wighm8c1LnW0ZB5t8Dz/UtY+Q8cJgUOWbVD vaeuzPn6usfPo4ulvx6/pHZiAT9asPTy50LJt4uNxJutTehG6+7KkxsVlZ1lqHuMmDH9vnblT0k PikOGJhzrZPNwqJs+aA== Content-Type: text/plain; charset="utf-8" sca3000_stop_all_interrupts() is called only from the driver remove path and its return value is discarded, so convert the helper to return void. No functional change. Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- v4->v5: Keep the label unchanged as its all going away in next patch [ Based on suggestion from Andy, thanks Andy. --- drivers/iio/accel/sca3000.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 53628a0ee50a..d3e2a981874d 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1435,7 +1435,7 @@ static const struct iio_info sca3000_info =3D { .write_event_config =3D &sca3000_write_event_config, }; =20 -static int sca3000_stop_all_interrupts(struct sca3000_state *st) +static void sca3000_stop_all_interrupts(struct sca3000_state *st) { int ret; =20 @@ -1443,14 +1443,13 @@ static int sca3000_stop_all_interrupts(struct sca30= 00_state *st) ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) goto error_ret; - ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); error_ret: mutex_unlock(&st->lock); - return ret; } =20 static int sca3000_probe(struct spi_device *spi) --=20 2.47.3 From nobody Mon Feb 9 04:07:59 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918803A0B0E; Thu, 5 Feb 2026 13:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297186; cv=none; b=cppDPPfgBXHxplQa2W66bVXSr8RUtEv3sXm/tsdbswFYZ91Q2HlFdlUsGS1anbXlp8jowbaqfHbGpxv+2/0wXsFrcHrYuMcjmfV6WFrsJKRWBO/eIW63+eN1loUlu0gcx3u48p/4Pz/BJg44hj8qyHnsvpTDTITStSlBP379QcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297186; c=relaxed/simple; bh=/wPUS9cV0xqKTOleYUNuY2F/z6GSIl8yw8SIeK9LpXw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TnQcYzhHbwiPgZve7pfs0t1R0Tl5QvAfB0a4VEMoEQVx+1a2J1gizxhA/cuVhJEdjlUiTt/bLyuFbMxObCwtolExHGEFO0XEWjcTZuDIh2zu/4Vy+V+ZYypkWcqCKGpdXoS8Za/3p7O1DIoI/dfx0ILA21WxlLwhFT++GLrGWbs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=SGnT7CgE; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SGnT7CgE" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614N3dbZ2453313; Thu, 5 Feb 2026 13:13:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=lbzuF Uxr7CiMmL/KovieMOXKVrXH756GzhPXX2pCYzw=; b=SGnT7CgEy/MkwNo9RMt63 6MVR+1aVdu4Om5ELSC9jkzzlScRT+gSG5YZN5M7/10KXvtJ1gl1OtCY6WTs0+a/R Z3Grs4UNPwYjNCHm+0We8QW4vv0MQrlMBPqy2dMVEYbsNPb4hvhZFUF1kyAB5Rn0 eED86j7OLMRzynmlQCrJg9TdDE7uy/xc04o36E+TaCjgDFmbPjuZnuo+ni/lh6je TdGZIox41630pvVXKfYpfrTuudKC1IY8GM6rKkBxOKVeGvHM4+qNlxzXaQWoHjaM qNL5eCFGH+/3B16A0RKpechbxIkakqUQR0V6uZWh1Nwnh4WY1kpKSoZR5Rr/b5nd g== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1au67py9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:13:00 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615D3Tc9003605; Thu, 5 Feb 2026 13:12:59 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55j2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:12:59 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbE5038070; Thu, 5 Feb 2026 13:12:59 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-6; Thu, 05 Feb 2026 13:12:58 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v5 next 5/7] iio: sca3000: use guard(mutex) to simplify return paths Date: Thu, 5 Feb 2026 05:12:11 -0800 Message-ID: <20260205131234.3244467-6-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-GUID: t2HiztFU7m9-zKSsSdgI1MitY6deIiym X-Proofpoint-ORIG-GUID: t2HiztFU7m9-zKSsSdgI1MitY6deIiym X-Authority-Analysis: v=2.4 cv=Nf7rFmD4 c=1 sm=1 tr=0 ts=6984975c cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=Fb_YtQGqNHn76Ybc1w8A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfXyMCjBIEH41be 3n4SynP1Vp1oUBAbEjroOi/RLByyp8Ls0WQKhADpDAfHiAN69VMZTA8RIOwGjk42IyhlX3mpKk8 lW9VMaQFaIhfod5BLh8vVOHDTsPBMmpSUsxbdT/2uUfDa+XQGms8LbUzFVQy7WliA4t5nGCnXUd J8yOV+22qPa0culjMM06qM5ot1JFGHTBHaA4CKD1Efw7GotDL4RIIGbkYX4j6RvdsO95BRJBDYk rI44XIddLowvt7eMHB5cqmagyS46WUp1vWzfEiAFWxwcYs8kCyFiJT3dJ72gbUG4vzAotK/kG0j b6gDRjqwStG4Y+8OGl3TcI9YJiii2eyKfbeWNvRdMXjieooaoMMLuAAfthi1ZGO+aQLqXgBlSH+ zrNfVrdF7zg4e0IYPXgYSz3VVCE1xsRLy27BCiMJO8SwnTQu0zaPK/IKWb5Thu1ROW6mH8N+edi jtOHgY3o6donO46wG5Q== Content-Type: text/plain; charset="utf-8" Switch sca3000_stop_all_interrupts() to use guard(mutex) to simplify the error paths without needing a goto. Suggested-by: Jonathan Cameron Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- v4->v5: rebase it accordingly as we didn't change label "error_ret" in the previous patch. --- drivers/iio/accel/sca3000.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index d3e2a981874d..56ff646684c0 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -7,6 +7,7 @@ * See industrialio/accels/sca3000.h for comments. */ =20 +#include #include #include #include @@ -1439,17 +1440,17 @@ static void sca3000_stop_all_interrupts(struct sca3= 000_state *st) { int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto error_ret; + return; + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, (st->rx[0] & ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | SCA3000_REG_INT_MASK_RING_HALF | SCA3000_REG_INT_MASK_ALL_INTS))); -error_ret: - mutex_unlock(&st->lock); } =20 static int sca3000_probe(struct spi_device *spi) --=20 2.47.3 From nobody Mon Feb 9 04:07:59 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514953A0B0E; Thu, 5 Feb 2026 13:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297192; cv=none; b=Wy/5TtwFFa9Re7Jh4tCKgkmXzKDtqe2uSGvz0/02zz8lIiSxDEkrRNPAcJWPFEulh56K044Ica5OT/DHC/IyoAFo58mbnG7+YngQGMVy+KHsoPncFKrNq8YknPenvp2KwQ4WFxyGYRPRtMK1vCcFHw+857lx317T8ceJMsDh3ZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297192; c=relaxed/simple; bh=cqx2EVfWHXbkjp/7PC0dXNOUYZ0rTWtw4elZE54WjUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bsDAfVehpoSL37ECYpJxpm5fW/VEZi9KhoukwPXWWnE+1ntyWBZmkWfznYQDtR+Xamh7/I3nXY56skh0z8G7n7Rh4+8q7ffzOT7eZgqNV3s3w9OU2TkPE4fuVJphx9mtrBeL3dhgk6CjMC8hFN3jt6Hh7/6BdmnkZ4k20A372Bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=YSnoWE0k; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="YSnoWE0k" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614NGfYi2453238; Thu, 5 Feb 2026 13:13:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=xPkAT GQtIoyKWOdZf6accwcFRfJmM/Cqq4uijf0YxXc=; b=YSnoWE0ko3lsWjkrtBuDC mmQrakIJR7TzXtXoAqIwIYUQ8AO6ZeOM4vIK0yZ6bDpXO0YCWU97qEEzeYHS/GHj 18rd2/rrsC0vD4tzihu5yq1MeAhSDeaRYeRmGN5m4INF0FSZzgs2JVWDP09Yzmf2 38qENylUB0xlA1opKcsVWBKWBY/BRkVQztoztnLSIJqnud7F0L1CppDzTIbAwDg0 qkXEXWOLVAi6Bm4X9rGD6XkMFLKALaw8gl9MI1yfLsO23LjnngTGO7YzWnMd6meO 6dPjptkX0QcV9a8V195Yw0NGwirO7nU26fKWZ43ukjkP3EEF0g6JtzZD3su0Rpq9 A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1au67pyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:13:05 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615BZqjA003449; Thu, 5 Feb 2026 13:13:05 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55n9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:13:04 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbE7038070; Thu, 5 Feb 2026 13:13:04 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-7; Thu, 05 Feb 2026 13:13:04 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com Subject: [PATCH v5 next 6/7] iio: sca3000: stop interrupts via devm_add_action_or_reset() Date: Thu, 5 Feb 2026 05:12:12 -0800 Message-ID: <20260205131234.3244467-7-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-GUID: bYEaDreFoJCnmHS6GFJ8whgE61D1ltLC X-Proofpoint-ORIG-GUID: bYEaDreFoJCnmHS6GFJ8whgE61D1ltLC X-Authority-Analysis: v=2.4 cv=Nf7rFmD4 c=1 sm=1 tr=0 ts=69849761 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=IpJZQVW2AAAA:8 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=mjWuCRx8u4tSYEBlnWYA:9 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfX0iwe7O8rU6bf HrfLCS4ps1xHKg/GFyIKcYtP3z1RA+VVhSosEAZ78ZXLdsrNc7h6UODgSYsZFjZU+z0dgOfypjp /YPyVs0p2sLyFvVhKnCdgvRp/cjp1XOqNxOxaytXvLCp9UqKRShSp8Ae/U5bnGAyDPSJtdsFuVs 4I9g4qVlynX+HrpwTSfxWRc1Um9xu7KrlNhOnmdfXvepGR4e2val6n2e7/TYgt8Ll1Qb4a1Tvou T+cv+mLzjgBMYZHsTHg2gbMajt7h/wu1U+MIlMdBpaezTJ2JlYUcWcygk1QUDRnJ4gaB9WDGV0k vyzTlCs7gdJN4y8V5nCZXc7mwtxr4094QbPMKejGEm2qiTUSi1kHYQRbOGcBx993Gqn4MdjEGVK iOItMuOnClnXZmoYcCgE1+Wi4UdfOLer6d9WnHZIRqk62mTRcPyUDmUGoefE1kHV3iv85IJyDCs huL1ciRLC2NdcJ+sNMg== Content-Type: text/plain; charset="utf-8" Used devm_add_action_or_reset() for shutting down the interrupts. Make sca3000_stop_all_interrupts() return void now that it always hooks into devm cleanup. No functional change intended. Suggested-by: David Lechner Suggested-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- v4->v5: Offloaded the move of the sca3000_stop_all_interrupts() above probe in a earlier patch, thanks to Andy for the suggestion of making this simple. --- drivers/iio/accel/sca3000.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 56ff646684c0..cfc3353f7ffd 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1436,8 +1436,10 @@ static const struct iio_info sca3000_info =3D { .write_event_config =3D &sca3000_write_event_config, }; =20 -static void sca3000_stop_all_interrupts(struct sca3000_state *st) +static void sca3000_stop_all_interrupts(void *data) { + struct iio_dev *indio_dev =3D data; + struct sca3000_state *st =3D iio_priv(indio_dev); int ret; =20 guard(mutex)(&st->lock); @@ -1504,6 +1506,10 @@ static int sca3000_probe(struct spi_device *spi) if (ret) return ret; =20 + ret =3D devm_add_action_or_reset(dev, sca3000_stop_all_interrupts, indio_= dev); + if (ret) + return ret; + ret =3D iio_device_register(indio_dev); if (ret) return ret; @@ -1514,12 +1520,8 @@ static int sca3000_probe(struct spi_device *spi) static void sca3000_remove(struct spi_device *spi) { struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - struct sca3000_state *st =3D iio_priv(indio_dev); =20 iio_device_unregister(indio_dev); - - /* Must ensure no interrupts can be generated after this! */ - sca3000_stop_all_interrupts(st); } =20 static const struct spi_device_id sca3000_id[] =3D { --=20 2.47.3 From nobody Mon Feb 9 04:07:59 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541DB3A0B0E; Thu, 5 Feb 2026 13:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297199; cv=none; b=P/WUTOAw8db7V4tbTX1vThUPPcPT03l7G6LpzR2tTPRqLZh7SHrKxoduxyhiYKfS/zTOk5ueFCRhBMvYnfzkZgH1AYWlM1wc58/5iE7rkyfMkkQLBLzyTbDWtrb057/G4aRtxNTsxkfMUL4FelPkFfnWDDPFWSD8nA4egaZqIR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770297199; c=relaxed/simple; bh=W1l3BG66FZpu6RpW3YmOTfR1KhTLDujC/83K9BApQrw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CYaMxmgodEJg1MAjKF+TjT3mIRIQiltOsXHsDd6a7fAPnp0ecuoGQhyyPtB92zgrcHCL0ypKfoRlJUDgdnjdlTulmYEg8sgKpMwB35/DWxE/XTAwushLqfDtPKsDeZARuYtb7FYsKYEm/jvzcShfOOFJ9ebVvFKZuhRzUjQd89c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ZdrJMSUN; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ZdrJMSUN" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614Ka1xe2730756; Thu, 5 Feb 2026 13:13:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=Fh9xo OM903iacZumat+t8PuBkVN4UlB84F4tz2RNITw=; b=ZdrJMSUNbCe9gURycT/VS 8NJLtk6AgfsjiqsZtfHzVUJeBMeWHsCtbTdKnXti1Yy+bxNg1hgGSI7qVoKfUbAq t54yJv78ljmAqIJAhrCWQZPeXMoiiRN3REza6rf44yTqGyOZclmUhIvNic70YNlk zIrtdKg1gwv9b0J4dVxJlfH8fwQRmbkxSEzq1gbpUByqs1LAmlNqQSIm98VzbJyC XF3ZSxyQfuuh0dOaVWDBK7QRHVYKwktM0I59yEf0o0QYeUouXj4Cvy/twTcfe5wg iGAZL3S8I35PBo0d7GecmmIsgIRkZ/cHxMw1DW9LEsA/unbHC9uC/oTpN0lqIa7H w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c4d9v10ja-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:13:09 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 615AvAea001347; Thu, 5 Feb 2026 13:13:09 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4c186d55qj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Feb 2026 13:13:09 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 615DCbE9038070; Thu, 5 Feb 2026 13:13:08 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4c186d55b9-8; Thu, 05 Feb 2026 13:13:08 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, andriy.shevchenko@intel.com, David Lechner Subject: [PATCH v5 next 7/7] iio: sca3000: manage device registration with devm helper Date: Thu, 5 Feb 2026 05:12:13 -0800 Message-ID: <20260205131234.3244467-8-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> References: <20260205131234.3244467-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602050098 X-Proofpoint-ORIG-GUID: VDoqOGYo96hI17KfRc2wn8NdfNtCffDl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfX68aNE5qPYO+G 1jt6iOK0FA+qTh4muTZAeJy/3/fzJzhZjvIQRp+vuIS36Jb5DJrRt3FttTX/MjiJamVf5D38We/ TWyEhTQBQoCDUEnCdQhYvvvTsgU22z0/1oUMcoPE+QCUvCdHsWcOhcOwE+i69pNbmO4XXl9GuI6 CN8zpRBOcYyGEZvGait6ejaAKbOHCEsApt+qWmGD2jEhQns0mX0Ge94LmukdFv/YW8NrmW5mZwH XqRwmZ5uvZ32wjaS8Giq2kHSiLIRMuG5BEnereuyxgjNrKDqPbFGY65fUAGhi3vUcjnnLfDIvxP gFuxzUuy62VTWya8MWdgssoSjMU2S1gyIDm8nZ39vwGUoX544xuhIVUAyKSib/FAXHL/lIIqHkV OqXEwRpEHaDWxpcKEFp/kEc1t00RCdaS59WQC/FtfVSo18XJtNicgdQ3EuD3gcEcS9xVm2DHjLI 1AXAv8lQTF2tvi831tw== X-Proofpoint-GUID: VDoqOGYo96hI17KfRc2wn8NdfNtCffDl X-Authority-Analysis: v=2.4 cv=NprcssdJ c=1 sm=1 tr=0 ts=69849765 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=AKfxoly6AAAA:8 a=yPCof4ZbAAAA:8 a=TX5tIiqRz0IEpTnFED8A:9 a=4Q71d_afUUiBcdzZNBSr:22 Content-Type: text/plain; charset="utf-8" Convert the iio registration to use devm_* helpers so the probe no longer needs a separate cleanup path and remove callback can also drop the unregister. After this there is no need for having a remove callback, so remote it. No functional change intended. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Reviewed-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- v4->v5: Add RB from Andy. --- drivers/iio/accel/sca3000.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index cfc3353f7ffd..49abe4ece233 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1510,18 +1510,7 @@ static int sca3000_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D iio_device_register(indio_dev); - if (ret) - return ret; - - return 0; -} - -static void sca3000_remove(struct spi_device *spi) -{ - struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - - iio_device_unregister(indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id sca3000_id[] =3D { @@ -1538,7 +1527,6 @@ static struct spi_driver sca3000_driver =3D { .name =3D "sca3000", }, .probe =3D sca3000_probe, - .remove =3D sca3000_remove, .id_table =3D sca3000_id, }; module_spi_driver(sca3000_driver); --=20 2.47.3