From nobody Mon Feb 9 00:26:42 2026 Received: from mail.crpt.ru (mail.crpt.ru [91.236.205.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965D43B52EB; Thu, 5 Feb 2026 11:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.236.205.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770292698; cv=none; b=FbTBVgV9r3ObUB6PKPpEFAsi1AQ73CZw/ibCc8mn8Ftu+GtRqHN3JnUDRlFfnd0Ynd2/nA7goIcg2Dw3bY0LsjW3sfV79ufnNkvUyun46hUkumcUH8UrXGuHxVSCxR25Q1nv4Wi+ZNd+9AgmoP3xL6aTK91e4lQlQBx9sWaftOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770292698; c=relaxed/simple; bh=Cxwqo1+Ald8SW5wGI3cU9gfdpqeTn5wUlmZNEXeOLFs=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=mYREgW+Q7gTSQ6Bp1SXvVuxtu0x6IeSEu4T1gXJbsbogc4xb5MTRhVG+6eBuYIhEslln/D34GrMdjwfg9JWpQ5oqDFsk9q7RNOzsGfYt+y25ZzsPHVgJ8g2Fdh2mVyjYjpMv06dKZcze8Y6+cC6s+G3GEx8TdSP3drtxjp+9aRY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=crpt.ru; spf=pass smtp.mailfrom=crpt.ru; dkim=pass (2048-bit key) header.d=crpt.ru header.i=@crpt.ru header.b=uZM0d2Q2; arc=none smtp.client-ip=91.236.205.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=crpt.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=crpt.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=crpt.ru header.i=@crpt.ru header.b="uZM0d2Q2" Received: from mail.crpt.ru ([192.168.60.4]) by mail.crpt.ru with ESMTPS id 615BgNgF000324-615BgNgH000324 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=OK); Thu, 5 Feb 2026 14:42:23 +0300 Received: from EX2.crpt.local (192.168.60.4) by ex2.crpt.local (192.168.60.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 5 Feb 2026 14:42:23 +0300 Received: from EX2.crpt.local ([192.168.60.4]) by EX2.crpt.local ([192.168.60.4]) with mapi id 15.01.2507.044; Thu, 5 Feb 2026 14:42:23 +0300 From: =?koi8-r?B?98HUz9LP0MnOIOHOxNLFyg==?= To: Saeed Mahameed CC: =?koi8-r?B?98HUz9LP0MnOIOHOxNLFyg==?= , "Leon Romanovsky" , Tariq Toukan , Mark Bloch , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shay Drory , Gal Pressman , Patrisious Haddad , Gerd Bayer , Mark Zhang , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" , "stable@vger.kernel.org" Subject: [PATCH net] net/mlx5: return error in case of lag device allocation failure Thread-Topic: [PATCH net] net/mlx5: return error in case of lag device allocation failure Thread-Index: AQHclpR+rj15C/aV2EGrrujnDvpJnQ== Date: Thu, 5 Feb 2026 11:42:22 +0000 Message-ID: <20260205114206.1763509-1-a.vatoropin@crpt.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-kse-serverinfo: EX2.crpt.local, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 2/4/2026 10:27:00 PM x-kse-attachment-filter-triggered-rules: Clean x-kse-attachment-filter-triggered-filters: Clean x-kse-bulkmessagesfiltering-scan-result: protection disabled Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-FEAS-BEC-Info: WlpIGw0aAQkEARIJHAEHBlJSCRoLAAEeDUhZUEhYSFhIWUhZXkguLVxYWC48UVlRWFhYWVxaSFlRSAlGHgkcBxoHGAEGKAsaGBxGGh1IWUhZX0gbCQ0NDAUoBh4BDAEJRgsHBUhYSFpIWVpIWVFaRlleUEZeWEZcSFBIWEhYSFFIWEhYSFhIWllICQYMGg0fQwYNHAwNHigEHQYGRgsASFhIWVFIDAkeDQUoDAkeDQUEBw4cRgYNHEhYSFlRSA0MHQUJEg0cKA8HBw8EDUYLBwVIWEhZXEgPCQQoBh4BDAEJRgsHBUhYSFpYSA8KCRENGigEAQYdEEYBCgVGCwcFSFhIWV1IAx0KCSgDDRoGDQRGBxoPSFhIWlBIBAEGHRBFAw0aBg0EKB4PDRpGAw0aBg0ERgcaD0hYSFpQSAQeC0UYGgcCDQscKAQBBh0QHA0bHAEGD0YHGg9IWEhZX0gYCQoNBgEoGg0MAAkcRgsHBUhY X-FEAS-Client-IP: 192.168.60.4 X-FE-Policy-ID: 2:4:0:SYSTEM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=crpt.ru; s=crpt.ru; c=relaxed/relaxed; h=from:to:cc:subject:date:message-id:content-type:mime-version; bh=tBD1DIuDM76b6fn+eP1KQnG1xb2lizg00yg48aXcuog=; b=uZM0d2Q2z7WKW5bGntydI2OPkVD/58tNjdPcyrXdhVcppvHH192qFBJcsbE6pYtDgyPa86zUvYnv PF+PAPu6tz1nsVprMduWg3H+kN4Lx/4tszfQVYa8fyFA2fac83VXJnQ3CA1m+Inn8tie8uQpWnr5 vZy/XjQKrct8m0mKCGZTh6c8dwlBiV/AH6xDCj/3IuZ6PyY+QsQteB+iIk20W5miO/m1xbFlSMEf bVkhUXi+40YJif8B6gX54SU3g63ZSpCShI5da4/2zaD2QI9+IU/ZECrMKOm5SpZzS/x01/IDVVfJ ovoNFB1MwZLMOn4J5UryKlg25CTyzpeAYl1erg== Content-Type: text/plain; charset="utf-8" From: Andrey Vatoropin The function __mlx5_lag_dev_add_mdev() attempts to allocate memory for the pointer ldev by calling the function mlx5_lag_dev_alloc(). If the memory allocation fails, mlx5_lag_dev_alloc() returns NULL and the __mlx5_lag_dev_add_mdev() returns 0. Later in the debugfs handlers there is an attempt to dereference the ldev pointer. Change the return value to "-ENOMEM" to avoid NULL pointer using. When "-ENOMEM" is returned __mlx5_lag_dev_add_mdev() will attempt to reallocate memory for ldev after a sleep interval. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: cac1eb2cf2e3 ("net/mlx5: Lag, properly lock eswitch if needed") Cc: stable@vger.kernel.org Signed-off-by: Andrey Vatoropin --- drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/lag/lag.c index a459a30f36ca..6e914472a2d7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c @@ -1392,7 +1392,7 @@ static int __mlx5_lag_dev_add_mdev(struct mlx5_core_d= ev *dev) ldev =3D mlx5_lag_dev_alloc(dev); if (!ldev) { mlx5_core_err(dev, "Failed to alloc lag dev\n"); - return 0; + return -ENOMEM; } mlx5_ldev_add_mdev(ldev, dev); return 0; --=20 2.43.0