From nobody Mon Feb 9 08:56:05 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C4D3A783C for ; Thu, 5 Feb 2026 10:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770287748; cv=none; b=iiDwG7OIwcrJZPV0ffI4O4aeuD+QQG+z4B1gqkFDLk+axEG0C3iQQRsGv9Y/9GE7sdmVxegbthLbrr9/ap5TPgYspetl9Z8M0gAtUkO4pQE+gP4WN8l1D3H3zuHVqIZSHu6MqA1II1bdvBWGCJRkUARK2bWlMFQ5pmmj9i5xT4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770287748; c=relaxed/simple; bh=Uml2Jc5zq2ELeW2m7lg/hpmfJO/PpPf6Iv4tN7jmR+U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ffKOA74+8Oye6HiXwyQPvkNyqrMBadn5rmvZJQ5DibI59rButE072gSM7Exra1JQTx2u6EVWgcIaDKgnKJfbQ729Y1cchDMe2/fSuXTTqd2H7VBUi4eLacQpcTq1Qjmn6GT7l6Yc5bY/3OTzhG137vdJbr7LYoatOMriq6VX65A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jc0ZzOzG; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jc0ZzOzG" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so6325045e9.1 for ; Thu, 05 Feb 2026 02:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770287746; x=1770892546; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W5Uax/LDotqlsD55VWpiCWlcKNKI7QyNOkqZjmWwhCs=; b=Jc0ZzOzGz8ooCzlI1hNelGUfwOaOz9+fQjNxcsJB3qieaYM1ZhGjkzsyd/JEEm3qw8 BP1iMrJ0nyojYPBGCCuko1ngs2RmsFtP9Vz2j10X53JAGrxHGwuuzwkVuvapH8nw3gZN gH3jNvk36XEU7WsUTdJ++rdnJ/Zy9ZElWLREqIduTWpaKhiJX95x0DvchaNeLOhsL/s0 ULHet1ajRzddY0I0kYI5Q8ivvKNOcjEmBcFd2cy6jYkU56Xbbh9N9YywiU/ONf65EL73 JTb4judH41bUwADOsgC5Tpf6snkRPH28JmOfcLJ4xbFaDy+4U8nXjgu+zDVCWMZU56yw cBFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770287746; x=1770892546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W5Uax/LDotqlsD55VWpiCWlcKNKI7QyNOkqZjmWwhCs=; b=pPJHpURTMUsHn9EvMKVmKrCxzk2T3hv8pKbystkReiVAfZmaY/+MkspJ4VxZa2jg8/ ho0x6remZjKCNO9vZqpNUphSunjVqQG+OaDdE1i/RQr7H+68Itm/LplMhjSLHd9P9BHx NtYQ5XziUFvCZvXpzBUUYIW/sM+RpE8EaEsjFQfg8E8kp8NP8v6JwDAQ4VE0r18UBvwo +bg32BU3oGKh8NE6ihOZ69a+Oix30lcY1xWpjFRCPpXkqbdpg6FS/GMlTa5NxxF3BdAi v20VFFz46i5yHV4VfoUmtRoQtbWClKy9mGVCu2KG9MkYS+Aupaxwx5aHaxhBnONBHiEE V5fQ== X-Forwarded-Encrypted: i=1; AJvYcCXb78+RsDxycAF4wR9FUogAkxcaMOLIIeulW02bbrbFX+QwToLQ05/nFxnjFNfxrPTxOdYFvyGVliwahsc=@vger.kernel.org X-Gm-Message-State: AOJu0YzcLmpJwtaxxflae3mLKMUxAQ0z2v5BfZ3kQl+bIhz7YUo56o98 D+cxrQ8UdkoMuq/GLI506x7WNFmKZ+5WCo0dJcm/A6YOdeYUNDtPNgJi X-Gm-Gg: AZuq6aLUKLCXaxZ3FjFJUO7aLRyytqdQdmxbeyXUey8aYEfC0zMcHXBtCQMVsPF6Umh FjV762sVOb7d8EDxb5WxcS9sc0JT+ZgsEp3rklSHza6Zlf8ZSf3szE6vfCgPEumkJRlbX0KkD6U dabnBfAbM760tyaqT6Ow95Kckw+5djREr3T6Z6Bba6Q+M1MaCdrJVIW6tDVm7qecQaDQj1f3CPE uqxtL1k+0iWrJNGxm9iN2ThNDoZJK3TZ8GXtUvItXGlfqJYealokyrv63GYZwZ4COWu0ap1mVPE C80y8hG4SGsR0GRZzX62atxsvU+LvUd4Hk4WK6wkFpPxrPWFmpQyKD1ILZW7aSNEb5CYdMZAE7b f+8/+GjkfMb1LX7819cbYVUXMLIpnO11inM3Zpo0/Q5RBrBDgysAlhk0joyaiBNk5udt++d4nEz uGnBqBFJ86TraLL8WgXuJAkUwQobrQRSgE X-Received: by 2002:a05:600c:c4b8:b0:47e:e712:aa88 with SMTP id 5b1f17b1804b1-4830e971bddmr97102565e9.31.1770287746111; Thu, 05 Feb 2026 02:35:46 -0800 (PST) Received: from localhost.localdomain ([196.191.61.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830ec4a76esm67876655e9.1.2026.02.05.02.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 02:35:45 -0800 (PST) From: Tinsae Tadesse To: Wolfram Sang , Jean Delvare , Andi Shyti , Guenter Roeck Cc: Tinsae Tadesse , linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] hwmon: spd5118: Fail probe if SPD writes are disabled Date: Thu, 5 Feb 2026 13:29:25 +0300 Message-ID: <20260205102942.28745-3-tinsaetadesse2015@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205102942.28745-1-tinsaetadesse2015@gmail.com> References: <20260205102942.28745-1-tinsaetadesse2015@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SPD5118 requires write access for page selection, configuration, and cache synchronization during suspend/resume. If the host controller does not allow SPD writes, the driver cannot function properly. Detect this state using adapter quirks and determine whether to stop the probe. Signed-off-by: Tinsae Tadesse --- drivers/hwmon/spd5118.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c index 5da44571b6a0..094d05472562 100644 --- a/drivers/hwmon/spd5118.c +++ b/drivers/hwmon/spd5118.c @@ -525,6 +525,8 @@ static int spd5118_common_probe(struct device *dev, str= uct regmap *regmap, unsigned int capability, revision, vendor, bank; struct spd5118_data *data; struct device *hwmon_dev; + struct i2c_client *client; + const struct i2c_adapter_quirks *quirks; int err; =20 data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); @@ -552,6 +554,19 @@ static int spd5118_common_probe(struct device *dev, st= ruct regmap *regmap, if (!spd5118_vendor_valid(bank, vendor)) return -ENODEV; =20 + /* + * SPD5118 requires write access for correct operation + * (page selection, configuration, and suspend/resume cache sync). + * If the SPD writes are blocked by the SMBus controller, the + * probe fails. + */ + client =3D to_i2c_client(dev); + quirks =3D client->adapter->quirks; + if (quirks && (quirks->flags & I2C_AQ_SPD_WRITE_DISABLED)) { + dev_err_probe(dev, -ENODEV, "SPD Write Disable is set on adapter; refusi= ng probe\n"); + return -ENODEV; + } + data->regmap =3D regmap; mutex_init(&data->nvmem_lock); dev_set_drvdata(dev, data); --=20 2.52.0