From nobody Sun Feb 8 07:57:49 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B929D35F8A6 for ; Thu, 5 Feb 2026 10:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770287399; cv=none; b=UQHboWfGIoqytkzbDSxmm5OFzu0VbPViEyc/qNgJu4zFEWfeICjVXeKwWArESsn1au5jQcVDtqIamzyFq33v0FmFo0T1y5DxNyB7jaackCTOnwlftL3kdRxYqt05kxE25vZJVhx6s1VQesgLylNMOaO4f9LC4w64uu6UH4G2HEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770287399; c=relaxed/simple; bh=9Uvgn7wB83wIdJ44vZfC1a6QsqNb41gYdz1rDR5ln50=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H/ADp0Q0UYUI1Cb0FNzB4oyO6OVdoePkoqQ1bCZTDmc9dEr0Q1uRVddpdKZHbbJfijki0ma1l4piPz/jgetA2mxWvO+0q3twdjgcCdVUzSG2017GQPFw5xO9MaN3izK8d3sqqoevnTFfIDjcIE3BAR4tpd6Xhv/3CoLUs0BH/co= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cMTsEYH5; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cMTsEYH5" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-480706554beso7890165e9.1 for ; Thu, 05 Feb 2026 02:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770287397; x=1770892197; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MEdQ0xFhhqTQqO4ph+nQmO3asTf3iBjVYOgorcwP4nc=; b=cMTsEYH5ce5KbB+0RB09d6+9qfcxFDfrDd+2tdIIsvmxGK1Dnqm/s7JrckUVzQtOJ0 3+ueuZmU4WDPo8Gp6yIgxJv3+4+TL4W+8QrvmY8zhGzNizakQ1tbdIETRICtVv9wf8vV /6pbks/1lgAPCgyPvE7BFr++Dt9RMfPmDB6YK33GUMsbDUYR9OWgTAOhOWMNpMob6x5u NwW1cbrENtYMWgNF9r5CO7+qRgHuWM7Oio1C6ffQ6MfHAU+z62N1dPfaLLjfH2IlQmCa aHvskdG7o9GD5rl8rdDE3OT4YoNGoOfQdG45aYMRjdhvfSC+Tpjw+4z0nUnPg8wNrC+V wlkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770287397; x=1770892197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MEdQ0xFhhqTQqO4ph+nQmO3asTf3iBjVYOgorcwP4nc=; b=Ep5dWTsqEhK1SwE+Au4ahXOUWNmRKSAPNBPF8kjfzXMbkpYETISzDrExuwUTXz9w/9 7ohNCYtClanla0Jds3jaiVo1F4yoWchz6IAl2c8V+eoVg02KTW8dBPa9d4Nb81viMGPs qRSJK/2C8XJeITULOHQpq7mLgwXEyTaeTVWa7S/+aMUXJnpuVv1NMlkwuLFF7rIiQt87 WGtj0M9JMhBI8nhSl+sstViTusEtqVlcQ5gV+j4U6fYdSX5VX3k2TCcoPvzSu7MIJF2i HGBWrHEk9b8Vi3gTi5CrSBrLJ1O7EegSl2QjOdtruWeKRVfmf0oS23HwJ3d7y6s+jPav 4DNA== X-Forwarded-Encrypted: i=1; AJvYcCXTNbgy48tTL+rYqz6ceJB0cBUInWxHWludnEEJuPeE9ZS0/VW0OsHLfFhoUzbJXsUoMz9VrddrsQuRXBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyYVNJu08JBDNqWt7197laIZXV5A63s99pTTcthycgGnTo2B6bm 13ZeOaxfKf7dDgnlBswzPPq1BZSiw6iK73DV/PYeehwr7JkB+juRqM7A X-Gm-Gg: AZuq6aLKRVXldIeNCgdIXcDKgiv+Uzjb63IjFzcQNkcQmRzp9fnpp+76N9Pp11SWkC/ cm+egJTwitwGMM+ChGBn3UcBstFD1CPw8NRf8Tz9onx0UYru+MESJTicpckz6PAj23xpcpVLjEN 2QS94VttjJsAO4onFlJD3Xs9wv3vABnnDI9b9YerhsGd2FJ/JylDt+2jS7RcjTY748XhmpCO0AI JHl5wdpQyoWBirFR4Xj35nWFTkBAUU2avf8y+CtisMlGLFI9UX9EgXsRIrb2Yp3vRevaFxKijYi 9SN+QvPY4Tn8Td6M8jyxur7hOoE6x9d8YHqDzLvF2KPK5zfr5Ji6jnkA2xUeoEWymLHqlvNhAGv ci1yUzgwxZe8GE6+dCzfK5xhkLJzrXF+kzqfgSpBs62GdJL8wmOm1Bbjm6ubjcUbcvPE/Yuzm8v 38Tv0kfHKmOnrBG3Pn8MZ5nU+XiR8eEn1s X-Received: by 2002:a05:600c:6087:b0:483:a21:7744 with SMTP id 5b1f17b1804b1-4830e977f1cmr78474795e9.26.1770287397099; Thu, 05 Feb 2026 02:29:57 -0800 (PST) Received: from localhost.localdomain ([196.191.61.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830ec4a76esm67876655e9.1.2026.02.05.02.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 02:29:56 -0800 (PST) From: Tinsae Tadesse To: Wolfram Sang , Jean Delvare , Andi Shyti , Guenter Roeck Cc: Tinsae Tadesse , linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] i2c: i801: Detect SPD Write Disable and expose as adapter quirk Date: Thu, 5 Feb 2026 13:29:24 +0300 Message-ID: <20260205102942.28745-2-tinsaetadesse2015@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205102942.28745-1-tinsaetadesse2015@gmail.com> References: <20260205102942.28745-1-tinsaetadesse2015@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Detect SPD Write Disable in SMBHSTCFG and expose it through I2C adapter quirk. The I2C client driver may decide whether SPD write operations are supported without implementing device-specific policies in the SMBus controller driver. Signed-off-by: Tinsae Tadesse --- drivers/i2c/busses/i2c-i801.c | 16 +++++++++++++++- include/linux/i2c.h | 3 +++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 9e1789725edf..d771e9f5f82f 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1533,6 +1533,11 @@ static int i801_probe(struct pci_dev *dev, const str= uct pci_device_id *id) { int err, i, bar =3D SMBBAR; struct i801_priv *priv; + struct i2c_adapter_quirks *quirks; + + quirks =3D devm_kzalloc(&dev->dev, sizeof(*quirks), GFP_KERNEL); + if (!quirks) + return -ENOMEM; =20 priv =3D devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -1600,8 +1605,17 @@ static int i801_probe(struct pci_dev *dev, const str= uct pci_device_id *id) /* Disable SMBus interrupt feature if SMBus using SMI# */ priv->features &=3D ~FEATURE_IRQ; } - if (priv->original_hstcfg & SMBHSTCFG_SPD_WD) + + /* + * Detect the SPD Write Disabled status. Mark the adapter + * as unable to perform SPD writes, which allows consuming + * drivers to decide on safe operation. + */ + if (priv->original_hstcfg & SMBHSTCFG_SPD_WD) { pci_info(dev, "SPD Write Disable is set\n"); + quirks->flags |=3D I2C_AQ_SPD_WRITE_DISABLED; + } + priv->adapter.quirks =3D quirks; =20 /* Clear special mode bits */ if (priv->features & (FEATURE_SMBUS_PEC | FEATURE_BLOCK_BUFFER)) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 20fd41b51d5c..4b89f0bf62a1 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -726,6 +726,9 @@ struct i2c_adapter_quirks { /* adapter cannot do repeated START */ #define I2C_AQ_NO_REP_START BIT(7) =20 +/* SPD writes are blocked by host controller */ +#define I2C_AQ_SPD_WRITE_DISABLED BIT(8) + /* * i2c_adapter is the structure used to identify a physical i2c bus along * with the access algorithms necessary to access it. --=20 2.52.0 From nobody Sun Feb 8 07:57:49 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C4D3A783C for ; Thu, 5 Feb 2026 10:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770287748; cv=none; b=iiDwG7OIwcrJZPV0ffI4O4aeuD+QQG+z4B1gqkFDLk+axEG0C3iQQRsGv9Y/9GE7sdmVxegbthLbrr9/ap5TPgYspetl9Z8M0gAtUkO4pQE+gP4WN8l1D3H3zuHVqIZSHu6MqA1II1bdvBWGCJRkUARK2bWlMFQ5pmmj9i5xT4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770287748; c=relaxed/simple; bh=Uml2Jc5zq2ELeW2m7lg/hpmfJO/PpPf6Iv4tN7jmR+U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ffKOA74+8Oye6HiXwyQPvkNyqrMBadn5rmvZJQ5DibI59rButE072gSM7Exra1JQTx2u6EVWgcIaDKgnKJfbQ729Y1cchDMe2/fSuXTTqd2H7VBUi4eLacQpcTq1Qjmn6GT7l6Yc5bY/3OTzhG137vdJbr7LYoatOMriq6VX65A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jc0ZzOzG; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jc0ZzOzG" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so6325045e9.1 for ; Thu, 05 Feb 2026 02:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770287746; x=1770892546; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W5Uax/LDotqlsD55VWpiCWlcKNKI7QyNOkqZjmWwhCs=; b=Jc0ZzOzGz8ooCzlI1hNelGUfwOaOz9+fQjNxcsJB3qieaYM1ZhGjkzsyd/JEEm3qw8 BP1iMrJ0nyojYPBGCCuko1ngs2RmsFtP9Vz2j10X53JAGrxHGwuuzwkVuvapH8nw3gZN gH3jNvk36XEU7WsUTdJ++rdnJ/Zy9ZElWLREqIduTWpaKhiJX95x0DvchaNeLOhsL/s0 ULHet1ajRzddY0I0kYI5Q8ivvKNOcjEmBcFd2cy6jYkU56Xbbh9N9YywiU/ONf65EL73 JTb4judH41bUwADOsgC5Tpf6snkRPH28JmOfcLJ4xbFaDy+4U8nXjgu+zDVCWMZU56yw cBFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770287746; x=1770892546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W5Uax/LDotqlsD55VWpiCWlcKNKI7QyNOkqZjmWwhCs=; b=pPJHpURTMUsHn9EvMKVmKrCxzk2T3hv8pKbystkReiVAfZmaY/+MkspJ4VxZa2jg8/ ho0x6remZjKCNO9vZqpNUphSunjVqQG+OaDdE1i/RQr7H+68Itm/LplMhjSLHd9P9BHx NtYQ5XziUFvCZvXpzBUUYIW/sM+RpE8EaEsjFQfg8E8kp8NP8v6JwDAQ4VE0r18UBvwo +bg32BU3oGKh8NE6ihOZ69a+Oix30lcY1xWpjFRCPpXkqbdpg6FS/GMlTa5NxxF3BdAi v20VFFz46i5yHV4VfoUmtRoQtbWClKy9mGVCu2KG9MkYS+Aupaxwx5aHaxhBnONBHiEE V5fQ== X-Forwarded-Encrypted: i=1; AJvYcCXb78+RsDxycAF4wR9FUogAkxcaMOLIIeulW02bbrbFX+QwToLQ05/nFxnjFNfxrPTxOdYFvyGVliwahsc=@vger.kernel.org X-Gm-Message-State: AOJu0YzcLmpJwtaxxflae3mLKMUxAQ0z2v5BfZ3kQl+bIhz7YUo56o98 D+cxrQ8UdkoMuq/GLI506x7WNFmKZ+5WCo0dJcm/A6YOdeYUNDtPNgJi X-Gm-Gg: AZuq6aLUKLCXaxZ3FjFJUO7aLRyytqdQdmxbeyXUey8aYEfC0zMcHXBtCQMVsPF6Umh FjV762sVOb7d8EDxb5WxcS9sc0JT+ZgsEp3rklSHza6Zlf8ZSf3szE6vfCgPEumkJRlbX0KkD6U dabnBfAbM760tyaqT6Ow95Kckw+5djREr3T6Z6Bba6Q+M1MaCdrJVIW6tDVm7qecQaDQj1f3CPE uqxtL1k+0iWrJNGxm9iN2ThNDoZJK3TZ8GXtUvItXGlfqJYealokyrv63GYZwZ4COWu0ap1mVPE C80y8hG4SGsR0GRZzX62atxsvU+LvUd4Hk4WK6wkFpPxrPWFmpQyKD1ILZW7aSNEb5CYdMZAE7b f+8/+GjkfMb1LX7819cbYVUXMLIpnO11inM3Zpo0/Q5RBrBDgysAlhk0joyaiBNk5udt++d4nEz uGnBqBFJ86TraLL8WgXuJAkUwQobrQRSgE X-Received: by 2002:a05:600c:c4b8:b0:47e:e712:aa88 with SMTP id 5b1f17b1804b1-4830e971bddmr97102565e9.31.1770287746111; Thu, 05 Feb 2026 02:35:46 -0800 (PST) Received: from localhost.localdomain ([196.191.61.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830ec4a76esm67876655e9.1.2026.02.05.02.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 02:35:45 -0800 (PST) From: Tinsae Tadesse To: Wolfram Sang , Jean Delvare , Andi Shyti , Guenter Roeck Cc: Tinsae Tadesse , linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] hwmon: spd5118: Fail probe if SPD writes are disabled Date: Thu, 5 Feb 2026 13:29:25 +0300 Message-ID: <20260205102942.28745-3-tinsaetadesse2015@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205102942.28745-1-tinsaetadesse2015@gmail.com> References: <20260205102942.28745-1-tinsaetadesse2015@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SPD5118 requires write access for page selection, configuration, and cache synchronization during suspend/resume. If the host controller does not allow SPD writes, the driver cannot function properly. Detect this state using adapter quirks and determine whether to stop the probe. Signed-off-by: Tinsae Tadesse --- drivers/hwmon/spd5118.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c index 5da44571b6a0..094d05472562 100644 --- a/drivers/hwmon/spd5118.c +++ b/drivers/hwmon/spd5118.c @@ -525,6 +525,8 @@ static int spd5118_common_probe(struct device *dev, str= uct regmap *regmap, unsigned int capability, revision, vendor, bank; struct spd5118_data *data; struct device *hwmon_dev; + struct i2c_client *client; + const struct i2c_adapter_quirks *quirks; int err; =20 data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); @@ -552,6 +554,19 @@ static int spd5118_common_probe(struct device *dev, st= ruct regmap *regmap, if (!spd5118_vendor_valid(bank, vendor)) return -ENODEV; =20 + /* + * SPD5118 requires write access for correct operation + * (page selection, configuration, and suspend/resume cache sync). + * If the SPD writes are blocked by the SMBus controller, the + * probe fails. + */ + client =3D to_i2c_client(dev); + quirks =3D client->adapter->quirks; + if (quirks && (quirks->flags & I2C_AQ_SPD_WRITE_DISABLED)) { + dev_err_probe(dev, -ENODEV, "SPD Write Disable is set on adapter; refusi= ng probe\n"); + return -ENODEV; + } + data->regmap =3D regmap; mutex_init(&data->nvmem_lock); dev_set_drvdata(dev, data); --=20 2.52.0