From nobody Sat Feb 7 10:15:56 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C2F13A4F5C for ; Thu, 5 Feb 2026 10:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770286876; cv=none; b=XK1oeSdM62cIpzIU8w4ZXym+4PBzWbSSqqO22cbFlbz+vTdRNRi3cOdm8rbD7b4j+ZZgEyW5CVMGu4IvqmWGSyjUrFJLYqaSG3n558PWN7JeDvUSNgbECS6cBa1ekkuTAZclCuz2AWOHG0P3D4YUGvROxNH32om60LxuPUPOIyg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770286876; c=relaxed/simple; bh=5vdYkw57EiYeIaL+x9xosY2jNoR2mgB/EI5FNgbkC3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G3V/PVdROg+o+7AJp5ZfzBgMeQiH4a8X8hC4kEuKWjtOFFxrft6dzT0qoKGxbE/6Io3stoDmUcEwr5PkzlMLEX4KVeG4YFt0UaTP/XFz145Sp+JYrrWx4JvaodcW5XCQCw8zcAqRwa2iENrpDxqwj5sTp8SteIziVYevEN5iPjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=nB6keqMm; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="nB6keqMm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=P2HRF2ZHD1WJ7uTJ5H+4KPD8cHuQGGOB2lb+kwP4OjE=; b=nB6keqMmTqcjes1wcRMPcsv3YJ tZhqThEyFWtp2rjsPde6l4XQwkuT2I48u1si9YiNbHdo/l+4jeMIO4KvYFJLrhWKouJnitNs+zNYF bq7zaRasbleG73Ttp+cnEHx+4qqY0/HsK/bMBnz3zb+PWnJos6TBTQET6G9VPIyoZQ6xggY5+CIYC e9o89IXPsyotgYRyXb4x3brFpSbgbGbCrXu095eLGutq107PqFNCI8MSnHj5hl10IIbGy5m9RFSvl +ZgulElngjs6z9bwVjdLi8U2BP6sfCQJiDe2///sc5BvN76TwdHCSzXT8ciWgQjKtty/8rJHTzfa8 CnI5SaYg==; Received: from i53875afe.versanet.de ([83.135.90.254] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vnwU5-0075El-Hv; Thu, 05 Feb 2026 11:21:14 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner Subject: [PATCH 1/3] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-jaguar Date: Thu, 5 Feb 2026 11:21:02 +0100 Message-ID: <20260205102104.394991-2-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260205102104.394991-1-heiko@sntech.de> References: <20260205102104.394991-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Heiko Stuebner Using a combination of fixed clock and gpio-gate clock works but does not describe the actual hardware. Use the gated-fixed-clock binding to describe this in a nicer way. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts b/arch/arm64/bo= ot/dts/rockchip/rk3588-jaguar.dts index 952affaf455c..6eea4e0b6ca4 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts @@ -90,21 +90,16 @@ led-1 { * 100MHz reference clock for PCIe peripherals from PI6C557-05BLE * clock generator. * The clock output is gated via the OE pin on the clock generator. - * This is modeled as a fixed-clock plus a gpio-gate-clock. */ - pcie_refclk_gen: pcie-refclk-gen-clock { - compatible =3D "fixed-clock"; + pcie_refclk: pcie-clock-generator { + compatible =3D "gated-fixed-clock"; #clock-cells =3D <0>; clock-frequency =3D <100000000>; - }; - - pcie_refclk: pcie-refclk-clock { - compatible =3D "gpio-gate-clock"; - clocks =3D <&pcie_refclk_gen>; - #clock-cells =3D <0>; + clock-output-names =3D "pcie3_refclk"; enable-gpios =3D <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; /* PCIE30X4_CLKREQN_M0= */ pinctrl-names =3D "default"; pinctrl-0 =3D <&pcie30x4_clkreqn_m0>; + vdd-supply =3D <&vcca_3v3_s0>; }; =20 pps { --=20 2.47.2 From nobody Sat Feb 7 10:15:56 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C3753A63EF for ; Thu, 5 Feb 2026 10:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770286876; cv=none; b=qHFu0VRifFfocEYXrkx5nr1CiGDlmpWg4aW34UaaifAOvjY7hVESzmqBH0Wiz/b9E1aQbgX06Q1Hn+IpNSygRJZfp2X1025vfYNWxI1dD5ia9osbxeWAlYwT+FCPv3d/yP/l9hH1zeTtRmjO07RSePizbabk7gocCkKHPbyY16I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770286876; c=relaxed/simple; bh=/T3NK/diXd1A5/o4dGbi2BHCZI+4FYU5BNPLZnmfUD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i4UDhdN0wHJOshfvtC3C7HoU/5cboJxYe7viYEmh/itTlweIF/jEn3Qkox9rdB2HU/r1YktXzTdvTZNmfRCKzX3dtY5nu21Gy48xfkIDMtn+T7wX/JbXSloKb/cXTIdPoQkSkfiEwajooEiikPXuhJJPsyKhIgrldlqnwV1DvfU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=liyafqLL; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="liyafqLL" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=xySJEGujkFZ5SXwhZvO8uWauZklpO37yk1SL78e8tXg=; b=liyafqLL6Ss89F6mVD5XkguWuC GERgLbswu++vGijR1UVRX2VmxV+RrAlvzFDRrBFO/c4LEPmzXtVAZ685xyLLTTWAEE3PjVwDvWxid Yf5AjFHXfBvnRjAdl13ZGZYBv/eENpTZaOjS9l710D15ar0ioF7NjpR9++QZMRU1KK6sb5gOPu/IK m75rjpJ/9xc27Wt+XXGr/suzI3lJirQ04md2vPmU3DjiJFOEXoAGvf0HGxKmHehC0y/X/lt8zemgC pFhny2J5bA0wm+PCAq8srSHrR1DR2MWk1KSzVYQoVHu/5Q7AiyMLa9QWgIOb7MRsSpfl0TebSvd+Y klBRrCTw==; Received: from i53875afe.versanet.de ([83.135.90.254] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vnwU5-0075El-Rr; Thu, 05 Feb 2026 11:21:14 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner Subject: [PATCH 2/3] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-tiger Date: Thu, 5 Feb 2026 11:21:03 +0100 Message-ID: <20260205102104.394991-3-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260205102104.394991-1-heiko@sntech.de> References: <20260205102104.394991-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Heiko Stuebner Using a combination of fixed clock and gpio-gate clock works but does not describe the actual hardware. Use the gated-fixed-clock binding to describe this in a nicer way. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi b/arch/arm64/bo= ot/dts/rockchip/rk3588-tiger.dtsi index 27269b7b08aa..259fb125e13f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi @@ -51,19 +51,14 @@ led-1 { * 100MHz reference clock for PCIe peripherals from PI6C557-05BLE * clock generator. * The clock output is gated via the OE pin on the clock generator. - * This is modeled as a fixed-clock plus a gpio-gate-clock. */ - pcie_refclk_gen: pcie-refclk-gen-clock { - compatible =3D "fixed-clock"; + pcie_refclk: pcie-clock-generator { + compatible =3D "gated-fixed-clock"; #clock-cells =3D <0>; clock-frequency =3D <100000000>; - }; - - pcie_refclk: pcie-refclk-clock { - compatible =3D "gpio-gate-clock"; - clocks =3D <&pcie_refclk_gen>; - #clock-cells =3D <0>; + clock-output-names =3D "pcie3_refclk"; enable-gpios =3D <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>; /* PCIE30X4_CLKREQN_M= 1_L */ + vdd-supply =3D <&vcca_3v3_s0>; }; =20 vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 { --=20 2.47.2 From nobody Sat Feb 7 10:15:56 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C25138E5EC for ; Thu, 5 Feb 2026 10:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770286876; cv=none; b=WblS3rSrsRlV2zbzOLiZcaie7asqoP3Il3NUF0XTXfEKutyMU3AzV7qLTHRupDpCLykRfzk8s128KnKfE92Nn8FOblSU0Y7b75O5b/KA4FE1OR/3TFgVaBtxEkqIEsQh+sNnrukvR/NO5XcrGMwTvGgsFxuyDBmoRPOsT1MrljQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770286876; c=relaxed/simple; bh=+OHQ2Qb9u6ZAsCtAo+Ar8fFPAGUYDImVhrtI8sL74SU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O2rr/KXQTUlL7ihUj5LYzgxQVC40ClqCu4NHeeRkyQCGopXX8w2NKNZfbIEMQEOMtXZ2rV+oHHHDzW0EMmTthkQAwzv68VGj4xioxz2ifsZYIPh9n5qjyScMRLnPfuG4yRmUkZqBp2nCNQzhiAVBy+as3Mft+b0VjVAjoI/x8YU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=mRKVfEn4; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="mRKVfEn4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=05jgx+0MnkFAcnKU6lS4I/sXEof8lEHcRFmjOH00Mlw=; b=mRKVfEn4WKG8d+UIFi+2uHEt67 ZQ5HoaXCPE+ugg7D/iUwwndTw7p2kQFlS/4hakxCxvSAY3bxEscbspxlnkoD3LzpMWAgJ+rnX6McH AarGgNCvyICTJvOWxwKUwEM7rqRvjVRpton/MhW3Scjtlv4C2AW6bDRAMPK9ZTBSLirL/CsMk7G9S 52zY3vpLnUUCzB2PMsgRiJ3c5BeFUFlcpafS/X98Nz54s8wR2u7MDjnCcXg9S7Llb/ZBYU25eg9PO SizpeiywKKpTRLtBYKJG2x2If5yn0CtmamLUiDdFoAggdaN/+NxtxRZ7mmS9LWFq3vfoD/ZqOY/W4 EHgj6asw==; Received: from i53875afe.versanet.de ([83.135.90.254] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vnwU6-0075El-5Q; Thu, 05 Feb 2026 11:21:14 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner Subject: [PATCH 3/3] arm64: dts: rockchip: add pinctrl for clk-generator GPIO on rk3588-tiger Date: Thu, 5 Feb 2026 11:21:04 +0100 Message-ID: <20260205102104.394991-4-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20260205102104.394991-1-heiko@sntech.de> References: <20260205102104.394991-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Heiko Stuebner While specific driver in the Linux-Kernel handles GPIOs gracefully without matching pinctrl entries, this might not be true for other operating systems. So having pinctrl entries makes the hardware-description more complete. The somewhat similar rk3588-jaguar board has a pinctrl entry already, so also add one for rk3588-tiger. Signed-off-by: Heiko Stuebner Reviewed-by: Quentin Schulz --- arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi b/arch/arm64/bo= ot/dts/rockchip/rk3588-tiger.dtsi index 259fb125e13f..91057b166690 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi @@ -58,6 +58,8 @@ pcie_refclk: pcie-clock-generator { clock-frequency =3D <100000000>; clock-output-names =3D "pcie3_refclk"; enable-gpios =3D <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>; /* PCIE30X4_CLKREQN_M= 1_L */ + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pcie30x4_clkreqn_m1_l>; vdd-supply =3D <&vcca_3v3_s0>; }; =20 @@ -357,6 +359,12 @@ module_led_pin: module-led-pin { }; }; =20 + pcie30x4 { + pcie30x4_clkreqn_m1_l: pcie30x4-clkreqn-m1-l { + rockchip,pins =3D <4 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + usb3 { usb3_id: usb3-id { rockchip,pins =3D --=20 2.47.2