From nobody Mon Feb 9 16:20:47 2026 Received: from mail-yx1-f100.google.com (mail-yx1-f100.google.com [74.125.224.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D91E035E54D for ; Thu, 5 Feb 2026 07:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770277858; cv=none; b=Wtl/DVYCFuU8a3NiLijT2NbAyGW1KdMlTEnXeWbLmRZ22iyO+Hs96ZsVJbaC9rHm8JvapZy0RMRwzqvKYgcDDQAaw0Xd9xBTtZA6qCMM6ZmZLo/em3upBFcR7T0UgAbcIs7+KJfmP5s3z67ZXyk2XL3k5z44G1usGKakd3v96BQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770277858; c=relaxed/simple; bh=JyGRnFnWXYKREoWVJoTjnH8Ki9I7rBqgCKkWILXrJ3c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gdPbI+ZWjavHJUCBcfKfIOaLSQOO5amycDCAM//kTZGjcST11Pw22IBavXWxsROgFUsIdS2cTuAd5pGqNwP+0gsXCqdjDVXfq4OnYUsjhQ+TPLLrN0BQYBOl69ScRvdwk7I3ImYt1XItcn33UK4EZFVMO2CEQOcnL98PF+E9ReE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=SYfEq2pT; arc=none smtp.client-ip=74.125.224.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="SYfEq2pT" Received: by mail-yx1-f100.google.com with SMTP id 956f58d0204a3-649ddc91c05so79847d50.0 for ; Wed, 04 Feb 2026 23:50:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770277857; x=1770882657; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6TSEFqGFDtEPF0mGKcpvzCirZypCr4KunIPUFFgq2YU=; b=cF71+F+PoFFsRcOC3DFCUufJmKGxwmxefAnNxj1hQNEwSW1eio16JZMc0xlsk/nKUx k+XrMhaW1g/4W6ROKJZavpNsnjUnsU5lqkeaJ1+nmTw/Pfl+mDBLrBYjiWA52jgZTS2m ps5ytp66dmqhTDH+XFzatSfOHxZ7lmHVikSqwErs8UgU8wfs53dG4b+WFyaEY37ih6s2 oFPAFt+GYmjNflvpQdfJhWA2NPoCbVOeZggJAg7prc/9hSJHwMH7HXbOLAUqUMG0L/XV P2lXESH81+VQIjiEFRLEf5K3rU3YXLm9kmrZsFG3fUVNi+2R/vTp332MYF6QjFJty8YQ Q9yQ== X-Forwarded-Encrypted: i=1; AJvYcCUHfa/R95hqV8JcEKMq6qv48lt1nPtUghLPcwBJXXJWf3Sv4z5AKRIRJVloLjhqAcYxUK1fXV++wSGYBUI=@vger.kernel.org X-Gm-Message-State: AOJu0YzgLnyrj390V9hZpgAMVQEtwU7hTg17BA+uH7b0K8mMQNQnmrLx NameAl9QlC8FHg3VHw8d2z1LsY/V0Dr9VWV4yUAmeELr0RkjfqvIIfdAyJwzCdGcEU4iSr1nDik utSbs6WBl3uPC7tOJVzp+/KIJ7CRxKWXKPFKUvOK3Kp81OwzMatLbsEMIX+/LbEnP6zlJPvMC1x 5VE1zXmWeIkhSK8F5NNMCnBQLGF+/r87VVLkc4rgdX3Bwlumqb9Ag6LLG2vX3qTTjRjaTJMeWlL pknHiADQ7CXbJ7xK0ZUBmF2RJQ5uyqWBP3uzw4= X-Gm-Gg: AZuq6aIBzGlZwh0p73A1sS4Oi4VcBpMpTJG6s8jBfNDEaNLMOUp9IIxx6SsNiAo7YhY cOPGtleaAtBbi7ZfJ6wYdo9rxzQcQ6Tvuwb3+Czpt42uVg7Ic0v04YZbVShRYtrgeURpYCpZAc/ 0EXKUrEi7yn2EBOSNdaRvVDYrZJDcgyGdVACnt7FrPIzvfMhNrKTh2nAakPx4oi8zG7olUBXGa9 nR1R3LFrrWviAyUebjOWbseNVLULizfrzGthe4LNykMH5L539kBMSDvEIu3Z9SHv556YevF+4ag DLHA61EoadtMLroCuxhqjVqk2o9gwhPdsXJ8Oq8Yjla5KEd0vsA98aWe1aUClkLO4cOVadoM+8V Yxmlg3pTxCHmFEbm40K/lxcGP3vLfRgGt4NksKi2aJBacLQbQ6fOJCevLkN9prHkvytOcihMkTJ oosSNnkkIQuL4iN/JUj7vzaLP4BFHmXOgID+hRRr8WIOe4MuLqNuOLVcTuwpc= X-Received: by 2002:a05:690c:1e:b0:794:c0c7:43e8 with SMTP id 00721157ae682-79501fd4a77mr34615587b3.3.1770277856698; Wed, 04 Feb 2026 23:50:56 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-2.dlp.protect.broadcom.com. [144.49.247.2]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-794fefa21e7sm2327697b3.22.2026.02.04.23.50.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Feb 2026 23:50:56 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2b796c874a9so27079eec.2 for ; Wed, 04 Feb 2026 23:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1770277855; x=1770882655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6TSEFqGFDtEPF0mGKcpvzCirZypCr4KunIPUFFgq2YU=; b=SYfEq2pTMsYznxj/Te7raCN+W7usL29BRXO1urFFPPwvLfYkiaY2W2Ik0l1S60TW3n Nm7DBxQd6rhHctK4aHdwJf+KG+aw0ZhX/WnJwhUn/vCkvtEJJ5sTnHvutK87QeIVH3cG 84n1jOpzu13zQiQqNZb4ZCOaZeGMpuIXoCkxw= X-Forwarded-Encrypted: i=1; AJvYcCV/CnepXsmXxNTS5H0bWjb6u/HDTnlHwBW59naudarq0r30GVPPqQl3kcGMhNI4InJ4udQbDGQSgZItkR0=@vger.kernel.org X-Received: by 2002:a05:7022:50e:b0:119:e56a:4fff with SMTP id a92af1059eb24-126f60ba802mr1109941c88.4.1770277855238; Wed, 04 Feb 2026 23:50:55 -0800 (PST) X-Received: by 2002:a05:7022:50e:b0:119:e56a:4fff with SMTP id a92af1059eb24-126f60ba802mr1109932c88.4.1770277854649; Wed, 04 Feb 2026 23:50:54 -0800 (PST) Received: from keerthanak-ph5-dev.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-126f4e10935sm3383959c88.6.2026.02.04.23.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 23:50:53 -0800 (PST) From: Keerthana K To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kafai@fb.com, weiwan@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Sasha Levin , Keerthana K , Shivani Agarwal Subject: [PATCH v5.10-v5.15 ] ipv6: use RCU in ip6_xmit() Date: Thu, 5 Feb 2026 07:46:44 +0000 Message-ID: <20260205074644.2091266-1-keerthana.kalyanasundaram@broadcom.com> X-Mailer: git-send-email 2.43.7 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Eric Dumazet [ Upstream commit 9085e56501d93af9f2d7bd16f7fcfacdde47b99c ] Use RCU in ip6_xmit() in order to use dst_dev_rcu() to prevent possible UAF. Fixes: 4a6ce2b6f2ec ("net: introduce a new function dst_dev_put()") Signed-off-by: Eric Dumazet Reviewed-by: David Ahern Link: https://patch.msgid.link/20250828195823.3958522-4-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin Signed-off-by: Keerthana K Signed-off-by: Shivani Agarwal --- net/ipv6/ip6_output.c | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 426330b8d..3411da42a 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -255,33 +255,34 @@ bool ip6_autoflowlabel(struct net *net, const struct = ipv6_pinfo *np) int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl= 6, __u32 mark, struct ipv6_txoptions *opt, int tclass, u32 priority) { - struct net *net =3D sock_net(sk); const struct ipv6_pinfo *np =3D inet6_sk(sk); struct in6_addr *first_hop =3D &fl6->daddr; struct dst_entry *dst =3D skb_dst(skb); - struct net_device *dev =3D dst->dev; struct inet6_dev *idev =3D ip6_dst_idev(dst); + struct net *net =3D sock_net(sk); unsigned int head_room; + struct net_device *dev; struct ipv6hdr *hdr; u8 proto =3D fl6->flowi6_proto; int seg_len =3D skb->len; - int hlimit =3D -1; + int ret, hlimit =3D -1; u32 mtu; =20 + rcu_read_lock(); + + dev =3D dst_dev_rcu(dst); head_room =3D sizeof(struct ipv6hdr) + LL_RESERVED_SPACE(dev); if (opt) head_room +=3D opt->opt_nflen + opt->opt_flen; =20 if (unlikely(head_room > skb_headroom(skb))) { - /* Make sure idev stays alive */ - rcu_read_lock(); + /* idev stays alive while we hold rcu_read_lock(). */ skb =3D skb_expand_head(skb, head_room); if (!skb) { IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS); - rcu_read_unlock(); - return -ENOBUFS; + ret =3D -ENOBUFS; + goto unlock; } - rcu_read_unlock(); } =20 if (opt) { @@ -329,17 +330,21 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *s= kb, struct flowi6 *fl6, * skb to its handler for processing */ skb =3D l3mdev_ip6_out((struct sock *)sk, skb); - if (unlikely(!skb)) - return 0; + if (unlikely(!skb)) { + ret =3D 0; + goto unlock; + } =20 /* hooks should never assume socket lock is held. * we promote our socket to non const */ - return NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_OUT, - net, (struct sock *)sk, skb, NULL, dev, - dst_output); + ret =3D NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_OUT, + net, (struct sock *)sk, skb, NULL, dev, + dst_output); + goto unlock; } =20 + ret =3D -EMSGSIZE; skb->dev =3D dev; /* ipv6_local_error() does not require socket lock, * we promote our socket to non const @@ -348,7 +353,9 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb= , struct flowi6 *fl6, =20 IP6_INC_STATS(net, idev, IPSTATS_MIB_FRAGFAILS); kfree_skb(skb); - return -EMSGSIZE; +unlock: + rcu_read_unlock(); + return ret; } EXPORT_SYMBOL(ip6_xmit); =20 --=20 2.40.4