From nobody Sat Feb 7 18:21:11 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10152405EC for ; Thu, 5 Feb 2026 03:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770262456; cv=none; b=brg+VTabDuFQJFiIi2zszl9A9McXBTZjbxzHLMHzF7dd6ytI+jJyxneLxGJx/dMshU18Ct4xa5ar9RLdCyO6y/jCKQA2QwMKa3dtlPMbVqdKBNDUuy1GaivIlzTwJJn4JegMzpsItzJCzTngF461093sr3uSiJdDxHRi4DDVPwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770262456; c=relaxed/simple; bh=JsM3bs9wbuea4OGau2HK8ogv4O7M4EeZBKJ0wErNKLs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YNzHoVNNsnpCZx5EIXM2wLiso8kmrLDnMWB/LSR28Kg86vC9uIL2gdcPHs9hcgiQHJ1Wn4qfpZ0IDsCqlS+JykZUGRj6oKGk4qBWthYHjNvd81+lmQXEbQlCwNc8q+gbgExNsxLJRKkAUmHArzATyd6FuJbubyFn4PR+8yoRRYQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BeWUYw5d; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BeWUYw5d" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8c70daf9c94so43273485a.0 for ; Wed, 04 Feb 2026 19:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770262455; x=1770867255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d61n7HxTXPgkp/RcfIbsA3Xy8ZsyJxLiUSY6lHZjydM=; b=BeWUYw5ddfbNQOMSVJ/1tKXwU4VSHjlos7TKYj5NguUmglZ45SYwJ6PH7tdCZCEYTx LlckC3LgBI6i+gp8bcKO5OUwHb6rs2bXi9dxNLHF3mau1hMmTDPGlxQ47SvAbG0S5eJ+ clXM31mGzuoZ8KbKfWiyJXASrUO/e0izVh79gpU5f6Fsv520u/7YF5I32nNmsrDgSGwg K3JtkC2j201a2yVnmTmyJq7x/V6MoZRTw1jH5tNMIeh3+7roAVceXikTadB7va5b/Ssz eQOLOC0onSXlrC8BtBQV7sJOwPkDpkhaLl1QrB0JbfEn6RPeXJFPS6Gk4+06XYn89weH bKQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770262455; x=1770867255; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d61n7HxTXPgkp/RcfIbsA3Xy8ZsyJxLiUSY6lHZjydM=; b=VWW1Wl0ufC5LtIUGL6AROu8KRlpjc1dZkzLVa3nD5R4JVFQLr1mT+Nob5USQFMziZO Z5S9y7Bvq4b4ojLOHiPur+tx/+GqHYPocdFl/Mw5IZLITIS5PBdD958G0tcIbHifkzmt OZbmoPIyQqiHkZeDJY0a+E2M/deZ9iIOeazgIRvbDDHRWK1Rnwkk5U+2N2oesfG339oW HbMhAIb5wFdz4fAQyynGN8RdgU5+WtPCNgvqE3J3I8oi1iZty8V0M4xEZnWnLlL+Z6+V 8BOsvSnwmtj9bczttaf8m2OfKmbTbiLcVedpNXCD/5E5V4WDf5l5cVkSxxdYTrQ1r8eF 6T4g== X-Forwarded-Encrypted: i=1; AJvYcCU7SP/PITNIZadE0fBR4/oKlQs3oK59U2fc5iGsFVEOLlMvYdmXDkZee/wvP4S4Y2fLry/PPvMJCXBzokc=@vger.kernel.org X-Gm-Message-State: AOJu0YzBn1BOO9AI8ALNd6gDhKEgbn9l7Lzl76hzJtwd1snoQfJRPRn2 CcYeXAj2kuvDg3FlDUS4urocAdUzN9mC9R4n0gSD7MSETq5wEt1r47kE X-Gm-Gg: AZuq6aKWdkMyCg+K1IqKNdxlDHf8BCN1ccVVf+PfTQ2fNBiUrXpVVah9L6t0UsdNniT MKJKCs9dwUEMbw44JMYL5zPp6VzoKr+izozvZibCuMbvEA3D1MjmvomcFZznezpGRZPfAEQg8Of 09N0xKsNYrdM+Yf3MspRlccSPC8l3nK08WFcJPbRzbG3X+jIzan4tcI3NPOkIvGY3IVkeafiMz7 0v8nPZDlCPgXnmhZDWy3aMOkDRf5otmtQXzhlWF/FU0UAQWe3g5tnKdu1zzmtYuSxfDuRILqV6Z H2WCQfsExxxkcLWg9CQDYJqxDYZpzT+x0RMtlmo0kJRM7KhTriDal1pnWaKe6jhEEmdIi5RlQSd 0+uht1lDWkEM/fe8Rc5cXOlOXH69MMv1k7NY/3UMztPYDcvejDmJZRlQdP/86AFlO4y6u433j0S jXfp1PF9Y69R2NwhIx0417WuliHc15iw== X-Received: by 2002:ac8:7d92:0:b0:4ee:1dd0:5a47 with SMTP id d75a77b69052e-5061c1d010emr62182591cf.76.1770262454778; Wed, 04 Feb 2026 19:34:14 -0800 (PST) Received: from localhost.localdomain ([50.21.71.60]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5061c147f42sm30275891cf.3.2026.02.04.19.34.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 04 Feb 2026 19:34:14 -0800 (PST) From: Neel Bullywon To: Johan Hovold Cc: Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Neel Bullywon Subject: [PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf() with sysfs_emit() Date: Wed, 4 Feb 2026 22:34:08 -0500 Message-ID: <20260205033408.86340-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in the protocol_id_show() sysfs attribute function. This code is safe as-is, but replace sprintf() with sysfs_emit() because we are trying to get rid of calls to sprintf() as part of kernel hardening; sysfs_emit() is more appropriate in this context. Signed-off-by: Neel Bullywon --- This was compile-tested only (no VM/hardware used) Changes in v2: - Subject: change to imperative "Replace" (was "Replaced"). - Wording and line breaks adjusted in the commit body for clarity. Changes in v3: - Clarify what "safe" means (buffer is PAGE_SIZE) per Dan Carpenter's suggestion. - Reflow lines to avoid awkward breaks. --- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbph= y.c index 60cf09a302a7..55f132b09cee 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev =3D to_gbphy_dev(dev); =20 - return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id); =20 base-commit: de0674d9bc69699c497477d45172493393ae9007 --=20 2.44.0