From nobody Sun Feb 8 11:16:40 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B9338DD3 for ; Thu, 5 Feb 2026 02:45:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770259543; cv=none; b=Df3fteIDmlIcEOI+098qrB/UY3srt402mVurwoYgZWO3brobeUTBYyL61JWKIxGuj8XeRTLexY4996D9vMCbZLGmqOUzos4GFq+AN/WtBhr/zdfWRN/PjDfRykKKEBeGmLqO0WUWTklCrSbLYkO/SRqzvF3M3Fp8vC1ibrlVOHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770259543; c=relaxed/simple; bh=BkJkXiYh7mMTUBmGCvojZvuddZOMLgQxn22wCKuErj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q1mWOMxD7Pm9/B5ltzpeOXpD2B9cAFf1vDgY5DoRFx0lAzcsD2J+YAZo6fk5kgVdMe6BHuqtt2ezsM92VYt0UUBp4VzRVSd1dVDfKA94iPsRjNFJteebry8AT5kHaAqP6omdv8u5hLFpiQOTMWFmjCnCwgNDmE3b9Yt8BssNb3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zi1A/v36; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zi1A/v36" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a9296b3926so3680405ad.1 for ; Wed, 04 Feb 2026 18:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770259542; x=1770864342; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GaTc+ycCvumpJYJcwKRI4hW0J2cOJ2cWHWwWTrxR1mY=; b=Zi1A/v36yMFYyImGD1abZB8hDR1QHhtqcFVqMn0gdDvvO55xnJp6qK+YykaiCxmDlb 9x/i5P0LdkaCncOHDnjgPk0449C4JpQ9FWliVsN3Cic3/DPf5+inLlU5HLFILh8lyqOT M5moO9VRx/7JtpImDd2+h9xgq44l9tStUKR5ZLOBIWrYFAzY7HRkUCVqyT3vPEX+Co9v NGQH+WlkkBV8c1iPGmTVIZResgz/HhyoLnAIzsEfhidIy8dJBye+9TIQNXIXvJKjzHng TSZjyKPLX/2DH3uZmQNmUgC65kNPUOnyeg6Ug2J1UNfe4E5VrZe0jxofCHbp6i7KSRu+ Nnow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770259542; x=1770864342; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GaTc+ycCvumpJYJcwKRI4hW0J2cOJ2cWHWwWTrxR1mY=; b=cgLN6GaJWpYGZhmaRnPqc2daQ72TGnQxBaSRY86LZNR/l7NW4s0asnutWMVFRtymls OYuf0PRRn4Tll0v4cl59dYljA9M0HQXWGmZEgRGRz64GxLI8c3jtdcsV25Ma0VZTThDt aXxU9ORAocs3jjoBnOHGrEinwwE2wR8uX78a0wKGaGTKImHmDZ/HFddD71+3vkadclZN SBxjRZoAu6im8jk9nNbH9JND1RdMQLeWLm+0I/6iF8YoSlCQMqjqL9WUlvZKlePDQKwy ivF2t/kk36EA2pNdYbSyY7Jm63o3U+sMjpQ5Z30TDqxSWNMGOUC4kM0LhHafs/oSZ0XZ b1dQ== X-Gm-Message-State: AOJu0YzvS43DOopHaqkS65LQweWpndvuQfGomFbGP6WosRaP/RLf+f6U texo3VEGtkMdzyZtH1N1HrGd7j6xBEsuqmkdZZ06uV3AipNrD26dHDBzpggrjQ== X-Gm-Gg: AZuq6aJ3XnNYr4935cPFC9b5tM2eU5C34OIR+32rSCRo/UC4BugsoPaWU0s34KSj2O8 WJGzWNKLerEbL3oni8zBdyHD84WSYd7X1fMTr2KSels1DxoZubOaN/utgop2zAwkJXr5vxDxJp9 B0NvSvSaLeN5Zo063We7zsbHTCq3lh1fT2yVqSQ7EOMEkj7R+pd0dE0H7ghZYumX+Gzt68TvhFM qViswd1y3htO61nOg3B7FUXbmcN+ZaUFDxbhJBWk4ozwCR8cuMpuyS/U7hO16+rifzVOH4gA7Vx 7aZQ5Gl+ytz9RbUCUYhCob8pkPvJgrEhKejXq5Ul3czoI0c2UCESSIGIymbf8mGOXr4rGNyAsU6 17YxA2zK+azHsN2Jo3F0YwlQz3whYS+9N5+xBdw8/dAhP0ak2a6nmLuz+GOQosBvytJ34Vwl6uC iEq4NM2PFN4mHULYAaZmW2aBxbzcrPMq43PJM= X-Received: by 2002:a17:902:f70b:b0:2a0:906b:ac35 with SMTP id d9443c01a7336-2a933fdcf09mr56997075ad.42.1770259541401; Wed, 04 Feb 2026 18:45:41 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.239]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a93385127bsm39541105ad.1.2026.02.04.18.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 18:45:40 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH v2] timers/migration: Ensure proper resource cleanup on error in tmigr_init Date: Thu, 5 Feb 2026 10:45:37 +0800 Message-ID: <20260205024537.100664-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <87sebg1r89.ffs@tglx> References: <87sebg1r89.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Free resources allocated by zalloc_cpumask_var and kcalloc on failure. Reviewed-by: Thomas Gleixner Signed-off-by: Zhan Xusheng --- kernel/time/timer_migration.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c index 18dda1aa782d..ab8354ad85be 100644 --- a/kernel/time/timer_migration.c +++ b/kernel/time/timer_migration.c @@ -1994,7 +1994,7 @@ static int __init tmigr_init(void) =20 tmigr_level_list =3D kcalloc(tmigr_hierarchy_levels, sizeof(struct list_h= ead), GFP_KERNEL); if (!tmigr_level_list) - goto err; + goto err_free_cpumask; =20 for (i =3D 0; i < tmigr_hierarchy_levels; i++) INIT_LIST_HEAD(&tmigr_level_list[i]); @@ -2007,15 +2007,24 @@ static int __init tmigr_init(void) ret =3D cpuhp_setup_state(CPUHP_TMIGR_PREPARE, "tmigr:prepare", tmigr_cpu_prepare, NULL); if (ret) - goto err; + goto err_free_level_list; =20 ret =3D cpuhp_setup_state(CPUHP_AP_TMIGR_ONLINE, "tmigr:online", tmigr_set_cpu_available, tmigr_clear_cpu_available); if (ret) - goto err; + goto err_remove_prepare_state; =20 return 0; =20 +err_remove_prepare_state: + cpuhp_remove_state(CPUHP_TMIGR_PREPARE); + +err_free_level_list: + kfree(tmigr_level_list); + +err_free_cpumask: + free_cpumask_var(tmigr_available_cpumask); + err: pr_err("Timer migration setup failed\n"); return ret; --=20 2.43.0