From nobody Sat Feb 7 04:47:32 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3889292B44 for ; Thu, 5 Feb 2026 01:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255349; cv=none; b=OEZnxc0epJNc3eKMn7CkJhGhPeGWmFvFu1rF8hOhH4A9AQhTxsps16lpZ7Et5G1L47X+YJXu+QTl8QnpdrqKV1kuiBnONkcacO453VuEwK9ILs9DbcMx3fDsOoIBLBRlObaOkKSUjkOkzx+cWHrr2MWhIhmQ1Nju/YtIRA+TJ+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255349; c=relaxed/simple; bh=a5VJa/3HQljIKgbSk3fzRur4DvUYq94MD1TqWGsXxm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L6PUCtr5fG2ClmFdq3nfL+1Wnj6OuTkFyBHx1yP3MXbIN6Kql4doB/2lvy7XoydAPoM/Zc4fgryzsuBi+22s9ZxJyRKXVt8vVWsXz4/uqu0RnBceNyxeJEvkJCxQCqXwNQFD1TYhUuLumVJkb7eGgI1P2ModxmWmpbXCL/6leI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lNkc7bqL; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lNkc7bqL" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2b8397e3e09so589900eec.0 for ; Wed, 04 Feb 2026 17:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770255348; x=1770860148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IW48nM3DmZSMMmpiusrL/Y8AeUwB4gdi5tKxeg6LSPU=; b=lNkc7bqLQYVgWfFF4qm0yYzAD5WimVygohG8cVqygqeRtA3/ghD+s7+HDBVshT9MHp a1BGs4D3yfIgfhIBQl8JmdecowAxcORi+m+rOHLs5sSgaX/xIqvQvSyqi9EoppuU/2G3 UmItM6GmISlvL46c/XfnxH2QWvChqZLisOqhkuXHXv2q7vJUfkAOGewNKSp7BoTGCnlX zeHdW9ZJPNtGd/6mghf3E401p7IJlCnJ1DAHmEmglQZmwacKEhFbjEbop3abwCiR0K7i dzeX4WYclNIHHHWKbJ8ImuA2l0EdnwzDPYzLMzp1jhKrZQL1RBZPPtvRa1ky+gFk+DNZ t4kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770255348; x=1770860148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IW48nM3DmZSMMmpiusrL/Y8AeUwB4gdi5tKxeg6LSPU=; b=NICwkFXDVXTz+YrvX7wbrCACqQ7SovQQ56sK/B9dZd5z9fyAwWNIwXQaQfAgQDFGYw 4Jj7UYnCaUzrTpzw0RUy4ZHC5PtiNsT5dFZY7Vs23ahJFLON243XiMF2MsWNVBh4j99G h9OJZOfFKWgHz8PdGhpU7ycrBUrNYhFmjXrwy1ULRlfF1HbSJdcV8iRG3n2tLNuRik4F dI4C17fSo+s6qMeplvopK66c8FTL12ULP4OGo1+H56TM2B6LPjBKQEDLdUTYQv1Oy06j yXm9gpAWkc+0GRiDxLTYmysjzVAJo0TnL1o11EfOQzTvf+ao/fCurOicaSQBMb9VP8ni tHbA== X-Gm-Message-State: AOJu0Yy2wnYTxGWHJSuimgPvz72mTjm+tiyfpHZVcpOEGwuGi6bIXGIU hAXW+sAmKMU55jpiDpGL/O1mH1x1NOu+xHxWvZYUwz17TFZTOTY3qgcQ/sM+gQ== X-Gm-Gg: AZuq6aKNEfFcxRqGfCM2fnratdXurG9bV7n3HJQ8WWeNColQqtJCZIdwY3Rs+WW+NiR 14LUvWLxeEv8SZOQsSOvM1/oN3Nra52LhP1gxDNGElocqNqTg76EGN5t0KgKfKCd0zoayMuLmwT ddrYgSd8xk6dSp/FmiGVLX6ZV+HKWQEcTU35wN5wFlBPTdmiKa2IUDUgOoOa+5r/gxarytL1aXi ihqUDCM4UEftgkGruycmpMYOoOmSYfu2bp6e2jmbbRPRiM0stzeSsrYmNgmLzROoHbtKfwa8vih z/eSJFB9bSDoUI0GK+ji6Viltu8ll2kIRMbxmtok2Q4ZVsE80CmsVzByIxT9keqgQEsGSZ4j9R6 TDmg3lFBIbYYys05o/UIhrWTT6Pf5s+nmcD+dxegWZaRBnQVOLdVRq2IbxL+HTaXmNb9buA9FrN vzhmd342KYzlSZ/cEEWW75PmzRvcIEUyZJOUx9yrU2olQUcRrDDM3Qfw== X-Received: by 2002:a05:7301:2f8c:b0:2ae:533d:19ee with SMTP id 5a478bee46e88-2b8329e39a7mr2414062eec.21.1770255348163; Wed, 04 Feb 2026 17:35:48 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-126f4e0f98asm3424982c88.5.2026.02.04.17.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 17:35:47 -0800 (PST) From: "Vishal Moola (Oracle)" To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , Dave Hansen Cc: akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Andy Lutomirski , Peter Zijlstra , "Vishal Moola (Oracle)" , Dave Hansen Subject: [PATCH v4 1/4] mm: Add address apis for ptdescs Date: Wed, 4 Feb 2026 17:35:24 -0800 Message-ID: <20260205013527.322157-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205013527.322157-1-vishal.moola@gmail.com> References: <20260205013527.322157-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Architectures frequently only care about the address associated with a page table. The current ptdesc api forced callers to acquire a ptdesc to use them. Add more apis to abstract ptdescs away from architectures that don't need the descriptor. This patch adds pgtable_alloc() and pgtable_free() to operate on the underlying addresses associated with page table descriptors, similar to get_free_pages() and free_pages(). The allocations will be zeroed since theres no reason to want a page table with stale data. Suggested-by: Dave Hansen Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 4 ++++ mm/memory.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index f8a8fd47399c..3f3000567823 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -3419,6 +3419,10 @@ static inline void __pagetable_free(struct ptdesc *p= t) __free_pages(page, compound_order(page)); } =20 +unsigned long pgtable_alloc_addr_noprof(gfp_t gfp, unsigned int order); +#define pgtable_alloc_addr(...) alloc_hooks(pgtable_alloc_addr_noprof(= __VA_ARGS__)) +void pgtable_free_addr(const void *addr); + #ifdef CONFIG_ASYNC_KERNEL_PGTABLE_FREE void pagetable_free_kernel(struct ptdesc *pt); #else diff --git a/mm/memory.c b/mm/memory.c index d6d273eb2189..96c4c4d06aa1 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -7451,6 +7451,40 @@ long copy_folio_from_user(struct folio *dst_folio, } #endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ =20 +/** + * pgtable_alloc_addr - Allocate pagetables to get an address + * @gfp: GFP flags + * @order: desired pagetable order + * + * pgtable_alloc_addr is like pagetable_alloc. This is for callers who onl= y want a + * page table's address, not its ptdesc. + * + * Return: The address associated with the allocated page table, or 0 on + * failure. + */ +unsigned long pgtable_alloc_addr_noprof(gfp_t gfp, unsigned int order) +{ + struct ptdesc *ptdesc =3D pagetable_alloc_noprof(gfp | __GFP_ZERO, order); + + if (!ptdesc) + return 0; + return (unsigned long) ptdesc_address(ptdesc); +} + +/** + * pgtable_free_addr - Free pagetables by address + * @addr: The virtual address from pgtable_alloc() + * + * This function is for callers who have the address but no ptdesc. If you + * have the ptdesc, use pagetable_free() instead. + */ +void pgtable_free_addr(const void *addr) +{ + struct ptdesc *ptdesc =3D virt_to_ptdesc(addr); + + pagetable_free(ptdesc); +} + #if defined(CONFIG_SPLIT_PTE_PTLOCKS) && ALLOC_SPLIT_PTLOCKS =20 static struct kmem_cache *page_ptl_cachep; --=20 2.52.0 From nobody Sat Feb 7 04:47:32 2026 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03E80298CAB for ; Thu, 5 Feb 2026 01:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255351; cv=none; b=qvN/yHRkXtkRfDZmkgkB5A5h4WnezbAYabwXe6XpAY4yCD13Hol/GnHvCg3bs3iuMsQ6nwPRBQOfBZETeVMd5f/UiWBwHsejMdyLMQAfpS8BBK0ERKyNirownLw11mpeHdXaDcJ3yQpV2a1HWESogpZP7+vKUrP0pe51hMYs5lI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255351; c=relaxed/simple; bh=ObmdkjbC2W6Ftm8OZa3tEwzcrExjrV5+TDSBt1PO7ig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qirMBYlI1/mQiI22pKj8Z7Bc8j/P2yTfRqLSLK2/cgb6R7iU4sEoZU7RJHcWyzzgrvndeJZ5NBUB1UeewmFqnE1nScCMPWzWctOoawr4oBFq/RdUf4uyOMDNRTgY0RvNqY2zbAkTp9i/x+j3zVbhWE1/cAQ08DKqEANYfUEdu8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bZZvhM4s; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bZZvhM4s" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-124a1b4dd40so1036220c88.0 for ; Wed, 04 Feb 2026 17:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770255350; x=1770860150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4jB+pKLVdpa0bbqVI1xb7HhQNNAElviybHSqCegf2x4=; b=bZZvhM4sJA5Ggl7iCMVcOv1/F6klnaU+PVfw3qddhbdFKgBZfD4DYnUdcn3/VHiF/j 7Qyc0fzRIJTNm7GqSrxmKE6+MqdFjq1OJbUldpM3iJigz1PdjLTwxEcpc3R2a8nrcs+3 ZparIMutK23RJP4wZGQDKUF+UpqF754/EiWhDh8zz6NJg0UaKoDvIbACNjKJUR5NiUrB EbmNGIUXrIvkYFI/ALK+bzzQqBcYxjpSuD4JcLEAixziK8ZrjSOqB1fV9vXxE4f+YsDO kie8nNoe/rnBllGgj3oRDRhDPuDNf0XWUbP7TcU8CR2XGb0MRFL5+AdVt63GvV9R76Ab kkpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770255350; x=1770860150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4jB+pKLVdpa0bbqVI1xb7HhQNNAElviybHSqCegf2x4=; b=akoHNKgWXRRvXbnW15yWTRH19/I+j4GrpZWJuHcc2z9cSnzVxAbmMryuNSp9CXaLV2 O9oLKZee7keQfsYN8/fGDQly5+ygEiD6jJ7gggNRxKOvqOqrX9P53rYJ9Oxz6GKsA8SG VzKaEgeOdGXtO+OqX4wCctGbHQ9ZqBEaq2SzwaJXCG8lqob8DyJ2UFWc3ctn8M3oSf6I 32qjXZTO1i1Uy9x4ji3Wt19FldVcbzkjV6X2xVOsiyH2a5pkdH5OPglZjz8/Q/4rfWTP 6Pe6AwXf89bfXTzih+m9AVqVjer8r1G0LCmXQ4OTwkAJOZtQg8YpBBMr8im5YbP0tAEE oEtA== X-Gm-Message-State: AOJu0YxAcuaUw+t9OvHs2Ifw1XQ7qzkBOl1JDInJIFLzePvlS+ew4Ef8 gt/aQgSfTrhSclUFttFin8gv0OOsHDj1++zEDXYa4KklPZXL8rJVwHNJ9oeSBg== X-Gm-Gg: AZuq6aKhB+54t5HLYU08ZWRO0kxwK2S6WHc6rszSE1RGQ662izOYY9B7sqZe5G0RhK2 iAbiSPMc67GVepa3BCq8DiBTkZB3TLQ0PE8OXZJcTcHsKc4+d43TiiLe4wb0sjHifXK4eQdS4Ch 7W5G5ZER4t9Xin6E3F+NloGaqqmwrjGkwjcg8EoRlW8Uq/N4+WIuTms/zHGNxmek4E2KypgJkbU BJSbRTp/i+3+GGOjNl509gJv0tKuRfwRO7D06guLqWZ+ARXfmHqXa5dKu8mSQdqml69uY373jYg eInZeueCq63xdYpZh7Wn7oVCRrIEvLm0O57gyku2wmNmOEAVLfSYmgm7Q0J6x764UmZsbD/Byzm agW/DSuedqh3PowJLNYWvrYkHXcctlbGlvIehyP1GpCyKEuwAiJgdtZcZIf/rWLVu3W9Tmf8JnW wp9Wh8HIS6FDrvtInQA5gmftyVIHxy9qdoF1GyTmHVTJU= X-Received: by 2002:a05:7022:10f:b0:119:e56b:9581 with SMTP id a92af1059eb24-126f4771da3mr1937601c88.6.1770255349537; Wed, 04 Feb 2026 17:35:49 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-126f4e0f98asm3424982c88.5.2026.02.04.17.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 17:35:49 -0800 (PST) From: "Vishal Moola (Oracle)" To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , Dave Hansen Cc: akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Andy Lutomirski , Peter Zijlstra , "Vishal Moola (Oracle)" Subject: [PATCH v4 2/4] x86/mm/pat: Convert pte code to use ptdescs Date: Wed, 4 Feb 2026 17:35:25 -0800 Message-ID: <20260205013527.322157-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205013527.322157-1-vishal.moola@gmail.com> References: <20260205013527.322157-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We need all allocation and free sites to use the ptdesc APIs in order to allocate them separately from regular pages. Convert these pte allocation/free sites to use ptdescs. Also, rename *_pte_page() functions to *_pte(). Rename them now to avoid any confusion later. Eventually these allocations will be backed by a ptdesc not a page, but that's not important to callers either. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/mm/pat/set_memory.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index 6c6eb486f7a6..c6c68fbbb046 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -1400,7 +1400,7 @@ static int collapse_large_pages(unsigned long addr, s= truct list_head *pgtables) return collapsed; } =20 -static bool try_to_free_pte_page(pte_t *pte) +static bool try_to_free_pte(pte_t *pte) { int i; =20 @@ -1408,7 +1408,7 @@ static bool try_to_free_pte_page(pte_t *pte) if (!pte_none(pte[i])) return false; =20 - free_page((unsigned long)pte); + pgtable_free_addr(pte); return true; } =20 @@ -1435,7 +1435,7 @@ static bool unmap_pte_range(pmd_t *pmd, unsigned long= start, unsigned long end) pte++; } =20 - if (try_to_free_pte_page((pte_t *)pmd_page_vaddr(*pmd))) { + if (try_to_free_pte((pte_t *)pmd_page_vaddr(*pmd))) { pmd_clear(pmd); return true; } @@ -1537,9 +1537,9 @@ static void unmap_pud_range(p4d_t *p4d, unsigned long= start, unsigned long end) */ } =20 -static int alloc_pte_page(pmd_t *pmd) +static int alloc_pte(pmd_t *pmd) { - pte_t *pte =3D (pte_t *)get_zeroed_page(GFP_KERNEL); + pte_t *pte =3D (pte_t *) pgtable_alloc_addr(GFP_KERNEL, 0); if (!pte) return -1; =20 @@ -1600,7 +1600,7 @@ static long populate_pmd(struct cpa_data *cpa, */ pmd =3D pmd_offset(pud, start); if (pmd_none(*pmd)) - if (alloc_pte_page(pmd)) + if (alloc_pte(pmd)) return -1; =20 populate_pte(cpa, start, pre_end, cur_pages, pmd, pgprot); @@ -1641,7 +1641,7 @@ static long populate_pmd(struct cpa_data *cpa, if (start < end) { pmd =3D pmd_offset(pud, start); if (pmd_none(*pmd)) - if (alloc_pte_page(pmd)) + if (alloc_pte(pmd)) return -1; =20 populate_pte(cpa, start, end, num_pages - cur_pages, --=20 2.52.0 From nobody Sat Feb 7 04:47:32 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2B828DF07 for ; Thu, 5 Feb 2026 01:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255352; cv=none; b=Zmk7QHJUrAT9UiH4+rj+lkcRaf+2x9QLMP3VXa+OEeT/k85VoOUIIXSwXM+kVV2IFE/Jf79yRt7I5baUSfCGBtxY0wQLtAnbYTxUDVja6INP0sdEjhBMAV24C9QdZnx6hp4lF5vjaE71qb8Bo1acPSXTRzEa1VEPh7UQUZrb2TI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255352; c=relaxed/simple; bh=vnefgSUg/EyZcfdw3rPiNEtAaxMblSpzza1WocM12gI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hh+9vFnXR8trLDUIM7dczvh4EUfBr+1b9sv5vlCK2xLmsNlTo5tnDZIFPrBaZ27aWjexJvc8yvRzNqgdYw73DOYiwfcwYj6uUI2wn+MzwbmgHNdbPGHPb1umT780CV0WMJSdD6NaSRApN6zEF62DjbWBDxqBCQ98fp0YQC6MxQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hUp6qhUx; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hUp6qhUx" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-126ea4b77adso455315c88.1 for ; Wed, 04 Feb 2026 17:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770255351; x=1770860151; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JS1rPHn8kZyPcvTQXgyDxncq77srAM3QsnsXxPBvNxs=; b=hUp6qhUx+muphAKqVWxAkNK8xs3u5eCbnq2+VpcgUz2iJVZtSzAbl7tNJFaRlUUF5B 7RODwIqWLHuIDjXGRAuV2AC+RTUvSTBj4FItaJMjKve05wH9sKLMqTbK9aZl8ueOlmt6 x58ZLmdj/Ori5EHZmqUedKeyduh69KiK979/4UwEV6gbsaD2Zqz0PGMVLkEEHTUgC4Rl QjDWIDUk05qztmSCohD6Ubw5Dba7EyCytDnhZgWA/AXGT3sAIW7an+Rtpp0ecwgv0Hc4 +mQq4OpWcUHk1ijzlcyALJQrbOmuTBAOzTCD/jcVZZYY5Pq7REYb19XtrjaoTrikTSBb N0Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770255351; x=1770860151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JS1rPHn8kZyPcvTQXgyDxncq77srAM3QsnsXxPBvNxs=; b=qVdX0LaVP1zPrXvUFXP5t+tZQ+1FIpmHGxojnGz5oh/415PMh1RcBUAa7+on+RKTci 2IxsxLvzh5BuWzkxXLlkjSS/FfKRlumCtiKQm7t6FfuXgwogFi6Hg8/+AcpK8MfRZ/xK /Zth9jQbGALRD4X97Al/8G9QlSDbAx0JeCkb8GOna8rBjoGcn55o6T83DtM6HGq0lgKt 7nS/lX9zKpJBC91t3Qi4KxRUFTZRjtPGwM7EYlFgoT45CUfQ5oUvli/mzMVXUWR41+Mr vePWktmzArvE0S/nvKHdLzwDsVme7PzJGIXGyirriY0uDNl18yYTDezKNkNSgqbcHXXC sJSQ== X-Gm-Message-State: AOJu0YyLPS3zYt4YYXv0SY4Sd6C5FDGL/mhc2sJZL5By6hxS2L/rv2qQ aqSuu1Nz0Sf9ssUsa+E26qyJQLjYFO+kITgvLl/DRQV4TYg+jZf99mx6v0flVA== X-Gm-Gg: AZuq6aL2x8OT4j8FPNadja590DbEHbso2jVOla+MgUTgsOCaliYQJBITK1VnwL3ii91 gkuiubyYT0qOtYsJHyaXjTjlVE/dFJ+A0H/dtziGI+xJif3+gl46komrXEauNsuxxvqR4zXlrxU et6YJg/X8i9duekVASrOPuSVZ3pcgpKG+YvHJcch/TQxgHs9QmlM7j1mZG3GZMTvl1ztZx2jQSm wWMF8hEym+YyMLJ/tjIz4jh8X7jjGogrNiM2eNIH7cgInTlMx2A7Km4Id18m6QYOJf8wDUGJbl7 cL7k4SAKfXyv2+wHjXGezUYzic3ozW0RBHO65tYvWh2CHTBAsmKxQND608wWV4g99HOC0L5buq8 DGbEGKCVQCyoas9RpSlMiIL+b4HqB/fsDNpAN8VEQEfVuFccH7SNDzYilKMpwB59b9oxDu24wI5 TjKh2uM7BOx2+cL7RAQlrd7DJOEA4HLF9QJXyfy4LMLpDYWRAcbXAH1g== X-Received: by 2002:a05:7022:207:b0:124:adfd:623d with SMTP id a92af1059eb24-126f47c3357mr2146966c88.31.1770255350963; Wed, 04 Feb 2026 17:35:50 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-126f4e0f98asm3424982c88.5.2026.02.04.17.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 17:35:50 -0800 (PST) From: "Vishal Moola (Oracle)" To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , Dave Hansen Cc: akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Andy Lutomirski , Peter Zijlstra , "Vishal Moola (Oracle)" Subject: [PATCH v4 3/4] x86/mm/pat: Convert pmd code to use ptdescs Date: Wed, 4 Feb 2026 17:35:26 -0800 Message-ID: <20260205013527.322157-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205013527.322157-1-vishal.moola@gmail.com> References: <20260205013527.322157-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We need all allocation and free sites to use the ptdesc APIs in order to allocate them separately from regular pages. Convert these pmd allocation/free sites to use ptdescs. populate_pgd() also allocates pagetables that may later be freed by try_to_free_pmd_page(), so allocate ptdescs there as well. Also, rename *_pmd_page() functions to *_pmd(). Rename them now to avoid any confusion later. Eventually these allocations will be backed by a ptdesc not a page, but that's not important to callers either. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/mm/pat/set_memory.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index c6c68fbbb046..dfe05cdf460c 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -1412,7 +1412,7 @@ static bool try_to_free_pte(pte_t *pte) return true; } =20 -static bool try_to_free_pmd_page(pmd_t *pmd) +static bool try_to_free_pmd(pmd_t *pmd) { int i; =20 @@ -1420,7 +1420,7 @@ static bool try_to_free_pmd_page(pmd_t *pmd) if (!pmd_none(pmd[i])) return false; =20 - free_page((unsigned long)pmd); + pgtable_free_addr(pmd); return true; } =20 @@ -1446,7 +1446,7 @@ static void __unmap_pmd_range(pud_t *pud, pmd_t *pmd, unsigned long start, unsigned long end) { if (unmap_pte_range(pmd, start, end)) - if (try_to_free_pmd_page(pud_pgtable(*pud))) + if (try_to_free_pmd(pud_pgtable(*pud))) pud_clear(pud); } =20 @@ -1490,7 +1490,7 @@ static void unmap_pmd_range(pud_t *pud, unsigned long= start, unsigned long end) * Try again to free the PMD page if haven't succeeded above. */ if (!pud_none(*pud)) - if (try_to_free_pmd_page(pud_pgtable(*pud))) + if (try_to_free_pmd(pud_pgtable(*pud))) pud_clear(pud); } =20 @@ -1547,9 +1547,9 @@ static int alloc_pte(pmd_t *pmd) return 0; } =20 -static int alloc_pmd_page(pud_t *pud) +static int alloc_pmd(pud_t *pud) { - pmd_t *pmd =3D (pmd_t *)get_zeroed_page(GFP_KERNEL); + pmd_t *pmd =3D (pmd_t *) pgtable_alloc_addr(GFP_KERNEL, 0); if (!pmd) return -1; =20 @@ -1622,7 +1622,7 @@ static long populate_pmd(struct cpa_data *cpa, * We cannot use a 1G page so allocate a PMD page if needed. */ if (pud_none(*pud)) - if (alloc_pmd_page(pud)) + if (alloc_pmd(pud)) return -1; =20 pmd =3D pmd_offset(pud, start); @@ -1678,7 +1678,7 @@ static int populate_pud(struct cpa_data *cpa, unsigne= d long start, p4d_t *p4d, * Need a PMD page? */ if (pud_none(*pud)) - if (alloc_pmd_page(pud)) + if (alloc_pmd(pud)) return -1; =20 cur_pages =3D populate_pmd(cpa, start, pre_end, cur_pages, @@ -1715,7 +1715,7 @@ static int populate_pud(struct cpa_data *cpa, unsigne= d long start, p4d_t *p4d, =20 pud =3D pud_offset(p4d, start); if (pud_none(*pud)) - if (alloc_pmd_page(pud)) + if (alloc_pmd(pud)) return -1; =20 tmp =3D populate_pmd(cpa, start, end, cpa->numpages - cur_pages, @@ -1743,7 +1743,7 @@ static int populate_pgd(struct cpa_data *cpa, unsigne= d long addr) pgd_entry =3D cpa->pgd + pgd_index(addr); =20 if (pgd_none(*pgd_entry)) { - p4d =3D (p4d_t *)get_zeroed_page(GFP_KERNEL); + p4d =3D (p4d_t *)pgtable_alloc_addr(GFP_KERNEL, 0); if (!p4d) return -1; =20 @@ -1755,7 +1755,7 @@ static int populate_pgd(struct cpa_data *cpa, unsigne= d long addr) */ p4d =3D p4d_offset(pgd_entry, addr); if (p4d_none(*p4d)) { - pud =3D (pud_t *)get_zeroed_page(GFP_KERNEL); + pud =3D (pud_t *)pgtable_alloc_addr(GFP_KERNEL, 0); if (!pud) return -1; =20 --=20 2.52.0 From nobody Sat Feb 7 04:47:32 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3401129B22F for ; Thu, 5 Feb 2026 01:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255354; cv=none; b=VMAu64cA2K+yPiEn/fBBeHNsoWjZhNIhB/UM6pXq9ZXGUfNE8cpU/TK6IxMfE0WYWEBKE0jm1RLipy2nC+dflYHoM5+hEfykGdWZfdLFIIU/+YCXezieY6hr2pVAeNXYmvSVUSWZOm0uuujNlB6o5uuaVjotvXd/fQ32Iypgdco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770255354; c=relaxed/simple; bh=n21PSZcBP2kgIaoriiGPGo42ii/uLL897xP2Y7tvyms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=moDTm53q5gRV0nKiLgeKVEz+Gt27q5g9yB04ENEg0OxvhWQh1DPFSsk32ZMYpV6WM65mwADpZ9R41zzgKL9ARa17o/EBSbK+qnK4URBVdcdqNd9XjofcPGAedxSLLPmkvY1M/SnFoWygmzI3ikjh9fqPI5fCrVQXMgWzfZuh+cY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QsC08TVF; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QsC08TVF" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2b834e17c3fso374940eec.0 for ; Wed, 04 Feb 2026 17:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770255353; x=1770860153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UFN9WQ43/aevrauLhpt7dEPveYAFUArl8cBKZr8FsjM=; b=QsC08TVF14ti3cfFrJJjLW1weKtlYdm+kt4kdqMWzzlrgSB0bf5QfRrus5VZgSMDJB OJ5X8vBSBEZsfEwPyHnpC/r2oyWnDolEw6GNMpNGF6S4zDkPJcF20x9/ZEkMb4lJ6p7Z pPpc/acwQnlWuWsHKXBVDVgfWM7MUgbfSvLCZV6R+egYO0VXaqWRa8yAbMQN3M48SMmI UclBqR9s282XoLLCNYiX7g1ZhP90DDmUq4NKaHb4Jz1pmrPH4tr4Mw/w3fm5KkvCFJmy /06sT65U+m3l79RApLrDwyBB3OHsmUsZjidlVN4izrtS2sgvzFJl1dnplhGZZSfmBnMZ qQqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770255353; x=1770860153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UFN9WQ43/aevrauLhpt7dEPveYAFUArl8cBKZr8FsjM=; b=Xj29VnwYc8Q3Ra3/BSq9kD4D4EgwwS8rcjAnOWq8FDap82fuzgHFohKMPr/4vuIPn+ g0efELD+VfLQ0IK4KvClTKRS8vtugr0miIJUf7nTmkAXpITX6K4le+yy/0zxX3U4YnLn /ARquAAdF0VzXnjAS+czaUWLaFP7SNUkt/jt3FCGioow8Nzlvlf1VZBzZrTX2q2a7aYB 0nBXMg7WRetptFMgYXVpX5+dZlP4Ove5rR8s5v8PdgEvVdQgVQw1zSOPQyn3/kYTEedu +wkfl3mQBimzJQ0SpXs5EeiwwG726b2F8vJ8sEi4go910poImcf0sU4zIbAS5dvCwlVA +efQ== X-Gm-Message-State: AOJu0YxESHBmOv4y0ebNhglyCaf2cwH26soeFz4p8Nzv5j+gtPPpYPbp T50Tl/in/idrPobSMsRrjMF9G7ti9DMMsmWX9LO/CAm95cu04TvaOzzsxSL2Bg== X-Gm-Gg: AZuq6aKVt828tMGDu/PlHw8UajehMoFepzWoQJkHWnXHm/Bm4Ksd9GPXVp5OqOL2j/V YFBQ0m8EY6OFgqoYdfSgV55sfvL5ucXQRa1tLv9YNM6QBlvqUq/bvY5FWXwc7eYdzXP922e91oA rjQi6EvAuzBaCRBBthCBBBXBr8Ux8DSwyZydB/nkouX/Eack2pSExHQ6OUaFfLiKJM1zxkb31cf OCOrX5GThi9rXNFv5XTZnnuS1RQuMPVVVth4xjq7DdgBnuKsxKQOwN5+h0by0jsutz5W9LKYSvA SN4osf0ZR6Nnlr3nKxjgX7lmkJ6mW3uoV7YPg9PDKVfEgrRV+qfGTuCweW6Dneuv/u202GHl7Ot dLl9vw1uezfE/v03NIttvZ3jGPW5sC02GjRLIyw2WeAWZ+qeWNGvcJZ76UV/GcYd3dZvVY0/dvm /iX9Pug7//y9zsI/zXrp32/koHG5dP/W0XT3621/HsCJ0pXcjSlE/15A== X-Received: by 2002:a05:7300:7fa2:b0:2b6:a622:25f5 with SMTP id 5a478bee46e88-2b8328950b0mr2058646eec.11.1770255352786; Wed, 04 Feb 2026 17:35:52 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-126f4e0f98asm3424982c88.5.2026.02.04.17.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 17:35:52 -0800 (PST) From: "Vishal Moola (Oracle)" To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , Dave Hansen Cc: akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Andy Lutomirski , Peter Zijlstra , "Vishal Moola (Oracle)" Subject: [PATCH v4 4/4] x86/mm/pat: Convert split_large_page() to use ptdescs Date: Wed, 4 Feb 2026 17:35:27 -0800 Message-ID: <20260205013527.322157-5-vishal.moola@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260205013527.322157-1-vishal.moola@gmail.com> References: <20260205013527.322157-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In order to separately allocate ptdescs from pages, we need all allocation and free sites to use the appropriate functions. split_large_page() allocates a page to be used as a page table. This should be allocating a ptdesc, so convert it. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (Microsoft) --- arch/x86/mm/pat/set_memory.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index dfe05cdf460c..dd17034a3c58 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -1119,9 +1119,10 @@ static void split_set_pte(struct cpa_data *cpa, pte_= t *pte, unsigned long pfn, =20 static int __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long addres= s, - struct page *base) + struct ptdesc *ptdesc) { unsigned long lpaddr, lpinc, ref_pfn, pfn, pfninc =3D 1; + struct page *base =3D ptdesc_page(ptdesc); pte_t *pbase =3D (pte_t *)page_address(base); unsigned int i, level; pgprot_t ref_prot; @@ -1226,18 +1227,18 @@ __split_large_page(struct cpa_data *cpa, pte_t *kpt= e, unsigned long address, static int split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address) { - struct page *base; + struct ptdesc *ptdesc; =20 if (!debug_pagealloc_enabled()) spin_unlock(&cpa_lock); - base =3D alloc_pages(GFP_KERNEL, 0); + ptdesc =3D pagetable_alloc(GFP_KERNEL, 0); if (!debug_pagealloc_enabled()) spin_lock(&cpa_lock); - if (!base) + if (!ptdesc) return -ENOMEM; =20 - if (__split_large_page(cpa, kpte, address, base)) - __free_page(base); + if (__split_large_page(cpa, kpte, address, ptdesc)) + pagetable_free(ptdesc); =20 return 0; } --=20 2.52.0