From nobody Mon Feb 9 04:07:47 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF425361DD1 for ; Thu, 5 Feb 2026 08:22:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770279721; cv=none; b=NL16td2/cgs/3AT47trSQdzm8hzmfXBzGYy/aDqMqyFvxEVPyHLF1oN+YJEBQqrZ2ifYc8VDdaI8Mp69GUgNZGWla8DnR5ZMWRMX8ZqaFio4McLXeLb8I3MH9bKrRfuVZkSv1qrKDwSPvcLy78T42yRBrmdo7xDVmnB4dNPS7tQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770279721; c=relaxed/simple; bh=jiW3ZXnEOZX76PllSYO8HYRBw83unl7LOEgietEhHhA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=F9zXa4Ndnq8jV5scCincKKFT3ENlmEXpxOPaHmMSZmCRwAagG7+0O4lLRyshy7K+LLkMgEUJJokcVLRizVw0+NfmdQg8BbJTQuUjlz0siGiwUu+Kq0hJU3/8rOjlCZ7abwLT/qkryIXClp/mlV9zJC7ybCoFMYkVHYzTDyljR6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IUohQ3tT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MSvfKGnO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IUohQ3tT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MSvfKGnO" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6153eJah2641533 for ; Thu, 5 Feb 2026 08:22:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=y9i4TwIvWEN8PiR9U1wcY1 KcMyRCSyGRU8II9XqOB7U=; b=IUohQ3tT/WPmwGy2mHsGCxvfHFBO8M0cSGetZ6 4WkMPvr99rYnkDz8WxIf2if4ts4phyMgGuimDxhaN0rqOcdkZ417ebQL6ZhpdI2Z VLoxGrtfNSyKoCQhWUGc3orPMESmuMS42lGhhDxyH3yYPKw8ZifrMVNf3fR0DRlf DNEOEXanyVjuFMY4v1XIuzjKycBH/VU7VxCWWVA51nvtb2OOg86bNpyf8y+VAD2a mD9UIW02JflKpOTGr2sLDshb1iM4rRTvHZfkJQ3lHdWvZBRNIZ/Tp5YuDZ4ydg9B ddWFknO155mK0m2EU79g+eEnd5vdFeVCgAGBpwRHL2zhAqgg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c47qvaypx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Feb 2026 08:22:00 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-81e81fbbb8cso600430b3a.3 for ; Thu, 05 Feb 2026 00:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770279719; x=1770884519; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=y9i4TwIvWEN8PiR9U1wcY1KcMyRCSyGRU8II9XqOB7U=; b=MSvfKGnO8R2T4tI48Oj5rDMQYSZwtoy6EddpixK803FzA87hidRBQbCcxmIdqWS/eW PHBJSrqrOATzIU5uZyz9g0MJrveAbJoltLYejbDLjSSDwLngnxgRAAAu7YrPT5QGVaVU Qyg+IquHzpqy9i7VbCKnKrMUuPGhE/NRY5/ifstEx3t4Dz0+H8gHODFkoeC3dHyYCXFj NdWGtYRW29Pc3Rui8M8RDJPAikNOjZEhBhehZnV6x9cV1CBOAdg7GDshWwcIWgcfbxYy LZWo/xveV2z+77t1JQ0FMrE2leNnRjWxRyZMoP7O6DfY5+b7A0Z0iT7I5d/vBGoW8PcS xqMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770279719; x=1770884519; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y9i4TwIvWEN8PiR9U1wcY1KcMyRCSyGRU8II9XqOB7U=; b=urCtIknMEXd4H4jlETPZ3CH8AFfVOqJ0AFIG+kB8Fz7WfqXPxrGpy7eYYmSOL24eoU GVCNlRmKSoboQVCZhBYI5Zc1YvTomSWcIExZmGj6pA+S9bGtqN8D5We9EnyyVm3E0rBK lOJRiY1jzWfPj76BTCC3Qdt96fDIbiE20ht0IKTgn99yOo4wH8551LNHm8/7za4qUFy2 YaoF2gaIq6ETwOgW+fOVpHbFxKp2NVRdlx+5m8ObMBWYrx81eJJBo3PW6HGjf+mCAume RF6fpkmNEcd1LgrBHloy283W89T62qTKjKjRdoxy/r5KD0xaZdfkLf7ZhVb/8MqayOsd w+7Q== X-Forwarded-Encrypted: i=1; AJvYcCVeqIf/JFShK5+PIC7tU0hUtiarqEhSJ8C+GP61EaMeqPA7PP264uu5qlru0DE6EHlDW815SoR+XiwEKLE=@vger.kernel.org X-Gm-Message-State: AOJu0YzvKTt1LCiymBdpeZ+KghleTqbgyfaRejfSyzFLDBf9gVRdjjqv 385g4yxj/VkzFBn3nlynQyvRgZOZUdkxa7BCGaXl99UGFF3lztsbDoQJG38iOyY4dy4dujqlyrN SYWJ6R+/sJv77cC1HmNCtH18n1CpUHH8QPz4rNSdOkv4YVS7ef4oSnfWi3aAB8H4OVHw= X-Gm-Gg: AZuq6aLZIznUSA6Z+Kvvx8vq05caZmNgyeNJCZNiDxrDu1JP5ijLuJ9LWTrwy6hknU4 sf+K2MHEFKNayuC8192mfC8engIirnfw7zFBpVVPYTDIfkBx3O4plXJEiOmKbgaWyTSNsz0rPtL owWOjwK85CJ3SqLZVRsxBDzm7jyddYP9q39JqupXBpxVe92gmZ10yWDbDUc9iscX7bQUg5tTzck UTg4TDKn7LygiRWA5EcD0X8zMDK0Si3yxKNbS0gutepLTfXRP9T0C1kzvLNQSkXQeqBxA6b4sLg Zi0KPlOJKgH+KVDGRriO0USMo/ic9KHwWVoDINyfhvAxo/N52Mbt+29sxBcmQRudcbSJ4ieyTXe B/ZQUHla9lfD+OQidaH+2rzBZNl0FMdLeYRc6r+7zeSZMkQ== X-Received: by 2002:a05:6a00:66c4:b0:824:374a:1425 with SMTP id d2e1a72fcca58-824374a1791mr406233b3a.53.1770279719539; Thu, 05 Feb 2026 00:21:59 -0800 (PST) X-Received: by 2002:a05:6a00:66c4:b0:824:374a:1425 with SMTP id d2e1a72fcca58-824374a1791mr406207b3a.53.1770279719018; Thu, 05 Feb 2026 00:21:59 -0800 (PST) Received: from hu-vishsant-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d49e0e4sm5251224b3a.61.2026.02.05.00.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 00:21:58 -0800 (PST) From: Vishnu Santhosh Date: Thu, 05 Feb 2026 13:51:31 +0530 Subject: [PATCH] net: qrtr: Expand control port access to root Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260205-qrtr-control-port-access-permission-v1-1-e900039e92d5@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAApThGkC/x2NQQqDMBAAvyJ77kIMKqZfKT3EdNUFTdLdIAXx7 017nMPMnKAkTAr35gShg5VTrNDeGgirjwshvyqDNXYw1vT4liIYUiySNsxJCvoQSBUzyc7683G aybfOuc73I9RSFpr58788ntf1Beq1Umd1AAAA X-Change-ID: 20260205-qrtr-control-port-access-permission-bfea19994a58 To: Manivannan Sadhasivam , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, chris.lew@oss.qualcomm.com, Deepak Kumar Singh , Vishnu Santhosh X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770279714; l=2228; i=vishnu.santhosh@oss.qualcomm.com; s=20251203; h=from:subject:message-id; bh=jiW3ZXnEOZX76PllSYO8HYRBw83unl7LOEgietEhHhA=; b=5BVvID3XLuTRLyEgXb+XszDuvwbNTM3oC1gXx8dhkJlTlJm0kwqDY/ibd4sRk7S3g+Kw96bV+ EdvKsYi+vGiCdiz8t/S/2rbbW2R5XvSv1cbc1J6thwJRqb5OPgN9Jwv X-Developer-Key: i=vishnu.santhosh@oss.qualcomm.com; a=ed25519; pk=G8/AJPecB1feGI7wxArGWGN0PPGQS0GUaD4THQCbdis= X-Authority-Analysis: v=2.4 cv=GaEaXAXL c=1 sm=1 tr=0 ts=69845328 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=1Fy8072LN9Nq9XkES_AA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: fHDeYeqfj41WaYSRhLoLfgs68BIqA_QJ X-Proofpoint-ORIG-GUID: fHDeYeqfj41WaYSRhLoLfgs68BIqA_QJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA1OSBTYWx0ZWRfXwfsl7nurQFTa tHH2shD2hL1FalbPqRxr/ghaU7jSso1AZ/XNDTMFEnRzDvlxS+nAnifeMlygB6sw0OBI5B2MVFi Xp6e6a5Rs72fhV4/A/+G4G4osZn6Hg7qTDgr3UgRfWX9BWn0Qey/3/k1HOLLqNQnxBSeRQKZns4 qiztU7MVJae9l+byABrDT5vAfsqko5R5adpX0lJkxWkNbyzPohVDC4Jr+fGh1Egc5oB1LIMPHko 7XkLLBpC3RdcrbBijOkv4J8hIc+/z8M2X5jyFtgBtY6sJax9wRNVZ1AX3oq22oOlZlFpNlZch+6 FDfH2yYpWKP/fsFHNnOY3wr13vh5xEofrn7/1bavSMB3IH/OMjGc570vMcUCNDa99szIf1Hug6h zb1+8rHEJ+nrHxNkPJG1FGf7qksGL0pb8pjt2TMUiJSHovYadA5smF4eKEm/zBXcnu1Ngqu9t9V Ig6rgPC4JZc+qjH00mg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_01,2026-02-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050059 When qrtr is loaded as module, qrtr-ns runs from SELinux kmod_t domain. On targets using upstream SELinux policies, this domain does not receive CAP_NET_ADMIN, which prevents it from binding control port even though qrtr-ns is a trusted system component. Granting kmod_t the CAP_NET_ADMIN capability in policy is possible, but not desirable, as kmod_t is not expected to perform networking operations and widening its capability set is discouraged. To address this in a contained way within qrtr, extend the control port permission check to allow binding when either: - the process has CAP_NET_ADMIN, or - the process belongs to GLOBAL_ROOT_GID (root-equivalent tasks) This permits qrtr-ns to successfully bind its control port in kmod_t restricted environments without broadening SELinux capability assignments. Co-developed-by: Deepak Kumar Singh Signed-off-by: Deepak Kumar Singh Signed-off-by: Vishnu Santhosh --- net/qrtr/af_qrtr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/qrtr/af_qrtr.c b/net/qrtr/af_qrtr.c index dab839f61ee93b876021d904ae6b8dca8ed43745..b0e252c16f156c05973988fbdf3= 17a149ad9840d 100644 --- a/net/qrtr/af_qrtr.c +++ b/net/qrtr/af_qrtr.c @@ -8,6 +8,7 @@ #include #include /* For TIOCINQ/OUTQ */ #include +#include #include =20 #include @@ -738,7 +739,8 @@ static int qrtr_port_assign(struct qrtr_sock *ipc, int = *port) if (!*port) { rc =3D xa_alloc(&qrtr_ports, port, ipc, QRTR_EPH_PORT_RANGE, GFP_KERNEL); - } else if (*port < QRTR_MIN_EPH_SOCKET && !capable(CAP_NET_ADMIN)) { + } else if (*port < QRTR_MIN_EPH_SOCKET && !(capable(CAP_NET_ADMIN) || + in_egroup_p(GLOBAL_ROOT_GID))) { rc =3D -EACCES; } else if (*port =3D=3D QRTR_PORT_CTRL) { rc =3D xa_insert(&qrtr_ports, 0, ipc, GFP_KERNEL); --- base-commit: f14faaf3a1fb3b9e4cf2e56269711fb85fba9458 change-id: 20260205-qrtr-control-port-access-permission-bfea19994a58 Best regards, --=20 Vishnu Santhosh