From nobody Sat Feb 7 06:21:16 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10EA23624CA for ; Thu, 5 Feb 2026 12:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770294140; cv=none; b=N5myaqIc7pk66W+kmaU6YHI+msWLC82rfIArhHAR25Hf2uQtF2IB5Y1DKYD33/wYaDhemCQQZizzyIB3G+OmJAI/J3HnTH9+p6fr/+guVXXdt4RSsh1My7mA5LtuzkzziRlAOr8hfXb+ksYhmVhXAjfdaOZEY0/yvJM1JthtNXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770294140; c=relaxed/simple; bh=H2b9qe82F3NXpW5+PmGfSXkyJVfUW6/VsUT/F2lRB8A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:Cc; b=UzFCYyBE0Md4dT0SWAEHo9xHrJlXQJvbUhFs6QVBz1HxzHt+0SUDhqhGtdv7dwwsphDYnFp82pPZ0AcDvnS0O0VBA/lvWa7vU8MOqOO2RJ619pmHVEw35fes2ezpAsU5gyFn11pOUjg/SgbcREkVXqotk1CQlYooNJFeADGSNag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=KPQCjZ/k; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="KPQCjZ/k" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1vny43-00H705-S1; Thu, 05 Feb 2026 13:02:27 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vny42-00H6yV-9N; Thu, 05 Feb 2026 13:02:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1770292945; bh=7tYuSUIFO3bNlvD56jcySwCVe0ZQSlHEZveCIdZShmc=; h=From:Date:Subject:To:Cc:From; b=KPQCjZ/kGxxzve4GOq0lDTPtuufT7AL6PjpiztTMxr9OOpf1PN7Kz7rl2JkSQYWA1 eUuidcdPsHRuJG+Tnn2K7Nc1t85JnPrGWG1CULMUfT0tHB/+qoBHY+UYFIbi9tX8Bq twTQ+XbtY6AJA11ki+IJnOygF/BHxsjHRhIQOTKSbolPVaRnRklqKNlOy/FtDDLjpn X7baniZxOtbXxRMlZHfaLdkHdbrzZEVVfLDlUJvl+G4IEnESuO2uF8tzq6QIxgw+h/ NOmzkAj3eq7PXX1F9xFz9WXsBQ2yjbKZQQ/jvaSUHi4S3/jYJ6c3+JCLmJb3kp6Hvw FFtcVuaiwfx8g== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id D1EB7240040; Thu, 5 Feb 2026 13:02:25 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id CB7FE240036; Thu, 5 Feb 2026 13:02:25 +0100 (CET) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id A6BA22282D; Thu, 5 Feb 2026 13:02:25 +0100 (CET) From: Florian Eckert Date: Thu, 05 Feb 2026 13:02:11 +0100 Subject: [PATCH] phy: intel: phy-intel-lgm-combo: Add missing boot trigger Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260205-phy-intel-lgm-combo-v1-1-dc6e58919585@dev.tdt.de> X-B4-Tracking: v=1; b=H4sIAMKGhGkC/x3MTQ5AMBBA4avIrE1SQwlXEQs/g0lopRUhjbtrL L/FewE8O2EPTRLA8SVerInI0gTGtTcLo0zRQIpKRUrjsT4o5uQNt2XH0e6DxamqSZPOirzOIZa H41nu/9p27/sB4qpCEmUAAAA= X-Change-ID: 20260205-phy-intel-lgm-combo-d79252514393 To: Vinod Koul , Neil Armstrong , Dilip Kota Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Eckert , Florian Eckert X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770292945; l=1629; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=H2b9qe82F3NXpW5+PmGfSXkyJVfUW6/VsUT/F2lRB8A=; b=jlcmrRnyqyHtHGxvEfkimYfaUomV9WJNsim11m/h2MIjd02Ljz2jcamqh+AazeFaID2fZKMkS ibMmEm4Vsf6Axx6oxk0RNGjBVpnjx6ymDhB3tf5RRbAxOzqskgYV+gl X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate-ID: 151534::1770292946-B6E69F62-166307F9/0/0 X-purgate-type: clean X-purgate: clean In the current implementation, the PHY firmware is not started on the LGM. The PCIe RC cannot establish a connection to the PCIe EP via LTSSM, because the PCIe RC on the PHY is never started. Setting the bit 1 in the PCIE_PHY_SRAM_CSR app register boots the PHY firmware. This changes are based on patched kernel sources of the MaxLinear SDK, which can be found at https://github.com/maxlinear/linux Signed-off-by: Florian Eckert --- drivers/phy/intel/phy-intel-lgm-combo.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/phy/intel/phy-intel-lgm-combo.c b/drivers/phy/intel/ph= y-intel-lgm-combo.c index 9ee3cf61cdd00439f6a9b76c715aec0fa95c8a15..61690d418a5632d4b0c685116a4= 43edba1fe8363 100644 --- a/drivers/phy/intel/phy-intel-lgm-combo.c +++ b/drivers/phy/intel/phy-intel-lgm-combo.c @@ -24,6 +24,9 @@ =20 #define PAD_DIS_CFG 0x174 =20 +#define PCIE_PHY_SRAM_CSR 0x08 +#define PCIE_PHY_SRAM_LD_DONE BIT(1) + #define PCS_XF_ATE_OVRD_IN_2 0x3008 #define ADAPT_REQ_MSK GENMASK(5, 4) =20 @@ -345,6 +348,16 @@ static int intel_cbphy_init(struct phy *phy) =20 cbphy->init_cnt++; =20 + combo_phy_w32_off_mask(cbphy->app_base, PCIE_PHY_SRAM_CSR, + PCIE_PHY_SRAM_LD_DONE, + FIELD_PREP(PCIE_PHY_SRAM_LD_DONE, 1)); + + mutex_unlock(&cbphy->lock); + + /* 15ms is required for the FW to take effect after load */ + mdelay(15); + return 0; + err: mutex_unlock(&cbphy->lock); =20 --- base-commit: 18f7fcd5e69a04df57b563360b88be72471d6b62 change-id: 20260205-phy-intel-lgm-combo-d79252514393 Best regards, --=20 Florian Eckert