From nobody Tue Feb 10 12:40:06 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EE4C33508F for ; Thu, 5 Feb 2026 21:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770327767; cv=none; b=kICUiPJRvacornrc23rh5Hqatqu+QlYJuj/hSEp7Wmq28vdqZP81CBQFDCKECtHCQF9XyM/y2APSstbFL8XSlUl3y+u31bm02592LHHYMbKmwZ38JC8gqIAUt9uRhDc8Iwf+3WLNDUbjaFe0hJa9jQucXEvL1v635mWmkuugdqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770327767; c=relaxed/simple; bh=u4sg0GJwh6e+BEq1gu8SNmu5JD78FxHznumDbt705qY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pdKUtTQBEygOTS/1ZpEB5k2csQrSrFFdo9bkJEzysS9OiC3t/BpYyPsWtl1UobfpytVzyh7N9eWzNBzU12irFzsUC+hoGz+yWQrCq4GAFYr3CE46fbscZstlfgcj29WGkuHUIehk7D+o6IAasmuX7JHkAG46TZqdq1Ct5tveW6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xs7mYAxe; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xs7mYAxe" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-65832e566edso2032672a12.2 for ; Thu, 05 Feb 2026 13:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770327760; x=1770932560; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=khuzBcy7Hz6jo0S9i03alRelHLigzIL+h0sUh48v3Z4=; b=xs7mYAxerbmg5OfOg6zqJEFq+eQGrBgS0dwnvnxoxt+TUkZrGA9dak4soSHA9/YvF6 wJo6PXQD6gK0MWcdkwBauNEAoUczScw9yXy3UCYRKppnVZoP4jr+JDUCBntMEhUg3SWM Qg/0BOH2ghJyS1mpKxNK52rQmk1iq6Uz8zj39T2f0rrE9v5gBTBQ5LgKGwmY0K/CbE/o JS8CFHWEZqDHkT70uAt9T6+FM3qE4U1u7XOdHsxjGXsYZ7P7JUxARPOZ91RpAaukxGeW OcI7IdTTGuHMDosWF5++KOfeitJtrI5d2TX31NlJkJgonjd2xsyZk1BSoXmnDqpIge/e tPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770327760; x=1770932560; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=khuzBcy7Hz6jo0S9i03alRelHLigzIL+h0sUh48v3Z4=; b=F4/aEjBeABRZysc1yP5V3SaHPrBfWk+jafebr/cjgh5Tu/rqL7Nv5Lh5LzYta7QGn0 7SBk1OyFIDXgmtySnQ5894j77QMLVwkZ3uEQKozlTHrryso4ykp1ok7AKye5BNZLv4I2 GjMjioTxb6ba2xsf6/RvvP/vf6+z0/Bi6zV9xWbYBAYEc+m2c3kpGhlOY5gDyKLmCpb5 0yM2sQc3pMq59GZZrQPPdS8fxVeO2chOC/5eQKMRvuNxq3nkF5i+QD5Mj9HlGciAebFh 4Iur3a3Z6bSCcRXCjzMwjjSJRrOSkMZhlmWyGLlfNeCfYTOwXysRy9RkMR7W/82/Lrka h6nQ== X-Forwarded-Encrypted: i=1; AJvYcCU63RxMXwPJbPy1VQZa1gwKrOOIFqz1mQsftw3P/iRHnOufcvjz0hlRsTmdAu4fhqC8Jxh6E+wvt3EnGVA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/4/zlXkjh3lwCX4VOZhMz+sP3/Y481XJG5B41mKeyfpIRR1DJ FzeiZZ7gFnWpe7CvkFabNKKq+xQtJWUaZMugda38hfbZIPXX1K9WTjUzMSqqoempGuY= X-Gm-Gg: AZuq6aLs8maiyHKw6U7IW62W8Fq/MoSMWu6kXQ7XVkDGMLr/fEtvbQDQ7HB8YVADugt tI6S2wmbaTUo1Py+t+ciznaA9vCGJoouyh+kS4Ionqy6ytjZweM3fXDBi0vPnO3RXmGY/6C40ig stKrkkgjkxDBTr0skA1tOfRCk+bC7pRI2v6cmEQsW57/b8TPCa0D9te2jSDVBooi5rA8SQTEhcN WliVHIPYKJisAljbG6uwsLelGUO+fCGhUOno1+OiI/DIb/owv4gg3IAQbj1QMW5NQLhoYzpv40o VGLLiQTUe9Ue8BswJtxQFug5KutGj4d1rtDrEq1eKjtnxdvWVWk66RTg7BxHRJD5Ik9EQuSu45+ ypbFEcbFVeCQOF6GMKuxNTVjroKLqmP+197nX2cF+mxLHM1TPKEdxSi8eJGMbeHWAV1A3bbjuYO dYdZLhLN23vSh6e7MqIkDINddMUbliVm97OiRE6wcH4ecSlnxGwmRvmizRmC6jNkrT9Q0+vFtzE G1jQw== X-Received: by 2002:a17:907:9810:b0:b87:39d:2bb4 with SMTP id a640c23a62f3a-b8edf45a619mr26687766b.59.1770327759827; Thu, 05 Feb 2026 13:42:39 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8eda7a0074sm21859966b.18.2026.02.05.13.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 13:42:39 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 05 Feb 2026 21:42:38 +0000 Subject: [PATCH v5 10/10] pmdomain: samsung: implement domain-supply regulator Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260205-gs101-pd-v5-10-ede49cdb57a6@linaro.org> References: <20260205-gs101-pd-v5-0-ede49cdb57a6@linaro.org> In-Reply-To: <20260205-gs101-pd-v5-0-ede49cdb57a6@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Some power domains on Exynos are fed by a regulator rail and therefore regulator control needs be implemented for Exynos power domains. On Google gs101, HSI0 (USB) is one example of such a power domain. While at it, add a to_exynos_pd() to avoid direct use of container_of() in various additional places, and update existing code to use it. Signed-off-by: Andr=C3=A9 Draszik --- drivers/pmdomain/samsung/exynos-pm-domains.c | 53 ++++++++++++++++++++++++= +--- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomai= n/samsung/exynos-pm-domains.c index f59986b56213dfcc470d9cccc61a36a81954bdcc..ed7a5807555bcf86e4ec88166bf= d5f6c06c9322c 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -20,12 +20,15 @@ #include #include #include +#include =20 #define EXYNOS_SMC_CMD_PREPARE_PD_ONOFF 0x82000410 #define EXYNOS_GET_IN_PD_DOWN 0 #define EXYNOS_WAKEUP_PD_DOWN 1 #define EXYNOS_RUNTIME_PM_TZPC_GROUP 2 =20 +#define to_exynos_pd(gpd) container_of_const(gpd, struct exynos_pm_domain,= pd) + struct exynos_pm_domain_config { /* Value for LOCAL_PWR_CFG and STATUS fields for each domain */ u32 local_pwr_cfg; @@ -39,6 +42,7 @@ struct exynos_pm_domain_config { struct exynos_pm_domain { struct regmap *regmap; struct device *dev; + struct regulator *supply; struct generic_pm_domain pd; const struct exynos_pm_domain_config *cfg; u32 configuration_reg; @@ -64,12 +68,10 @@ static int exynos_pd_access_controller_power(struct exy= nos_pm_domain *pd, =20 static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) { - struct exynos_pm_domain *pd; + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); u32 timeout, pwr; int err; =20 - pd =3D container_of(domain, struct exynos_pm_domain, pd); - if (!power_on) { err =3D exynos_pd_access_controller_power(pd, power_on); if (err) { @@ -126,14 +128,45 @@ static int exynos_pd_power(struct generic_pm_domain *= domain, bool power_on) return err; } =20 +static int exynos_pd_regulator_enable(struct regulator *supply) +{ + return supply ? regulator_enable(supply) : 0; +} + +static int exynos_pd_regulator_disable(struct regulator *supply) +{ + return supply ? regulator_disable(supply) : 0; +} + static int exynos_pd_power_on(struct generic_pm_domain *domain) { - return exynos_pd_power(domain, true); + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); + int ret; + + ret =3D exynos_pd_regulator_enable(pd->supply); + if (ret) + return ret; + + ret =3D exynos_pd_power(domain, true); + if (ret) + exynos_pd_regulator_disable(pd->supply); + + return ret; } =20 static int exynos_pd_power_off(struct generic_pm_domain *domain) { - return exynos_pd_power(domain, false); + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); + int ret; + + ret =3D exynos_pd_power(domain, false); + if (ret) + return ret; + + /* Ignore regulator errors - the domain was disabled after all. */ + exynos_pd_regulator_disable(pd->supply); + + return 0; } =20 static const struct exynos_pm_domain_config exynos4210_cfg =3D { @@ -283,6 +316,16 @@ static int exynos_pd_probe(struct platform_device *pde= v) if (ret) return ret; =20 + /* get the domain power supply if required */ + pd->supply =3D devm_regulator_get_optional(dev, "domain"); + if (IS_ERR(pd->supply)) { + if (PTR_ERR(pd->supply) !=3D -ENODEV) + return dev_err_probe(dev, PTR_ERR(pd->supply), + "failed to get domain supply"); + + pd->supply =3D NULL; + } + /* * Some Samsung platforms with bootloaders turning on the splash-screen * and handing it over to the kernel, requires the power-domains to be --=20 2.53.0.rc2.204.g2597b5adb4-goog