From nobody Mon Feb 9 09:09:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9902C3921D6 for ; Thu, 5 Feb 2026 09:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770283269; cv=none; b=UBbOaFav4BEHi5PJVsF0cVbzxS9dE2dwsEZzX8bOdO1dTfBl658H+0DXYr9Td64e9BYTZRIpUxeTYAdDZ67/HwhAao38AC5gP2WEOdWBOsMd2hDl/aOijtVmks6sENCdw4rgcvj7u7AFwoMtNXQh+gyuTucCIKd9/XvgOep9Dis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770283269; c=relaxed/simple; bh=KR1lfA9py9VcnA7CnaicBd9b1jx1HH4FleZGlA3kwl8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S0BuuEsIFYE6Bato2igzUj7kkUZYDYMG+PlTcmwnxrhIR1eiLOoJaXFp8wYom8qmlCscK98l9vwIHSQoSkcLD1xCXwS6/5JnnxrWvfOKOOB2O1phb2jtwjhd9oV7E3riKImMt63gRNzkVMf/hyIvsSKgwoZJDuTo0cmKwdIwgPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pWC84+fZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DUP7vmII; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pWC84+fZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DUP7vmII" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6153du7q2639846 for ; Thu, 5 Feb 2026 09:21:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= g3Dgz+3YUHjLoZot0YgIGQm2oT7n6h0PpInYZRGVXIo=; b=pWC84+fZqd0lbnHm MlxXXK3vyQUxJh2+9giGlhyiFdtqub/TlAmYW4kWT07wf7DtBYG4/+HIwAZVtVNo EWhvANUYDSOLHFnyYggyE4BNDBkdZYmL7DBm2Fa5+diJtDjvBAxyRMQSfoKCniGv Zjb6N71NuRpYCLWQwUUnMlr4+RpJ937WFGvKiHPueuGWGC6ahCugFoAkiUX6PKQn kSXTe83nvvuT2xX9dytm6wgsmCqtPD+S0u8rj4e+/u3yuQVSFZShd7YrvLTmXyNH KfdHYgJArqSKBN3u57ch9Go+sELQO6t6WJp1az16m8Nv3+UWqIP40FYqqTI385gX s3cqpA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c47qvb6ke-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Feb 2026 09:21:08 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89471079a13so48250026d6.0 for ; Thu, 05 Feb 2026 01:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770283268; x=1770888068; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=g3Dgz+3YUHjLoZot0YgIGQm2oT7n6h0PpInYZRGVXIo=; b=DUP7vmIIqKAihRRk0Kux62phnik0S8sdPoZgKb3Upp/TEmuC105uVcQAyAt3GX48HT mNa0/HMZRLKLwdOEq1tpHgoTlFzs7aAB5nppliUJ+SqH4YhbjAb18Xh16AgXG+RE7F5p U+j4r0fPBGf5DwO2LDTI4V3XcUW9TWnHZ0kZK/Meaf92zB559QxApTe7XKlF08hJiaTX JPJTuTf1/+Q8IcJecQS82FWKax6R61fAZIgMGLa/OBn5y4oKJiIDo+aeAD0kMXhz3Naw WgMP7SWE+D9JAhYZSNLAfnp/AOjt1htLEKF/JF0widz6J6Gi/26d/I0CAjYadDrz81O3 iU/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770283268; x=1770888068; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=g3Dgz+3YUHjLoZot0YgIGQm2oT7n6h0PpInYZRGVXIo=; b=Jz3dR6qz7K/awguhTHn+FEdTyLEco2cP72gzcazOKj4R7Z2nAZkn6i1W+NOyKT/JVV 59B4L7nkNmoxDGVGQeL5Y00jaEDheGHKTQIB0UrDu1jpzNXf8fhYSxwGEvv0RHOmfVCK RrJXG0DKN7wHIxEI2LWZsxGHlS6A5maSfgOslbSexjoJLx+MYYLlmLEUpXP2S4WvJCCm duuN9sxx/KDy0wygHZ7R/APQt0zi6hZbhpNo/40kGOSEvEwvglaFQH5OvGFmPRQ91F6l 3YYLcIX7O4bGDJ2+Y/99b3jYXCAUmEtbWgLoBtpwRZnYHlzo4e10VR6g1LtBMReLloKs tmZg== X-Forwarded-Encrypted: i=1; AJvYcCUHQ8phEJA/rgamFbym6VgfoFdrQuM2BrdKmgud77MjibuHpa4kgoSWu6e6H1LhiVSmIlZJCrwL8xKGFIQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0vrNyLF+IcUrCIjIfngg2awOlPagybkEDegeNKMHo6KA2Oxpu Vs6nqPFTVpgzDS6hirg5vuQtqqYSJ1yHwyXFL8CvkVdl3WXpPlSTwSSNJP5LASn9Nh8R85r+liY /6QIKcgB67AzBLA/eUTFjMyGSlHjV573T9OX6OIXR84jSTer0HkRdqQ69iEy1vC1SI9s= X-Gm-Gg: AZuq6aLHARAO7KUAuoSgSwAsimuA8wgzSyC3ShRhwXH9+HmCfdTZwaNn+rB1j1wpP3l lX3QOojBaPXxID9S0eaiTemUEwAkjMoB5w6G0ymqqyk6JrEWR7rw0uPWvhxI2rkKNFUPDxh80VM TAexpJ9i4EkoR8aR6nNjk9LBq/f3gaKj9eWmRe1FN7a8s2szYsVPU2iWnoKnvYa4yCAFowJrxkF 5TbpGYEVaipwkGxKdotqffJMjJUJoa/+zsYIgHuxFmUPrH2BSC6DzSy09yTRlJCxCXCj+gkhesL 0Sk2Sqy9Dvy9dfpMT19ahWjwf1SY0ZkUJ1sfktZhObSxe19wZutXOuptaxbEoaobMoeYh+HApml 4POtYGFvaQjylekFB6Y5bWprilk12VV3fJiAOOY/6GvJMFo2fTPlVJLbWBdjT82NR7zMGJU8= X-Received: by 2002:ad4:4ea3:0:b0:894:7fd1:923a with SMTP id 6a1803df08f44-8952214215dmr80679826d6.24.1770283267828; Thu, 05 Feb 2026 01:21:07 -0800 (PST) X-Received: by 2002:ad4:4ea3:0:b0:894:7fd1:923a with SMTP id 6a1803df08f44-8952214215dmr80679616d6.24.1770283267341; Thu, 05 Feb 2026 01:21:07 -0800 (PST) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ca2fd2c3easm353674885a.32.2026.02.05.01.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 01:21:07 -0800 (PST) From: Yongxing Mou Date: Thu, 05 Feb 2026 17:20:53 +0800 Subject: [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260205-edp_phy-v1-1-231882bbf3f1@oss.qualcomm.com> References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> In-Reply-To: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770283262; l=3768; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=KR1lfA9py9VcnA7CnaicBd9b1jx1HH4FleZGlA3kwl8=; b=WNBKT8KCEyDOW5YYauXcAxqX7LU+YIBpPQPP4xwdsKxXfW/61jDxhHC6JSXRZ0LEsYdxIsiA0 +iBDfr02ygKB/eiglRfgrV53L1MQ4T8FFkNxM/29NRbughvNT4x9Nuv X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Authority-Analysis: v=2.4 cv=GaEaXAXL c=1 sm=1 tr=0 ts=69846104 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=_hJh01-1qFuxGScrDK8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: 3B1x13BQ7MrNmhZu4zoaihaJLCsTJEiG X-Proofpoint-ORIG-GUID: 3B1x13BQ7MrNmhZu4zoaihaJLCsTJEiG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA2NyBTYWx0ZWRfX/F93vQjhs7XD H94pdnWEQ0TLxlHnldCT7Dbjq4LKzwcG23jS71OYVftGPE6WI7uQzIpw599Ohejch6nhfwSO/48 s1QRhVhzv3yae6Q0xpfMETxKh+gF6blDYzyOoFvm3TCHV7THcud2WS04dEnt5NUT80MIfEyNQt8 2khYtXB0DxJK7tovT20QjkhscfTLR9Y8GO/OPMXGwy0EPo5U4h/WLuOCekrMVQK4N9eAeyk+8EX W8nuIoMmRIGNiVv2SzKalI/xYnLEbR9CLRE9rce6yTbo65bMEV6oxGPZt7WtZV+ldosmeLkpsRo iVR4HExQobTmSvroGS8SpZ1A9R7+LS1inYoCZdLKZy58sYp6A/xMxqcyWXls73Qu+XZ2MibREi0 vMCcbIbX9lD47ni+g+D0E9G28Vpe3HvfRn4+tPeLl2t1Pj7tQQjYefWdllymUYpIeqdgBI05fq4 cOKHnY4/gwbGgRFZLnw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_01,2026-02-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050067 According to the current HPG settings, most eDP/DP combo PHYs can reuse the same configuration values. DP mode=EF=BC=9A -sa8775p/sc7280/sc8280xp/x1e80100 -glymur eDP mode(low vdiff): -glymur/sa8775p/sc8280xp/x1e80100 -sc7280 The current driver still keeps multiple versions of these tables and doesn't fully support every combo PHY mode. This patch removes the redundant configs and keeps only the sets we actually use, matching the platforms listed above. Signed-off-by: Yongxing Mou --- drivers/phy/qualcomm/phy-qcom-edp.c | 41 +++++++++------------------------= ---- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy= -qcom-edp.c index 13feab99feec..10cbb7d9a8a0 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -116,17 +116,17 @@ struct qcom_edp { }; =20 static const u8 dp_swing_hbr_rbr[4][4] =3D { - { 0x08, 0x0f, 0x16, 0x1f }, + { 0x07, 0x0f, 0x16, 0x1f }, { 0x11, 0x1e, 0x1f, 0xff }, { 0x16, 0x1f, 0xff, 0xff }, { 0x1f, 0xff, 0xff, 0xff } }; =20 static const u8 dp_pre_emp_hbr_rbr[4][4] =3D { - { 0x00, 0x0d, 0x14, 0x1a }, + { 0x00, 0x0e, 0x15, 0x1a }, { 0x00, 0x0e, 0x15, 0xff }, { 0x00, 0x0e, 0xff, 0xff }, - { 0x03, 0xff, 0xff, 0xff } + { 0x04, 0xff, 0xff, 0xff } }; =20 static const u8 dp_swing_hbr2_hbr3[4][4] =3D { @@ -158,7 +158,7 @@ static const u8 edp_swing_hbr_rbr[4][4] =3D { }; =20 static const u8 edp_pre_emp_hbr_rbr[4][4] =3D { - { 0x05, 0x12, 0x17, 0x1d }, + { 0x05, 0x11, 0x17, 0x1d }, { 0x05, 0x11, 0x18, 0xff }, { 0x06, 0x11, 0xff, 0xff }, { 0x00, 0xff, 0xff, 0xff } @@ -172,10 +172,10 @@ static const u8 edp_swing_hbr2_hbr3[4][4] =3D { }; =20 static const u8 edp_pre_emp_hbr2_hbr3[4][4] =3D { - { 0x08, 0x11, 0x17, 0x1b }, - { 0x00, 0x0c, 0x13, 0xff }, - { 0x05, 0x10, 0xff, 0xff }, - { 0x00, 0xff, 0xff, 0xff } + { 0x0c, 0x15, 0x19, 0x1e }, + { 0x0b, 0x15, 0x19, 0xff }, + { 0x0e, 0x14, 0xff, 0xff }, + { 0x0d, 0xff, 0xff, 0xff } }; =20 static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg= =3D { @@ -193,27 +193,6 @@ static const u8 edp_phy_vco_div_cfg_v4[4] =3D { 0x01, 0x01, 0x02, 0x00, }; =20 -static const u8 edp_pre_emp_hbr_rbr_v5[4][4] =3D { - { 0x05, 0x11, 0x17, 0x1d }, - { 0x05, 0x11, 0x18, 0xff }, - { 0x06, 0x11, 0xff, 0xff }, - { 0x00, 0xff, 0xff, 0xff } -}; - -static const u8 edp_pre_emp_hbr2_hbr3_v5[4][4] =3D { - { 0x0c, 0x15, 0x19, 0x1e }, - { 0x0b, 0x15, 0x19, 0xff }, - { 0x0e, 0x14, 0xff, 0xff }, - { 0x0d, 0xff, 0xff, 0xff } -}; - -static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg= _v5 =3D { - .swing_hbr_rbr =3D &edp_swing_hbr_rbr, - .swing_hbr3_hbr2 =3D &edp_swing_hbr2_hbr3, - .pre_emphasis_hbr_rbr =3D &edp_pre_emp_hbr_rbr_v5, - .pre_emphasis_hbr3_hbr2 =3D &edp_pre_emp_hbr2_hbr3_v5, -}; - static const u8 edp_phy_aux_cfg_v5[DP_AUX_CFG_SIZE] =3D { 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02, 0= x00, }; @@ -564,7 +543,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg= =3D { .is_edp =3D false, .aux_cfg =3D edp_phy_aux_cfg_v5, .vco_div_cfg =3D edp_phy_vco_div_cfg_v4, - .swing_pre_emph_cfg =3D &edp_phy_swing_pre_emph_cfg_v5, + .swing_pre_emph_cfg =3D &edp_phy_swing_pre_emph_cfg, .ver_ops =3D &qcom_edp_phy_ops_v4, }; =20 @@ -944,7 +923,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v8 =3D= { static struct qcom_edp_phy_cfg glymur_phy_cfg =3D { .aux_cfg =3D edp_phy_aux_cfg_v8, .vco_div_cfg =3D edp_phy_vco_div_cfg_v8, - .swing_pre_emph_cfg =3D &edp_phy_swing_pre_emph_cfg_v5, + .swing_pre_emph_cfg =3D &edp_phy_swing_pre_emph_cfg, .ver_ops =3D &qcom_edp_phy_ops_v8, }; =20 --=20 2.43.0