From nobody Sat Feb 7 06:14:39 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B0924676D for ; Wed, 4 Feb 2026 21:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770241665; cv=none; b=eyHO91kMrXcE88i4PNwOPf0RZqChhO0HddgCXv/JpH/VLQsKnUe0U8GjWOCyE2CmhH7up7gB59GtdmbHqsUXvwRIpn82svr22O2EjpVvSCpEJa+tiL+5D4xybd0o2l9cXgGrGM5bmvx96khEkGwAN3tfwcBp/qXBd6gWiVO6OWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770241665; c=relaxed/simple; bh=8mKulAfF6fv6fA4qufaMB1JzZQZAd1SGWOSTjID6ZoU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=CIc6eZ65E9RAqRqeaDEapbnLF8d98g/aN2xOoPGE2e6PRtXN6LJbJNgv5C6lyz93jnmrnQe+ao0zybC7E8CHu17+HFA9LIfxFS8QPxsRVsUCtbrGLjKe6aPyJA5VUezBDN3zkvXbYCYizvcfbyUAFlQnPEKMG3amuD3mtTQop8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jiaqiyan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=t8wMUvSt; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jiaqiyan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="t8wMUvSt" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-34e70e2e363so161106a91.1 for ; Wed, 04 Feb 2026 13:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770241665; x=1770846465; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=1C8BsUE0cw0C5/pQHANl3vMiV1SA8sa3LG6A1Szcvck=; b=t8wMUvStPmesNpapMBkY54/QsSIWVGe3wS9AQFlSIRhlULewdbSVqs6n5EzdlbI3Ia EAR6HOkV6P+/FNoTrvYJF8kWsyNOsta8MxwM6l6DuniqRRbLvccZyEqTdz6aVJvEG4SG 6EPuLd7YsrEM7KAaD0rq6xh5e1ODPq5NZSMZG8vhT4S56wL3K9KHKZ70FUdn0lOGrUck EepjO5XysqWLP3Ust71iCr+x/eHtVQsjvtrWsf7fBMT/MHJMzgiaey61XLj239CXp1ry 8TxwTdmv40ltcZsfUDuaHTdYobFiLqMn9PHkC4N+fRu5T8GmPpk0L84IzJJqQgH0zKEY /sPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770241665; x=1770846465; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1C8BsUE0cw0C5/pQHANl3vMiV1SA8sa3LG6A1Szcvck=; b=FXpPh5jwJcqMNvH7KKHlmZN16UPcVWQ/0YykQcWDMo17wmBJ0vPddSPkW+YAJZWAGq HKoJUTujNV7PobR2yIn9BGKfIbdlsDD66RDGyLsLl+UAm37Re5fl4Y5eGNmUkbBvDlwX m0y3dhneFQDECimtukSsx0PVNXaWl4dm6fluJHesDEQMmkuyhRAQfd0K7QQK7u6oR0b+ xXGsvSXaeI7azBBrzEPMm98y4naJMqeEWXhTJEq7OjU2s3uZGBdtseijwPzisKQhMUd3 JPWZz+BZHrVh06+U8iYxDJ8iL1a9HaH/8wQTTjmep8XFTE+qPC3VnGJSgxL8eEPVDyUW 8AvQ== X-Forwarded-Encrypted: i=1; AJvYcCV8cpg6DkR1ajbC3/U++QhYZk6IC5Q+KlCVBQqUsz857ZzohMH/T3T9+arPy0T6oa218RCW/4PUfosBPyU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/IL59s1xlz5VIAdodQxWl/65mSQ2bg7AcbxzqCFDmtj3x+s1n +7J+HZulTWAMvOO31KahQKcTF0bGbmRwGswyYou++IsbPdVW44eREdMo+d8oT/dln0WoUFFG3ZJ b++oKJwTrQDSnIw== X-Received: from pjuf20.prod.google.com ([2002:a17:90a:ce14:b0:34c:2ca6:ff3e]) (user=jiaqiyan job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4c84:b0:34c:6d33:7d34 with SMTP id 98e67ed59e1d1-35487123756mr3731737a91.16.1770241664741; Wed, 04 Feb 2026 13:47:44 -0800 (PST) Date: Wed, 4 Feb 2026 21:47:41 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog Message-ID: <20260204214741.3161520-1-jiaqiyan@google.com> Subject: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages() return type From: Jiaqi Yan To: jane.chu@oracle.com, muchun.song@linux.dev, david@kernel.org Cc: akpm@linux-foundation.org, osalvador@suse.de, william.roche@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jiaqi Yan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When remove_inode_hugepages is introduced in commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to remove s= ingle file folio") it used to return a boolean to indicate if it bailed out due to race with page faults. However, since the race is already solved by [1], remove_inode_hugepages() doesn't have any path to return false anymore. Simplify remove_inode_hugepages() return type to void, remove the unnecessary ret variable, and adjust the call site in remove_inode_hugepages(). No functional change in this commit. Changelog =3D=3D=3D=3D=3D=3D=3D=3D=3D v2 -> v1 [2] - Use two-tab alignment for parameters wrapped to new lines. - Remove return type in remove_inode_hugepages()'s comment. [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle= .com [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@goog= le.com Suggested-by: Jane Chu Reviewed-by: Jane Chu Reviewed-by: Muchun Song Acked-by: David Hildenbrand (arm) Signed-off-by: Jiaqi Yan Reviewed-by: SeongJae Park --- fs/hugetlbfs/inode.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index 3b4c152c5c73a..09c88c09718b4 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -513,15 +513,11 @@ hugetlb_vmdelete_list(struct rb_root_cached *root, pg= off_t start, pgoff_t end, =20 /* * Called with hugetlb fault mutex held. - * Returns true if page was actually removed, false otherwise. */ -static bool remove_inode_single_folio(struct hstate *h, struct inode *inod= e, - struct address_space *mapping, - struct folio *folio, pgoff_t index, - bool truncate_op) +static void remove_inode_single_folio(struct hstate *h, struct inode *inod= e, + struct address_space *mapping, struct folio *folio, + pgoff_t index, bool truncate_op) { - bool ret =3D false; - /* * If folio is mapped, it was faulted in after being * unmapped in caller or hugetlb_vmdelete_list() skips @@ -543,7 +539,6 @@ static bool remove_inode_single_folio(struct hstate *h,= struct inode *inode, */ VM_BUG_ON_FOLIO(folio_test_hugetlb_restore_reserve(folio), folio); hugetlb_delete_from_page_cache(folio); - ret =3D true; if (!truncate_op) { if (unlikely(hugetlb_unreserve_pages(inode, index, index + 1, 1))) @@ -551,7 +546,6 @@ static bool remove_inode_single_folio(struct hstate *h,= struct inode *inode, } =20 folio_unlock(folio); - return ret; } =20 /* @@ -599,9 +593,9 @@ static void remove_inode_hugepages(struct inode *inode,= loff_t lstart, /* * Remove folio that was part of folio_batch. */ - if (remove_inode_single_folio(h, inode, mapping, folio, - index, truncate_op)) - freed++; + remove_inode_single_folio(h, inode, mapping, folio, + index, truncate_op); + freed++; =20 mutex_unlock(&hugetlb_fault_mutex_table[hash]); } --=20 2.53.0.rc2.204.g2597b5adb4-goog