From nobody Sat Feb 7 06:20:51 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A050A395DBB for ; Wed, 4 Feb 2026 21:44:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770241499; cv=none; b=HP7s2bk4Rql56Qzvmvtk3/r8yJzQSg816nIsjDZOjVcHdVltAC5FWNoPljOBQo2/r0x4IXkfBgkHoYQacpwl+4TVMsswi8yMJq0faFgX0paB+8csRRSy1WLDmHKN3MO0QPrV+UuGkXxuuPWZUlNYScWQpLG2UtWbebDMtMWwK/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770241499; c=relaxed/simple; bh=3Dz1vnnDfCC5xjG/JwffkR96Prb0LwO5Hv1srPsistI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=JZ7+g87rT+XkSiUu+C7VlhytvCDMfiGUEDyYqhh9QMUzUa+Q1cGiPwBlmyXhIfowrOFZ9R/CeC+gZ+GDcWx0C//bK0QAUcUnQbi3otJQBGWYDVLpaqtocrZBdmTcC5AKT1x57q4SS5N+Du/UocfmeKb1j0jEvQfvszCPxQ/Jk7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XOP4nFVX; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XOP4nFVX" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-658323d1c91so39486a12.3 for ; Wed, 04 Feb 2026 13:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770241497; x=1770846297; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uk8I4gK12p2whVBkLvAYAwLETubRrF0Kti+U7YhSaa0=; b=XOP4nFVXIC14bg7Mqr9W+nT0gV5IlxInCtip3Xkr6zEvHum3TnyoT+ZJHPmxh5QHNV ImutymEPWA0PiNsgHWBe/Yw0Qv2xUAcGK8LpLoWwXfVX3Vbxbe7mbi/f7UYpvm4y9JLS 1sC1OSw5WCBkY0/MhFkXnVWRAVTHqFE/UMy9z970rpSJjsUJ3AHzCxanr2lUkglSj5Pp yeFtl2gqkh1Sw/MnuWVKc6ff2cbn5Nu5YyRs5xRZz7eeloLc6YaUQ+HaalFHaqjJHbrK 0d5UGzsHMSL6TzPPw/VYnzT45m9InPbxPkwOh1Y/rS+bMkqxTMW/uMK3647q7af3yJ+n eyeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770241497; x=1770846297; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uk8I4gK12p2whVBkLvAYAwLETubRrF0Kti+U7YhSaa0=; b=PD1Jq3AjWt5bdQpNSQ32CnSSOnChiXX78+EluZ9FDPf+YGn2HtBf9MetBSNJH9iAgw BLrJgJ3N0as4wBFjST9+fSmYBqFQNRsqlSMffk8CLKw3m5T71RPxZNvhhB5igpg4oyFu Fp6nFLfe3FQHBKs6MGJgM8y8qo35Vd38Ud9A6kypnwx5sEM4/B9Dq20UEHGIG64bc3bS dn4uy9KAuqAChrU+3O3HOSEQ09s8/bbrXQyDiF+a38OEKw6L4BROUZSTp4J5ifN9vt/F xzK/Nifn7d3UEbN8dv5VVZzRSO4RQj0r5DEBfOYYo6LSJsgb7kAKNqIiSljFDPh+42yR pb+w== X-Forwarded-Encrypted: i=1; AJvYcCVfgy/BmCOaJcUMNP9HZf0f5W5K+r+m1FokGwJdSvxYPo6vRCA2q2M2wjdVvhAn5GeQCC7bY/IQqK/03cM=@vger.kernel.org X-Gm-Message-State: AOJu0YxkuEFFcc3VxnKAbRKrba2kFi//GVOAbiNRcSyEkQhwNgNqXAZf wotduGp1oYBsm69GS2fau8FHX7fHHNXwEQWwLLvXVlaGCBVVJXKms+GY X-Gm-Gg: AZuq6aLwZuSQKgT2KEqVVTzjRKWxGBTRiXvUEkERskxRj0boF67FAJgZ98IXnbiafV3 B//eGlxdiEUCmQj4q5b3i86JcLDzGUE32rlsmgYj5UUHvK7QIQborvtwSa5MUrhZdEiSIw+Ngs3 ElGUkYfAiJxClgztuKeqj3WjPPO31yZX++HzATnkhxwbEkxWucszqaz54ArVeYuwBPnZvgdH5gb h5YS5JMqTsN8tx5LxvSNn8A44F7RlCZklr/SXtpQrhQqPVSsrabu0XoTVKtxz4Ugg4h+Crt5ftx ptQwQPvzE+sUIQdfG/jtOFdFyiTCiWF02V04YIue95AoQuAFQ8Ul3gYawaZFtOamP+DQgKEMwIg HgkudgHvPOeoTe9mdSjxhqrEL4yiDBpEnnkUowbjJ0wDiVC+/cO+AKSzZc3g4pT3cjOeYm340YR mxLNxBArPuymTjPxT69E6kEEtX7EY0KXNNDkh9opf5DHjQ7qMXU1O5y7Y4HfeTloni X-Received: by 2002:a05:6402:50cf:b0:64c:9e19:983c with SMTP id 4fb4d7f45d1cf-659499b66c5mr1494417a12.2.1770241496789; Wed, 04 Feb 2026 13:44:56 -0800 (PST) Received: from laptok.lan (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65949ed6d2esm1585953a12.10.2026.02.04.13.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 13:44:56 -0800 (PST) From: =?UTF-8?q?Tomasz=20Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, tomasz.pakula.oficjalny@gmail.com Subject: [PATCH v3] HID: pidff: Fix condition effect bit clearing Date: Wed, 4 Feb 2026 22:44:55 +0100 Message-ID: <20260204214455.68629-1-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable As reported by MPDarkGuy on discord, NULL pointer dereferences were happening because not all the conditional effects bits were cleared. Properly clear all conditional effect bits from ffbit Fixes: 7f3d7bc0df4b ("HID: pidff: Better quirk assigment when searching for= fields") Cc: # 6.18.x Signed-off-by: Tomasz Paku=C5=82a --- Urgent for 6.19 rc period V1 -> V2: Simplify by using bitwise or operator V2 -> V3: Going back to separate bool variable. Turns out I couldn't use bitwise or operator there. Sorry =20 drivers/hid/usbhid/hid-pidff.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index a4e700b40ba9..56d6af39ba81 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1452,10 +1452,13 @@ static int pidff_init_fields(struct pidff_device *p= idff, struct input_dev *dev) hid_warn(pidff->hid, "unknown ramp effect layout\n"); =20 if (PIDFF_FIND_FIELDS(set_condition, PID_SET_CONDITION, 1)) { - if (test_and_clear_bit(FF_SPRING, dev->ffbit) || - test_and_clear_bit(FF_DAMPER, dev->ffbit) || - test_and_clear_bit(FF_FRICTION, dev->ffbit) || - test_and_clear_bit(FF_INERTIA, dev->ffbit)) + bool test =3D false; + + test |=3D test_and_clear_bit(FF_SPRING, dev->ffbit); + test |=3D test_and_clear_bit(FF_DAMPER, dev->ffbit); + test |=3D test_and_clear_bit(FF_FRICTION, dev->ffbit); + test |=3D test_and_clear_bit(FF_INERTIA, dev->ffbit); + if (test) hid_warn(pidff->hid, "unknown condition effect layout\n"); } =20 --=20 2.52.0