From nobody Sat Feb 7 18:20:49 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DBEE3793D7 for ; Wed, 4 Feb 2026 18:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770230504; cv=none; b=A0VRbNPNoXhUZLFN69Yit+i03lFZP5kEVlvibzHvRypnBXOkdLF79GkqJ7frqsSWtsMChnqIcxhALSQC1Zgbah6o73i0j3JUmIG5tGzo8MKWaTTwLCzyTC2GmPQwDuJr7fPaXw/5lCOsUPOesxPwlQ7DGlXRkZeK563K43z2WQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770230504; c=relaxed/simple; bh=DQpHOL+0SXTSy2z6/ZBNI7Ckko1Pz1MNVGGKcr8ZfRY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fJO/yBv56hasrcvAifLK0NSkpNZ5bXtMnZoYDlGFmybc9sKIfz9MgJEz/53midfat4is6RypVFyGlLTOrO8MfSouFSrW090Ob46s+gvTYahGTQELzXTXxltQ1ZLcxHBwJ/i1epWP8blWgzoa9ldfzX2m3qpjKrx04SMzNi2YZI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HiIsZaSA; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HiIsZaSA" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b8842e5a2a1so7346166b.2 for ; Wed, 04 Feb 2026 10:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770230503; x=1770835303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Gh3x73JwXTZjbn+cDuP9/cavTn3mXryUSuTK1vUTUgY=; b=HiIsZaSAx/HQoeVAGp5LjYAGJUXACi7bVNYJMEPbOqJl9dRK3iTNIvVF1pZNEvgCq9 j5Ekdp1aEGwPJ9kbywJtkGApHK79APOQIS/mwVgbjMXzl0rxsiii+/0nVcOUmUZLoefs 6R8FCqJJdhyJbkT0Ynb62+6qd7YhyHQCIiC080vnNxOIUJKC1wJU4Spt63yxemn/RTOm FW7CJWiZ/A9rlV5cWK7YldSklEnyKgTxmCsCMVa05UA1gVsmkSRXjtpL6MqYZOvHI3e4 k6OPLgzpn+ohCQzy0Jqv2/y/EpqktDcJzOMi9z9SgD6RoiG4GP3CSoxiq7XnSbJV1ty6 Oq0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770230503; x=1770835303; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gh3x73JwXTZjbn+cDuP9/cavTn3mXryUSuTK1vUTUgY=; b=uUlbpcxJQGJEXhb+oOUBIpRK1MLW0Tu5mHmOEOhOxSPYVtSM9LYZvUTG2ZHSx8JkTp MsmNIK+lYZyGqkyR1sJKvCa5bORfV4v951Pq8KG1J3bwYEPuFTRbCtK5qI+sev5bQv/T SwUBcZHCJEQju5i/BSwUkd0Ifhrn625XX6DGcYD0JMHjL5SEGWmnrcDFePZ6OP9x/drT AlwROkK2PEXKw3bSPHFKCG0Pi81bOBtrzqEougP3e40J5QHrBaKd+KJ/Fb19FiYsFY7z soMrt+6S8p7CrZSQ8aHkxKRM0nqs73VgQxsyNqnkeALaAE1liUE8WplEav7zeb2dX5qu pwkQ== X-Forwarded-Encrypted: i=1; AJvYcCWAuFahmtqXeiJekQK+KJgB/c96gD1XNPjTpNb//XiFxenJI2DCNaqDJYq4TmCmoVwfCO7UbQQBkLv07JQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwhXrcHuI2VJaVGzqVO25S4cPoPQ8xTC7w7TVSmrZCeaIDMCE5A 8mt2r6eZ/CxGp2Ts1g+aEswu6bQoqGy5rKfpinZWwdmGFK4CY87jiyjt X-Gm-Gg: AZuq6aI8Ttdu0J93wWhW+3pj7JqzV4ct0CUNbAuP/ZPbcn1RruuRHZbE/PuywjHYrwP GuCXTh+NeEpCYtT5kCVXzohpiNOqpImOJu26F4awDt8TkLxGKThDTT0lXaP5RjBd5bRgYfp3/Zj vq3tpW7hbMCXkiY18cS9sxE2VDkcNxCG6Efac5w3Zp+Fo9fbjy9gdt4jrdgEpJdjLRaYR6GJFX8 Rc/FnN6RHWTxnQbNLxVOuIRBgYuVZcnK6zz+LbWJ5isXyf/vM3T8qGUCKEIaGP54zXko0eFvRuo Rr+zEBhKqWviZGApj6tR6cgSfDZgipp6shIW/JJ9iwpIcS7CXIVl5EjGJ/I+j+s1UCx77Lb5ys5 uIbWGnpauZB6xOmc1ETxy3Y40CqcS18YvBZNzzOThrpzePoGWIkjvbrYEokFHVjQ4idENhccFcf 60VZZcPEyEf0gxjV8zV4xGmDiimPaAnwsyLwkkPal0pkdlyWfP X-Received: by 2002:a17:907:2d94:b0:b7f:f862:df26 with SMTP id a640c23a62f3a-b8e9f054a77mr298027566b.14.1770230502375; Wed, 04 Feb 2026 10:41:42 -0800 (PST) Received: from arch (45-161-98-95.ftth.glasoperator.nl. [95.98.161.45]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9feeff5csm147871266b.34.2026.02.04.10.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 10:41:41 -0800 (PST) From: Haroen Tmimi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Haroen Tmimi Subject: [PATCH] Fix checkpatch.pl warnings in rtw_ieee80211.c. Date: Wed, 4 Feb 2026 19:41:33 +0100 Message-ID: <20260204184133.142511-1-tmimiharoen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 1. Fix "Yoda condition" style issues by moving constants to the right side of the comparison (e.g., changing "_SUCCESS =3D=3D val" to "val =3D=3D _SUCCESS"). 2. Change the _action_public_str array to "static const char * const" to ensure the array entries are read-only, preventing accidental modification of the pointers. Signed-off-by: Haroen Tmimi --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 8fdeeda88..febc14de6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1009,7 +1009,7 @@ static int rtw_get_cipher_info(struct wlan_network *p= network) pbuf =3D rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork-= >network.ie_length-12); =20 if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS =3D=3D rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &= pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher,= &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; @@ -1019,7 +1019,7 @@ static int rtw_get_cipher_info(struct wlan_network *p= network) pbuf =3D rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwor= k->network.ie_length-12); =20 if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS =3D=3D rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher,= &pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_ciphe= r, &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; @@ -1139,7 +1139,7 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame= _len, u8 *category, u8 *act return true; } =20 -static const char *_action_public_str[] =3D { +static const char * const _action_public_str[] =3D { "ACT_PUB_BSSCOEXIST", "ACT_PUB_DSE_ENABLE", "ACT_PUB_DSE_DEENABLE", --=20 2.53.0