From nobody Sun Feb 8 05:53:37 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C45ED346AEF for ; Wed, 4 Feb 2026 18:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770229239; cv=none; b=kEVQzZ93mDqRAecLQ0WOwOHSOqyRNm4PH3SJGACN8dMV4HQ5YPxBslrk70VS/Mmpw56TyqdJWL5kWjEB7nuexaqm0I5Mjujd0NYk1WwtM89NNRpwveV1jA6C+76AYomJaMezkdnl/7mAbAdFTw76b3LPAn2TbFP2Q8d1oCQxaR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770229239; c=relaxed/simple; bh=1OJZ9w3pH+0A1cqNN4yRXjWvRKrooGbIMxdW91jxkb4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mW6g3jiVSqjdnxhD4kEFV9kVk7eLwTte59Tj1Tmjgd+JGWb6CfZyZIVTUmIcAEYd1R9DyLoqHNdqD1kWdH4eki2jFB+Io/7DjjBbXM0zcKTfnH+M3eVNTNQUpW77Dhql64ZKDqj4lSmLOQ4GvA3zplPeAOmHlzPHfj6F5XBYtvg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d4VyrFv+; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d4VyrFv+" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a78e381fc1so553565ad.3 for ; Wed, 04 Feb 2026 10:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770229239; x=1770834039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kUEqY7Elf3v+fO71b69COKkIcYYp9M1x48maF82X5UI=; b=d4VyrFv+NkIxnobpzENEk9w65w68Mky8v9v/eYlAa7/nSwCzOJZSEnSt72/XNRmtur HE4Y61aP6zQeHzR1wE+mwdd1HIbzK1nK8dBk5h7IjaJSB/D2Yc5ZvWDhbkAuJ2ec1itN 4ajTLjf9Sz5bnjk4ZdIJoHQcchyHu0CzRTN9+1cNQbcIT8mAnPT0AyZ5OAeAdlaEezwZ b4082v1zEOf+JFAaJf+6wnWExLdQ3cFl/CTv/FIk0tJ2fn445OerqYTxLp7yAx/XG7wR 8p0BgaxEH010wvBardYuxLn89OOV2s6XEFa/aVgnx3dpFIL75ZWux/NrV3834leDnKIt l/Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770229239; x=1770834039; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kUEqY7Elf3v+fO71b69COKkIcYYp9M1x48maF82X5UI=; b=IpyjAXEB+lKHZXV0Mr2F/m9xISwxfi26Rjc7oZKHgPJUeL+LFAYa2Jb1SKZMYksz10 kmIYsc9X3yjka+IoNZ+lU1/PYz20VCOscwh9Hh0AHFeabute8U2DjXxtMafPco0994MR kzBYARGufpDzXZK2u3Sc4Xx1IPadBtpR44eMYDVGlkV3HTzAFxxvdUlELsw1wTzWNbKT QRfEfLx837lpiBr8IItojXmWph2Vnn1gCxNzuSM6R2LVopopDr/D2HeDhbEGxA16LUoa JeUd+y6e7sFRNNjIqjLam2G4GRgeW1Hdkiw8eW/ZpeIuBYzKEpT6wbI3ABvdSuVny77j GBGQ== X-Forwarded-Encrypted: i=1; AJvYcCXatZoIZqQbVfqqegZmpWPJ9wiaBkvS7pLOkTJnsxBGkgZW3xbzxJg5zG/hOx73tRmUcTAg02cUkoERaR0=@vger.kernel.org X-Gm-Message-State: AOJu0YzjUK/vjNVMzXxvE4j1Sy6C+OE2DXntZx1YZC688lNDSpsCJK9v RRB6bBKG8uPPnliVsUB4A+FbyEhWiXnJ9ygEIARIe/uhGseJcP4MO3B0 X-Gm-Gg: AZuq6aJdO6oG6k0yNeQrwTm244FshUkIsi8jKQcbK6drWhSkWr52B/J5B94yiEb9eFj 8dt0UlBcE+gaNpGn9/JAkmWJWNDkTJ0w7c+HRvjMqSbK4liIJfB7mxs7MgOg14Divqm0R8Nipy5 hQVtC6K7J9MIVOY2oXkC6EXDjjLZwor84UOmGQ4bkJ5gw2b48W8/RUmLcglLPJtzxUCWsNx179J EJzVN5OWBt49UXzP2Xx99EuWsuG48K7a+LRW22cZa5AXrewY19j1tNcIryHCsKMGluyi876J3gd PEuZX5fLuuq7l4Y93UTbHKEEzs3faAWBgKc78M942LkanOcBDQqA9jq2zfbDs9dwWIPMksJj6cs CuxFP0TbqZiZs8msDHIeJVdqOWolg3sbkt8VJijAtQUuj14uC4rfoSgnDnK9hwoSj8xtXBxo4Ln BJs/fyO6LL2Q4RBVNNFV8SljzChw== X-Received: by 2002:a17:902:d488:b0:2a8:a133:dfed with SMTP id d9443c01a7336-2a933fdc6bfmr35752495ad.55.1770229238979; Wed, 04 Feb 2026 10:20:38 -0800 (PST) Received: from chandna.localdomain ([106.222.233.39]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a93397ee2asm30417715ad.98.2026.02.04.10.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 10:20:38 -0800 (PST) From: Sahil Chandna To: jikos@kernel.org, bentiss@kernel.org, connorbelli2003@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu Cc: Sahil Chandna , syzbot+13f8286fa2de04a7cd48@syzkaller.appspotmail.com Subject: [PATCH v2] HID: asus: synchronize fn_lock_sync_work initialization and teardown Date: Wed, 4 Feb 2026 23:50:29 +0530 Message-ID: <20260204182029.278659-1-chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Syzbot reported a workqueue warning where cancel_work_sync() was called on an uninitialized work_struct. Fix this by adding a mutex lock and initializing fn_lock_sync_work before marking fn_lock as enabled. This ensures cancel_work_sync() is only called for an initialized work. Fixes: f631011e36b8 ("HID: hid-asus: Implement fn lock for Asus ProArt P16") Reported-by: syzbot+13f8286fa2de04a7cd48@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D13f8286fa2de04a7cd48 Suggested-by: Alan Stern Signed-off-by: Sahil Chandna --- link to v1: https://lore.kernel.org/all/20260130155204.96831-1-chandna.sahi= l@gmail.com/ changes since v1: - Add mutex locking between init_work and cancel_work. Testing: - Reproduced bug on local setup and original syz reproducer. - Tested with fix and original C reproducer, issue is not reproduced locally. --- drivers/hid/hid-asus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 1b9793f7c07e..2d6b6e363bde 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -147,6 +147,7 @@ struct asus_drvdata { unsigned long battery_next_query; struct work_struct fn_lock_sync_work; bool fn_lock; + struct mutex lock; }; =20 static int asus_report_battery(struct asus_drvdata *, u8 *, int); @@ -960,8 +961,10 @@ static int asus_input_configured(struct hid_device *hd= ev, struct hid_input *hi) } =20 if (drvdata->quirks & QUIRK_HID_FN_LOCK) { - drvdata->fn_lock =3D true; + mutex_lock(&drvdata->lock); INIT_WORK(&drvdata->fn_lock_sync_work, asus_sync_fn_lock); + drvdata->fn_lock =3D true; + mutex_unlock(&drvdata->lock); asus_kbd_set_fn_lock(hdev, true); } =20 @@ -1258,6 +1261,7 @@ static int asus_probe(struct hid_device *hdev, const = struct hid_device_id *id) hdev->quirks |=3D HID_QUIRK_NO_INIT_REPORTS; =20 drvdata->hdev =3D hdev; + mutex_init(&drvdata->lock); =20 if (drvdata->quirks & (QUIRK_T100CHI | QUIRK_T90CHI)) { ret =3D asus_battery_probe(hdev); @@ -1343,8 +1347,10 @@ static void asus_remove(struct hid_device *hdev) cancel_work_sync(&drvdata->kbd_backlight->work); } =20 - if (drvdata->quirks & QUIRK_HID_FN_LOCK) + mutex_lock(&drvdata->lock); + if ((drvdata->quirks & QUIRK_HID_FN_LOCK) && drvdata->fn_lock) cancel_work_sync(&drvdata->fn_lock_sync_work); + mutex_unlock(&drvdata->lock); =20 hid_hw_stop(hdev); } --=20 2.50.1