From nobody Tue Feb 10 01:30:38 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D1C38E5FC for ; Wed, 4 Feb 2026 16:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222559; cv=none; b=KUkS3uoTckE+jsBOZmqgLJzglzAxsgxCoO+gpdFIja7ZBrNA4DhTUiCGPrCDaNwXOWFRPjgMoV9yAi/VSDxabzZ6+3uNZ6nzI8oD0BmiMBYX094NTgn8K0XuMP3nmrarixu+lvV+VWX5MAg2byO1pzf3WNUL6LQDZ4GjtP+8D8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222559; c=relaxed/simple; bh=3me1SodZTkHVWGIC0kYi6tRJygZte7A7CmjLrhhOe9w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rY8dR5ozFOH9/3r7jGl7RTovxWJI/Pw++oCKv0/O74eIIFrxDI4dhPZgIwt4DdkPODvazlVxqolPviz1GMDl7uukcLp+E/7sdkOiw7DjAQRfIR3oNVHjbWrWdwBJmQ38CmMTq1EaGUVY9QgJMgbjUHeeJfGzfewlrDHzBvSS9a0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YvwwIGUS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Jhqjpr6a; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YvwwIGUS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Jhqjpr6a" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614CIMpI095947 for ; Wed, 4 Feb 2026 16:29:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=HYH50Zm6WCw xpaucxpsuIwIJ6T3oQhCQ2WmmzPUspP4=; b=YvwwIGUSXTGXSY/Mlh2fpz4u/Mb eO05hW0d/HuBOorz3SecgKJqaUaX2U4zhBy3/5U0nrMsBlwsiVpyRY3qDRKJQ10z v6Dc0vQobj0Wlq1WRDl7zRhkEheaVNpsVw8CVHQyglWEDTeU9bkQPgXTGkUzgaSg Vb/TSsVlmiGdDTFnlS+8a/POGGqLFS38IM1eB5t0ogaRix2XrDn4mKLV+7VXEQYY Uktd+6lZI1bJezkA1vbL3c3GRsGaEjW/kI0vdE9UPHMjt0elF+haCuFRcPDZ2EbG yZmDex7GwMvuwexFidloC3ZlvTwJvLXrmmuHuZzR5xG4sFwYiDwnT3J47pA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c44kbh232-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 16:29:18 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b62da7602a0so4565365a12.2 for ; Wed, 04 Feb 2026 08:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770222558; x=1770827358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HYH50Zm6WCwxpaucxpsuIwIJ6T3oQhCQ2WmmzPUspP4=; b=Jhqjpr6aj4qvseGKY2rtv891GN86LwBESwyffo/quB8PaYmMVsMyxq/nC6QkyPwWcb Uioqtkan4S8fmR0cJX+UtXVmXG9vSV5uVAFet3kydl0DIA0dzY6OzfNV61/rB+oHLoDD Lj4/VaA3q8BZsFTBLUviGCB2fSFdSQ0//xD+bArcBD9SrqJm9EEgYNXzCCKQaD1sdfxe A+3loZ5PxP2x0cyErOfScyXsELGdt0j3xXZj5kXMelaKgxpgx7wyUTrQk/Ngmq+jp+KL S2MNxDHWTukcFVgQ9nIAZqsmj104CDvdz3KMaqC/QJNzZq8+cckQ0LmX2oHQLfl+9SSZ XOow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770222558; x=1770827358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HYH50Zm6WCwxpaucxpsuIwIJ6T3oQhCQ2WmmzPUspP4=; b=Vk4OTvvFSqlK3s9pyeZSEjKhmX3Ejg5i0XdG30sDK3NyxCtFjoWSxHHNpViLh7pc0f ZFD4p8l2W+wg2mHQ1X15Fgt+qxCgxHWTHWQjmneUH1geoGAWr1YXiheRTGQ9FSKKshl5 S2Js/eezP6Rz7BLpjeQyqqlwtO2QgIdbL5nw7WAHZXyGmYnSJPablNMT9mG6am8nboYG GQBmByKmpfp9awxcmz5XnUEI+pzw4nPnSjenCzWlB9Q1e2YWVZ/NS7VH7jLoj75mEA8A ZUO9gYpRLQwnjBm/mUmjgahUcTM73bn+eG0Y7QfiIoTNQep2AjcjC+lbt95pEn7bRWho gfOA== X-Forwarded-Encrypted: i=1; AJvYcCXFH8hviKQS7I3DPuxn+QHnPkgNPkYzY48UlyhgE6J49VBhsL0UT7mt/c3dtYgTvXuUchUlVFkl8DtBdJU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7ky51+/qCt9xZgXILaNimGDY95rnb2d+/gwoPkOBVH3kdmqel 2kHAAEzgIOQqY/1QlKzkuhKDjTpHchKhsNMbMbgQ9VcKXB4c1GoxTQXcUy2B+tPsA2x8ZOVAQsb o1M0fVerSK2jBodDeTJekjlXqUaA8viJEIHFYo3MUB2LygdpEZ/t3hLEVe1663gTyz9A= X-Gm-Gg: AZuq6aL2mqc3bw9CWJmQargy4qJUhhrmOICbSr+0HGUeaaNH4NtesG5erwrutUxHWyv k5SYAnFx3KOuUQwRfNjfJwcBRCy8OrTCxq/YUCTgqjzPLa0OVfImFZFzzw5TS0ceyE7Rn4kovQ6 d6+pB8s52TPh/7ITQyA9mN89916kKAD7oIO1eJwHyz84Lc7Ec4rWzG3dX9Zr7fV/p6SQaLnI2mx ltm1dkVHwCPwZGg4AV0oRlGEeoxrhbUd8hW2pR7zNZnmMaxKDJPsnrMdxGb7iNQB/KQSseewGub 5IcCIiNX5b0MLm48N8hQtatcMa7JKUnWM1Y2g4JPQSahPHXoUaa7++GPN5iV53Y5gTxCcfITiCy 35U20HRDoyNU/ky3dnm4dX94VKDIgodF0xKUvWoEd8rk= X-Received: by 2002:a05:6a20:43a7:b0:38e:9e77:9168 with SMTP id adf61e73a8af0-393725d73e7mr3446756637.79.1770222557970; Wed, 04 Feb 2026 08:29:17 -0800 (PST) X-Received: by 2002:a05:6a20:43a7:b0:38e:9e77:9168 with SMTP id adf61e73a8af0-393725d73e7mr3446728637.79.1770222557396; Wed, 04 Feb 2026 08:29:17 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6c8515f36esm2546878a12.29.2026.02.04.08.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 08:29:17 -0800 (PST) From: Praveen Talari To: Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, Praveen Talari Subject: [PATCH v2 2/4] spi: geni-qcom: Fix abort sequence execution for serial engine errors Date: Wed, 4 Feb 2026 21:58:52 +0530 Message-Id: <20260204162854.1206323-3-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260204162854.1206323-1-praveen.talari@oss.qualcomm.com> References: <20260204162854.1206323-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: XtdkvHUcmxg4Mj9aUu5TMTjDsRTH_62j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEyNSBTYWx0ZWRfXzy6lSRVGM3Vw VXAKDanphRQ0yC7cQtYvU4EbHSFagiEl4DCeD5H4re2H3c39AdWeGvYeCnkvMgkuaA5yQu3DW1h sHsNINT+GrqRQw3VWj1cpeT4J2yuO4iUf9UnO7VFe4wPm9TV5uvqdizTEFk70oedw0YEPRW9rFg 7MF8984+9q88zU7VQrgH7TDdpqtB0w1O5UlVBL9khimjtdwLFvBjaGyUEsyMz/fixJQH5oRmWZt I2CNhyNX/DS6TVfDLFhLzIfGmZG1hgT+i1Pf87T40Ru5GhqYbiGpyiMY3Vu878U4KrJXRTurdhM F69e0E/NqTv2LbmjRI9qORf0t6qbjjm8fv5neny9zmWBWs7U1xabEajI63diPk+8MF5fhGJ0VEM zO9Oovt9UMC1vT8gcAw+JYAkZulg9wyHOh2UNKxmiwKCZ612VqOBrxgJBwYq6k8Ob74uhNHUps/ npRtUwPjz8EMxb6UbXA== X-Proofpoint-GUID: XtdkvHUcmxg4Mj9aUu5TMTjDsRTH_62j X-Authority-Analysis: v=2.4 cv=HN7O14tv c=1 sm=1 tr=0 ts=698373de cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PwoySFKYIoUPqChjOH0A:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_05,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040125 Content-Type: text/plain; charset="utf-8" The driver currently skips the abort sequence for target mode when serial engine errors occur. This leads to improper error recovery as the serial engine may remain in an undefined state without proper cleanup, potentially causing subsequent operations to fail or behave unpredictably. Fix this by ensuring the abort sequence and DMA reset always execute during error recovery, as both are required for proper serial engine error handling. Co-developed-by: Konrad Dybcio Signed-off-by: Konrad Dybcio Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio --- v1->v2 Konrad - Updated code changes as suggested by Konrad --- drivers/spi/spi-geni-qcom.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index f886a9ba56e6..e48aea7ce681 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -161,24 +161,20 @@ static void handle_se_timeout(struct spi_controller *= spi, xfer =3D mas->cur_xfer; mas->cur_xfer =3D NULL; =20 - if (spi->target) { - /* - * skip CMD Cancel sequnece since spi target - * doesn`t support CMD Cancel sequnece - */ + /* The controller doesn't support the Cancel commnand in target mode */ + if (!spi->target) { + reinit_completion(&mas->cancel_done); + geni_se_cancel_m_cmd(se); + spin_unlock_irq(&mas->lock); - goto reset_if_dma; - } =20 - reinit_completion(&mas->cancel_done); - geni_se_cancel_m_cmd(se); - spin_unlock_irq(&mas->lock); + time_left =3D wait_for_completion_timeout(&mas->cancel_done, HZ); + if (time_left) + goto reset_if_dma; =20 - time_left =3D wait_for_completion_timeout(&mas->cancel_done, HZ); - if (time_left) - goto reset_if_dma; + spin_lock_irq(&mas->lock); + } =20 - spin_lock_irq(&mas->lock); reinit_completion(&mas->abort_done); geni_se_abort_m_cmd(se); spin_unlock_irq(&mas->lock); --=20 2.34.1