From nobody Sat Feb 7 19:45:58 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081182F12C1 for ; Wed, 4 Feb 2026 16:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222735; cv=none; b=rR16JVXZE8n7PeJiwp4F7PjtioVfr60m7SHbu9KBtsWMvJ3NMixz6iE90jXUMunsvXqQv6BSb0S8GkoW5/c4jBkBj8tAnpWmdQG7JDS6PhVUFWQUkyHU98iEDV/Zaauj+ubtqDSZ3jpTdZdNJWlbBKnwVkrXSIFZVF0IKvGCprA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222735; c=relaxed/simple; bh=cNOMoPICMTO7Jd/feVQ1G3OBQwG43K4Z1Ef+EsXsnu0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QjdYZTbXJnIgxk0UvmqVWwGvsDyC/Np7Jb4xjNQVIPMQoWaOdBfFC2kupVVuO+IlxS1GoR7Z88TjoUZloVfe6oVq6ON0aa6KctsgaA40dEthkj1WCw4Irbcf6qwIWnN8zOEXn/U7+e+s+Fg7/54XPFbfS90HNbD26gSx4K58ZMU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B7G5s6ni; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B7G5s6ni" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4358f854840so6879f8f.3 for ; Wed, 04 Feb 2026 08:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770222733; x=1770827533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FhzKPlo/o1GqrY1Xo5QLsYHf6TE8sJz/yK5MOWUEpRg=; b=B7G5s6nih128aQkHe/yGNNXDt8RJh5UD23KumLb6VgMGmSSvVIiv1FhlbF2bzxbufN 9akNRgsrssziQVDzyyyoD5veddNvhf4nygkmJQnWDqrfgZvzToXFGwcCMZGpCCBTw73a ZIV5rfyM8EIxO9gW+RFP1P/+O+7M0XPDxBfPPb/LQ3y85PwsiDEkybXHesmyHPUmb0lP zkiB9bP5tc0+fJPiEf0Ksy2NWZrlMJ+IdY22HeERVH0vmtJ6WMPNXpSp/rko0+el+fl/ iAaFw6rhWgbeXQWsapMWL0aNMtAZShD3dIi/URGECWW7neTmNNH7GWnx8VB0FkxZ+4xO zIpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770222733; x=1770827533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FhzKPlo/o1GqrY1Xo5QLsYHf6TE8sJz/yK5MOWUEpRg=; b=F+msLgj2+tDxdlPtoGkaPIlVaXSWCNctvRo/aKfcr/tMvIrgP4u5kTchvquuUGysxm 9fpycK/bq0/2cq+UT5Z/qaTVOlWAZjEViOWd6UX1lP8yog9h8B7mtJkgeICeM0yF6cSe yT3tQPM1y/47jmF7huHvxQmZQ27tK02YGNaZXtlIyi0GObJvP1WZeW+QcEDg1h5fzWZd kjt2A382JkdXe+Nj+jg+qipR9nkKz1eXuC1UiMqFXJypBmrS68OfiynlMimfZRQxk6/V 5EUYUsxl5fy2PtyG9uyqvsSWAc19KJTTRxd/VegBgl0Z0eJ4VdW/qtYI2sC+K6ducalo tJrQ== X-Forwarded-Encrypted: i=1; AJvYcCXkiMGckxRoBN9fWMW/E/XnfDh7bgMhmK4bOdQ5r8hX5dBoIMm3tUWViorY/DF9i/44zHJ0RQ6Kum0Yibs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj+qriCepcxwQ0XgjG8trCPazVx8Xe5B+pkf9BDxdYNHisB9yB V8E8EjJCXeEsiVB6un8J2B4mcQh2ypV2u7wRJMKZa+P+n+L06W8g7viC X-Gm-Gg: AZuq6aL63q/4L7dQaZOgz0Ulhqk9r4lzdxFUQrEZuv89OVT2Ud+WbyudqC10RHch5xX cWd3hf1NWR3rNSCTL6pSILIRZ6+jnEKVzSFWIoJXbGQQiN8YWIgr3S8nea0dWjYeEejIwSSrzxT lee48DiL/p3vP3T/2R3S0VV5c2dnXhchO6K0ao5E5nnuiE8q35O4w3azh5AnV9hpd+pA+A9Uoru SQy9HIbqLylGjkzIUncXTn68wSGTHh7QpEdocQxbSK7g4OMePKtB7o9W1FcHNvEGb7SxQ/FiWEx VcAjQSKe43pzd58kenAM+bJ/Q6bqu+dTPW+lXFl3pMyZUdriPv0tLsplt2FK44rmX0AVYvWDUrn fE2aPuknQ9axoqRgrsYcCgKO/r0KdSwXlRjEWAE0RjNRSNOjrX6Ls5lrp4vRf8cgU3ytkSrVj+V keiKq41aho8k6yhz6/HG3GahPWuPrJiT2n2SRcZAPUYzdt1uoNgEqzgXDD6qRp9fNLFL9DAk7NK J54N0k= X-Received: by 2002:a05:6000:4205:b0:435:91a5:1325 with SMTP id ffacd0b85a97d-43619405830mr2296210f8f.7.1770222733044; Wed, 04 Feb 2026 08:32:13 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-213.paris.inria.fr. [128.93.83.213]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-43617e25683sm7377005f8f.6.2026.02.04.08.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 08:32:12 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , stable@vger.kernel.org, Zhao Qiang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: wan/fsl_ucc_hdlc: Fix dma_free_coherent() in uhdlc_memclean() Date: Wed, 4 Feb 2026 17:25:47 +0100 Message-ID: <20260204162548.94160-3-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The priv->rx_buffer and priv->dma_rx_addr are alloc'd together as contiguous buffers in uhdlc_init() but freed as two buffers in uhdlc_memclean(). Change the cleanup to only call dma_free_coherent() once on the whole buffer. Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") Cc: Signed-off-by: Thomas Fourier --- drivers/net/wan/fsl_ucc_hdlc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index f999798a5612..59cd861d13d6 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -790,19 +790,11 @@ static void uhdlc_memclean(struct ucc_hdlc_private *p= riv) =20 if (priv->rx_buffer) { dma_free_coherent(priv->dev, - RX_BD_RING_LEN * MAX_RX_BUF_LENGTH, + (RX_BD_RING_LEN + TX_BD_RING_LEN) * MAX_RX_BUF_LENGTH, priv->rx_buffer, priv->dma_rx_addr); priv->rx_buffer =3D NULL; priv->dma_rx_addr =3D 0; } - - if (priv->tx_buffer) { - dma_free_coherent(priv->dev, - TX_BD_RING_LEN * MAX_RX_BUF_LENGTH, - priv->tx_buffer, priv->dma_tx_addr); - priv->tx_buffer =3D NULL; - priv->dma_tx_addr =3D 0; - } } =20 static int uhdlc_close(struct net_device *dev) --=20 2.43.0