From nobody Sun Feb 8 15:57:46 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21EE641323E for ; Wed, 4 Feb 2026 14:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770216608; cv=none; b=Q0cXTIrf6ChnESz8RisVsTidntlzR6F3doPQnxJ4O0GAj0nT1gHNBBXqv6THdg4LyA4f8Bq3NVF41CbOnk9Tq9k2+LUXg4s43L4GbrRXI35ukTSG/J3YUVUrJLaAd9zGZ9ZXGw8xx4yhd9jP157NUv2EIp7nwmFcbzztTG6wWsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770216608; c=relaxed/simple; bh=X2kf3fZ5LR5TgJP+TJj6XwWzQKodGD7lX1MkZwTSo2o=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o9qc7CCooUPHoyByRJPp5m0a9Xeqf/p5O187cgM8IeJ4pqGmKbb2hp2JTFckqCoRYe4QOUhkxYK+AGX+iXt5XYSviC6+JjdWRgGrsMHoB56drNz48NR63VvOeJC9e50gltZrxCQpIze91MOSr4Z6EqobVC4tRfQXnp4fiUp9ZyA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JNp4WLsn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JNp4WLsn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770216607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LdDoCJaPfE+4alVDcmgH28uP/ZjHFVm7qqMaWa15mmE=; b=JNp4WLsncmip8gJFcuSIi9CNELTxRXTNpdbOSB5OVLnQnZpQMWyjytnBg5OiFIwX07ntM3 wV0KezHgwZF5J2aVD2TUyA8a1HUZzT/q5h2eLl2Ne4r/+9sBcqGC1WlHJ9bGci6e5R+mpq D8v9KaZhIugeNajcX5JUTuIn627F16I= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-THbIqvTdMveM9GC8GLT2NQ-1; Wed, 04 Feb 2026 09:50:04 -0500 X-MC-Unique: THbIqvTdMveM9GC8GLT2NQ-1 X-Mimecast-MFC-AGG-ID: THbIqvTdMveM9GC8GLT2NQ_1770216603 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D18971956095; Wed, 4 Feb 2026 14:50:02 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.88.140]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 28B5130001B9; Wed, 4 Feb 2026 14:49:59 +0000 (UTC) From: Wander Lairson Costa To: Steven Rostedt , Gabriele Monaco , Nam Cao , Wander Lairson Costa , linux-trace-kernel@vger.kernel.org (open list:RUNTIME VERIFICATION (RV)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 01/20] rv/rvgen: introduce AutomataError exception class Date: Wed, 4 Feb 2026 11:42:27 -0300 Message-ID: <20260204144914.104028-2-wander@redhat.com> In-Reply-To: <20260204144914.104028-1-wander@redhat.com> References: <20260204144914.104028-1-wander@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Content-Type: text/plain; charset="utf-8" Replace the generic except Exception block with a custom AutomataError class that inherits from Exception. This provides more precise exception handling for automata parsing and validation errors while avoiding overly broad exception catches that could mask programming errors like SyntaxError or TypeError. The AutomataError class is raised when DOT file processing fails due to invalid format, I/O errors, or malformed automaton definitions. The main entry point catches this specific exception and provides a user-friendly error message to stderr before exiting. Signed-off-by: Wander Lairson Costa --- tools/verification/rvgen/__main__.py | 9 ++++++--- tools/verification/rvgen/rvgen/automata.py | 17 ++++++++++++----- tools/verification/rvgen/rvgen/dot2c.py | 4 ++-- tools/verification/rvgen/rvgen/generator.py | 7 ++----- 4 files changed, 22 insertions(+), 15 deletions(-) diff --git a/tools/verification/rvgen/__main__.py b/tools/verification/rvge= n/__main__.py index fa6fc1f4de2f7..3bd438f8476ed 100644 --- a/tools/verification/rvgen/__main__.py +++ b/tools/verification/rvgen/__main__.py @@ -8,11 +8,15 @@ # For further information, see: # Documentation/trace/rv/da_monitor_synthesis.rst =20 +from sys import stderr + + if __name__ =3D=3D '__main__': from rvgen.dot2k import dot2k from rvgen.generator import Monitor from rvgen.container import Container from rvgen.ltl2k import ltl2k + from rvgen.automata import AutomataError import argparse import sys =20 @@ -51,9 +55,8 @@ if __name__ =3D=3D '__main__': sys.exit(1) else: monitor =3D Container(vars(params)) - except Exception as e: - print('Error: '+ str(e)) - print("Sorry : :-(") + except AutomataError as e: + print(f"There was an error processing {params.spec}: {e}", file=3D= sys.stderr) sys.exit(1) =20 print("Writing the monitor into the directory %s" % monitor.name) diff --git a/tools/verification/rvgen/rvgen/automata.py b/tools/verificatio= n/rvgen/rvgen/automata.py index 3f06aef8d4fdc..6ecd5ccd8f3d3 100644 --- a/tools/verification/rvgen/rvgen/automata.py +++ b/tools/verification/rvgen/rvgen/automata.py @@ -10,6 +10,13 @@ =20 import ntpath =20 +class AutomataError(Exception): + """Exception raised for errors in automata parsing and validation. + + Raised when DOT file processing fails due to invalid format, I/O error= s, + or malformed automaton definitions. + """ + class Automata: """Automata class: Reads a dot file and part it as an automata. =20 @@ -32,11 +39,11 @@ class Automata: basename =3D ntpath.basename(self.__dot_path) if not basename.endswith(".dot") and not basename.endswith(".gv"): print("not a dot file") - raise Exception("not a dot file: %s" % self.__dot_path) + raise AutomataError("not a dot file: %s" % self.__dot_path) =20 model_name =3D ntpath.splitext(basename)[0] if model_name.__len__() =3D=3D 0: - raise Exception("not a dot file: %s" % self.__dot_path) + raise AutomataError("not a dot file: %s" % self.__dot_path) =20 return model_name =20 @@ -45,8 +52,8 @@ class Automata: dot_lines =3D [] try: dot_file =3D open(self.__dot_path) - except: - raise Exception("Cannot open the file: %s" % self.__dot_path) + except OSError as exc: + raise AutomataError(f"Cannot open the file: {self.__dot_path}"= ) from exc =20 dot_lines =3D dot_file.read().splitlines() dot_file.close() @@ -55,7 +62,7 @@ class Automata: line =3D dot_lines[cursor].split() =20 if (line[0] !=3D "digraph") and (line[1] !=3D "state_automaton"): - raise Exception("Not a valid .dot format: %s" % self.__dot_pat= h) + raise AutomataError("Not a valid .dot format: %s" % self.__dot= _path) else: cursor +=3D 1 return dot_lines diff --git a/tools/verification/rvgen/rvgen/dot2c.py b/tools/verification/r= vgen/rvgen/dot2c.py index 06a26bf15a7e9..74147ae2942f9 100644 --- a/tools/verification/rvgen/rvgen/dot2c.py +++ b/tools/verification/rvgen/rvgen/dot2c.py @@ -13,7 +13,7 @@ # For further information, see: # Documentation/trace/rv/deterministic_automata.rst =20 -from .automata import Automata +from .automata import Automata, AutomataError =20 class Dot2c(Automata): enum_suffix =3D "" @@ -71,7 +71,7 @@ class Dot2c(Automata): min_type =3D "unsigned int" =20 if self.states.__len__() > 1000000: - raise Exception("Too many states: %d" % self.states.__len__()) + raise AutomataError("Too many states: %d" % self.states.__len_= _()) =20 return min_type =20 diff --git a/tools/verification/rvgen/rvgen/generator.py b/tools/verificati= on/rvgen/rvgen/generator.py index 3441385c11770..a7bee6b1ea70c 100644 --- a/tools/verification/rvgen/rvgen/generator.py +++ b/tools/verification/rvgen/rvgen/generator.py @@ -51,10 +51,7 @@ class RVGenerator: raise FileNotFoundError("Could not find the rv directory, do you h= ave the kernel source installed?") =20 def _read_file(self, path): - try: - fd =3D open(path, 'r') - except OSError: - raise Exception("Cannot open the file: %s" % path) + fd =3D open(path, 'r') =20 content =3D fd.read() =20 @@ -65,7 +62,7 @@ class RVGenerator: try: path =3D os.path.join(self.abs_template_dir, file) return self._read_file(path) - except Exception: + except OSError: # Specific template file not found. Try the generic template f= ile in the template/ # directory, which is one level up path =3D os.path.join(self.abs_template_dir, "..", file) --=20 2.52.0