From nobody Mon Feb 9 01:44:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C44B413222; Wed, 4 Feb 2026 14:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770215638; cv=none; b=DvMlvi5ZRmGyGUVcmW6r4yPsmOM+ERmSzZHIgkDXrB2el93qh620yzTRVo2zfo35Xjp5nOXokVgYyfWn3urVR7nF/q9+Hg5rUvO9MUN4yv9ptFVbkzo+tXwFxSytDjATCGz5HmRm+c6UY4fGYiijZNuiW2zpPrCBcF9bS3DmzSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770215638; c=relaxed/simple; bh=zvt5X2CYNOVO2U21/7I0YsGO5725K1hef1h00UHWmrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E/lzgLRqW71DaC3Hj4Ik/0qDUbTjAgIvMLIpCITrCtNmTOiVvmy4qOi3+ZhcD9Flpq9mQoZbDUnwIKk67X9vFmCOO1t1SqyaAboNWXvy8n5CyHX7rrR0qxTiWu5eB4hzRdEow0yOuxICsMUv5uXmD5Y88dMgHFNEWPqlV5W+pBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L5/EcaXo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L5/EcaXo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E9DC116C6; Wed, 4 Feb 2026 14:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770215637; bh=zvt5X2CYNOVO2U21/7I0YsGO5725K1hef1h00UHWmrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L5/EcaXo2Ri66K58vAmZOnDlXMnx3Zmh3vc5UJ1UayR33y/RpakgI/DcH8LqzmwB4 SxclDeFtBjUM7bL/q0edgN7Owz1T/gcnEh+KOJ2OElqGgshV+J5ArDv1rmzPyamzUN nAAAtgU5uyY0prV2EJujQYsJdYX8berVMf9uncUCNprecx/qQPwq0/aEDW2XBXY3Iq LvTKkA27n8B0NotHoHi5fidAqj0Dbmr0Xna9srx1wqHMiDr7qXgEOvm9R8hQYz6drf iZMR4OhonbehZnM/sKyrutijIsPwOYdkesjIH63KSsBhJoc8dpzElexxvuFog7fIfk LXW4XcphRdlHQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vndx1-000000005q8-0pWi; Wed, 04 Feb 2026 15:33:51 +0100 From: Johan Hovold To: Greg Kroah-Hartman Cc: "Rafael J . Wysocki" , Danilo Krummrich , Tzung-Bi Shih , Bartosz Golaszewski , Linus Walleij , Jonathan Corbet , Shuah Khan , Laurent Pinchart , Wolfram Sang , Simona Vetter , Dan Williams , Jason Gunthorpe , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 1/3] Revert "selftests: revocable: Add kselftest cases" Date: Wed, 4 Feb 2026 15:28:47 +0100 Message-ID: <20260204142849.22055-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260204142849.22055-1-johan@kernel.org> References: <20260204142849.22055-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 9d4502fef00fa7a798d3c0806d4da4466a7ffc6f. The new revocable functionality is fundamentally broken and at a minimum needs to be redesigned. Drop the revocable selftests to allow the implementation to be reverted. Signed-off-by: Johan Hovold --- MAINTAINERS | 1 - .../selftests/drivers/base/revocable/Makefile | 7 - .../drivers/base/revocable/revocable_test.c | 136 ------------- .../drivers/base/revocable/test-revocable.sh | 39 ---- .../base/revocable/test_modules/Makefile | 10 - .../revocable/test_modules/revocable_test.c | 187 ------------------ 6 files changed, 380 deletions(-) delete mode 100644 tools/testing/selftests/drivers/base/revocable/Makefile delete mode 100644 tools/testing/selftests/drivers/base/revocable/revocabl= e_test.c delete mode 100755 tools/testing/selftests/drivers/base/revocable/test-rev= ocable.sh delete mode 100644 tools/testing/selftests/drivers/base/revocable/test_mod= ules/Makefile delete mode 100644 tools/testing/selftests/drivers/base/revocable/test_mod= ules/revocable_test.c diff --git a/MAINTAINERS b/MAINTAINERS index b277baee5eb6..7759e9103070 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22392,7 +22392,6 @@ S: Maintained F: drivers/base/revocable.c F: drivers/base/revocable_test.c F: include/linux/revocable.h -F: tools/testing/selftests/drivers/base/revocable/ =20 RFKILL M: Johannes Berg diff --git a/tools/testing/selftests/drivers/base/revocable/Makefile b/tool= s/testing/selftests/drivers/base/revocable/Makefile deleted file mode 100644 index afa5ca0fa452..000000000000 --- a/tools/testing/selftests/drivers/base/revocable/Makefile +++ /dev/null @@ -1,7 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 - -TEST_GEN_MODS_DIR :=3D test_modules -TEST_GEN_PROGS_EXTENDED :=3D revocable_test -TEST_PROGS :=3D test-revocable.sh - -include ../../../lib.mk diff --git a/tools/testing/selftests/drivers/base/revocable/revocable_test.= c b/tools/testing/selftests/drivers/base/revocable/revocable_test.c deleted file mode 100644 index f024164e9273..000000000000 --- a/tools/testing/selftests/drivers/base/revocable/revocable_test.c +++ /dev/null @@ -1,136 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Copyright 2026 Google LLC - * - * A selftest for the revocable API. - * - * The test cases cover the following scenarios: - * - * - Basic: Verifies that a consumer can successfully access the resource - * provided via the provider. - * - * - Revocation: Verifies that after the provider revokes the resource, - * the consumer correctly receives a NULL pointer on a subsequent access. - * - * - Try Access Macro: Same as "Revocation" but uses the - * REVOCABLE_TRY_ACCESS_WITH() and REVOCABLE_TRY_ACCESS_SCOPED(). - */ - -#include -#include - -#include "../../../kselftest_harness.h" - -#define DEBUGFS_PATH "/sys/kernel/debug/revocable_test" -#define TEST_CMD_RESOURCE_GONE "resource_gone" -#define TEST_DATA "12345678" -#define TEST_MAGIC_OFFSET 0x1234 -#define TEST_MAGIC_OFFSET2 0x5678 - -FIXTURE(revocable_fixture) { - int pfd; - int cfd; -}; - -FIXTURE_SETUP(revocable_fixture) { - int ret; - - self->pfd =3D open(DEBUGFS_PATH "/provider", O_WRONLY); - ASSERT_NE(-1, self->pfd) - TH_LOG("failed to open provider fd"); - - ret =3D write(self->pfd, TEST_DATA, strlen(TEST_DATA)); - ASSERT_NE(-1, ret) { - close(self->pfd); - TH_LOG("failed to write test data"); - } - - self->cfd =3D open(DEBUGFS_PATH "/consumer", O_RDONLY); - ASSERT_NE(-1, self->cfd) - TH_LOG("failed to open consumer fd"); -} - -FIXTURE_TEARDOWN(revocable_fixture) { - close(self->cfd); - close(self->pfd); -} - -/* - * ASSERT_* is only available in TEST or TEST_F block. Use - * macro for the helper. - */ -#define READ_TEST_DATA(_fd, _offset, _data, _msg) \ - do { \ - int ret; \ - \ - ret =3D lseek(_fd, _offset, SEEK_SET); \ - ASSERT_NE(-1, ret) \ - TH_LOG("failed to lseek"); \ - \ - ret =3D read(_fd, _data, sizeof(_data) - 1); \ - ASSERT_NE(-1, ret) \ - TH_LOG(_msg); \ - data[ret] =3D '\0'; \ - } while (0) - -TEST_F(revocable_fixture, basic) { - char data[16]; - - READ_TEST_DATA(self->cfd, 0, data, "failed to read test data"); - EXPECT_STREQ(TEST_DATA, data); -} - -TEST_F(revocable_fixture, revocation) { - char data[16]; - int ret; - - READ_TEST_DATA(self->cfd, 0, data, "failed to read test data"); - EXPECT_STREQ(TEST_DATA, data); - - ret =3D write(self->pfd, TEST_CMD_RESOURCE_GONE, - strlen(TEST_CMD_RESOURCE_GONE)); - ASSERT_NE(-1, ret) - TH_LOG("failed to write resource gone cmd"); - - READ_TEST_DATA(self->cfd, 0, data, - "failed to read test data after resource gone"); - EXPECT_STREQ("(null)", data); -} - -TEST_F(revocable_fixture, try_access_macro) { - char data[16]; - int ret; - - READ_TEST_DATA(self->cfd, TEST_MAGIC_OFFSET, data, - "failed to read test data"); - EXPECT_STREQ(TEST_DATA, data); - - ret =3D write(self->pfd, TEST_CMD_RESOURCE_GONE, - strlen(TEST_CMD_RESOURCE_GONE)); - ASSERT_NE(-1, ret) - TH_LOG("failed to write resource gone cmd"); - - READ_TEST_DATA(self->cfd, TEST_MAGIC_OFFSET, data, - "failed to read test data after resource gone"); - EXPECT_STREQ("(null)", data); -} - -TEST_F(revocable_fixture, try_access_macro2) { - char data[16]; - int ret; - - READ_TEST_DATA(self->cfd, TEST_MAGIC_OFFSET2, data, - "failed to read test data"); - EXPECT_STREQ(TEST_DATA, data); - - ret =3D write(self->pfd, TEST_CMD_RESOURCE_GONE, - strlen(TEST_CMD_RESOURCE_GONE)); - ASSERT_NE(-1, ret) - TH_LOG("failed to write resource gone cmd"); - - READ_TEST_DATA(self->cfd, TEST_MAGIC_OFFSET2, data, - "failed to read test data after resource gone"); - EXPECT_STREQ("(null)", data); -} - -TEST_HARNESS_MAIN diff --git a/tools/testing/selftests/drivers/base/revocable/test-revocable.= sh b/tools/testing/selftests/drivers/base/revocable/test-revocable.sh deleted file mode 100755 index 3a34be28001a..000000000000 --- a/tools/testing/selftests/drivers/base/revocable/test-revocable.sh +++ /dev/null @@ -1,39 +0,0 @@ -#!/bin/bash -# SPDX-License-Identifier: GPL-2.0 - -mod_name=3D"revocable_test" -ksft_fail=3D1 -ksft_skip=3D4 - -if [ "$(id -u)" -ne 0 ]; then - echo "$0: Must be run as root" - exit "$ksft_skip" -fi - -if ! which insmod > /dev/null 2>&1; then - echo "$0: Need insmod" - exit "$ksft_skip" -fi - -if ! which rmmod > /dev/null 2>&1; then - echo "$0: Need rmmod" - exit "$ksft_skip" -fi - -insmod test_modules/"${mod_name}".ko - -if [ ! -d /sys/kernel/debug/revocable_test/ ]; then - mount -t debugfs none /sys/kernel/debug/ - - if [ ! -d /sys/kernel/debug/revocable_test/ ]; then - echo "$0: Error mounting debugfs" - exit "$ksft_fail" - fi -fi - -./revocable_test -ret=3D$? - -rmmod "${mod_name}" - -exit "${ret}" diff --git a/tools/testing/selftests/drivers/base/revocable/test_modules/Ma= kefile b/tools/testing/selftests/drivers/base/revocable/test_modules/Makefi= le deleted file mode 100644 index f29e4f909402..000000000000 --- a/tools/testing/selftests/drivers/base/revocable/test_modules/Makefile +++ /dev/null @@ -1,10 +0,0 @@ -TESTMODS_DIR :=3D $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST)))= )) -KDIR ?=3D /lib/modules/$(shell uname -r)/build - -obj-m +=3D revocable_test.o - -all: - $(Q)$(MAKE) -C $(KDIR) M=3D$(TESTMODS_DIR) - -clean: - $(Q)$(MAKE) -C $(KDIR) M=3D$(TESTMODS_DIR) clean diff --git a/tools/testing/selftests/drivers/base/revocable/test_modules/re= vocable_test.c b/tools/testing/selftests/drivers/base/revocable/test_module= s/revocable_test.c deleted file mode 100644 index a560ceda7318..000000000000 --- a/tools/testing/selftests/drivers/base/revocable/test_modules/revocable= _test.c +++ /dev/null @@ -1,187 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Copyright 2026 Google LLC - * - * A kernel module for testing the revocable API. - */ - -#include -#include -#include -#include - -#define TEST_CMD_RESOURCE_GONE "resource_gone" -#define TEST_MAGIC_OFFSET 0x1234 -#define TEST_MAGIC_OFFSET2 0x5678 - -static struct dentry *debugfs_dir; - -struct revocable_test_provider_priv { - struct revocable_provider __rcu *rp; - struct dentry *dentry; - char res[16]; -}; - -static int revocable_test_consumer_open(struct inode *inode, struct file *= filp) -{ - filp->private_data =3D inode->i_private; - return 0; -} - -static ssize_t revocable_test_consumer_read(struct file *filp, - char __user *buf, - size_t count, loff_t *offset) -{ - int ret; - char *res; - char data[16]; - size_t len; - struct revocable rev; - struct revocable_provider __rcu *rp =3D filp->private_data; - - switch (*offset) { - case 0: - ret =3D revocable_init(rp, &rev); - if (ret) { - snprintf(data, sizeof(data), "%s", "(null)"); - break; - } - res =3D revocable_try_access(&rev); - snprintf(data, sizeof(data), "%s", res ?: "(null)"); - revocable_withdraw_access(&rev); - revocable_deinit(&rev); - break; - case TEST_MAGIC_OFFSET: - { - REVOCABLE_TRY_ACCESS_WITH(rp, res); - snprintf(data, sizeof(data), "%s", res ?: "(null)"); - } - break; - case TEST_MAGIC_OFFSET2: - REVOCABLE_TRY_ACCESS_SCOPED(rp, res) - snprintf(data, sizeof(data), "%s", res ?: "(null)"); - break; - default: - return 0; - } - - len =3D min_t(size_t, strlen(data), count); - if (copy_to_user(buf, data, len)) - return -EFAULT; - - *offset =3D len; - return len; -} - -static const struct file_operations revocable_test_consumer_fops =3D { - .open =3D revocable_test_consumer_open, - .read =3D revocable_test_consumer_read, - .llseek =3D default_llseek, -}; - -static int revocable_test_provider_open(struct inode *inode, struct file *= filp) -{ - struct revocable_test_provider_priv *priv; - - priv =3D kzalloc(sizeof(*priv), GFP_KERNEL); - if (!priv) - return -ENOMEM; - filp->private_data =3D priv; - - return 0; -} - -static int revocable_test_provider_release(struct inode *inode, - struct file *filp) -{ - struct revocable_test_provider_priv *priv =3D filp->private_data; - - debugfs_remove(priv->dentry); - if (unrcu_pointer(priv->rp)) - revocable_provider_revoke(&priv->rp); - kfree(priv); - - return 0; -} - -static ssize_t revocable_test_provider_write(struct file *filp, - const char __user *buf, - size_t count, loff_t *offset) -{ - size_t copied; - char data[64]; - struct revocable_test_provider_priv *priv =3D filp->private_data; - - copied =3D strncpy_from_user(data, buf, sizeof(data)); - if (copied < 0) - return copied; - if (copied =3D=3D sizeof(data)) - data[sizeof(data) - 1] =3D '\0'; - - /* - * Note: The test can't just close the FD for signaling the - * resource gone. Subsequent file operations on the opening - * FD of debugfs return -EIO after calling debugfs_remove(). - * See also debugfs_file_get(). - * - * Here is a side command channel for signaling the resource - * gone. - */ - if (!strcmp(data, TEST_CMD_RESOURCE_GONE)) { - revocable_provider_revoke(&priv->rp); - rcu_assign_pointer(priv->rp, NULL); - } else { - if (priv->res[0] !=3D '\0') - return 0; - - strscpy(priv->res, data); - - priv->rp =3D revocable_provider_alloc(&priv->res); - if (!unrcu_pointer(priv->rp)) - return -ENOMEM; - - priv->dentry =3D debugfs_create_file("consumer", 0400, - debugfs_dir, - unrcu_pointer(priv->rp), - &revocable_test_consumer_fops); - if (!priv->dentry) { - revocable_provider_revoke(&priv->rp); - return -ENOMEM; - } - } - - return copied; -} - -static const struct file_operations revocable_test_provider_fops =3D { - .open =3D revocable_test_provider_open, - .release =3D revocable_test_provider_release, - .write =3D revocable_test_provider_write, -}; - -static int __init revocable_test_init(void) -{ - debugfs_dir =3D debugfs_create_dir("revocable_test", NULL); - if (!debugfs_dir) - return -ENOMEM; - - if (!debugfs_create_file("provider", 0200, debugfs_dir, NULL, - &revocable_test_provider_fops)) { - debugfs_remove_recursive(debugfs_dir); - return -ENOMEM; - } - - return 0; -} - -static void __exit revocable_test_exit(void) -{ - debugfs_remove_recursive(debugfs_dir); -} - -module_init(revocable_test_init); -module_exit(revocable_test_exit); - -MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Tzung-Bi Shih "); -MODULE_DESCRIPTION("Revocable Kselftest"); --=20 2.52.0