From nobody Sat Feb 7 10:15:03 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BEB63EDAAD for ; Wed, 4 Feb 2026 12:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770207246; cv=none; b=KuWL8pOxXTk1pNTpMP+bWqnOtob/TqyQ1uCz6GUWNUcgRWk9sa8GGuCimDo3Naep8yfMD2ZzxVuI+GU5kTShGEZsLV6Cl12ACw/zsaejDpubcrjBwB5WWBFSUnizLEyCb9OnDh4IpM+SshEpJ18qfQbFpUfcMg9MwGzp7PohV2M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770207246; c=relaxed/simple; bh=c3Ki7YhXJGsrY1EHJdXQahN87wiUTEcPt2dcaioG84k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X2bZIcNCUm0EHAQKZwBkS8o1rAAfm3LkafPP4OdBtV3ILRoq7+BNH2jT/bmGQ/351OalCMFV7/NtTSk0IfyPtzAifUPHc07PzcBaeziUyQKrl3c3RE1fkSMQPF3FDjwdSeDAED2WO0Gw6v615iFTq3+RxBWfI7n0lbaldQyr6VY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VLdOLd6i; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VLdOLd6i" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a0d52768ccso46042605ad.1 for ; Wed, 04 Feb 2026 04:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770207245; x=1770812045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bA1AdF9WhHexthfe8YUVwhafTHXgnPEul4eYzpiPpqI=; b=VLdOLd6iLIZJTJkorfyRnoEzMp4VvYqxID+ixj1WNj/Pq+w1vVPz1/CGVKZaZkw63u /e6lg8DM5wtdzyrdJUrrSmHGdLT5vFwbcZoR4pjRlDSThnqbM64ZSZxozJAFo3r8JQXv /za9Pv2i5LYpc1fyHaQ42wCEOAz24wIuM+l19njI8QkzzsQ8Uh+J+x0y/zPHJOTs3mcj vy+SyFyx2c2cHxErkcL9C59QctQdYTvOfeRVNhNS5tMU+xt4cL0qHs37Ws37Ma73pAfS pQY7va3prkbRbAP4sMMq8kFY7nPmtpBs5xUYNvdky9LwxHwabNKZyGiC+11Df4S2e0t6 RvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770207245; x=1770812045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bA1AdF9WhHexthfe8YUVwhafTHXgnPEul4eYzpiPpqI=; b=moI9l5rEv1ybQ9zUYD9BYk3AN2c6cNx96XS4d/OGgwPI9Gd+30o8wOZaLJ+O92m3Uu Zmwm060bLCAb8n3aEnkp7u7kt4wpRkVWc4BBJHWAHcUhrSKioyx0DaDZ6ylUmJGkYG4d K2jg16O1oc62qfCpT1xU6XW5Nr5JaTJMHa2rmXvXOBcU0GlfTMTHv1dMFvURZDdcVXfC twLgDs75cZGOJoOseMcoWwCgNMUZrl7fKAEX5GvAUzx6ptu+/06w1EIYkLZtJal1TX6p BiR4DWC1kmDM6woszA7xT/y1iJsP7EDlNyt486foU98h6dJC+JmfcTdca99P9BklTCAB m19g== X-Forwarded-Encrypted: i=1; AJvYcCV0tC5Kxa24oMeFUMVrBbDp5uhQYKXhi39gPL/7fz8ICW+UdtkyVq7dvbd13P9EgqWKeRg0EnPdAoZo8c4=@vger.kernel.org X-Gm-Message-State: AOJu0YzUIzLUMNSPQYI5PojXZ6ka7G4tqEynlH1BXx0U2h2vTyeW7TLJ fzRx2T7984oQFJSejwOJYii1DO3Hg7sJodxtduFC5/N83o2Jf6nZFIXr2Bf6OvqV X-Gm-Gg: AZuq6aIXKqukpROt5+JFlH0D6LPC1xMDgWptEuVECRG/XH+f1DnDOM/bBdDqVYQRJb/ Cp2wBsicsT/s3OElDKAubwJCdHKEsyoBf+l6hfhMwP+pICqtg+VqfsXDXv+5Ve7NwRtemhW7ui1 qDd0NGwVPQZ7a/X4Qp59yegjeo0iErqAfpVNPYawXXtLxnFuAZaOyj6AEmdLk6V9tz37cmBgeqJ qFf95jxKPbIP+SSuCc9HG+KihshsdXnpooZstHTxowiQzUKuX1cCffakazNVbE9unhAPdZ2E7mx sfg+N8/h27l/GIgojDzjb1Hrc51s0qvw8XoAZY+rhzuN/Qg1GYYPBPpHvlbNJ8WoVXnL99CW5l5 PhYpOVoonycWqMLGLxLWIfen/PonGZXQMl88/Y+zeXY88Oxsgo/7B8MP3QL/ZHBIKXPqcYowDkD rvBJXYKjREjg== X-Received: by 2002:a17:902:d4d2:b0:2a7:d93a:a3c5 with SMTP id d9443c01a7336-2a933bbb3damr30198215ad.14.1770207245449; Wed, 04 Feb 2026 04:14:05 -0800 (PST) Received: from mint.. ([2401:4900:53f5:9794:b4e2:d5:4aa9:9038]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a93394e37csm21299155ad.62.2026.02.04.04.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 04:14:04 -0800 (PST) From: dhyaan19022009-hue X-Google-Original-From: dhyaan19022009-hue To: kvalo@kernel.org Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, dhyaan19022009-hue Subject: [PATCH] staging: sm750fb: fix naming styles and const declarations Date: Wed, 4 Feb 2026 17:43:36 +0530 Message-ID: <20260204121337.4819-3-dhyaan19022009@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204121337.4819-1-dhyaan19022009@gmail.com> References: <20260204121337.4819-1-dhyaan19022009@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: dhyaan19022009-hue --- drivers/staging/sm750fb/sm750.c | 26 +++++++++++++------------- drivers/staging/sm750fb/sm750.h | 14 +++++++------- drivers/staging/sm750fb/sm750_hw.c | 22 +++++++++++----------- 3 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm75= 0.c index 9bf3c0a37..13d513bff 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -33,7 +33,7 @@ static int g_hwcursor =3D 1; static int g_noaccel; static int g_nomtrr; -static const char *g_fbmode[] =3D {NULL, NULL}; +static const char * const g_fbmode[] =3D {NULL, NULL}; static const char *g_def_fbmode =3D "1024x768-32@60"; static char *g_settings; static int g_dualview; @@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int = index) "kernel HELPERS prepared vesa_modes", }; =20 - static const char *fixId[2] =3D { + static const char * const fix_id[2] =3D { "sm750_fb1", "sm750_fb2", }; =20 @@ -764,7 +764,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int = index) * must be set after crtc member initialized */ crtc->cursor.offset =3D crtc->o_screen + crtc->vidmem_size - 1024; - crtc->cursor.mmio =3D sm750_dev->pvReg + + crtc->cursor.mmio =3D sm750_dev->pv_reg + 0x800f0 + (int)crtc->channel * 0x140; =20 pr_info("crtc->cursor.mmio =3D %p\n", crtc->cursor.mmio); @@ -862,7 +862,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int = index) fix->ywrapstep =3D crtc->ywrapstep; fix->accel =3D FB_ACCEL_SMI; =20 - strscpy(fix->id, fixId[index], sizeof(fix->id)); + strscpy(fix->id, fix_id[index], sizeof(fix->id)); =20 fix->smem_start =3D crtc->o_screen + sm750_dev->vidmem_start; pr_info("fix->smem_start =3D %lx\n", fix->smem_start); @@ -918,12 +918,12 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev= , char *src) =20 swap =3D 0; =20 - sm750_dev->initParm.chip_clk =3D 0; - sm750_dev->initParm.mem_clk =3D 0; - sm750_dev->initParm.master_clk =3D 0; - sm750_dev->initParm.powerMode =3D 0; - sm750_dev->initParm.setAllEngOff =3D 0; - sm750_dev->initParm.resetMemory =3D 1; + sm750_dev->init_parm.chip_clk =3D 0; + sm750_dev->init_parm.mem_clk =3D 0; + sm750_dev->init_parm.master_clk =3D 0; + sm750_dev->init_parm.power_mode =3D 0; + sm750_dev->init_parm.set_all_eng_off =3D 0; + sm750_dev->init_parm.reset_memory =3D 1; =20 /* defaultly turn g_hwcursor on for both view */ g_hwcursor =3D 3; @@ -942,9 +942,9 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, = char *src) } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) { sm750_dev->nocrt =3D 1; } else if (!strncmp(opt, "36bit", strlen("36bit"))) { - sm750_dev->pnltype =3D sm750_doubleTFT; + sm750_dev->pnltype =3D sm750_double_tft; } else if (!strncmp(opt, "18bit", strlen("18bit"))) { - sm750_dev->pnltype =3D sm750_dualTFT; + sm750_dev->pnltype =3D sm750_dual_tft; } else if (!strncmp(opt, "24bit", strlen("24bit"))) { sm750_dev->pnltype =3D sm750_24TFT; } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) { @@ -1121,7 +1121,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev) sm750fb_framebuffer_release(sm750_dev); arch_phys_wc_del(sm750_dev->mtrr.vram); =20 - iounmap(sm750_dev->pvReg); + iounmap(sm750_dev->pv_reg); iounmap(sm750_dev->pv_mem); kfree(g_settings); } diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm75= 0.h index 2dc57bbe7..19dbb9120 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -14,8 +14,8 @@ =20 enum sm750_pnltype { sm750_24TFT =3D 0, /* 24bit tft */ - sm750_dualTFT =3D 2, /* dual 18 bit tft */ - sm750_doubleTFT =3D 1, /* 36 bit double pixel tft */ + sm750_dual_tft =3D 2, /* dual 18 bit tft */ + sm750_double_tft =3D 1, /* 36 bit double pixel tft */ }; =20 /* vga channel is not concerned */ @@ -39,13 +39,13 @@ enum sm750_path { }; =20 struct init_status { - ushort powerMode; + ushort power_mode; /* below three clocks are in unit of MHZ*/ ushort chip_clk; ushort mem_clk; ushort master_clk; - ushort setAllEngOff; - ushort resetMemory; + ushort set_all_eng_off; + ushort reset_memory; }; =20 struct lynx_accel { @@ -97,12 +97,12 @@ struct sm750_dev { unsigned long vidreg_start; __u32 vidmem_size; __u32 vidreg_size; - void __iomem *pvReg; + void __iomem *pv_reg; unsigned char __iomem *pv_mem; /* locks*/ spinlock_t slock; =20 - struct init_status initParm; + struct init_status init_parm; enum sm750_pnltype pnltype; enum sm750_dataflow dataflow; int nocrt; diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index de1331c56..9e69f3387 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -49,19 +49,19 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pc= i_dev *pdev) } =20 /* now map mmio and vidmem */ - sm750_dev->pvReg =3D + sm750_dev->pv_reg =3D ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size); - if (!sm750_dev->pvReg) { + if (!sm750_dev->pv_reg) { pr_err("mmio failed\n"); ret =3D -EFAULT; goto exit; } - pr_info("mmio virtual addr =3D %p\n", sm750_dev->pvReg); + pr_info("mmio virtual addr =3D %p\n", sm750_dev->pv_reg); =20 - sm750_dev->accel.dpr_base =3D sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dp_port_base =3D sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dpr_base =3D sm750_dev->pv_reg + DE_BASE_ADDR_TYPE1; + sm750_dev->accel.dp_port_base =3D sm750_dev->pv_reg + DE_PORT_ADDR_TYPE1; =20 - mmio750 =3D sm750_dev->pvReg; + mmio750 =3D sm750_dev->pv_reg; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid); =20 sm750_dev->vidmem_start =3D pci_resource_start(pdev, 0); @@ -79,7 +79,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_= dev *pdev) sm750_dev->pv_mem =3D ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size); if (!sm750_dev->pv_mem) { - iounmap(sm750_dev->pvReg); + iounmap(sm750_dev->pv_reg); pr_err("Map video memory failed\n"); ret =3D -EFAULT; goto exit; @@ -93,7 +93,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct p= ci_dev *pdev) { struct init_status *parm; =20 - parm =3D &sm750_dev->initParm; + parm =3D &sm750_dev->init_parm; if (parm->chip_clk =3D=3D 0) parm->chip_clk =3D (sm750_get_chip_type() =3D=3D SM750LE) ? DEFAULT_SM750LE_CHIP_CLOCK : @@ -104,7 +104,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct= pci_dev *pdev) if (parm->master_clk =3D=3D 0) parm->master_clk =3D parm->chip_clk / 3; =20 - ddk750_init_hw((struct initchip_param *)&sm750_dev->initParm); + ddk750_init_hw((struct initchip_param *)&sm750_dev->init_parm); /* for sm718, open pci burst */ if (sm750_dev->devid =3D=3D 0x718) { poke32(SYSTEM_CTRL, @@ -136,10 +136,10 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, stru= ct pci_dev *pdev) switch (sm750_dev->pnltype) { case sm750_24TFT: break; - case sm750_doubleTFT: + case sm750_double_tft: val |=3D PANEL_DISPLAY_CTRL_DOUBLE_PIXEL; break; - case sm750_dualTFT: + case sm750_dual_tft: val |=3D PANEL_DISPLAY_CTRL_DUAL_DISPLAY; break; } --=20 2.43.0