From nobody Sun Feb 8 12:14:12 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 172643EF0C2; Wed, 4 Feb 2026 11:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204320; cv=none; b=QbIIDQSml6QqKYpHs/ADxDJKQpdFspx4uC7Av2PYlvt7yAhXYA5sKRnRoFrq3q9KQBqB0+0UA2QRZg3+o5D/DYqDIIFc3vO6u1fR3mNgcYzuBR3YJKHFJXHpHWMksCg7GDPu9TwpGsSyDMqH3KsYAJxfFbeOGSkIvJs4IspkVgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204320; c=relaxed/simple; bh=iclPN213YkwPa7GEz0O6Lo/r6Ez5c+6GrJlnrVg1GZ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QWKiqTIzShm7T0eIJAm9EHD94nptU5EWabWrTI8waXk59fbN8IMcVsaaHKI6NckF45dasFIgLLEOrqDsD8C3NtwnY8q7nOJqcbzSgWzUyKFqRDi3zp3visNTul+1Y/uOSznU2T3SPvzmSMVp2QSSlIAjPWJ4LQLON02cOnc3XZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=I9Ba2pMZ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="I9Ba2pMZ" Received: from t16.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E1B210C4; Wed, 4 Feb 2026 12:24:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770204271; bh=iclPN213YkwPa7GEz0O6Lo/r6Ez5c+6GrJlnrVg1GZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I9Ba2pMZwtZSybtnMEdOBP0t/mo3fP4PY8d9Lo3MRnP9uOIzMtjSE+VRC8lzugVDT LMH6Feh3sZoewAhb1udhgHhos9uggsP6Kc75OKE9y6yCADp8Vcuej5tOCt5bru85Q2 6kCFBVxhvfnSovc2XGyIZc5ggDjyX8MZgB1fNt6o= From: Isaac Scott To: linux-media@vger.kernel.org Cc: dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Isaac Scott Subject: [PATCH v1 1/6] media: rkisp1-resizer: Add YUV source formats to resizer Date: Wed, 4 Feb 2026 11:25:01 +0000 Message-ID: <20260204112506.3706049-2-isaac.scott@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To be able to use YUV bypass, YUV formats need to be available on the source pad of the rkisp1 resizer. Add them. Signed-off-by: Isaac Scott --- .../platform/rockchip/rkisp1/rkisp1-resizer.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/driv= ers/media/platform/rockchip/rkisp1/rkisp1-resizer.c index 8e6b753d3081..e72b76ab078c 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c @@ -23,11 +23,26 @@ struct rkisp1_rsz_yuv_mbus_info { }; =20 static const struct rkisp1_rsz_yuv_mbus_info rkisp1_rsz_yuv_src_formats[] = =3D { + { + .mbus_code =3D MEDIA_BUS_FMT_UYVY8_2X8, /* YUV422 */ + .hdiv =3D 1, + .vdiv =3D 1, + }, + { + .mbus_code =3D MEDIA_BUS_FMT_VYUY8_2X8, /* YUV422 */ + .hdiv =3D 1, + .vdiv =3D 1, + }, { .mbus_code =3D MEDIA_BUS_FMT_YUYV8_2X8, /* YUV422 */ .hdiv =3D 2, .vdiv =3D 1, }, + { + .mbus_code =3D MEDIA_BUS_FMT_YVYU8_2X8, /* YUV422 */ + .hdiv =3D 1, + .vdiv =3D 1, + }, { .mbus_code =3D MEDIA_BUS_FMT_YUYV8_1_5X8, /* YUV420 */ .hdiv =3D 2, --=20 2.43.0 From nobody Sun Feb 8 12:14:12 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 172E93EF0C3; Wed, 4 Feb 2026 11:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204320; cv=none; b=e/XsAloMlFse0WK85C+j5Swvdmlb22tdlFwCUS5ky8pPtxKJbUjATpV9xbreygIv42nqWa/CDFkfuxdXAdxBwjpe0l40XbgjCjlqWErNZBVQc0+I/57rgnxVPWp9bYDMmjWUnVD3+HZQHhYPI0NVWZShcRyWv0NMLtFfdzZ2UII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204320; c=relaxed/simple; bh=BN1rqD2UnDUl0GUeoH96i0K4YwyQWxp/kIksm/8/gh4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IjZ80efTKyijPuH36NN2v4mQe/dH3rY6zU0EuXFOtqy5YJPgvpIklnwV3ngxiXD7/pIjFWxweJT7Qza469iKUdTah1YHKU+Ge3HZR6PF9rGnvIDjhfMpIjz98tVlpc/HBxPqpGLqnvQXnLl6/HDmySIUdWXlL6Odd7GzTT+sItY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=SnyoIVet; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SnyoIVet" Received: from t16.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B7F1F1337; Wed, 4 Feb 2026 12:24:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770204272; bh=BN1rqD2UnDUl0GUeoH96i0K4YwyQWxp/kIksm/8/gh4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SnyoIVeti2D98FR9LQYR8dnmP+B0sto2MCJoSJfJcfthO3SVDwDpoBY2A2ldKGCUZ XlduBL7e/IgT5lLUvErEGe5ofevcnQLkzNyCEq85ZXZ9zPe+4jtENkL8xEBXNC8yhs GS2iVo2JLgEPVZfHylUzVxxAZuiR7SRLtXdg8XcY= From: Isaac Scott To: linux-media@vger.kernel.org Cc: dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Isaac Scott Subject: [PATCH v1 2/6] media: rkisp1-isp: Add in_bypass flag for YUV bypass Date: Wed, 4 Feb 2026 11:25:02 +0000 Message-ID: <20260204112506.3706049-3-isaac.scott@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rkisp1 features a 'bypass' mode for RAW and YUV formats. This disables all ISP blocks, and makes the rkisp1 display input data from the mipi csi receiver at the output, unmodified. To determine whether we can activate bypass, we can detect whether both the source and sink formats are YUV. If they are, we can set a new in_bypass flag. For YUV bypass, we should configure the ISP input to interpret incoming H/VSYNC signals as data enable / disable. Add this. Signed-off-by: Isaac Scott --- drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 1 + drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drive= rs/media/platform/rockchip/rkisp1/rkisp1-common.h index 5e6a4d5f6fd1..d90233e31ad3 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h @@ -532,6 +532,7 @@ struct rkisp1_device { struct rkisp1_debug debug; const struct rkisp1_info *info; int irqs[RKISP1_NUM_IRQS]; + bool in_bypass; bool irqs_enabled; }; =20 diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/= media/platform/rockchip/rkisp1/rkisp1-isp.c index 2311672cedb1..f636d738b7e8 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -212,6 +212,8 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp, const struct v4l2_mbus_framefmt *sink_frm; const struct v4l2_rect *sink_crop; =20 + rkisp1->in_bypass =3D false; + sink_frm =3D v4l2_subdev_state_get_format(sd_state, RKISP1_ISP_PAD_SINK_VIDEO); sink_crop =3D v4l2_subdev_state_get_crop(sd_state, @@ -240,7 +242,10 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp, } } else if (sink_fmt->pixel_enc =3D=3D V4L2_PIXEL_ENC_YUV) { acq_mult =3D 2; - if (mbus_type =3D=3D V4L2_MBUS_CSI2_DPHY) { + if (src_fmt->pixel_enc =3D=3D V4L2_PIXEL_ENC_YUV) { + isp_ctrl =3D RKISP1_CIF_ISP_CTRL_ISP_MODE_DATA_MODE; + rkisp1->in_bypass =3D true; + } else if (mbus_type =3D=3D V4L2_MBUS_CSI2_DPHY) { isp_ctrl =3D RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601; } else { if (mbus_type =3D=3D V4L2_MBUS_BT656) --=20 2.43.0 From nobody Sun Feb 8 12:14:12 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4D9C3ECBD1; Wed, 4 Feb 2026 11:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204322; cv=none; b=ZKNspZLwifHY3a6BdXFBd/VxH6MqTu1X4sHcoOwB7KK8p+QUJU8oVM1KxhZbpwvGXSR7frfpSn/dy5sISFXwDZbA7I6VzdMi2CLUttFai9aKeVQMVpt0FSw3Qt8f4Yfs3ltuPbZZTs/BkVSQIxhEQMPSg4M/nfoPR6tXqKmhY6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204322; c=relaxed/simple; bh=Dvl3Tree0wsEccwQaxwDEFxXPpQC0laXl6e03FgkyEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dNXDVfKDRB74tm6+POg2zaznwVFesnD1ms4x9tmqwrPKKMBTf75sGJmj4vdfDfYPOkqlbJhn3aR+VEar+Tvu0yPlyRnbQR+MjnX9GdT53pquv6Lvu8FBR2WJZLaFb8Ho6y0BldD5PIVftC+DQ8XD4DIvSHCvnwM3akJ2uHBDblw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=bWhK2CM2; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bWhK2CM2" Received: from t16.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 22DBD1356; Wed, 4 Feb 2026 12:24:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770204273; bh=Dvl3Tree0wsEccwQaxwDEFxXPpQC0laXl6e03FgkyEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bWhK2CM2Ml1myVRfbA2vz9SqyzEkleAq5+dv54lr6FCE59eA2ba+WNfxCeFh0tIQd 20C4ugZ3FQcpVnw7Pgv1fg2Sfb8LkQrywxNOotcXAUVuSPBhD6RkebFvIeRJtpzmf7 a+0qC8E20QAFhbfnklnTD7N00OOqMEw836bX+K+I= From: Isaac Scott To: linux-media@vger.kernel.org Cc: dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Isaac Scott Subject: [PATCH v1 3/6] media: rkisp1-isp: Add target_format Date: Wed, 4 Feb 2026 11:25:03 +0000 Message-ID: <20260204112506.3706049-4-isaac.scott@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In passthough mode, we want to make sure the output format of the ISP is identical to the input format. Add logic to ensure the format we configure the output of the ISP with is the sink format when we are in bypass, and the source format if we are not. Signed-off-by: Isaac Scott --- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/= media/platform/rockchip/rkisp1/rkisp1-isp.c index f636d738b7e8..716bd7f3c66d 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -175,9 +175,10 @@ static void rkisp1_gasket_disable(struct rkisp1_device= *rkisp1) static void rkisp1_config_ism(struct rkisp1_isp *isp, const struct v4l2_subdev_state *sd_state) { - const struct v4l2_rect *src_crop =3D + const struct v4l2_rect *target_crop =3D v4l2_subdev_state_get_crop(sd_state, - RKISP1_ISP_PAD_SOURCE_VIDEO); + (isp->rkisp1->in_bypass ? + RKISP1_ISP_PAD_SINK_VIDEO : RKISP1_ISP_PAD_SOURCE_VIDEO)); struct rkisp1_device *rkisp1 =3D isp->rkisp1; u32 val; =20 @@ -185,10 +186,10 @@ static void rkisp1_config_ism(struct rkisp1_isp *isp, rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_MAX_DX, 0); rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_MAX_DY, 0); rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_DISPLACE, 0); - rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_H_OFFS, src_crop->left); - rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_V_OFFS, src_crop->top); - rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_H_SIZE, src_crop->width); - rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_V_SIZE, src_crop->height); + rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_H_OFFS, target_crop->left); + rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_V_OFFS, target_crop->top); + rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_H_SIZE, target_crop->width); + rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_V_SIZE, target_crop->height); =20 /* IS(Image Stabilization) is always on, working as output crop */ rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_CTRL, 1); --=20 2.43.0 From nobody Sun Feb 8 12:14:12 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4E3C3EF0D4; Wed, 4 Feb 2026 11:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204322; cv=none; b=nYOA0aHR4Xs1uWgcgr5SHVcHm+PxeYhIuTPQVMis9NuTFS/EJURCC/XLEW9D3gU8pTkS2QRYE8w68t8Kin2X1a9l15pZ1XU2h7ENM4paXyFxL/KxbSW6ybe1EYr6dior6BCBNkkxJr5oOeFFEsB5v+FAvDdciZkRiIVX1FhqUNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204322; c=relaxed/simple; bh=5tT1QreBElhmzJ9xX6zFvlJg6hRkmTy0drDHUcyVEf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=geqdRWDyhUtySAvPn3pGHm0Mi31thst18lqyFdvD9rLbL7b2PYne29dXnZJtfPURHhpvTrHhdmuFu1MOx+/yP+3jpvLClveaiVHhwP7op6SZ/Nxr5Q47v5mfCbCPmltC2oAJBMiTYAtUpXZRuR9NZTBWtNXquKpxnNMnAatsdsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=iWCmWHFs; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iWCmWHFs" Received: from t16.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AF2691379; Wed, 4 Feb 2026 12:24:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770204275; bh=5tT1QreBElhmzJ9xX6zFvlJg6hRkmTy0drDHUcyVEf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iWCmWHFsKSdLFUC99b55o6TBcg1js9Z0ptZTLF1wD4SsuIJmw05tyU6+PH6oNNkcF lY6SaLchuk8oWonZGq9ld/hxJupjI/ReyJYh56UjZIDAwi838NALD0YVex54u9Psbn EkD05WdwsiKxplbpy24nQfUAbn1qDpZopLMYz5do= From: Isaac Scott To: linux-media@vger.kernel.org Cc: dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Isaac Scott Subject: [PATCH v1 4/6] media: rkisp1-isp: Propagate sink -> source format in YUV passthough Date: Wed, 4 Feb 2026 11:25:04 +0000 Message-ID: <20260204112506.3706049-5-isaac.scott@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If we are in bypass mode, we should propagate the sink format of the ISP to the source format to ensure the pipeline is valid. Ensure the source pad format of the ISP is configured to the same format as the sink pad. Signed-off-by: Isaac Scott --- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/= media/platform/rockchip/rkisp1/rkisp1-isp.c index 716bd7f3c66d..c457593526c5 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -630,6 +630,11 @@ static void rkisp1_isp_set_src_fmt(struct rkisp1_isp *= isp, */ sink_info =3D rkisp1_mbus_info_get_by_code(sink_fmt->code); =20 + if (sink_info->pixel_enc =3D=3D V4L2_PIXEL_ENC_YUV) { + format->code =3D sink_fmt->code; + dev_dbg(isp->rkisp1->dev, "ISP sink pad is YUV"); + } + src_fmt->code =3D format->code; src_info =3D rkisp1_mbus_info_get_by_code(src_fmt->code); if (!src_info || !(src_info->direction & RKISP1_ISP_SD_SRC)) { --=20 2.43.0 From nobody Sun Feb 8 12:14:12 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 717F13EFD18; Wed, 4 Feb 2026 11:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204323; cv=none; b=g9xF4p0vdgIlkr8OFIyJGWctZgxlINeJNIK9smFDhgULjiYtAoWIsto0DQ1LBWfVQZRYyGUzjb3gLZLrfwD206ByA8a4O0vV1fIx3m+jXtVuuyb7gF2fR9HtEUOEYb/MBaEFl1xNbF8CxCNply3hdqJMZ7H5Jiieepl2/g0ZUEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204323; c=relaxed/simple; bh=UusNAsGsuADFh1LH6Jjf0gCE90ONPblIBTQZe3RyvTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pfPjBh1PyJsCdPfGoyDw+01aAcTuOCVt9klxmmX+aGHpCJ5Mr5HlwzMhAnuhBg4i5qW/BKjQjqEISphzssPUeV3b+fQTXkamy/Eb2WX0udxUs0ylELJbCH5gBMk1Ld9DI0PrlRL8vLrKgeKIE+64vJIeo45aao48vxb6+2Wn6/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=pYTgLfH4; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pYTgLfH4" Received: from t16.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8580013CA; Wed, 4 Feb 2026 12:24:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770204277; bh=UusNAsGsuADFh1LH6Jjf0gCE90ONPblIBTQZe3RyvTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pYTgLfH4dCqrkwTHh3DyTlB/tVpX+dr3Bj6rgebnkyOdUQg9ljmR6905Ya0RlILki 7qwVR4wA2Liz1HfhBSL4WxU2krZd9hBbY2O1bPNJER5m93VuXDz8BMiPEd5REw0a57 b8J+P8fnFPQ7fjbWvkxL9ahytugVAVLKdH4SRWEc= From: Isaac Scott To: linux-media@vger.kernel.org Cc: dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Isaac Scott Subject: [PATCH v1 5/6] media: rkisp1: Give buffers back instead of dropping in bypass mode Date: Wed, 4 Feb 2026 11:25:05 +0000 Message-ID: <20260204112506.3706049-6-isaac.scott@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the data mode used for YUV passthrough, falling VSYNC events are used to determine when a buffer is complete. This means there is no 'Frame End' signal. Previously, all buffers would be dropped when bypass mode was active. Instead of dropping every frame, we should return the buffer to user space if it is marked as complete by a falling VSYNC signal. Signed-off-by: Isaac Scott --- drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/driv= ers/media/platform/rockchip/rkisp1/rkisp1-capture.c index 867cdddf9f89..2753be39ab33 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c @@ -832,6 +832,11 @@ irqreturn_t rkisp1_capture_isr(int irq, void *ctx) for (i =3D 0; i < dev_count; ++i) { struct rkisp1_capture *cap =3D &rkisp1->capture_devs[i]; =20 + if (rkisp1->in_bypass) { + rkisp1_handle_buffer(cap); + continue; + } + if (!(status & RKISP1_CIF_MI_FRAME(cap))) continue; if (!cap->is_stopping) { --=20 2.43.0 From nobody Sun Feb 8 12:14:12 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F8F33F0745; Wed, 4 Feb 2026 11:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204323; cv=none; b=YARS6mquXqIfA7eLRe/0VonNc02LI5nNexaWfiNg26PaXagvK93Z4UeCQO7DVVts+rvxYxRhm6l7sh4WlaqwtsjKeAk1WYvMs4Cz3FQo5ho92Am/Gwo/t+GSFox+4GJuZeCiFU5FHhqkC68c8WlkOcrIU30U6dm38YkPJ+8UVDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770204323; c=relaxed/simple; bh=Bt1EGAdaqcvf0NyytShh8FFlf4eE/kulWr9PEZlTjh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O6zWDsKAssMyZ7LKmCalGI/uvfr14PCS58/m96ZfmSZyQ7dr4Yx1BVok+f+J0lLW8X3X7fLu8CqXPYKt5eoPogm23sQT8g1sWpXZZOr4+Dwqw02oRuwzCKeBnJjNIi+kWUyjCA/JPN2U7CZMNkVLO7Cx5Bb477iCYqwZqRA8eEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CfDh3q0c; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CfDh3q0c" Received: from t16.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 49AFD13AB; Wed, 4 Feb 2026 12:24:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770204279; bh=Bt1EGAdaqcvf0NyytShh8FFlf4eE/kulWr9PEZlTjh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CfDh3q0c14ZEYW60C/Y3EC2oNNN13NbkHClS0vfboFM4vgN/lHfvOYllJV2JqxIZH hkiLBx6yFbhH/k6EKdmhi1pj/w78MDgKGWkaQr7ThPoSnr4KZkielFqrk2AQWHx+LM y7lOV3+9tqCDyZfhy85HP1Jvln8uDrB98A+sBmRw= From: Isaac Scott To: linux-media@vger.kernel.org Cc: dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Isaac Scott Subject: [PATCH v1 6/6] media: rkisp1: Treat 8 bus width and 16 bus width formats the same Date: Wed, 4 Feb 2026 11:25:06 +0000 Message-ID: <20260204112506.3706049-7-isaac.scott@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As MIPI CSI is a serial interface, we should be able to use a bit depth of 16 in the same way as 8 bit depth. Add a fallthrough case to ensure we don't reject 16 bit depth formats. Signed-off-by: Isaac Scott --- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/= media/platform/rockchip/rkisp1/rkisp1-isp.c index c457593526c5..722ebcfbddbb 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -265,6 +265,7 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp, =20 switch (sink_fmt->bus_width) { case 8: + case 16: acq_prop |=3D RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_8B_ZERO; break; case 10: --=20 2.43.0