From nobody Sat Feb 7 11:31:32 2026 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E3A3D667E for ; Wed, 4 Feb 2026 10:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770200098; cv=none; b=rDtFbQW1YBiVNVr4m2XdCwouwue224RyiXYmLCnD4nl0x9b22gfb3VZd/5mpaxIzodjFbbnuJ/68kdNXkgwg2h8sGLZUNkAbDsXD96PDVWP+Up823IlvXYCLXBn6pQ+ErwPwtBCLHl+2x1xn200ehCtUlsk7erHpDWRe54OtkFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770200098; c=relaxed/simple; bh=WiR906c8F0VEFLN4RA2AEE8JZtLkWBspsKYulRhxAEI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ZdOgf0JZ2oZr6pupmQc/f9hjszDolzF6nUMyHYza/wt5+4bN2DEH5iQ3H6nxI9/E97VsCaZfG+KyhUIDtsoSjKbWkHLaMTROnnYvaXE4zi0oVgtN0MEUlK0MSap2vkhIuqFmVHTyvEBXsq99UojMaQSiHpl/64N5J/ttDA6kjck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZrQql6eU; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZrQql6eU" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770200095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tNDuvLBbkzIbWJoE0G1ZqgGCpNPmYnXQHNWvh9P0CtQ=; b=ZrQql6eUufu63rSDKCzdzVXNSBwjStFKM8ncoqOtyiPXdNbP5cLDWEaZw0krnKvofwQGfp UX3JUHhW49zGQVLBlYZvXvre1OMbPTlOSPtFDbEURtluUFs8UMuTqo/A1xtNSZaeqPEdFo mxQJAxdNemxSSzCF08SWCW2fBkaExjo= From: Hao Ge To: Vlastimil Babka , Andrew Morton , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Ge , Hao Li Subject: [PATCH v2] mm/slab: Add alloc_tagging_slab_free_hook for memcg_alloc_abort_single Date: Wed, 4 Feb 2026 18:14:01 +0800 Message-Id: <20260204101401.202762-1-hao.ge@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" When CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled, the following warning may be noticed: [ 3959.023862] ------------[ cut here ]------------ [ 3959.023891] alloc_tag was not cleared (got tag for lib/xarray.c:378) [ 3959.023947] WARNING: ./include/linux/alloc_tag.h:155 at alloc_tag_add+0x= 128/0x178, CPU#6: mkfs.ntfs/113998 [ 3959.023978] Modules linked in: dns_resolver tun brd overlay exfat btrfs = blake2b libblake2b xor xor_neon raid6_pq loop sctp ip6_udp_tunnel udp_tunne= l ext4 crc16 mbcache jbd2 rfkill sunrpc vfat fat sg fuse nfnetlink sr_mod v= irtio_gpu cdrom drm_client_lib virtio_dma_buf drm_shmem_helper drm_kms_help= er ghash_ce drm sm4 backlight virtio_net net_failover virtio_scsi failover = virtio_console virtio_blk virtio_mmio dm_mirror dm_region_hash dm_log dm_mu= ltipath dm_mod i2c_dev aes_neon_bs aes_ce_blk [last unloaded: hwpoison_inje= ct] [ 3959.024170] CPU: 6 UID: 0 PID: 113998 Comm: mkfs.ntfs Kdump: loaded Tain= ted: G W 6.19.0-rc7+ #7 PREEMPT(voluntary) [ 3959.024182] Tainted: [W]=3DWARN [ 3959.024186] Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/20= 22 [ 3959.024192] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE= =3D--) [ 3959.024199] pc : alloc_tag_add+0x128/0x178 [ 3959.024207] lr : alloc_tag_add+0x128/0x178 [ 3959.024214] sp : ffff80008b696d60 [ 3959.024219] x29: ffff80008b696d60 x28: 0000000000000000 x27: 00000000000= 00240 [ 3959.024232] x26: 0000000000000000 x25: 0000000000000240 x24: ffff800085d= 17860 [ 3959.024245] x23: 0000000000402800 x22: ffff0000c0012dc0 x21: 00000000000= 002d0 [ 3959.024257] x20: ffff0000e6ef3318 x19: ffff800085ae0410 x18: 00000000000= 00000 [ 3959.024269] x17: 0000000000000000 x16: 0000000000000000 x15: 00000000000= 00000 [ 3959.024281] x14: 0000000000000000 x13: 0000000000000001 x12: ffff6000641= 01293 [ 3959.024292] x11: 1fffe00064101292 x10: ffff600064101292 x9 : dfff8000000= 00000 [ 3959.024305] x8 : 00009fff9befed6e x7 : ffff000320809493 x6 : 00000000000= 00001 [ 3959.024316] x5 : ffff000320809490 x4 : ffff600064101293 x3 : ffff8000806= 91838 [ 3959.024328] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff0000d5b= cd640 [ 3959.024340] Call trace: [ 3959.024346] alloc_tag_add+0x128/0x178 (P) [ 3959.024355] __alloc_tagging_slab_alloc_hook+0x11c/0x1a8 [ 3959.024362] kmem_cache_alloc_lru_noprof+0x1b8/0x5e8 [ 3959.024369] xas_alloc+0x304/0x4f0 [ 3959.024381] xas_create+0x1e0/0x4a0 [ 3959.024388] xas_store+0x68/0xda8 [ 3959.024395] __filemap_add_folio+0x5b0/0xbd8 [ 3959.024409] filemap_add_folio+0x16c/0x7e0 [ 3959.024416] __filemap_get_folio_mpol+0x2dc/0x9e8 [ 3959.024424] iomap_get_folio+0xfc/0x180 [ 3959.024435] __iomap_get_folio+0x2f8/0x4b8 [ 3959.024441] iomap_write_begin+0x198/0xc18 [ 3959.024448] iomap_write_iter+0x2ec/0x8f8 [ 3959.024454] iomap_file_buffered_write+0x19c/0x290 [ 3959.024461] blkdev_write_iter+0x38c/0x978 [ 3959.024470] vfs_write+0x4d4/0x928 [ 3959.024482] ksys_write+0xfc/0x1f8 [ 3959.024489] __arm64_sys_write+0x74/0xb0 [ 3959.024496] invoke_syscall+0xd4/0x258 [ 3959.024507] el0_svc_common.constprop.0+0xb4/0x240 [ 3959.024514] do_el0_svc+0x48/0x68 [ 3959.024520] el0_svc+0x40/0xf8 [ 3959.024526] el0t_64_sync_handler+0xa0/0xe8 [ 3959.024533] el0t_64_sync+0x1ac/0x1b0 [ 3959.024540] ---[ end trace 0000000000000000 ]--- When __memcg_slab_post_alloc_hook() fails, there are two different free paths depending on whether size =3D=3D 1 or size !=3D 1. In the kmem_cache_free_bulk() path, we do call alloc_tagging_slab_free_hook(). However, in memcg_alloc_abort_single() we don't, the above warning will be triggered on the next allocation. Therefore, add alloc_tagging_slab_free_hook() to the memcg_alloc_abort_single() path. Fixes: 9f9796b413d3 ("mm, slab: move memcg charging to post-alloc hook") Suggested-by: Hao Li Signed-off-by: Hao Ge Reviewed-by: Hao Li Reviewed-by: Harry Yoo Reviewed-by: Suren Baghdasaryan --- v2: Hao Li correctly pointed out the root cause of this problem. Per his suggestion, this patch adds the missing hook call. Many thanks to him for the thorough analysis. --- mm/slub.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index f77b7407c51b..452a92544c6a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -6689,6 +6689,8 @@ void slab_free(struct kmem_cache *s, struct slab *sla= b, void *object, static noinline void memcg_alloc_abort_single(struct kmem_cache *s, void *object) { + alloc_tagging_slab_free_hook(s, virt_to_slab(object), &object, 1); + if (likely(slab_free_hook(s, object, slab_want_init_on_free(s), false))) do_slab_free(s, virt_to_slab(object), object, object, 1, _RET_IP_); } --=20 2.25.1