From nobody Sun Feb 8 19:56:13 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA4492D46A1 for ; Wed, 4 Feb 2026 09:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770197157; cv=none; b=UA4Ya9TwKCYIjQAlT0GeNINNdE19962hmV3wflfVFPKMitF9M65++ts6ysjR2y0ecaqCtXmBzH1dtZqjahyjibayIWa81jqlEjWKSOXjrDaQDSIxRmnzSQ85/2JI7BsBs3i+8BS2gOi2339Nt+gowBuunhwyqzps0Lh4gQcXRbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770197157; c=relaxed/simple; bh=5O4IKLhSjY/PuvGmInn5Wp7fBrXg5O/LA2tUMxelaNM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VtqS5fLUE7AbChZIkT2Zw2vTNHtKTXYLYsOesv+OYmIakRHBy5JGuhsp6KVvrgjpxeYybYtGoAmDYorGbRSSj/eB+RIh3GYsfCnI6XPHksiwWRqD+TpM9eWthtoAl/0c7jeeJeuVyyo/t2l/XZXN7RKuYPCMfXgfWbHOrm7agto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowACnUm6WEINpbTYgBw--.17042S2; Wed, 04 Feb 2026 17:25:42 +0800 (CST) From: Chen Ni To: andyshrk@163.com, Laurent.pinchart@ideasonboard.com, airlied@gmail.com, andrzej.hajda@intel.com, andy.yan@rock-chips.com, jernej.skrabec@gmail.com, jonas@kwiboo.se, luca.ceresoli@bootlin.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, neil.armstrong@linaro.org, rfoss@kernel.org, rgallaispou@gmail.com, simona@ffwll.ch, tzimmermann@suse.de Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH v2] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind() Date: Wed, 4 Feb 2026 17:21:48 +0800 Message-Id: <20260204092148.2309681-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <3384b794.65bd.19c27b7d739.Coremail.andyshrk@163.com> References: <3384b794.65bd.19c27b7d739.Coremail.andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowACnUm6WEINpbTYgBw--.17042S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KFykJw47CF1DGF1rAr4ruFg_yoW8JFWrpF 4xXa15tr9YqF43tay7AF18CFnxGa4ktFWrCrW7Jwsav3s7WFyqywsIyrWayr1DWFWUCF15 Ars8XrWfCF4jkaUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBKb7Iv0xC_Cr1lb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v 4I1lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AFwI0_GFv_Wrylc2xSY4AK67AK6r 4fMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRC5l8JUUUUU= = X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" Return the value of devm_drm_bridge_add() in order to propagate the error properly, if it fails due to resource allocation failure or bridge registration failure. This ensures that the bind function fails safely rather than proceeding with a potentially incomplete bridge setup. Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before attach= ing") Signed-off-by: Chen Ni --- Changes in v2: - Use ERR_PTR() instead of dev_err_ptr_probe(). --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 432342452484..29fcba7a47d3 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2049,7 +2049,11 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct = drm_encoder *encoder, bridge->type =3D DRM_MODE_CONNECTOR_DisplayPort; bridge->ycbcr_420_allowed =3D true; =20 - devm_drm_bridge_add(dev, bridge); + ret =3D devm_drm_bridge_add(dev, bridge); + if (ret) { + dev_err_probe(dev, ret, "failed to add bridge\n"); + return ERR_PTR(ret); + } =20 dp->aux.dev =3D dev; dp->aux.drm_dev =3D encoder->dev; --=20 2.25.1