From nobody Sun Feb 8 05:41:30 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8349E396D24 for ; Wed, 4 Feb 2026 09:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770195888; cv=none; b=MjHKLa/kk0R7NZHHHPFiju1HE+dL0S+By9joy5KmAhXF1bXVj0Hldiw/rlMOZuwCUG01UE4J+MZEegLWpzs/e0/A/ltx59vhy4dz0JODrRhbupsymq6+huNAhZE+YIiMly2La9G9Jv+w5r7KkioY0cAtY9Wb0Xn7yOPZHGzCtFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770195888; c=relaxed/simple; bh=b7o9EGeczHhj0UnKFpJJndatUBCnTI8nb7udT0b939Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Y3GcqesL49foTABbiN/kdBpHSncHqrwT9uxrwAV06Kxxrc/3GJhGXpHhpD/gaQWI+yYqOSF6Q/HCn4sqfbC1B4LtSwQNZmGY5Fgh7tMD5YP+AmWFxZcJpeAPSoItSmABU9muafZgvEoy4WZFR7BW2UwemwQ43pBYlLRIPn8g4Ow= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ReW/SFcw; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ReW/SFcw" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-81ed3e6b8e3so3509800b3a.2 for ; Wed, 04 Feb 2026 01:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770195888; x=1770800688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IKhgcQfzdWAm6MrQstZzClRw7NEMvrb/unRTCiXNDpU=; b=ReW/SFcwP6Y89Hn1gkKwU0LZ67pc14gru7qwpKG6/vjokyrZptvSb26CzM8qEaKQnW 7JL3cO+Xeku9+nqc98afWNo6nsFtQYchfQim+F8bGpwwFZxaBBfXjpCWYjIF0mCHhw1B 30IARAFkLDwK5a+/7KckswZIZMGdoW/qFYMy9nLk0vz+5c5pzfO7qVMNzarAw7hQokvR 4i4CGNXtHuoQnYYV4yyTbxOsVaXC6ywNODBHed3z51dKu8UHrBToKz/fVHv7N0EHI9ss mwvOnr/aiml5xsVx3ld/PUVlao8mU4uR4197+H28lI6o9V8hFC8zfgPEH9gLUoXhNzAr AQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770195888; x=1770800688; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IKhgcQfzdWAm6MrQstZzClRw7NEMvrb/unRTCiXNDpU=; b=RnlNVoSmT84YN8jqqt7c585eSpUvaa1uauockBkdYBkHw/P2XfkUG9VF4C6r1aqsQU YXykgJdPCRDNpEe++WJ2b2p5AJxliYGzhXv7/HVVHAoJFlcUH8O8iM0sCsj4RzC/JPrq Ayd+etXBqiUHzz/KSEv+Uvb9m3UunydApneUU6cPi0/mLyZwEh6f+lKgErooC1RJdD+G MLb4HXr6HbG8Oopw0jAfRZLK1TYQHGSW22VmGwhXFhGYIxyM96gcwbI8LoC/xhBf+ugM iquDQZK4L2HBvQpKMGHIHhg6U9PyEReAAF/YWhi8DYj4ML3QDLBwN+ObZzdT3e9F4671 2QhA== X-Forwarded-Encrypted: i=1; AJvYcCXKWYht/IUaC5bHcEO3+SheqjGDwwPXT8FIfSpCz/ACVPtdQBhF2pDt+wsKewZqqLUVPSEAMjngVlELg2c=@vger.kernel.org X-Gm-Message-State: AOJu0YylBBr2VHwt1uNXat+ldMxaP4FQYVwCy/5H+po4SF5pLoRXE5Qm bZqo1KGhCmdLolY2GwQ8WlWfNvs53qlh42E0Wva74qtpuX2y31sIgprf X-Gm-Gg: AZuq6aJiR+okej+J+6CRor/bFeIK8oHO70naklJkVFCgwEmkOp3jS91GNs+7ga+/M15 My2RIWu+ckmEvsIa9IybFKbMSdYrqGUD1ZVkQ2/0nDPoSjcZtBDmneLrMlMSp6cRYnmfB6De0ie lHi96bl5bUu8QFKrH6hbHHMxwfOhUVhN3KS49PZoROsQF0o6zTM8Q5d86akbqv0DpBiWQV7fNsf HqZTONmA/dz/bUokYCkXYUNFKC09rSKzBAAh2xPjCFWBru8HDWIJVNG7KkG/d/ReThvu08B7S5c Q0va1VsgOsxCkxcrFeqILAKriC42JsCFebtrbAbxSfo0IcSOjKFckQuIPmyhSyHFtc3B6hSWPMR DM7DnI54LPugWLk6VzCJrWC/xszvuaZE9NZfoGQDQErueCMo72D8GeaM9//J1ZIjoI1I9bCLRBn 5/DMliaDccPeOlIK+WmKkCNxcBnxa0h4XkCP/vSYLuCGGmagKGAPTVUOOjlZLAsc4SxLM= X-Received: by 2002:a05:6a00:bd10:b0:821:7d7e:41e0 with SMTP id d2e1a72fcca58-8241c19dabbmr2028417b3a.5.1770195887712; Wed, 04 Feb 2026 01:04:47 -0800 (PST) Received: from eurus-Lenovo-Legion-Y70002021.. (n058152109156.netvigator.com. [58.152.109.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d163ce2sm2077923b3a.13.2026.02.04.01.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 01:04:47 -0800 (PST) From: Wang Jiayue To: rafael@kernel.org, lenb@kernel.org, pavel@kernel.org, gregkh@linuxfoundation.org, dakr@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Wang Jiayue , Gui-Dong Han Subject: [PATCH] PM: sleep: wakeirq: remove outdated comments Date: Wed, 4 Feb 2026 17:04:31 +0800 Message-Id: <20260204090431.84978-1-akaieurus@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the stale documentations. The comments claiming that dev_pm_*wake_irq*() helpers must be called with dev->power.lock held and only from rpm_suspend/resume paths are no longer correct, since pm_runtime_force_suspend/resume() call them lockless. Reported-by: Gui-Dong Han Closes: https://lore.kernel.org/all/CAJZ5v0jN9fU9NdWqc-+F5hiSEP4JkR=3D_qcdG= zzHtk1i5tvCDbQ@mail.gmail.com/ Fixes: c46a0d5ae4f9 ("PM: runtime: Extend support for wakeirq for force_sus= pend|resume") Signed-off-by: Wang Jiayue --- drivers/base/power/wakeirq.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c index 8aa28c08b289..4f57058f2148 100644 --- a/drivers/base/power/wakeirq.c +++ b/drivers/base/power/wakeirq.c @@ -269,9 +269,6 @@ EXPORT_SYMBOL_GPL(dev_pm_set_dedicated_wake_irq_reverse= ); * starts in RPM_SUSPENDED state, and the first pm_runtime_get() would * otherwise try to disable already disabled wakeirq. The wake-up interrupt * starts disabled with IRQ_NOAUTOEN set. - * - * Should be only called from rpm_suspend() and rpm_resume() path. - * Caller must hold &dev->power.lock to change wirq->status */ void dev_pm_enable_wake_irq_check(struct device *dev, bool can_change_status) @@ -303,7 +300,6 @@ void dev_pm_enable_wake_irq_check(struct device *dev, * @cond_disable: if set, also check WAKE_IRQ_DEDICATED_REVERSE * * Disables wake-up interrupt conditionally based on status. - * Should be only called from rpm_suspend() and rpm_resume() path. */ void dev_pm_disable_wake_irq_check(struct device *dev, bool cond_disable) { @@ -328,8 +324,6 @@ void dev_pm_disable_wake_irq_check(struct device *dev, = bool cond_disable) * Enable wake IRQ conditionally based on status, mainly used if want to * enable wake IRQ after running ->runtime_suspend() which depends on * WAKE_IRQ_DEDICATED_REVERSE. - * - * Should be only called from rpm_suspend() path. */ void dev_pm_enable_wake_irq_complete(struct device *dev) { --=20 2.34.1