From nobody Sat Feb 7 18:15:30 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D710936AB53 for ; Wed, 4 Feb 2026 08:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770193119; cv=none; b=aephDkzWyDxfRJTgABEbzW7KhAV3giqKHn9MLPLz12cJCNmXbUwS1DW/eeSHfG0g1x4KvOlXXyQi/cLZIVNQhH2gz9u1bwF5nH/jiYfFAL7B2DD08dLjY18OwAhLQvhRSMHuNqBbU2gjz/N1V2oSfqLjtnBWprdZfrLYJtJE3JM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770193119; c=relaxed/simple; bh=CmAuiWTnfTw6CxWyxFdT73KrhSFv3MZzhpRILF+Dm/A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LwMAcFck3bO821inIsk+ounwBFLAwp8qHWKnO2nZrsMrYkKETcbVQFcm5vb2EdSADmhdYbAFBoqE6+HSHJqmk8PnMTcQI1+DYY+C8kSi35lfDbvvXmZwXqFsJbyRar0NUSyYOFjQA5FX4mEyAYyBXkBIe83e6iQsgCtYp6l5n6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UNyDDUAW; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UNyDDUAW" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2b7da62b487so945949eec.1 for ; Wed, 04 Feb 2026 00:18:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770193118; x=1770797918; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+12J6wAvYsHe6gylK40n9R4Ga2aOlKmtmFkjYWPvM3o=; b=UNyDDUAWliwsgokJS83xaqiFlsAXJIAF18DZ0CT26Owrsfg71KahacklQ8EWnEPU7B fNaolUB+FYJmPhpImJD2uIFKtc8TY9aRYpO+xIayNSqwmnVW+vg5CuDkCAr9EXjFqLw9 VA6GDQyIuQx39yvVs6NnEAet4OIqODZRnz4KxAFmCrQHLQ3ZOYMQMKYGXhft1z2lrRAx okLk8KH4NGbGT3wGFFA/0EVw87luCrwsKXFQ2VmNeWo6PU7eCJ24uXYferRWHmrYxhhR G2vT82r9FhAvQjuhE3ViTedDfD06vhts240H0ek/5UWNoTK+TL5X9REzm5rjCyww9T9I dLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770193118; x=1770797918; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+12J6wAvYsHe6gylK40n9R4Ga2aOlKmtmFkjYWPvM3o=; b=JF7LccXsW39hCaq8Ozb5oMkFQ6OhnQK/uWWb+VzLiOTkIu6xJBoK8Sf1uqIxyjDe1g W+DSQd9M2jDKk0QR1ejyc2aY0rliS/XBGNEDZcrdZ9/AcLvIVKroOejFbWHDFupdhBM5 o3Z+PXYpIsSBpAUpV4cCssAzI0C3rklZ1gQVazFOMCGr96EGw8/pA+9VbjgqWY3qGJBg TQC1pA6miGcMG8Sic5Kbxg6KJ3SUaeWmEX9LDICnt2B4/8H+OoiyXtZQS4/q1FsmoXAM ynYjsqq4lpV5FOjMHkjibY8slJXQvFn3GHbnFhO7qBPB1Ek6XlT96VT8GoFrFFHlLQiq G8Kw== X-Forwarded-Encrypted: i=1; AJvYcCUXEEA2tF1XZGzjlHjkqPISOT++p79zDNy4C+rr6s+7rp6yyo4v093CLpXMWaFyc9ib+6eHRINiz8fWlxo=@vger.kernel.org X-Gm-Message-State: AOJu0YzlmaCKNqqhhUNGGwE5ZTXiMtf0z79IqV2hbw/QIAfUgHcSgDKj C8R5TcbkV8Iljjjep+NzY31vWByMg6TXOOqtCc0irHOcY6fevxLOAlzf X-Gm-Gg: AZuq6aIXk2sGOV9M3EjxzsoNh7jm6AoJs5wGZPIY5X7ei/HziIqzOqAb+fH2T8zR2qs 5LNpl2FrF/lVwX43E3qu1NF61r6zhtdDIucvmfQ/7tiMbqlFtYiwqkRRy9YJtp1AT6Lyr/+NI+R jerKclwEvRHv7Ef/VYJaNmb6oI9nqBTx0mDAc6cbvHXTXUMjad3a/i35OGmZXfts2Mse4m24FHD R4+PVHa1Ze8m5MqQqFRiAaobb1/EUHro2XHizpldJaJSTtn/ch72PboPOarTDIZbreKCkZdOtXP fwGTbgmwTA5ZQVXEkHi0tuPjYj2+g80/ehAHIA8LNnU9D/90nlg/Wxi4R+gk/mt/5py9+RmuhI+ z0BESnDNftbY6aejVvb3C2sPzDWtWdvz/7OaU0LMbUnAfJ/M7wJzoKtwflntsIFWf8D71TWFKgB eylsrtRud4x87ITq68rvu/u+wcqBPcCOQDjEZj5u1ytKYxrKK9hd2rf/teHXjyRgzRCf/LdNrcB edKY6gUQTd1jS1Ypc16 X-Received: by 2002:a05:7300:2303:b0:2a4:61d1:f451 with SMTP id 5a478bee46e88-2b8328bb865mr946839eec.16.1770193117807; Wed, 04 Feb 2026 00:18:37 -0800 (PST) Received: from localhost.localdomain (108-214-96-168.lightspeed.sntcca.sbcglobal.net. [108.214.96.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b832f8e78esm1093729eec.16.2026.02.04.00.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 00:18:36 -0800 (PST) From: Sun Jian To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sun Jian Subject: [PATCH] wifi: nl80211: drop impossible negative band check Date: Wed, 4 Feb 2026 16:18:21 +0800 Message-ID: <20260204081821.730673-1-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" band is derived from nla_type() of a nested netlink attribute, which is a masked u16 value and therefore cannot be negative. Drop the dead "band < 0" checks and keep the upper bound validation. No functional change intended. Signed-off-by: Sun Jian --- net/wireless/nl80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 03efd45c007f..a92b4e24b28b 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5759,7 +5759,7 @@ static int nl80211_parse_tx_bitrate_mask(struct genl_= info *info, enum nl80211_band band =3D nla_type(tx_rates); int err; =20 - if (band < 0 || band >=3D NUM_NL80211_BANDS) + if (band >=3D NUM_NL80211_BANDS) return -EINVAL; sband =3D rdev->wiphy.bands[band]; if (sband =3D=3D NULL) @@ -10536,7 +10536,7 @@ static int nl80211_trigger_scan(struct sk_buff *skb= , struct genl_info *info) tmp) { enum nl80211_band band =3D nla_type(attr); =20 - if (band < 0 || band >=3D NUM_NL80211_BANDS) { + if (band >=3D NUM_NL80211_BANDS) { err =3D -EINVAL; goto out_free; } --=20 2.43.0