From nobody Mon Feb 9 06:05:26 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2AED37756E; Wed, 4 Feb 2026 06:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185556; cv=none; b=M90E8K+eYkoF22mwJiGEaVtmNLAYji0uBzb0bh2LPeqj3CxNKGfGvOp2gkxTkbQmNwUI6+vUc3yPGQFH2isEKp1gR++1N6EbAcAeGV6WTlyIYBi+LHdi+ggJxbmo7ouTveRzMXoENXb7ofA+xaFUe9F+TUq4bhd3qRWlWG1fwoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185556; c=relaxed/simple; bh=XUyFGFtrEh0ZPbD0xEb6CrJSYnsMbsd99La1OeAHhJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qMpi5OKjdG6stxBfOYG0sLKFtjHYFMWaYVM7EEoIRRgpZ9YfIyjMuOy4gXSCWau5sfhdaxgfgqlxRIX01I/OMpVf20nPemd0un6NQe2YITGIJurw8HIhBn/bP40BR4XcxEV/VVXOFTaX0yyM007V5FrnP1Or3JabfEv+ZlOb3MQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=pUMsv7zA; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="pUMsv7zA" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6144Je7o1083653; Wed, 4 Feb 2026 06:12:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=euvID rOsXWoZLuf1uBMrPX+1OIMIYYC+RyWR1dcS0lQ=; b=pUMsv7zAo/6MIxb8I00wW yaNy26VAcTtnwU1dMYtJvQq1l0onXmVZKc2UHlDzLPoeFc7AaOex9Q1Hzz9yNyJU r78iFu+LtyYTCyaB3w832Mebzvzu58Cxv/jRX69SsbQGpStcOM6zDUiqzsEr2DLc hc9b4+fNCWlWX9CYXFsQO6JaYprdGaJrlwGktIGqfEi6R44JucD739vDQDdKpdv9 J5WsqZbs1dnGgY9264tYblZRLKJjuGi13dLIWlkF1BLTUzY7FPOWEglxscftHCgs lTbjHNsaP9m7j+rCvHS/g0moE7VrK7OBwd1qnfJIqiZlGEuS77b3vgc2jViSy9ll g== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1arkwceu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:29 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 6144dbhL018660; Wed, 4 Feb 2026 06:12:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c186nhbqt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:27 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 6146CNNx032959; Wed, 4 Feb 2026 06:12:27 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c186nhbnd-2; Wed, 04 Feb 2026 06:12:27 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Gustavo Bastos , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v4 next 1/6] iio: sca3000: reuse device pointer for devm helpers Date: Tue, 3 Feb 2026 22:11:56 -0800 Message-ID: <20260204061219.791037-2-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> References: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602040043 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0NCBTYWx0ZWRfXwjj8G00VdX6j SP9n4uL+nSLENWNjzqhed+YYyL3NTTPOvZADKx3Je3Z142CgD4b7Ki9aie9vwSN1C5StK7zHGng MUrDtohkfOhQ6WMQEIvmLn1+XrzLxm9PozPDAQ1uaxN4rMyGhmut4XZDisiP20UtWSXjT830cVp CEa+Xv0YKR80XkIYJ86DPDZNfCPkANhQVSGfjeTZvsYsBo1ewf/akmTOHWQq33bTzkJUqhH0kfH CLqDY/jhTp2arQQLA1oUpCPbd5uma6UUH69C94SENN9nHhuIEjtBBCY2k/sDCoyGxfl84lvpR/J HfaJgg6GgfB5AdHWoCl/E0dp7vRsZT7NMiAg7qcKLAq1BhHlyqExcLHsp41vDNCXxsF+HGrKrR2 EfwRZoYNU5+UqkUeq2dw2CG9DzlZ/uh+mM9qwUpaPgbg2aG7dubhT8+xLzE2Wtc151PXOXqFp4G X4WRUUJ7Qo/sTJjYMzzWjuTkIB56E/V4gTBh+ZJY= X-Proofpoint-ORIG-GUID: 3dVI_zgCWhcCwk6bEAB8VBdRnmA_hXb0 X-Proofpoint-GUID: 3dVI_zgCWhcCwk6bEAB8VBdRnmA_hXb0 X-Authority-Analysis: v=2.4 cv=VfL6/Vp9 c=1 sm=1 tr=0 ts=6982e34d b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=7-6Z21dQ6CCI4-vYCE4A:9 cc=ntf awl=host:12103 Content-Type: text/plain; charset="utf-8" Cache struct device *dev and feed it to the devm helpers to simplify the probe function. While at it, also use reverse christmas tree order for local variables. No functional changes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- v3->v4: Add RB from Andy and use a single line for devm_iio_kfifo_buffer_setup() --- drivers/iio/accel/sca3000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 9ef4d6e27466..fa0ec2e1a1a2 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1439,11 +1439,12 @@ static const struct iio_info sca3000_info =3D { =20 static int sca3000_probe(struct spi_device *spi) { - int ret; + struct device *dev =3D &spi->dev; struct sca3000_state *st; struct iio_dev *indio_dev; + int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -1466,8 +1467,7 @@ static int sca3000_probe(struct spi_device *spi) } indio_dev->modes =3D INDIO_DIRECT_MODE; =20 - ret =3D devm_iio_kfifo_buffer_setup(&spi->dev, indio_dev, - &sca3000_ring_setup_ops); + ret =3D devm_iio_kfifo_buffer_setup(dev, indio_dev, &sca3000_ring_setup_o= ps); if (ret) return ret; =20 --=20 2.47.3 From nobody Mon Feb 9 06:05:26 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C93AB376BE3; Wed, 4 Feb 2026 06:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185561; cv=none; b=WDszUg8hEBOPxqEckyEbudoxvnOotZ7X3gNQIeFwHxEijebsUdDtmVQijcOtZFnViKYJ1EcGhmT+UyCKucXx0lx4JxydIIQvghX0vgJWjfGpz2m/Fdi3+5LCX9E5SttPBsmJXBCn/25rHnJDaOTp469+5Oa2FK9qryrk8Md86gY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185561; c=relaxed/simple; bh=CR0oJLcesHf+ekPfQKoEmjvBpeTCIJdT+0qND8yzT+U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n2/Qht8NPCCInhjkym++7ETtfPdAct3MJja2gdh2F3+kcpjg96PDuSJs0WZOEsKsDzdsEqgwCV4Ykstv/lyhNzaP8zlm6OEWFJNKE31XWhAmGUGxxl8ksCu9HRg275R9kT3u4CYgIogGIgmNd5Y+dXyDs1m6RMdA3oxAEzioVnU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=dim+ieWg; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="dim+ieWg" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613IuJFw4161563; Wed, 4 Feb 2026 06:12:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=F5Z+9 1Bci2/ZpqTg1N9jfVcTz/9YX15bdqKQge3EMvM=; b=dim+ieWgWGJmEfhzgXjRb i8psY+uQQt7wa/UbaLHH+Uu5fyzSecQZh3TOHc+UeYQeTQdfXPj23u/stZbo7LV5 CaZ9oEYCMvMNqWtvYH+A5KwyRYo38VHrr572HwEFXKQd0GRUuGpgIhnPtu7ScOUT 4wtRUQBOMLed83YpujSOBOE430CS29+DLzIOvZyhD48GfNn63qGzkMjdY/NQmJRG nwtaGMTo7PK+vgWIgfnE9RNSJmjtu1LTfJYGCxCjQsJglVc4OZG/YQeXzTvfYmtL q1eL0d45oXG1/dc24nCQJDyipSigDY39iZ7MAgHWD1kFDnE5qdskLRfo0T7Jzm9V A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3j8uh9tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:33 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 6144fHR3018663; Wed, 4 Feb 2026 06:12:32 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c186nhbs9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:32 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 6146CNO1032959; Wed, 4 Feb 2026 06:12:32 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c186nhbnd-3; Wed, 04 Feb 2026 06:12:31 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Gustavo Bastos , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v4 next 2/6] iio: sca3000: switch IRQ handling to devm helpers Date: Tue, 3 Feb 2026 22:11:57 -0800 Message-ID: <20260204061219.791037-3-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> References: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602040043 X-Proofpoint-GUID: 7sN2dkJoNvDm498wXgWVqs5HKqph9ud9 X-Proofpoint-ORIG-GUID: 7sN2dkJoNvDm498wXgWVqs5HKqph9ud9 X-Authority-Analysis: v=2.4 cv=BJS+bVQG c=1 sm=1 tr=0 ts=6982e352 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=IpJZQVW2AAAA:8 a=yPCof4ZbAAAA:8 a=S4wibIGCh28zlk_8eiUA:9 a=IawgGOuG5U0WyFbmm1f5:22 cc=ntf awl=host:12103 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0NCBTYWx0ZWRfXyNh3X+hZJJMO tMgFUx3jTRw4++cNWHS7b72rpkAqXRL43pcSidYnSTmrL8raG2HpLkKHwBqbThXhIkpHPSIdF0L J2NTaqALI/D+Uv4ShwKCVV4Y3uKLaEujT2ZsKeacO0Pd39170O1HH/5Oll6yWHF0nLHEoGWh/cR jwHV7CbXDXKJSqyr4cIJWFeLY38JGv32q7jlgEmyjqe35iJ2WHHrfjRyLr6XJ2UXeXl331Wybyl 2wlDYWHMjbE6a2JgfCAbFFkgTbm2UpJWs97XXrvxtdjIdeOvtoQnX8dO/L1jErzeEV1rmN7EwRu 1hWzQCqdQAnXpwqxV2WWk366E2SEk0LolMKdk+/RtqIV1Eox5oVic5fmg2fURLpGYHWX+qozfmL Nf1WTZxvpt3nzCwb1M3/FKrml8WyVl/CTsAyPOHgKMkmbcH31yw8k9uv0mvKJ0D/R5doM+mB9Os st/TYjUPmEWq1eQQrNJdCBR8ocDZepWLfb0NtTEo= Content-Type: text/plain; charset="utf-8" Convert the threaded IRQ registration to devm_request_threaded_irq() so that the probe and remove paths can drop manual freeing of irqs. No functionality change. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Reviewed-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- v3->v4: Corrected RB address from David and Added RB from Andy. --- drivers/iio/accel/sca3000.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index fa0ec2e1a1a2..4bad152009e8 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1472,34 +1472,27 @@ static int sca3000_probe(struct spi_device *spi) return ret; =20 if (spi->irq) { - ret =3D request_threaded_irq(spi->irq, - NULL, - &sca3000_event_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - "sca3000", - indio_dev); + ret =3D devm_request_threaded_irq(dev, spi->irq, NULL, + &sca3000_event_handler, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "sca3000", + indio_dev); if (ret) return ret; } ret =3D sca3000_clean_setup(st); if (ret) - goto error_free_irq; + return ret; =20 ret =3D sca3000_print_rev(indio_dev); if (ret) - goto error_free_irq; + return ret; =20 ret =3D iio_device_register(indio_dev); if (ret) - goto error_free_irq; + return ret; =20 return 0; - -error_free_irq: - if (spi->irq) - free_irq(spi->irq, indio_dev); - - return ret; } =20 static int sca3000_stop_all_interrupts(struct sca3000_state *st) @@ -1529,8 +1522,6 @@ static void sca3000_remove(struct spi_device *spi) =20 /* Must ensure no interrupts can be generated after this! */ sca3000_stop_all_interrupts(st); - if (spi->irq) - free_irq(spi->irq, indio_dev); } =20 static const struct spi_device_id sca3000_id[] =3D { --=20 2.47.3 From nobody Mon Feb 9 06:05:26 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDACC374758; Wed, 4 Feb 2026 06:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185566; cv=none; b=eB1jymIqRWaUP2+CBeUyA/pTcO9brRQO+8LYecgPrTR1ih2HtJiCXDQwtG8wdyHmHsT5Pk77UPMbcuT8DwYPKagr/hMkjhKKpKJ8BdR8H/6IOUBotdygWgSrpDuLvNUTqExMjYlWDZjlFD8HNkZdX2gchi36R59jyTIdzG3dmVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185566; c=relaxed/simple; bh=AqSH0mAODuY+6aFj03LoC11FUPB04+XbTWG0dRzkTfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zzm99vvSoKFgzXSk/9ca0JzO2pmnt904Rs3jPGBAXWpaHal95QRq3PhQ78l4BI11WU3CuuE94+VF6tsa8/Jt1ebQ14kF+Y+6TuoDyBRceYUT8b9wCnZHVrYAJHtzgKpMzcFDnsP15QCBubyEGODJu16OczR7wy3teH8ZSTGGGhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=FMCh2EoU; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="FMCh2EoU" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613IuFeX318462; Wed, 4 Feb 2026 06:12:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=d1bQA LcdeCKZ50/FgwT8Y1MUiiGiMEmxFdOShjQk0dg=; b=FMCh2EoUM9ATF+1Dod1HO e6XRS8u9TaNNizRqosaVXit3HMj0Z29YiOVaH/wKL7UffMnYI4iY9INNV/no0Pcs 34EauJdy+bip8RhDbh/+tIuu+h3H3A2jtH/ABRkuaLskA6Q1HvO444Bhy/ImLGxR Tjw7PPtWAgn5DIfu+u2luXqnTdIZqLwr5GxEpucBIDDyNt+Kzbwehqpi7LdQGOAK 9MpbZjfH1h+LPjgSc+ajbhDVgmsdhACIGpFVlYUtfg9hOCorY96NdUxDpLT97Lug mFoONQgHMTEsFdo9jnk6vXFV6yHKx9aq5qV2KkWUuUU1be8ilghNtJSTytpsXUpi Q== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3k7uh52s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:38 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 6144pRMe018920; Wed, 4 Feb 2026 06:12:37 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c186nhbtp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:37 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 6146CNO3032959; Wed, 4 Feb 2026 06:12:36 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c186nhbnd-4; Wed, 04 Feb 2026 06:12:36 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v4 next 3/6] iio: sca3000: make stop_all_interrupts() return void Date: Tue, 3 Feb 2026 22:11:58 -0800 Message-ID: <20260204061219.791037-4-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> References: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602040043 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0NCBTYWx0ZWRfXwhdv3Ym7ild4 gKIry2xAEtb/hOxt/w/0bER42OEUznXRbdUVZJBaSS8u6xUmvDHqe38VYsPmiDzZ1ju1bYtg9M5 12LaH8FmkNAcKlnbm+a1/dgjKEbYPrIbACotX7IIby2ECaKqa4FZlzhMuzarwP/hOGfJXuUY/Bx kTXC6H+S93QoKFZ2EPvorn9wUK78vqk+0dCtW3rdugy8oDHONenq/o/XWKlVFz1/e709SChIrp1 04ljv9C/G8MqK7S5eWGhjgoe0KExQpccx1fLSRjuVAvkOeDFNIpqgGU95yrXvGo8orS28VGzYXw IMzyJn/dFGtexQ5Fi9Z6eYT8hhPlAra3CMpMno8v2Xhvany2ezQEcrdF95Y2G4zo6ourY3zVeLY lH8Tr/BCffE0ra9u1M36H2dMbetQQsLRC09Q3a+Hrb0wE13L3kBT/yeIjOYzp7XiyZjD8E6Jnmb OmxvOH3xmhRK+droeIUxpO6g2Xtxq2Vs+34l5Fbw= X-Proofpoint-GUID: hvADGnkdYKsW3MWfw9Kt3-fl839P5YXj X-Authority-Analysis: v=2.4 cv=Z7Dh3XRA c=1 sm=1 tr=0 ts=6982e356 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=_1GDA9l6zoHD2SEvZEwA:9 cc=ntf awl=host:12103 X-Proofpoint-ORIG-GUID: hvADGnkdYKsW3MWfw9Kt3-fl839P5YXj Content-Type: text/plain; charset="utf-8" sca3000_stop_all_interrupts() is called only from the driver remove path and its return value is discarded, so convert the helper to return void. No functional change. Signed-off-by: Harshit Mogalapalli --- drivers/iio/accel/sca3000.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 4bad152009e8..f9680071bbbe 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1495,22 +1495,21 @@ static int sca3000_probe(struct spi_device *spi) return 0; } =20 -static int sca3000_stop_all_interrupts(struct sca3000_state *st) +static void sca3000_stop_all_interrupts(struct sca3000_state *st) { int ret; =20 mutex_lock(&st->lock); ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto error_ret; - ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); -error_ret: + goto out_unlock; + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); +out_unlock: mutex_unlock(&st->lock); - return ret; } =20 static void sca3000_remove(struct spi_device *spi) --=20 2.47.3 From nobody Mon Feb 9 06:05:26 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6DF4376BE5; Wed, 4 Feb 2026 06:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185570; cv=none; b=RIfOatq4jHaW///RUPCUBw+xnvvGoOaAk8jMgAVTn1pVC/i0+TZsuQ4UKrASMvLEohHszpgG2+EKaZjEMhrFcvdB01vgoUkG9ivS+RiYnyfMXuOxoVS3/BH0J2covprAHrgC68Ep40R+azyY8D1mQeuwPK/HaHbZsmsvYz6XUX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185570; c=relaxed/simple; bh=4dV2WIY5YiwMvUwagQxea2LCppnTFc3jiBx2ATL1yPw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=irujo7zE/LdQKzpCRTDOIy6SJcqg9zsKn0HDzvJA4qUUgGY5Ujnn8GBkt8akswmK78mrOk5pUM1LW7AjVdn8led+wsFGsfb6/kMHmXFSnpVUZXVvht9oHyVC3S78eobRC5WWZYnQnStxOHKmy6b00ySj/V7qfqD4+MMiwCweUr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=AqQotHLu; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="AqQotHLu" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613IuFeY318462; Wed, 4 Feb 2026 06:12:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=Dbl2o NlT3HUVq+EJAxkKT3f7M6JchCPfJxV3yM+Ena8=; b=AqQotHLuQrT3eWp1o09z9 MKAQYdB5JpfvnAQxqicNZJLRDEHIOP+Lj0ywW8NfcgagKUHyt9E8bV9RC50EZAZo mHZsj0FxF6y03N03VfaFchYsuRKq1RPhJT+/83z2Y+rUr4i+IfGKsVw6neQ/AiFE Q2hr7vKk82QBLscfdBit8ao39ePUnDS54S1vkDG7Skc4Bai7OnpR4TIJEVWhW69X 8UAL2L6zUipl1KL3hHtYwk9w14Zpw30U/bTc+LgS7MCU6Sqfz5/WqdtuXRjvs0zM VEISSHKWU7YwOPX7tCBa/OvXALqVmKBtHzuw4lkHR1gtPoaEWiVBIQ3ar3yhWqxw Q== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3k7uh52w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:43 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 6143pthS018782; Wed, 4 Feb 2026 06:12:42 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c186nhbuu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:42 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 6146CNO5032959; Wed, 4 Feb 2026 06:12:41 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c186nhbnd-5; Wed, 04 Feb 2026 06:12:41 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Gustavo Bastos , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v4 next 4/6] iio: sca3000: use guard(mutex) to simplify return paths Date: Tue, 3 Feb 2026 22:11:59 -0800 Message-ID: <20260204061219.791037-5-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> References: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602040043 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0NCBTYWx0ZWRfX+u45InY8Jial g3xDeu9GMgvFLwHOOf9ikecnguBPN3MmtzqdGShBdGKPf83k1GmwfHF7HbmFsT/jJ+Ewup3fqD/ 4jwe5uPLLKf92gnXXwinLML9/y+xEnep3l2gQu38sYeGHMbppYJNycGo7lmQT1USHnRcebzhw/s doD3sndMmyFkizXZKpFXGWKxPerJfMx+J3tdB4ne8cDc+aXRdhvynSHx7rcHDn+eowL+Awp501U P6TSk4HXpGyELt9kwP9UeCKm2nTkaS14mYv9y6Mm+/6NyflF74rZBL+bD/7MR9VJoCH/ODPT12x g9aJIJ3iaIsSuNG8dL59P1m/KhhNXDq52pGvziRbGT3DkAPcrLDtB7MEtnfp7mYARfIyqO7t7vv ozsvKkZlxQ8PR+0UhX8kCsrSKpcIl5b9UOKUhs/uR0aXIo3fCQUzmCEFDpUn+2Y56dtmeh+C8YM I5kbjrSxuN83FIYN4u9si/WHUIc//Zy43knYyrpw= X-Proofpoint-GUID: C0X1R9qq30wDLL8dYpqI6XW_8OCsgcS- X-Authority-Analysis: v=2.4 cv=Z7Dh3XRA c=1 sm=1 tr=0 ts=6982e35b b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=Fb_YtQGqNHn76Ybc1w8A:9 cc=ntf awl=host:12103 X-Proofpoint-ORIG-GUID: C0X1R9qq30wDLL8dYpqI6XW_8OCsgcS- Content-Type: text/plain; charset="utf-8" Switch sca3000_stop_all_interrupts() to use guard(mutex) to simplify the error paths without needing a goto. Suggested-by: Jonathan Cameron Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- V3->V4: Move this patch earlier this simplifies a fucntion involved in the movement.[Thanks to Andy for the suggestion] --- drivers/iio/accel/sca3000.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index f9680071bbbe..a46990453ed0 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -7,6 +7,7 @@ * See industrialio/accels/sca3000.h for comments. */ =20 +#include #include #include #include @@ -1499,17 +1500,17 @@ static void sca3000_stop_all_interrupts(struct sca3= 000_state *st) { int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); if (ret) - goto out_unlock; + return; + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, (st->rx[0] & ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | SCA3000_REG_INT_MASK_RING_HALF | SCA3000_REG_INT_MASK_ALL_INTS))); -out_unlock: - mutex_unlock(&st->lock); } =20 static void sca3000_remove(struct spi_device *spi) --=20 2.47.3 From nobody Mon Feb 9 06:05:26 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EC9374758; Wed, 4 Feb 2026 06:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185575; cv=none; b=HEZ3qcyj4np1Cv5MR/rE4JN3KtW7QMGzcNJZLo9IG6RYWx2Mts944YwWqNBqz65KJ61uc4HBGfqQkbZWeKWzxBkErFwMQHokPGjW4ROmshXjUALiq03xevW0WDeiYkH/YpCFSkPivQfGzfWf1MmYwRsEyvv9W5nMj5y9TrJuW50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185575; c=relaxed/simple; bh=ZVyJxfc0bE2I9F2HJClUSo2hS6qDRGgaRQJpfxrttXM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FtnODvm4XU4yMFsUTTASABpLNm4Q+Y46cZkXEwQ2Mb26YxpjJ1c5CNs75l8VS0w0HG2kDz19oenhsaBrAE17Br4mvxqxd+dHlNn8gV7jJGeqODlB0wWtKX9XSc7TT6owHpmIT3c8M7361eYQpza9xLNTvMOFyadq1K7Bjxrqgmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=CciuPlZu; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CciuPlZu" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613IuGn84161162; Wed, 4 Feb 2026 06:12:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=Idpik wJ0rTCbj9DitdH2cLfftrSNru4S3cXLfBwSaj4=; b=CciuPlZuEE0Tpvjh0h1fA yK7cIajfCn6sZ6uPZlBSmTQZ6mSsRO3nue32C+3dSTdWcpisY0Dscf6Z/fb8OTuH VrHdy7WXPDaHUcBCcTTrJ66xO0wXjXUa14YFv+Jn1u+7as1K688tU9t1cGFXKNp6 zikH9vWR7Itlrbc0PG3f6nEX17WrPbhEyuNBEUsmAw3Hqx36x8AUb02qfLt4CxE2 wOZWTaKDhj2DORJjd+yQx7/IEkE2gH/6Jlo3qkn26qT8wzibWtR7dkmk1+Yqgzjm wFHJkivSx6sd5YJdB7v/azvdW89dZ7JfBfooJXycmF74qCQ83AxKi2PuY32ZWB1p g== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3j8uh9tu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:48 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 614666j3018820; Wed, 4 Feb 2026 06:12:47 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c186nhbwh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:47 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 6146CNO7032959; Wed, 4 Feb 2026 06:12:46 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c186nhbnd-6; Wed, 04 Feb 2026 06:12:46 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v4 next 5/6] iio: sca3000: stop interrupts via devm_add_action_or_reset() Date: Tue, 3 Feb 2026 22:12:00 -0800 Message-ID: <20260204061219.791037-6-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> References: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602040043 X-Proofpoint-GUID: NGMRdnLUtaQIQTClHWtzzhXEWFXiqNXN X-Proofpoint-ORIG-GUID: NGMRdnLUtaQIQTClHWtzzhXEWFXiqNXN X-Authority-Analysis: v=2.4 cv=BJS+bVQG c=1 sm=1 tr=0 ts=6982e360 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=IpJZQVW2AAAA:8 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=9yJhIapc68VNqS8YdaUA:9 a=IawgGOuG5U0WyFbmm1f5:22 cc=ntf awl=host:12103 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0NCBTYWx0ZWRfX4vn6spIbxJVl ymM/LtQwW9yr9dH8VwK0ufxYE3+wgAaHq5CrE9nPXYFwrw4xgBX90hOWm8OFmibVtTzKEf+ETF3 PCXHi2nIkoZAV1olHaJv9NWghZPB2G9cxP+S9yaEO2zehyiYt6aCiuEE/CcimRF7QMwG0qbmCtM kL9Gp4PTMCYyckUGLcx/ADqKZLfF90xqDEOAErSNOAdscR8oUu25HYYP4NydHq1X5wGlIkywU7X TkVyPkH/D9yuOuHJmduk9BKGZ4PO+yNReQimyfe8No3I4wnTAgpgifldpGEAHs3Vt9HGbWWANZT FpEoN2TNgC5BTTkxABYc3mo3YjkJLk1ijJMslDQOMPk50hHNOehyAdKb5gpjqVZThrojw8DwPXC oeKvZPjTbtnyvnSPRU5QmFfIeY3nAV7RQwCDBzISFlTSWyW3LcvulpfD/J642bfarq0BMtACNh/ gWV/XU0CU1XJqeZN55ELo4OO4/2M1kdBlUyDCl5w= Content-Type: text/plain; charset="utf-8" sca3000_stop_all_interrupts() is moved above the probe routine so the new function sca3000_disable_interrupts() used in probe can directly call it without additional declaration. Used devm_add_action_or_reset() for shutting down the interrupts. Make sca3000_stop_all_interrupts() return void now that it always hooks into devm cleanup. No functional change intended. Suggested-by: David Lechner Suggested-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- v3->v4: had to rebase becuase guard change is now moved earlier [Thanks to Andy for the suggestion] --- drivers/iio/accel/sca3000.c | 45 ++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index a46990453ed0..c3a8f34d4852 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1438,6 +1438,25 @@ static const struct iio_info sca3000_info =3D { .write_event_config =3D &sca3000_write_event_config, }; =20 +static void sca3000_stop_all_interrupts(void *data) +{ + struct iio_dev *indio_dev =3D data; + struct sca3000_state *st =3D iio_priv(indio_dev); + int ret; + + guard(mutex)(&st->lock); + + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); + if (ret) + return; + + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); +} + static int sca3000_probe(struct spi_device *spi) { struct device *dev =3D &spi->dev; @@ -1489,39 +1508,23 @@ static int sca3000_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D iio_device_register(indio_dev); + ret =3D devm_add_action_or_reset(dev, sca3000_stop_all_interrupts, + indio_dev); if (ret) return ret; =20 - return 0; -} - -static void sca3000_stop_all_interrupts(struct sca3000_state *st) -{ - int ret; - - guard(mutex)(&st->lock); - - ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); + ret =3D iio_device_register(indio_dev); if (ret) - return; + return ret; =20 - sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); + return 0; } =20 static void sca3000_remove(struct spi_device *spi) { struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - struct sca3000_state *st =3D iio_priv(indio_dev); =20 iio_device_unregister(indio_dev); - - /* Must ensure no interrupts can be generated after this! */ - sca3000_stop_all_interrupts(st); } =20 static const struct spi_device_id sca3000_id[] =3D { --=20 2.47.3 From nobody Mon Feb 9 06:05:26 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9D51CAA78; Wed, 4 Feb 2026 06:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185582; cv=none; b=H+nC9RUHP4RI2wFE/NTuQR1Nk9En+F+tOCejFPWd6iFadvxiebGPsfWctTVu49sgL8R/RpnmgN2BthgosNM/9To9ui043T71lhBsJbA6Yz3S0X8B01ZK3EiuUGAEZLrRJNzauqzpXn+9hMgOmHabJnBN376K4ruOEx19XxeBfIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185582; c=relaxed/simple; bh=1rCySF32yDiebvTRRRU+TWuGqgFpFzCm3OAvgYwodeM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ozg6BlL/994fd+Z6w/sRNx2Pw8aICk3DACm/qzRDO160fkjEcM8iyiTQPWcRzxWR8I/8uVedEECATEU9js6GtFqDQKqlFeICEWqWui2PqkGENELtARzqoz49MDe4LY/mjJBm8vZx9wqdX6fea8nTxUweMkGLmiFfrWRfy/wA/ZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=MBGDH/2d; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="MBGDH/2d" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613IuHvi4087925; Wed, 4 Feb 2026 06:12:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=ohcuo hxaQohL2AO2lfvb1PAi80c/48HAgDp5ft5wi88=; b=MBGDH/2dJtCUJHf4nWfr2 luKjfScqkHVt1fAmLQJvxyr1b+ZEo7aQde3apppNBURHKurjiCOlz6zVKRXacV/C hGHDHkNBYC50s00cidPEnJTHbEmO6jczsi4oRIltHLvXL/R9XyHIXYviC11RyYRL AcOguMETvEgZfT3F1y71na4gF/K8N/4yg9fJqRPtCzhuFT18L6qeE3Ddxv5gB+0v VjeJGm84iC1Yt2PdGg3GV+HmMJ3YdqKZYm16+fA3cJqoLe+VasEHEVeb+ruKTi7n dbn9OkcLkFwRz9EPhdWy3FbKLYUfF1rUdOT9T3cHme0dr5WeKC/abZgdb+YLzJSo A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c3jhb18m4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:55 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 6145n4PS018919; Wed, 4 Feb 2026 06:12:54 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c186nhbyb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Feb 2026 06:12:54 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 6146CNO9032959; Wed, 4 Feb 2026 06:12:53 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c186nhbnd-7; Wed, 04 Feb 2026 06:12:53 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Gustavo Bastos , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v4 next 6/6] iio: sca3000: manage device registration with devm helper Date: Tue, 3 Feb 2026 22:12:01 -0800 Message-ID: <20260204061219.791037-7-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> References: <20260204061219.791037-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602040043 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0NCBTYWx0ZWRfX+2mUC8Wkxu+W XnzIzE+00bS8k8Wxats549yYEEhC5QF/fAvdJPIxDjEdcWFXxFgqmOBvtP8S3Lvn9khFUePb2pD y2XUQq61byzmHQ4KeGXne+SkTKI8wq4CWPtPAU5J4iXyAiJ07NJt13PqrCK3xLvzQpxBNxr20/+ KEwQf/NPf7/aWaO7tfhsxCoG7ge5ClzCa76eg7nIo9QVzvVdxBWb9XdJgdC2IB4EdlwvHICFn5S kN+3fU1cw9PNwTnAenzN+rpYKeQpAWC01NBsp9zF44A7UNMmNaBW7Fhz6rOn1OFWWg4qrdflGk5 Dpo9GaHX1IwwhWVyFGKIJdQlFE2HntxTtrQvPFHzVlaGhryiWjQMDIl4aRNiaiNLDJx0BwqHQbb 0dH+2pXwKu8WbqpZ3ofpL4T/nrU0Ul5gELHTod4wHBHigR4qKnt2+JjZCKrYtStqBAMYrZyaHdz TyZALKmAmUhLT+dhtKLVW2/IhjIELW5lfh+OnpO0= X-Proofpoint-ORIG-GUID: X-bfEOADUP5GS6wV6mdX-b9RfXA8VDEo X-Proofpoint-GUID: X-bfEOADUP5GS6wV6mdX-b9RfXA8VDEo X-Authority-Analysis: v=2.4 cv=CaYFJbrl c=1 sm=1 tr=0 ts=6982e367 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=IpJZQVW2AAAA:8 a=yPCof4ZbAAAA:8 a=TX5tIiqRz0IEpTnFED8A:9 a=IawgGOuG5U0WyFbmm1f5:22 cc=ntf awl=host:12103 Content-Type: text/plain; charset="utf-8" Convert the iio registration to use devm_* helpers so the probe no longer needs a separate cleanup path and remove callback can also drop the unregister. After this there is no need for having a remove callback, so remote it. No functional change intended. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- drivers/iio/accel/sca3000.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index c3a8f34d4852..88900b9d5ee1 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1513,18 +1513,7 @@ static int sca3000_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D iio_device_register(indio_dev); - if (ret) - return ret; - - return 0; -} - -static void sca3000_remove(struct spi_device *spi) -{ - struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - - iio_device_unregister(indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id sca3000_id[] =3D { @@ -1541,7 +1530,6 @@ static struct spi_driver sca3000_driver =3D { .name =3D "sca3000", }, .probe =3D sca3000_probe, - .remove =3D sca3000_remove, .id_table =3D sca3000_id, }; module_spi_driver(sca3000_driver); --=20 2.47.3