From nobody Sat Feb 7 19:41:38 2026 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C0A27F005 for ; Wed, 4 Feb 2026 04:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770179901; cv=none; b=r30mj0+5ZD5MpbAUo9GrPRdjNY/A6I8M/69w7i21zDdz4yl/vDdcnsSOPwIyx8NcmVdQqAsPS5y7mgQT1/2hxYHj4L7DMCxPyl4vNn20cpuY7kjxqblCDykKrS9Dfw7WOcJBsVzgsFb1gXM2wewX9Hx8Yhs1Amu5slzlG+01Wrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770179901; c=relaxed/simple; bh=IdC2P4k6AyJqhGp3rnM+Q37EVEjqtthBYoW7YhLNPog=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FXNy+nN4Ejy9LBJg6MFqIISW0AK3G1y92C9S6u8K1xWPOpONWjBT2lqTTJS2WeCaNEcYBsPU4WlXXLJ9Ce4EXSSkk3pByFECL1IzBdTN7PTN7szjUVzNGkl0tI2LqfN7cAzRU6ZAYKH0wp4bwKTZkgbA4GbOq1cM/dELNdSwWYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=msSZLx47; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="msSZLx47" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8ca3807494eso3173585a.2 for ; Tue, 03 Feb 2026 20:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770179897; x=1770784697; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bGCt1oGCWGLX++wb2sUIXR3s0HE/K4T4ZaU5gwWu3Ys=; b=msSZLx47sIepa/7gQpMzQJMp8O/kzz8o3vZwNDTwVXYaGBf6rdAq3L+YRnOkxAUl6P EhRQqC4Iw9zR5mRFufUdVGBqfQWqBlPhAa/CsTlSSwd2ht5CKAJjHTEX6/kvDG0/3V1I nr6VmhAV+lScFltykvlYVkrAM+0o5kLysTg2HXX7d8xHRtwI1A3GhPoMnEkh/ecznt3f 3jCLy2BLQybBVRZu8JIGRK7+AxWnA4xMVmSqV4ptj+90sqAerCpo5fZGnQmR2GsNDgCf PQWikVq26ACjYcATYC/Un/IkeaIRnPiQf8FKD+oufCEeqWz7qNdROsj1M0KC0sFW9hk4 NCsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770179897; x=1770784697; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bGCt1oGCWGLX++wb2sUIXR3s0HE/K4T4ZaU5gwWu3Ys=; b=VJErdmxBKX98LXSSAcYt8+2VnIN7+eFnGiTnANwF2814P6c00NTZScuPffXr3qOZ3i r4EOhfkYLAPFdU9Ko8nEY+1Zw7m5//odnXJ+H831CDFF6pGdNFAmIdlhP6XJDHGzxGPI 102PR291FfPw230s/JbFM3DIa1GhzsI3teW/oVhymJWLSupJQEa15Dw3sn51lOIaE8Dh FC3QVcRyo4dYxj8VUnJEQcOubYSVYSRPq9kVWmrY7Pp3/c1Lzhx6TRLr4wmYKUQrhuvu PQYBmI7kLdYqCqYmzxAKf5KnrgEuwTDIs0uPcBMK4TglJDlm2DNMTOafj3S8QKDgvgFx HjIg== X-Forwarded-Encrypted: i=1; AJvYcCVO5elRiTB+JwGNr1eSpu6UI2SIQD2R4FTR5kUVuwE1Kg07Uv0WyR7nSJdEoAVn83iuVRk4GvmXRDDvKCo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq5GkK4lImG+mlqiMHHV97/46In0kragqXlh/abiiQ1SVPvGlS bM5CCLU+VhTm0vG3ngPNg5gwwINMTOdmXyUFg4z879pyM0Limmk8SOr9 X-Gm-Gg: AZuq6aJrikjX27bUsGjYZc1S3+w4kK4pr8RHxW44njdXsKZrJ4PE9g87iSy8CR6PYZB UDZWEDHAMdIH7oN5Hsc6rG56bu1kgrsxgGLNkPB4JmnMs/QAtvpPS+x0YR//g+rUfcRcW+cMxuU 6ckbwjyAkH0uok+oxqIt0sjvl3LJhCGMINAm8dr4oCDbJXvehDRvQxCWc4tAXHcM6CRJYccsY4p LoN/7QQmu5OtJUnfjVJSrxV0/3ZzgqrTgH59owSOg77gWEOhADM0qYFTzUMQcmEgBQ4qou5wJqc cXz10u1gInCDvoO58xmZ1Q5q/ILBtxAy2C/Jy174PV6jmfCz/F3Lahxr8mKH64WLMwr55Ze0e/M IB6anp78xV4kWmdK03p8gtle0v4I52FwGCnMFzQ0wrNR+x+xZA0qcjX3RaGNxYHDk2qIOggI++B AfMwKgU07gKiapoA== X-Received: by 2002:a05:620a:1728:b0:8b2:e51d:610d with SMTP id af79cd13be357-8ca2f84c6a1mr227680685a.32.1770179897451; Tue, 03 Feb 2026 20:38:17 -0800 (PST) Received: from Mac.home ([76.64.58.244]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ca2fa81908sm110036485a.19.2026.02.03.20.38.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 20:38:17 -0800 (PST) From: Neel Bullywon To: David Lin Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Neel Bullywon Subject: [PATCH] staging: greybus: uart: migrated from IDR to XArray API Date: Tue, 3 Feb 2026 23:38:02 -0500 Message-ID: <20260204043802.65430-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replaced the IDR API with the XArray API for managing TTY minor numbers. This addresses the checkpatch warning about DEFINE_IDR being deprecated. Following changes include: - Replaced DEFINE_IDR with DEFINE_XARRAY_ALLOC - Replace idr_find with xa_load - Replace idr_alloc with xa_alloc - Replace idr_remove with xa_erase - Replace idr_destroy with xa_destroy - Updated the include to use xarray No core functional changes, just modernized the code to a new API. Signed-off-by: Neel Bullywon --- drivers/staging/greybus/uart.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 5cece0a6606f..8bd6bf0a57a8 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include #include #include @@ -67,7 +67,7 @@ struct gb_tty { }; =20 static struct tty_driver *gb_tty_driver; -static DEFINE_IDR(tty_minors); +static DEFINE_XARRAY_ALLOC(tty_minors); static DEFINE_MUTEX(table_lock); =20 static int gb_uart_receive_data_handler(struct gb_operation *op) @@ -342,7 +342,7 @@ static struct gb_tty *get_gb_by_minor(unsigned int mino= r) struct gb_tty *gb_tty; =20 mutex_lock(&table_lock); - gb_tty =3D idr_find(&tty_minors, minor); + gb_tty =3D xa_load(&tty_minors, minor); if (gb_tty) { mutex_lock(&gb_tty->mutex); if (gb_tty->disconnected) { @@ -362,7 +362,7 @@ static int alloc_minor(struct gb_tty *gb_tty) int minor; =20 mutex_lock(&table_lock); - minor =3D idr_alloc(&tty_minors, gb_tty, 0, GB_NUM_MINORS, GFP_KERNEL); + minor =3D xa_alloc(&tty_minors, &minor, gb_tty, XA_LIMIT(0, GB_NUM_MINORS= - 1), GFP_KERNEL); mutex_unlock(&table_lock); if (minor >=3D 0) gb_tty->minor =3D minor; @@ -375,7 +375,7 @@ static void release_minor(struct gb_tty *gb_tty) =20 gb_tty->minor =3D 0; /* Maybe should use an invalid value instead */ mutex_lock(&table_lock); - idr_remove(&tty_minors, minor); + xa_erase(&tty_minors, minor); mutex_unlock(&table_lock); } =20 @@ -984,7 +984,7 @@ static void gb_tty_exit(void) { tty_unregister_driver(gb_tty_driver); tty_driver_kref_put(gb_tty_driver); - idr_destroy(&tty_minors); + xa_destroy(&tty_minors); } =20 static const struct gbphy_device_id gb_uart_id_table[] =3D { --=20 2.44.0