From nobody Sun Feb 8 01:32:58 2026 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0EDC2165EA for ; Wed, 4 Feb 2026 02:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770171182; cv=none; b=TkcEKnGgZkQ+mWrShqJi2DjtMSX063IoUM8ZrQTS1fTadFL0Nu7OKBxN4imiYeiI0tdjzzZSR1/leOzpTspeM1SDI5pnLdn7HJLMe0m8PJ9lWqEDODU7X6cwAdlFOw9j+Rzb+ggiJNyKdxZCPtRPwP1esRt29aVdSoQylmvU2pg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770171182; c=relaxed/simple; bh=oKNM+REI2hJr36BrtfD7xQkxrbh+hxTcT/mf9b+Xtuo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HwYlTNs7vrOifaMnnlQeSub390PJbz5RMyQEE1jlohcv/PPXAOxjfagR4Q52qFGHPlcLFV+QMFCIRQEjoxcNCT8Yt51dY9q4xfqooAtkLuhg4LlRLzNydSSwYOD9Oc3zXzssIYCr4S/PJFh7UawtircGr5tKOcWTejXCjesKtp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kaLHd+HS; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kaLHd+HS" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-89503a3bb83so27135326d6.1 for ; Tue, 03 Feb 2026 18:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770171180; x=1770775980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gz9Ddn+Ui2x0v3tU53PwxQ/IEt9Xt+KCvMbitscFCiI=; b=kaLHd+HSYsGjMQDqh5NZ8hFRp9EQUtlxKz5XLZNCno8To5i8l82u93YQnOEtum7OY6 OE5o/B22vDfdJN4wnad1PAqyh7GEpCw4PRXt/PZS/I8pGXZQZAZWsxbScv12x70TXz1k /rCS263tt2Cayw9inNqz5KRxYFnyYr/2xD9mFpuAmFrP1SOoDL+NE+e5EK8soNQ8bSW0 +eDWYqghNk8YQqmBRiw58hIl4c9Di9ldiKt0DU139C2/WF/L9QR6BAoX4rkFWS3C40Wa ss4i1UCBOtLZxpRxGGsWcPL01AO1+FOfp/BS2vqeAtCGylWZYiuWTdBwzD1fbhrRHL0V yuTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770171180; x=1770775980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gz9Ddn+Ui2x0v3tU53PwxQ/IEt9Xt+KCvMbitscFCiI=; b=im63Ny4bwNAiHA8JTYiPUlkjYtzrjDD+eqBZLwmExYjzwaXQXG6NElyl1YL8fa1mSI kAlf4mCJevxWf126scVWtzguJlaPmzgXEtBKjrj1JO6O9PIVR5FQYceddWObniQWvxIW OLoapYy8ySsUEwG5q692RjhfO0ht0cYaXbVTemlEQqCzMIVPRmWnyM9OrRSJUiDd2Tuh Hb0zjCdGAjAa2MCuGq54Bj2Lu9gd938sES6nHpHZc+Xo1BbFCblAcrqU9MwwPiVhXlGN LwjIMHzkZhWxGW3thdXv5uuyhIgsJYwlCtOuTPOmFJiLhcbea6VAq4Lgi1tNLMb3AGbO lkrA== X-Forwarded-Encrypted: i=1; AJvYcCXAR7ZV5JnuLmhFRfbX/niv4liyOcxrkphXE/N8CoMRnGr61WKug2fqueJ2Leha0g2L0CD0CiCTdfmQUfw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo3R+mguGmiWasY8x9EPWkRlOlMMa8GGci7HAEaX7z2iIWpJNL BlLHSd9lqdpES5F8TF0eqwomefoQqZ049B8O4dAFuQf5mG+5QZjx/0+B X-Gm-Gg: AZuq6aLX33+87NYJWqn3Mi2pBLtUzEYYXKGy2qhwK7EZ+Xt1/e0ATtVHjE1JDoPTcV8 WQEQ1jfCxMOvq9Bl6tlApNdUoR03bbhX9o9nNdPwSJ3Uz9f09l47WQPsmOjE8aCijSNfG2r+CY3 ygxP0GsI5Yb2Pdtet47KqmJ85B0LqTb94LQcL3RIMnzxeEacPgFJ1cS1VUig1QMc7aqSYnEfLoY oPPqgV/Yh3tR0SlrRHdeTKq4Bcz0DIstSgLebWQXs4pYcewc7XweD7LRr7I216zRyLTCjYDI3YW QERWmlBcfyilmYQXo0JfaT8lr2Yv59cOVznqZY2nPwQLPiXJyEVCSe1s6XV7H8YbJL3D1DN/tN3 h1oaeyCzvschKJXFGYZcRzKxotL03PdLD7sBd6CQX/qQN83vUnciVQxy1wK3is+KPgxvLXll9kB mnJvKobZcOGEpq4Q== X-Received: by 2002:a05:6214:483:b0:894:2e1c:3a7 with SMTP id 6a1803df08f44-895221b104bmr23637516d6.31.1770171179564; Tue, 03 Feb 2026 18:12:59 -0800 (PST) Received: from Mac.home ([76.64.58.244]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89521d255bfsm9333446d6.46.2026.02.03.18.12.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 18:12:59 -0800 (PST) From: Neel Bullywon To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Neel Bullywon , Andy Shevchenko Subject: [PATCH v3] iio: magnetometer: bmc150_magn: Used guard() for mutex protection Date: Tue, 3 Feb 2026 21:12:41 -0500 Message-ID: <20260204021241.53891-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260204010529.48000-1-neelb2403@gmail.com> References: <20260204010529.48000-1-neelb2403@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replaced the manual mutex lock/unlock calls using guard() to simplify the error handling and reduce goto statement usage. By using RAII-style cleanup, it ensures the mutex is always released when exiting the function, regardless of the return path taken. Signed-off-by: Neel Bullywon Reviewed-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/iio/magnetometer/bmc150_magn.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetome= ter/bmc150_magn.c index 6a73f6e2f1f0..bd2706c2078d 100644 --- a/drivers/iio/magnetometer/bmc150_magn.c +++ b/drivers/iio/magnetometer/bmc150_magn.c @@ -794,32 +794,25 @@ static int bmc150_magn_data_rdy_trigger_set_state(str= uct iio_trigger *trig, { struct iio_dev *indio_dev =3D iio_trigger_get_drvdata(trig); struct bmc150_magn_data *data =3D iio_priv(indio_dev); - int ret =3D 0; + int ret; + + guard(mutex)(&data->mutex); =20 - mutex_lock(&data->mutex); if (state =3D=3D data->dready_trigger_on) - goto err_unlock; + return 0; =20 ret =3D regmap_update_bits(data->regmap, BMC150_MAGN_REG_INT_DRDY, BMC150_MAGN_MASK_DRDY_EN, state << BMC150_MAGN_SHIFT_DRDY_EN); if (ret < 0) - goto err_unlock; + return ret; =20 data->dready_trigger_on =3D state; =20 - if (state) { - ret =3D bmc150_magn_reset_intr(data); - if (ret < 0) - goto err_unlock; - } - mutex_unlock(&data->mutex); + if (state) + return bmc150_magn_reset_intr(data); =20 return 0; - -err_unlock: - mutex_unlock(&data->mutex); - return ret; } =20 static const struct iio_trigger_ops bmc150_magn_trigger_ops =3D { --=20 2.44.0