From nobody Sat Feb 7 19:45:36 2026 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB2C1DF75B for ; Wed, 4 Feb 2026 01:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770167148; cv=none; b=bWd/A0gOWgbps2NvXKT25+jbMmVmQM3Fkf/YuqW9dM7gv3B+7mwayB9j12aqrJdDjqx2FhCwVgrvpLLobE5bEJZvubE4nZoobemSk64nBzG+APNkOQtgtwrolkt8qPJ6NX7UxcozKrDKH4G23rtUh6vljUk1v+hqiCXwXogiy6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770167148; c=relaxed/simple; bh=EA+DTyM0TvkKGgHedK2Q1Pd1vEFGamuZmTnbpViWc80=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kyxg1Tgg+AgCn9ec+rUvHBb0Gq7QxP8GGNnyPs0snIKqwxgQpPOzNPbH5Hw0soX44TWfCofPgvtVGue6Tb1cyn+AexlimowXc21wFFWG6XbIHk36/uXe6hcJ/MjTz9IGP8x6P0b8LUCyYKluXuMWmlNlcG+zM67m5pJnhyu52uk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DuOq5JGM; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DuOq5JGM" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-894770e34afso83133696d6.0 for ; Tue, 03 Feb 2026 17:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770167146; x=1770771946; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a/W/oqk8EYBypX45KeAKGlnyGIW8xFG9k4s1ez+lXmM=; b=DuOq5JGM3aACQI0m5uK3chsQ7B7gDU3u5MiaZnVltG01m01PsT2d1AuoWPsNgXQ+MA qDwfGBPq4ppjFTx7VMor0C4hsksBvddbd+pntRd2RowewC+XkvAxyl8Fut0ziqNDWybp finZS9VW0lkuGfPD0Ax9ugrnMEWUnsGzzsvKF9/30qTi9DU54ILlF0Af2+g+4V/sbQeY ENAJ+EQwKsdQmWGy49PShKRs3VPQe/JKrvzGyA1fU4y80yRZYibV98i+s3cBMjfEARqn /g7WgNmJwHqla5JsMbIOjBe5fW92u/XzhP0zZV3cd0THjlnhb3SUZV84B+dBdIVfN1H+ d/7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770167146; x=1770771946; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a/W/oqk8EYBypX45KeAKGlnyGIW8xFG9k4s1ez+lXmM=; b=QBIxKZ54CbZf99vh2K91Uu1rweFlFd7xMdpkXBMBPD0/ec55V7TsDZ8HbgBr+SkIIO X6pYpls5WskjW6D685eK+tz22Z5UTvNlGF3Iol7DkHnmhFIlngKRdGoMe8NovCZXtKMf VUvc7VmMPbEOgR4iydgNZou107MKQQtc2DFg4GvMXZ5pncyI9prmACtruK5Ez+UHtGlR CetyVcNIceYg9B+A4ir/dqTkDvyvkIN89wFmQ2Ldm6BD5sQmzkQYCfskkTi7v4+gd2nX zVMeeCCeLTViMF3lbFUWyEwpXn3pKTbpKeyuhOXgzLP6zqyWSLjKqRHDTwDqW2ri4nJb Y/Nw== X-Forwarded-Encrypted: i=1; AJvYcCWvt0Aks3RrFHD4t/2igXf89biVLP5cu08ORZdAUgUsPHt1R4/dHbw70ZHU36uqPGn2Kx4xAxC/ooziXYw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxy8CT1n74EJd/sxKatBnAP6Xq2Ppc5ccxmOVzDN19jr8aOZF4A 3w9l90+xjwD1h1rhWu5TxHvMYrV2UgtP86F6y93u4g08HhQg6zazwaXX X-Gm-Gg: AZuq6aKmqH7OFPkCuVNX1n8ovi9g1U60CEO/iWvTjPp656jjm+fcfjn8I1ge7MJ4wrE WEdv65AbkqW5wfeXFb0pr2lodEbQaHzRE+mE5fE3u4d3ZwKbEvDQzyhHlerVXvdSUpOohhoQN9q xJtCB8uEI/3gYhSz5OfY5ee5wz5h87GWiB2UPvWzFjqCpwcyn43M/yvMbvKVxscQqC8t68l6T0V kjTVwtFNf3Iji2UH2SPo+xkoCMKQtWuYCrx07IkEBfaDZaoXW1PfLR0ud1OuVJUw5PsSDWpfrhM 5og6ivZxzOsaEhmdJE2a5BLP5HehLGkYe32wayb3RKeu6BlTf6GuZ3QmutoGQAOBMEIrrQ4G3GA cHH8CkXWAE3pLw2jasJwcK2fe20zv8SyRY9aifSwWgK6PxvzWS9ItxAiH1vyCh1P4DzUOODSsBc JVZBjw3s4LAOWw0DpdkxSXdktx7p4odts= X-Received: by 2002:a05:622a:1a97:b0:505:d171:7e44 with SMTP id d75a77b69052e-5061c1bea5cmr15371771cf.81.1770167145974; Tue, 03 Feb 2026 17:05:45 -0800 (PST) Received: from localhost.localdomain ([76.64.58.244]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89521bfe8cfsm8837136d6.1.2026.02.03.17.05.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 17:05:45 -0800 (PST) From: Neel Bullywon To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Neel Bullywon Subject: [PATCH v2] iio: magnetometer: bmc150_magn: Used guard() for mutex protection Date: Tue, 3 Feb 2026 20:05:29 -0500 Message-ID: <20260204010529.48000-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replaced the manual mutex lock/unlock calls using guard() to simplify the error handling and reduce goto statement usage. By using RAII-style cleanup, it ensures the mutex is always released when exiting the function, regardless of the return path taken This was compiled test only Signed-off-by: Neel Bullywon Reviewed-by: Andy Shevchenko Reviewed-by: David Lechner --- drivers/iio/magnetometer/bmc150_magn.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetome= ter/bmc150_magn.c index 6a73f6e2f1f0..bd2706c2078d 100644 --- a/drivers/iio/magnetometer/bmc150_magn.c +++ b/drivers/iio/magnetometer/bmc150_magn.c @@ -794,32 +794,25 @@ static int bmc150_magn_data_rdy_trigger_set_state(str= uct iio_trigger *trig, { struct iio_dev *indio_dev =3D iio_trigger_get_drvdata(trig); struct bmc150_magn_data *data =3D iio_priv(indio_dev); - int ret =3D 0; + int ret; + + guard(mutex)(&data->mutex); =20 - mutex_lock(&data->mutex); if (state =3D=3D data->dready_trigger_on) - goto err_unlock; + return 0; =20 ret =3D regmap_update_bits(data->regmap, BMC150_MAGN_REG_INT_DRDY, BMC150_MAGN_MASK_DRDY_EN, state << BMC150_MAGN_SHIFT_DRDY_EN); if (ret < 0) - goto err_unlock; + return ret; =20 data->dready_trigger_on =3D state; =20 - if (state) { - ret =3D bmc150_magn_reset_intr(data); - if (ret < 0) - goto err_unlock; - } - mutex_unlock(&data->mutex); + if (state) + return bmc150_magn_reset_intr(data); =20 return 0; - -err_unlock: - mutex_unlock(&data->mutex); - return ret; } =20 static const struct iio_trigger_ops bmc150_magn_trigger_ops =3D { --=20 2.44.0