From nobody Sun Feb 8 09:33:09 2026 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F76A10F2 for ; Wed, 4 Feb 2026 00:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770163449; cv=none; b=KMk123uAy4upaemjaQ5eWaHEOwh57CMef6hx7aZgBj/NYsugjwKXkTjK2ZHzcD7PWQMIDczh6IyesKOmg5rnWc937WNBQjQeGIg+sflAqpyhQVNG1P89w2dR3k9oaL91WIyNotb1YhXSltMm5qr21psj4QZdY4QuFgEqpi/uwys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770163449; c=relaxed/simple; bh=Vl1dg9WukJqYTPC06lVnpHjD0vsq/0gDvQVBNUFmJh8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RlekTYw/Yrc6bP/6Sk2ZLTDCo1GtdxcxOryJm1wDO47V5kmpSmpGxR5FE2J+zqA2BWQWNFMnV8SBkBLJvFvCZwct7HIELoEgd9vhQeHfVh2S62ckqU/ds4QeM5L+fTQTCPp+YFiA8HEaTc4t4Hnzpxd4jKaJPacmASUAH4yexxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cSj+L81H; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cSj+L81H" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8c6f21c2d81so625287485a.2 for ; Tue, 03 Feb 2026 16:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770163447; x=1770768247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dWP6YHUklSTvYW2OX4DByGvzjUzKq5UuPUF3ht+MFPM=; b=cSj+L81HkWNenfrlLNAx0acgrN5kGQZs5kyGyAwjQYbqXyCgnpWyuRsCB3dSocZLbp /wS1Z18lmN5k99qoE6G9o0L36oKkUFXZrX4SplJhBQHLneo8vyYV/OYIrgYQ07RnU2jT uLC7dlG/y3vYmnJhXd6fFXN2yK22xogseZFKMRuFMP0DEzFSFRBrgSRD/aDVQTHzMnHf AIYxusw8SVp16CANqbN8mMLOUcCpN0rKoIeDXhCh6wetxcE62wW810uabX2KDTq6ni+5 7stXIFhzU1PLNMw6fRk0Hyb9qNC7t9Lu2bvGlSnERj+DkxZFTqh2ggdFmjIUzCRWOmLV e6Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770163447; x=1770768247; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dWP6YHUklSTvYW2OX4DByGvzjUzKq5UuPUF3ht+MFPM=; b=sJGpcCgp5+eScgT1Co5or/xBX2fUzpcrURCKZ3Wf1i7QBB75SSfKUWv8NSqRNJfDsF NhlBFNte3iU6qPzIIdl5KB+jt5cKen/3WR4zoEFMiAhrngapi1B9EebMQkU+jIkK8o+y bummRBvENO55AUnx4/tS0foCanu6bz2iWcth/ZgJd8TKNXZKmYgnwu+ruZ9fZfbMIUuL qa1r6+O80ijG1QP6X3NU5ofrEzIWWxZpmh0oFn/+e9rvpmaI+ER5blCyneVha4bAfuzl 3828eVRN0O9kX7pbPuCtuBepejk5kPq8MlOAyVZA1oTrp19bNEPfqhoTSzDCPU68p9fC mWHw== X-Forwarded-Encrypted: i=1; AJvYcCXUqs8fUWxkGfVfxi/UsyLcMThTM1J3ZotOgB5rPW4zMohO2s7uhRm60rnQvKki0U7LNjwWc8bQM38H/yk=@vger.kernel.org X-Gm-Message-State: AOJu0YyUHeLAXaqCkSoBXfIQcD0kkNyETfW8iZ5qtALk+/yeXjUWZO3Q r3VMbSsGRBGqaZBFJw8W9plcedo1+vXkzSRV2Hv4B3Y4J7ir0qL9Q0g5FxtxUg== X-Gm-Gg: AZuq6aJ7GjVht3uIXJkJGtA4w85S4hm+oNd9URnIi9zyg5I7hvxAkRXrHVLT4LiFF4A aCa6/o4hKctt93egbC4TiO+gdbv7Mxad5XASVebRHzTFsElSi4gg5x4rLQjj4gNIiFOrvsEwhcT Fiv40biFWy1Wb9NCDbevrzGlvlh/U2p2LSQYx3eNGDbuKDF44dG+nMThNhL3fOTXeSGrenR+0QD m1G+c4YzA1iamDM+HuO6gCJ5w5xt9ZDGu9hlurjCuCaGpQUXzav5lQouxRoVC0Gr7dpWu7RkEuY eQEH2/FMwRsRCEev8zIBV46tAn3mxUoXH9yr4TqNoXO8iQB1aXtD4toj/RKxuwTYLBFMuIXLE7M Qmhe4jm0qKT/Z9zOCZuvf+uW9OVJD4UYLMtjrtzXXg1oQkZBEUyq9ExtFNpEA3pRbPM5aF9lFvG IWPF5dI6qKUNGS/5V6OTlwuJFW X-Received: by 2002:a05:620a:3193:b0:8a2:234a:17be with SMTP id af79cd13be357-8ca2f839c7amr200973585a.7.1770163446871; Tue, 03 Feb 2026 16:04:06 -0800 (PST) Received: from Mac.home ([76.64.58.244]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89521d13461sm8518666d6.42.2026.02.03.16.04.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 16:04:06 -0800 (PST) From: Neel Bullywon To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Neel Bullywon Subject: [PATCH] iio: magnetometer: bmc150_magn: Used guard() for mutex protection Date: Tue, 3 Feb 2026 19:03:50 -0500 Message-ID: <20260204000350.25454-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replaced the manual mutex lock/unlock calls using guard() to simplify the error handling and reduce goto statement usage. By using RAII-style cleanup, it ensures the mutex is always released when exiting the function, regardless of the return path taken This was compiled test only Signed-off-by: Neel Bullywon --- drivers/iio/magnetometer/bmc150_magn.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetome= ter/bmc150_magn.c index 6a73f6e2f1f0..73d9183a354b 100644 --- a/drivers/iio/magnetometer/bmc150_magn.c +++ b/drivers/iio/magnetometer/bmc150_magn.c @@ -796,29 +796,22 @@ static int bmc150_magn_data_rdy_trigger_set_state(str= uct iio_trigger *trig, struct bmc150_magn_data *data =3D iio_priv(indio_dev); int ret =3D 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); + if (state =3D=3D data->dready_trigger_on) - goto err_unlock; + return 0; =20 ret =3D regmap_update_bits(data->regmap, BMC150_MAGN_REG_INT_DRDY, BMC150_MAGN_MASK_DRDY_EN, state << BMC150_MAGN_SHIFT_DRDY_EN); if (ret < 0) - goto err_unlock; + return ret; =20 data->dready_trigger_on =3D state; =20 - if (state) { + if (state) ret =3D bmc150_magn_reset_intr(data); - if (ret < 0) - goto err_unlock; - } - mutex_unlock(&data->mutex); =20 - return 0; - -err_unlock: - mutex_unlock(&data->mutex); return ret; } =20 --=20 2.44.0