From nobody Sat Feb 7 08:13:53 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD5D348457 for ; Wed, 4 Feb 2026 17:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770226921; cv=none; b=jP+rzVFDMvQOxkM/p09lpGK2S4cc9ONvxt/QjLB97hDPFFkXrV7aw8nlmaTzeNl+Clv5HX8dXGAvzseyZBm0xC0NevNjBnUlsb5JnCZAz/9Ma5IYZdPM3f652yLti5et8OEy8cOp8BfXQf4zWgQ63E5wWD31fw2BDlp30qV8muA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770226921; c=relaxed/simple; bh=5NcYr0RmNIwDSQZUlX4Xhwef5nxy4bSG12gyI9oSkxY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HfK6hFgsRCykwub7rQeHZ8OuYIibfCSOxnH8lOQTAaidwBz0BaBu7+2nIHIWYP+bdqFqT9ejikpvzWPysVCZoswtHkBFFL2++o3lSBX86l+fMUHXx7HiddxJnWYYFdtfWJ+LrokJjZLzGK41Y37vs1nTvGwb87F1Q4KfxTpgAok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AlY7qhLd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AlY7qhLd" Received: by smtp.kernel.org (Postfix) with ESMTPS id A5741C19423; Wed, 4 Feb 2026 17:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770226920; bh=5NcYr0RmNIwDSQZUlX4Xhwef5nxy4bSG12gyI9oSkxY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=AlY7qhLdbkBZ7kgZekFSJja9pmI3EHUxsJWSxX+X+pEKmqSn+uCHlBYs603rjhOle fNx3fFgYL1vY1MupNe3IwOjnQK/3wARMzv/aEgbg9WFJyZBCOFZQv9xJp5HWJacY8M hakCn04RC9EVFdYUES54FZefymISc7aEfPfaywK3zur+HggdsqnTWpaFGeL9XWSP6r O/WhiIlMwky4uXTZ3UaJJNMwJ3y7u7DgXpbtxD4u/x+hJAkdzEO+Y65MSKjSNn78wL zNf14+Rw5IzpMnT++G9YxTgWsn/CHuADXpeNO8C0ClPhctHPvcrCzOuIy9vx24Fjp5 W3Boqz8hiVZyw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A11E83EF6; Wed, 4 Feb 2026 17:42:00 +0000 (UTC) From: Andrea Scian via B4 Relay Date: Wed, 04 Feb 2026 18:41:44 +0100 Subject: [PATCH v3 1/2] mtd: rawnand: pl353: Fix software ECC support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260204-pl353-soft-ecc-support-v3-1-fd8ee7595cc1@dave.eu> References: <20260204-pl353-soft-ecc-support-v3-0-fd8ee7595cc1@dave.eu> In-Reply-To: <20260204-pl353-soft-ecc-support-v3-0-fd8ee7595cc1@dave.eu> To: Miquel Raynal , Michal Simek , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Andrea Scian , stable@kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770226919; l=1000; i=andrea.scian@dave.eu; s=20260121; h=from:subject:message-id; bh=A80dHB4AMIcsHk3PCD1NFYNrqV41Ik2X1cY9lUFAPTA=; b=iAQcNioIIB5TAEIv9MmTY44uveT4rvHhfdbQpBSpr7ostFz/xAFDnN7lF94kScPxOIGsQm562 KpwdPwUU+/7BzpHKEJ0WuSgJqx8o+mjJKfGi9ysnyQ19rw26BL0jy6l X-Developer-Key: i=andrea.scian@dave.eu; a=ed25519; pk=PMQL72nEsyoiJCobnq0uEXwUFpVmkwoWIx317WvaQOU= X-Endpoint-Received: by B4 Relay for andrea.scian@dave.eu/20260121 with auth_id=613 X-Original-From: Andrea Scian Reply-To: andrea.scian@dave.eu From: Andrea Scian We need to set also write_page_raw in ecc structure to allow choosing SW ECC instead of HW one, otherwise write operation fail. Fixes: 08d8c62164a322 ("mtd: rawnand: pl353: Add support for the ARM PL353 = SMC NAND controller") Signed-off-by: Andrea Scian Cc: stable@kernel.org --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nan= d/raw/pl35x-nand-controller.c index 11bd90e3f18cb..7f012b7c3eaec 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -976,6 +976,7 @@ static int pl35x_nand_attach_chip(struct nand_chip *chi= p) fallthrough; case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: + chip->ecc.write_page_raw =3D nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: ret =3D pl35x_nand_init_hw_ecc_controller(nfc, chip); --=20 2.43.0 From nobody Sat Feb 7 08:13:53 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BC51125D0 for ; Wed, 4 Feb 2026 17:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770226921; cv=none; b=AqOtR607lWEUyot1CUxscCmqAZJa2s9nCBfiwzlgAMC2aWsB0sbxlg1pwTtJvlaZnpSj4Jv8zKubM3dg2SyoaHgysAvGPTq3MnzIbmlRloA3wMic77ketSEmYwEKAfaxmGTxtvrEvrTKJOAXV82ZsQ9mxbZpNWH9VMuRrYZmwN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770226921; c=relaxed/simple; bh=nHKWb0pnwlZFnThr4s5+AJC2oYIZkNw8A0Hk+0GiZII=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FDNLB9c2ZCsZ1bdOMptHe5Vtgi/opFkRK41j3zaiSlM93aJ4cSQPxLKlQrBLXk9lYO+els481Vjrtic7BBJcaRTrbXgVo23jaUyFMm8Vmu1e5PeA6HDAirWf/zE3Mj/j5dXqDBHc6PHWGuDF16ZvSdvIr+bxd+pB/CUrPyIgDGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VL11Nti/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VL11Nti/" Received: by smtp.kernel.org (Postfix) with ESMTPS id AF0DBC116C6; Wed, 4 Feb 2026 17:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770226920; bh=nHKWb0pnwlZFnThr4s5+AJC2oYIZkNw8A0Hk+0GiZII=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=VL11Nti/nbiiosESFWD9DrUlKDrthp12O26QYs4VQ6gFFuPr/zov18FwfNVeU0rxV puPvqnGML5i++ie5Li+S1pjvcdsPDnJJSNjmtl21CfAJuE0LIsmK7NSeD0+yAyhnle aUkIvOEh2NwmTUU97RISE2H51SezVq2nxno0InQF2HO6WgF5wawOoRLyselx6g3xF0 8dCFL+Wm+cd6ajqSf5i7EaauaQLrtKEFVdgK5f/hgIZau1fT2acsuJ1qje3/ek+dJu Dw+4Zmo26McowFyj/sks8gvUBmw7Y4LkpUaO7+19PwOEfgSQ4gq+S3hyEvzw6fcpdX wF7tIE+lijmfg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ECCEE83F05; Wed, 4 Feb 2026 17:42:00 +0000 (UTC) From: Andrea Scian via B4 Relay Date: Wed, 04 Feb 2026 18:41:45 +0100 Subject: [PATCH v3 2/2] mtd: rawnand: pl353: Add message about ECC mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260204-pl353-soft-ecc-support-v3-2-fd8ee7595cc1@dave.eu> References: <20260204-pl353-soft-ecc-support-v3-0-fd8ee7595cc1@dave.eu> In-Reply-To: <20260204-pl353-soft-ecc-support-v3-0-fd8ee7595cc1@dave.eu> To: Miquel Raynal , Michal Simek , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Andrea Scian X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770226919; l=1229; i=andrea.scian@dave.eu; s=20260121; h=from:subject:message-id; bh=mFOVwp9FgeabNIemoScL8JgY/55GfGdOi+dmhdTS6v8=; b=ALtkDl7uC/+psoQZRq0MRd0+db0BPslbHhrRHdceughAs8Re8enbDMqxdnewH+RrYfa40zd3w KxNiSz9loJoDJ9mlRdzCSV5f+Vf/CvofgVLH0Sfe2RePFAlortGBkrU X-Developer-Key: i=andrea.scian@dave.eu; a=ed25519; pk=PMQL72nEsyoiJCobnq0uEXwUFpVmkwoWIx317WvaQOU= X-Endpoint-Received: by B4 Relay for andrea.scian@dave.eu/20260121 with auth_id=613 X-Original-From: Andrea Scian Reply-To: andrea.scian@dave.eu From: Andrea Scian This just add some information on kernel log about the selected ECC Signed-off-by: Andrea Scian --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nan= d/raw/pl35x-nand-controller.c index 7f012b7c3eaec..947fd86ac5fa2 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -970,15 +970,18 @@ static int pl35x_nand_attach_chip(struct nand_chip *c= hip) =20 switch (chip->ecc.engine_type) { case NAND_ECC_ENGINE_TYPE_ON_DIE: + dev_dbg(nfc->dev, "Using on-die ECC\n"); /* Keep these legacy BBT descriptors for ON_DIE situations */ chip->bbt_td =3D &bbt_main_descr; chip->bbt_md =3D &bbt_mirror_descr; fallthrough; case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: + dev_dbg(nfc->dev, "Using software ECC (Hamming 1-bit/512B)\n"); chip->ecc.write_page_raw =3D nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: + dev_dbg(nfc->dev, "Using hardware ECC\n"); ret =3D pl35x_nand_init_hw_ecc_controller(nfc, chip); if (ret) return ret; --=20 2.43.0