From nobody Tue Feb 10 18:54:38 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B1BF31C56D for ; Tue, 3 Feb 2026 23:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160714; cv=none; b=XNwFqkDTiDH9jte4U0ASDbJ704KCiMdW993HUMhMLCGGEyB/jVLiH0NtnWPHIhMKpVH/03BBE+TYjAgg3/gnxXFCqtxHhzEmWiGcFQy0S736U2S5YzU6lBNmprZwWeNYAHWVQS/KwjDqX34l3O5m2mbr9ey2SFv9eh8FIIlNkrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160714; c=relaxed/simple; bh=Brp5qrTUAsCcym21xMYfoZJ4cOoimrBdqQAWm42fdC8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bG071e1AVu+j3biB0wjZ6PVn0ot5o0++JJvZDfZA7vjTYYpWGYVoU2ekcUrO+Rks1fK6k9b8Rm7cM4JOH54RZ8sT3pTbTYhVCCJGdw8zyqgiX1GpkHrnn0XeuWKnlKDpsBVKP/htGyY4vDHKYJCTKHiBmyZ18D2Rhn/JkILmzdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pg6jk0bl; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pg6jk0bl" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43591b55727so5424461f8f.3 for ; Tue, 03 Feb 2026 15:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770160711; x=1770765511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CJhmxJ+KI+ZTVz7UVfJJ3AAKvigbqAtSvhVOs0qF4Uk=; b=Pg6jk0blnl0ypZcxqrSrY1Rr5XTnNY9xRgiIl/i+fRYTmxkDjoKP78nR5aV2jfmG2/ NJzewdkgKT+2V0B9t+z98PyONWjKRtVob/rdJKTnAdlF+4xAKRn8OvpnYqc2CQ6iH/KX w2Cc8JcC+IidDxVm3x2LNmYgR0ifMRXmyewS6CPFRLfjB4qcili3skpDEhqYNmn4L+pO MMQ34mC+McrlgXONZOQik6muKgpP+p3zQGO9z6tB+E+HYzcMZJNg76U95IA1GKAWWcCi 2FGqE8c531umK4CffbKjxoSCxG4mjw0oRgfqsrHfrE2qNogogS9Cqz2t26tL8M82+f3h bLRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770160711; x=1770765511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CJhmxJ+KI+ZTVz7UVfJJ3AAKvigbqAtSvhVOs0qF4Uk=; b=pv+x4r44w6Ly9T8a214F81Nqrni3T3MJOxQjHnswdwr1+cQFhzanCJD/+LXoShn7mM 7+pR1tv7nnvmWhRGlVERGqU6LXuqrD+CFzeCZgWYZ1L3duLQnQY8aHki3k+AaOUql9Jp 2Z4sISc6EZ5enV54YZwcGqk6GM7rHlt9ttDpeA1TxTxsxGtGwtcMahcrmSva9/lG2o+L iABnal5dYgg/vSOE/i372QM3qWetm69ieh0q44GIjY/ekQZwR09/wpx8MwSdPUfzaBUW MrQoB8uc61KyRf9OHeHVmNdyZ1eSXK4f/46EpDbUAgseorPj2v+TCxkJGCn6LBgvM1xO ur/A== X-Gm-Message-State: AOJu0YwknmjKNyJAyhVCNBkmcpe4o8TqL80Umk/F2R/sv0dW+VAMeO3Z moe3olXkZCZ/+K3qJEGCQHKpL1uHymhnsIOsLn2IjYOi8Q7HiO7sIjYB X-Gm-Gg: AZuq6aJOPhYyM1AyM/dqO7HWUdNsZnW/p3v92/1Y1ANJoLIbuZO+AOKMvJdGOf8jXU+ Fsf8zuGQlxlbgjGLZG/gS65jXgVhR8X8YBB+VxyxvbmPucL6n3XdUnBx/1Ap/EP7+Cp6oz5Wkkf K9laHeh1xftdXyanSaDVc3Q2Uh9AKyhXLhwORAsODSiAOASFv1ERSB5zZaf3wNYhhXAmQ/bMAZ7 JKVJO4NCUsmCVyX3BiPXHZzLgguqg1lbuGwLRpY6CQ3fuBWKvVPOUkE8Jnc6awvg2hx7UD4LxQ5 ziJQv5v4/gl7yuJOW6LK80D1kFWgvY/b7gfAOYatsOQkh7ts+QZud8lWDddQTCuvT0MXlIDKnHG Dck4UQL+lxWWiMocCEi1tO4wz2U7EZtW2kEWdRUMpn9Q9HxsX0ASrAcJJgGt+1wExYzWK3N4Bus huOcrJ9T80wL1QEUlwMvl6aZdq3RVJB4MhuIWwNHRvjRWlVqVGGrf7/M0UBnQMfEHV9hQySUFwJ Kz1xIq10BDVXP9XyVFGo/QU X-Received: by 2002:a05:6000:26c4:b0:436:173c:b8e3 with SMTP id ffacd0b85a97d-43618056bc4mr1401351f8f.29.1770160710658; Tue, 03 Feb 2026 15:18:30 -0800 (PST) Received: from iku.Home ([2a06:5906:61b:2d00:2e50:5c7f:afca:5f9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436180647aasm1739832f8f.41.2026.02.03.15.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 15:18:29 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 3/6] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Date: Tue, 3 Feb 2026 23:18:20 +0000 Message-ID: <20260203231823.208661-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203231823.208661-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260203231823.208661-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Make use of dev_err_probe() to simplify rzv2h_icu_probe_common(). Keep dev_err() for -ENOMEM paths, as dev_err_probe() does not print for allocation failures, ensuring they remain visible in logs. Signed-off-by: Lad Prabhakar --- v1->v2: - No change. --- drivers/irqchip/irq-renesas-rzv2h.c | 32 ++++++++++------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 766b981cf3d8..4aa772ba1a1f 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -560,10 +560,8 @@ static int rzv2h_icu_probe_common(struct platform_devi= ce *pdev, struct device_no int ret; =20 parent_domain =3D irq_find_host(parent); - if (!parent_domain) { - dev_err(dev, "cannot find parent domain\n"); - return -ENODEV; - } + if (!parent_domain) + return dev_err_probe(dev, -ENODEV, "cannot find parent domain\n"); =20 rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) @@ -576,29 +574,21 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); - if (ret) { - dev_err(dev, "cannot parse interrupts: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "cannot parse interrupts\n"); =20 resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); - if (IS_ERR(resetn)) { - ret =3D PTR_ERR(resetn); - dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); - return ret; - } + if (IS_ERR(resetn)) + return dev_err_probe(dev, PTR_ERR(resetn), + "failed to acquire deasserted reset\n"); =20 ret =3D devm_pm_runtime_enable(dev); - if (ret < 0) { - dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "devm_pm_runtime_enable failed\n"); =20 ret =3D pm_runtime_resume_and_get(dev); - if (ret < 0) { - dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "pm_runtime_resume_and_get failed\n"); =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 --=20 2.52.0