From nobody Tue Feb 10 23:13:17 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EECD318B80 for ; Tue, 3 Feb 2026 23:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160713; cv=none; b=pgjR2n5t6cPrwe0oOKDbd3Uo24oeLcFC6OCGz1UUPfGxbRr7CqW6d9nb1g9MPTi8b1R9wDefbBaM8dbhm5QUhMOzfz7IADogShsIQMDnq4/AsBnIlZUG3atgghHdRpyhk2JUz7R7nPX9bpeW7WjFKr4z/dVXfdfTaVFYbBlTHC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160713; c=relaxed/simple; bh=a8vKkne77LOvoIoaom92AJVMtkb1e2GLPRNFL48TDnQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TpLe6VYSAEcKRzvjmVHnQFvKxmxD9xuLI4ywXHSkJfgnK6gtH40gkSj8zn4Oi8GKYVqmZKwn+cD8gwTZPbZqE3kuW9HADf8s35TLjqtOrdxeQS8uZ7WKqkUAxm+tx8rbUurwXozHYithXYCnLYUZHYdgx9ypLkLNkUA9xNjRAAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HBWzV6F/; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBWzV6F/" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4359a316d89so4660998f8f.0 for ; Tue, 03 Feb 2026 15:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770160709; x=1770765509; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=omvaMk73tVK4sT4r3gG1rDVi2ZZXxOVPSdZBLdHJNa8=; b=HBWzV6F/80GnojClB05uBojqnuSnx9mgfqAAl7lM37z4401E3eNpS18Ydghnr73D/U ykLUy7jyJuPDp1/CU+CjxJNH0Xft+znp6hYiSq5RIfDPz+xGx6LgGxh0wAkMt9dLq7RC X/QINI8EIRRRzJ3jyQmf/PyCtOgce0lpfuZVX7AzLICKEn6RBx3/+k1FpivI/xF+571A 7t/bAb2Pd0dxH60b0sjnvFN/ZZ9xfnvCCVOY+tojmgpCW5gnc+eUvEwizePvNx/r9GIS 2GirZ/kXVljR/easHZ0xKZM1Ca8WrU3Vao1KsqdBg6bRl1vnrrEHXdk9HvNt2Q4txmep Yc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770160709; x=1770765509; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=omvaMk73tVK4sT4r3gG1rDVi2ZZXxOVPSdZBLdHJNa8=; b=JGeAcVSt4nED0yf6+DNDp5pYRye6890ddDE1R1YeKR/bICjAmnlmDA8ij61yU3aPq7 MWeDuClcLfGLwDYQx/qJ1RqP7AEi5+c9aLi4MJ8P3kIVghdCqemaNQV1zn6DkrNdmpM3 o+IhQTf20mVHoj+898UKAeu/j+Nk7U1lzU7CCdMJFBF61D0Z29ihdkz+1FKZrx1BIvwm +boHHmI10n0Zf2LNzPhAwLPUTXGIbfNLB3CVgj95Z1j8sbY/HcKRoHRYz1hNN4UuDTl0 hV7qwktZq02CAA0E0RQjo2FV36xqAUWja10CdO3MA+6Fns8Fa+qqvWpvKq0AYAejIflL QXjQ== X-Gm-Message-State: AOJu0YxQGqUn0MIKEoS8VMd6GL2wOLbKLrYVcw6bIUQ4nrNocoa5INOa w1ae6bWDULnHTSEYLs3NWOi5HBB58M1q7m++ECrii0/HBq1vvrIwaaZZ X-Gm-Gg: AZuq6aLWRR/8VqKHUaB7rZcU0RmWMGYgLbcv0zuujsm6ckXQ1htOFn7e+pbzh9zcrQp Mp+pDXi5SP+QcCCn1AiBzMInoqvNv0TgzHkk+u4DiAMm1RWqWVb+D1IBaVQqTt1iOt6mgz8pTdw CuKs05RgYEpIEQlh4xFcgc8f1wPuotQE1PdEf5W7iVRDPUE2mly5vDInhGl7U7d1g0J5n9eGrGL xyt7alng5+9CEKOLAZgLBkVvfQqjR7hz/itfo2Y20710OofIHeUT/e2DTyvnQAJVFBhFerB568e HcQ9l4Ht+uR8f8CF5QChG2y8jwSm+y1Ti8P9GS5n+z3OYZwCWJrSk4H+72iKTf7jgyJ4vrjtjck rKOgV432mXMiFYpG9n+T3sPLvvr+Lg6/MpENw3jfQlP3WnUemBkExQsq/8YSR8DRJ9tvYFscPtT u6F0boL15wXqp0SkeZ54ddSxipolfmXkzRSgFG3sJ2vrSD6Xli/+HJ1LUscerUuytssW9zZwGQ3 gcj6IXEZCs7VpygVh6sixXR X-Received: by 2002:a05:6000:2211:b0:430:f3fb:35fa with SMTP id ffacd0b85a97d-43618061b94mr1325430f8f.57.1770160709500; Tue, 03 Feb 2026 15:18:29 -0800 (PST) Received: from iku.Home ([2a06:5906:61b:2d00:2e50:5c7f:afca:5f9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436180647aasm1739832f8f.41.2026.02.03.15.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 15:18:28 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 2/6] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Date: Tue, 3 Feb 2026 23:18:19 +0000 Message-ID: <20260203231823.208661-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203231823.208661-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260203231823.208661-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a local struct device pointer in rzv2h_icu_probe_common() to avoid repeated dereferencing of pdev->dev. Signed-off-by: Lad Prabhakar --- v1->v2: - No change. --- drivers/irqchip/irq-renesas-rzv2h.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 20c0cd11ef25..766b981cf3d8 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -555,57 +555,58 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no { struct irq_domain *irq_domain, *parent_domain; struct device_node *node =3D pdev->dev.of_node; + struct device *dev =3D &pdev->dev; struct reset_control *resetn; int ret; =20 parent_domain =3D irq_find_host(parent); if (!parent_domain) { - dev_err(&pdev->dev, "cannot find parent domain\n"); + dev_err(dev, "cannot find parent domain\n"); return -ENODEV; } =20 - rzv2h_icu_data =3D devm_kzalloc(&pdev->dev, sizeof(*rzv2h_icu_data), GFP_= KERNEL); + rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) return -ENOMEM; =20 platform_set_drvdata(pdev, rzv2h_icu_data); =20 - rzv2h_icu_data->base =3D devm_of_iomap(&pdev->dev, node, 0, NULL); + rzv2h_icu_data->base =3D devm_of_iomap(dev, node, 0, NULL); if (IS_ERR(rzv2h_icu_data->base)) return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); if (ret) { - dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret); + dev_err(dev, "cannot parse interrupts: %d\n", ret); return ret; } =20 - resetn =3D devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); + resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); if (IS_ERR(resetn)) { ret =3D PTR_ERR(resetn); - dev_err(&pdev->dev, "failed to acquire deasserted reset: %d\n", ret); + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); return ret; } =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { - dev_err(&pdev->dev, "devm_pm_runtime_enable failed, %d\n", ret); + dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); return ret; } =20 - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret); + dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); return ret; } =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 irq_domain =3D irq_domain_create_hierarchy(parent_domain, 0, ICU_NUM_IRQ, - dev_fwnode(&pdev->dev), &rzv2h_icu_domain_ops, + dev_fwnode(dev), &rzv2h_icu_domain_ops, rzv2h_icu_data); if (!irq_domain) { - dev_err(&pdev->dev, "failed to add irq domain\n"); + dev_err(dev, "failed to add irq domain\n"); ret =3D -ENOMEM; goto pm_put; } @@ -616,12 +617,12 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no =20 /* * coccicheck complains about a missing put_device call before returning,= but it's a false - * positive. We still need &pdev->dev after successfully returning from t= his function. + * positive. We still need dev after successfully returning from this fun= ction. */ return 0; =20 pm_put: - pm_runtime_put(&pdev->dev); + pm_runtime_put(dev); =20 return ret; } --=20 2.52.0