From nobody Sat Feb 7 22:07:44 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AECD341ACC for ; Tue, 3 Feb 2026 22:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770157022; cv=none; b=bJS7uvUdZ46dRuB+dMBpCN5xLWMW1m2Uw3I77qSlJLadUfLVqnOtsibqrKOcVUe512Cr4ga8/SlUvVnLKNyup3U4jxApQlxv7+1WFesD9DdfEnEn9ye4IgqntcDnWG7g7/72pX6TxLrRr8le2o84kKk5bJ2g9OswdhmemcCOcOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770157022; c=relaxed/simple; bh=pYxYPURvz3MhNYNsewL0ZKU73YmQFgpw+7Rw6Nsrd3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JJBFcdubdU2GitGg7Qg1h4agj6KOEQfKamUvoFT4dEIAH+ft7w+8mjpUbD8AArjcCrlE/AGk33hpRRXGDq/k8LauK5KwT2a5HJklMmskB5acly/Gz1//oCc+VaHLjCUIBlFYOSZ8Ojf1ciuajAEq97X6iwuhoIX6tSacEpu0LiI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fGDxvx0/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fGDxvx0/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770157018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GFYAOGiLZN4gRTgbQkbegN6tbXaotzgssD6BTvxd+5U=; b=fGDxvx0/Rrj8S5yRJFU7+wFFu6EgDS0ZsbAfoDFUn3PdC1Qoa3HkPGqo0/ZdWdJa9QT8fr 7enPRC0+D38wnNqCrmJo9C0awEDNGn2kIoDpm4QCE0QUpz2bAykzkqTp2syTOx8S/UFXjr yIQYJ1IiQs2PI3JqP/HXsoYLhPKf8TA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-VQuSGUDNPk2YMyEgj0iwDg-1; Tue, 03 Feb 2026 17:16:55 -0500 X-MC-Unique: VQuSGUDNPk2YMyEgj0iwDg-1 X-Mimecast-MFC-AGG-ID: VQuSGUDNPk2YMyEgj0iwDg_1770157014 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B2B95195608F; Tue, 3 Feb 2026 22:16:53 +0000 (UTC) Received: from GoldenWind.redhat.com (unknown [10.22.80.51]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 01AFE180009E; Tue, 3 Feb 2026 22:16:51 +0000 (UTC) From: Lyude Paul To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: "Jiayi Li" , "Mathias Nyman" , "Oliver Neukum" , "Miao Li" , =?UTF-8?q?Johannes=20Br=C3=BCderl?= , "Lei Huang" , "Lyude Paul" , "Greg Kroah-Hartman" Subject: [PATCH 1/1] usb: core: Add quirk for Gigabyte Aorus Waterforce X II AIO coolers Date: Tue, 3 Feb 2026 17:10:27 -0500 Message-ID: <20260203221452.198682-2-lyude@redhat.com> In-Reply-To: <20260203221452.198682-1-lyude@redhat.com> References: <20260203221452.198682-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" The "Aorus Waterforce" is one of those fancy gaming water coolers that comes with fun LEDs and an entire dedicated LCD screen. A minor issue I've noticed with this cooler on Linux, is that we fail to actually reset the device when coming out of standby, ish: [ 281.652184] usb 7-10.4: reset high-speed USB device number 7 using xhc= i_hcd [ 287.179843] usb 7-10.4: PM: dpm_run_callback(): usb_dev_resume returns= -5 [ 287.179854] usb 7-10.4: PM: failed to resume async: error -5 Generally this isn't fatal, as even when the water cooler doesn't resume it will still reconnect itself moments later: 15:48:12 GoldenWind kernel: usb 7-10.4: USB disconnect, device number 14 15:48:12 GoldenWind kernel: usb 7-10.4: new high-speed USB device number 15 using xhci_hcd 15:48:14 GoldenWind kernel: usb 7-10.4: New USB device found, idVendor=3D0414, idProduct=3D7a5e, bcdDevice=3D 2.00 15:48:14 GoldenWind kernel: usb 7-10.4: New USB device strings: Mfr=3D1, Product=3D2, SerialNumber=3D0 15:48:14 GoldenWind kernel: usb 7-10.4: Product: Castor3 15:48:14 GoldenWind kernel: usb 7-10.4: Manufacturer: ITE Tech. 15:48:14 GoldenWind kernel: hid-generic 0003:0414:7A5E.000D: hiddev98,hidraw2: USB HID v1.01 Device [ITE Tech. Castor3] on usb-0000:74:00.0-10.4/input0 My guess here is that the device simply doesn't support resets properly - since that seems to be the only quirk I've found that actually works. Note that the device still ends up disconnecting and reconnecting after resume, but this seems to be normal behavior. So, let's fix this by adding the USB_QUIRK_RESET quirk for this USB device. This seems to work perfectly fine and prevents us from getting the aforementioned errors on resume. Signed-off-by: Lyude Paul --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index c4d85089d19b1..9a81994ee725b 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -584,6 +584,9 @@ static const struct usb_device_id usb_quirk_list[] =3D { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info =3D USB_QUIRK_RESET_RESUME }, =20 + /* Gigabyte ITE Tech. Castor3 (Aorus Waterforce X II AIO coolers) */ + { USB_DEVICE(0x0414, 0x7a5e), .driver_info =3D USB_QUIRK_RESET }, + { } /* terminating entry must be last */ }; =20 --=20 2.52.0