From nobody Sun Feb 8 14:10:18 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64B763A63E5 for ; Tue, 3 Feb 2026 17:59:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770141545; cv=none; b=bLskq8V334M7aLmc8QPcP2FoMj+/dJG3aN9jOb4tEDfeeeppr0k/f+l6bqF194d1Tuv4szkW4M8NXadM34DOCOcq7oAU7mSVRXlR9++tnCJLUZIh2LU1dnlbG4WFqo9OVnusZgLP6oyvN4Syn1DIXzglZxuWbhsUT2Bho+VLdK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770141545; c=relaxed/simple; bh=XIFEIkVfS2fiunES6GFpNr/znuPlzTOtGTmtlrXmHEM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CAoml/vyC2fo57HAE0cccK9M5G87KpRANTy3XcoAvNkZU1pXPi/o+mPfd1i7CMNccUc+fyg1Ob1XsBcZMVcKP8US90GCCMU4+D5dLb0dvjUGsmrIvV2CB5c03a91KsODkPuQtf709AhB1rvq9bNQHHYrXFCbZED2g1AxKvzrt+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZcSbhwoz; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZcSbhwoz" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-794d4f11a20so27534197b3.1 for ; Tue, 03 Feb 2026 09:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770141543; x=1770746343; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zMelDBIBf0H5OM784InI77d/gq298gB9xmca7hvO+Qw=; b=ZcSbhwoz0MFpq1oRcrd2KJN0FQ/j462YaNM40TNFru+WFaH6ugwMlvObId3+/HpoL9 WfefCE9lihgYLdluMzo9FXjR2nWfiYbZjt/n6PmyVCYXlJKu6mxlIDop9MDT9zHTcRAN xixU9NNSkWVP7HsZBmRqzebj+5elka3L1nORdnbyHknlnZYZX6HBHRvSDqlfRJxJ9wQd X8EI7OqLGsIKMizh0dYsXXxNHeCZJnNWQtLkj1EZZruog7jLyXCMaYyMLKG0KSU6lTgW w/0O+mlJBhwWDlmLsQnbLy9nThAId2lpacxXx6pLeWMGbty2eRoK7z5h8yHoleABTfZJ Oc2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770141543; x=1770746343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zMelDBIBf0H5OM784InI77d/gq298gB9xmca7hvO+Qw=; b=uCrbBWwuerJAdfaHLaWGd1rWcIgpFB/yhZEYgaBUUTCDjvzgCX66Zd+Xpoz6BecEyO eIfvrMNlAfCkcABd5/q7E7k8YuhHJff+smcd9xDasj+1d2B0qQRiMpFnC0WOSeXgb389 vC28Idc/9R4VoBmBqOejwmYMOzyVzZHkl4cN0+JBsvaKOAPpvZj7DDP06ksdrnCNnmLW 8oUoQWaswrwyzhXmt1hsYqktuAz0nPD9dpsNm4/PsR3tere3aBpYZ33vk+nlLlOGtQNF WxCy2oKV9OBmB54R9Dtzh6JFronDDVa9Z6xeePAV9FSLZU4qLhK5PfhuMOQj9v7a8DBI M0vQ== X-Gm-Message-State: AOJu0YyNrNFvcNxml+mjtrW8/wzgeigbLy+AZCo610fja9DbFiORFDbH s0xm5/KbOD89V6xhaIQMzlKC3RzR6gq6jDXxr7s49j+JFXpYBspkN/DMlUlV X-Gm-Gg: AZuq6aI3NF/A6mf0BRIYqE4aInw97B1Ycb1PMhETFJb5evmWtBHH/tTgEhn/vUIDDzz tJsxQc+KSgdk9swUC3ETO59cKAl5cUgcWa1LB5SPv+K39uw3G0e2FDoMJ25Giabt1UbVOQ1f/Ln AipdzGTMhGQx3odn3PG5leTMA1E8D01KiLnd3/Kn8kllBDFlQCMp1omE7Vkw/WPMRO6cuVpWtyz naj+UIZp6756GwH45LPsp3E1Y71QvX7HMaSTAn038ZDg6pJwxrYzKasdR+TP4zKZJcVmnaXn1/+ NRJI5Rnuv4BRcgui3kwTUZlabMHduK6uCbVCLE9KTtTj/0wQGeg/G6X7LSaRiHnAfSSBYQ2cuzp mw/zgzZhgDuEkWXqDk5Wm5QB6sKYdrCfsWu/OYx9I/0nGVwTl3HnJE9JBrYJfBZPWTQV/mWvMqY OhvMs= X-Received: by 2002:a05:690c:e4ee:b0:794:fc73:5d2e with SMTP id 00721157ae682-794fe7becacmr4080697b3.54.1770141543242; Tue, 03 Feb 2026 09:59:03 -0800 (PST) Received: from citadel.lan ([2600:6c4a:4d3f:6d5c::1dba]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794fefc8849sm1204647b3.38.2026.02.03.09.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 09:59:02 -0800 (PST) From: Brian Gerst To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Ingo Molnar , "H . Peter Anvin" , Thomas Gleixner , Borislav Petkov , Ard Biesheuvel , "Rafael J . Wysocki" , Len Brown , Pavel Machek , Brian Gerst Subject: [PATCH v2 4/4] x86/acpi/suspend: Remove redundant register saves Date: Tue, 3 Feb 2026 12:58:21 -0500 Message-ID: <20260203175821.511847-5-brgerst@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203175821.511847-1-brgerst@gmail.com> References: <20260203175821.511847-1-brgerst@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" All general purpose registers are saved in save_context. Remove the redundant saves to local data. Signed-off-by: Brian Gerst --- arch/x86/kernel/acpi/wakeup_64.S | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/arch/x86/kernel/acpi/wakeup_64.S b/arch/x86/kernel/acpi/wakeup= _64.S index b4bb1ca228b6..e8b3d01ba14a 100644 --- a/arch/x86/kernel/acpi/wakeup_64.S +++ b/arch/x86/kernel/acpi/wakeup_64.S @@ -25,19 +25,12 @@ SYM_FUNC_START(wakeup_long64) movq saved_magic(%rip), %rax movq $0x123456789abcdef0, %rdx cmpq %rdx, %rax - je 2f + je .Lresume_point =20 /* stop here on a saved_magic mismatch */ movq $0xbad6d61676963, %rcx 1: jmp 1b -2: - movq saved_rbx(%rip), %rbx - movq saved_rdi(%rip), %rdi - movq saved_rsi(%rip), %rsi - movq saved_rbp(%rip), %rbp - - jmp .Lresume_point SYM_FUNC_END(wakeup_long64) STACK_FRAME_NON_STANDARD wakeup_long64 =20 @@ -67,11 +60,6 @@ SYM_FUNC_START(do_suspend_lowlevel) movq PER_CPU_VAR(current_task), %rax movq %rsp, TASK_threadsp(%rax) =20 - movq %rbp, saved_rbp(%rip) - movq %rbx, saved_rbx(%rip) - movq %rdi, saved_rdi(%rip) - movq %rsi, saved_rsi(%rip) - movl $3, %edi xorl %eax, %eax call x86_acpi_enter_sleep_state @@ -120,9 +108,4 @@ SYM_FUNC_START(do_suspend_lowlevel) SYM_FUNC_END(do_suspend_lowlevel) =20 .data -saved_rbp: .quad 0 -saved_rsi: .quad 0 -saved_rdi: .quad 0 -saved_rbx: .quad 0 - SYM_DATA(saved_magic, .quad 0) --=20 2.52.0