From nobody Sun Feb 8 17:46:55 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C511B2F5487 for ; Tue, 3 Feb 2026 17:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770140569; cv=none; b=HmPXcslheHJ9O+x98wx1wjRvCxBt8GC/TIsbW59fdE2l9GNPKGCYkOx/It6aaFdvhFxu6em2WXIjqy8j56lsU+JN3wI1x9s/uJPPF1ffmjeMU3GWHoPm+WjjCq9PkEQBAD/qc2lYc16w5/IIsfC7jApQpuAEXAtL6QAlrwuNvGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770140569; c=relaxed/simple; bh=XsYfAuikLlaOfTmt/l8n20FoLsRWn3fKrE6HabUSTLg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=H9/TSEF/qkZVfqoIKugC1gp346IyST20hl9mcTR4XJZQR0Csf6PqLs3xjPHvhz5/YuY7fJai2ElqS9ZlNsDV4iJvAHPn0tLC7jQZ5+C4Ge/RwTTZvaBTGQNPegeb/cWRFkfu+BuWEOjP0Ngud6fC1WDxHq3Pr6wDEvXrLjGRXs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jxd3bWfL; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jxd3bWfL" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-655b5094119so597918a12.2 for ; Tue, 03 Feb 2026 09:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770140566; x=1770745366; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iJlB42/KFIlk7GeivHJ/GHOk3Bxvmmpk4HJ11cBcz4Q=; b=Jxd3bWfL0aaMhuL9v5xFUYg0a/wwRdauhiRvU3o96AJQT691nxBstIjKHfxzOgwExV cDH8WhKPg4RpABk3HnkwtOisD1bfOVDyYomqw8IKEIvC7QtuMSdaovMTmbcP8FQ7zSEq bqeGH57kpAAZlmvuT2P++t2dV+81Q5Rr00vFzBVqFqEXM1OFInLMSCZnjdBqC48n+N7P z0k987lQZK3JgdFP+KAKvTQJkCLrNfDfUwrJ0x7vXvhd1doP6wsdT9ePtIrxVYaZEWUU ydtYzxFp2Ora3XewaF4c5JDDdQy5rXhMtmde6jKP29xFucQqM/4Pyz4GnzP9sGVI9JGW un6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770140566; x=1770745366; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iJlB42/KFIlk7GeivHJ/GHOk3Bxvmmpk4HJ11cBcz4Q=; b=X5Tcq5bxQiQiMuIHN5s4PufMYYhKGCAPUQFakfnLqp+68PQJmkcajX3LnYebL3S2Z7 futjkbwvllVSMzELNJzF8sodKVsH9TngqKK9MBFl4s5Yd1V6CwRKoM1m9EORtMVgJhvP 0z8NIyr8NqyCCF/zPaHNHBBu5fRjLcwPCMbHbVMyuOd8JngBmHn0lgccc3X+zKGv1Txn Nt9Q5NBaY2IPdm4T0/iV2IyEc2BLOZgG7gnd9WRGUBUsxMA/LTuxPvM+BskDXASjD9oY Ab7XHAxKdIu20U0sEDxOEA0NfWQPz3QEpCE2zIwYID6AnNRmc0tjv4jA0f+S6PyBvuUe WRxg== X-Forwarded-Encrypted: i=1; AJvYcCXyTHUYn0Ir9FcEDX3uXcKfkUPpixzcGSAfK39WN5BItQiAbVhb1+HMlaqj+5LlJOadVEw4IM3ebU0U4eY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzln9TIZZM3Yjr6a/EfAKltc0eRNusZcO79DxSWRqqBK3KECw0D 7ji/f9BYAmTyITqQmtfOmbPK5RWQDIjxS+mo8ggt9OcshqQbdzdLjyXC X-Gm-Gg: AZuq6aKNo98ZoizuBL8x+RpLQ52S0/BimItvhgp3InyiOXkbgvMvpkZVuimgdH1XI/u SW1NN8qYcIsNZdigIc0z9l3tCASamFnqMJ1AOW1N3MdMJEThMzH/ehbsFEzF7dFqEyTn8/geylH IP9R8lkVWZmiaunqV708SIf9QIh6CzK17zx54lN/Fs3vKn1g6ljRZgEa98+6q1oLpqoSBQqudcm tha5gev9cdYEnJKpcb7plBLeshOGgwMAu660QcDu7SXK8y5SG7JZFOeWRtoxXDTniSAB9cjDIRv TKWv8BKSYVrf54vMZENQqxfU4A8IcjOQHBIkvshyy4QAifqyG8XvRoNVJhMhzMDAjHlB/Hm3cPT 9/DqNK8Ms3HB2RQPI6dmTADJDxxTzMBC9SF/E7rIygs8vGVM+mqh62QTvSbSUrQ6yEdXDhmyFss lafiFoMK8W5pvSSIb/I7LtWP/I613z2xN4Mn4OuVXmih+tm2mWshVUj8oQmRVKOZYU X-Received: by 2002:a05:6402:13ce:b0:659:3f9d:757b with SMTP id 4fb4d7f45d1cf-659499b8e05mr174881a12.2.1770140565884; Tue, 03 Feb 2026 09:42:45 -0800 (PST) Received: from laptok.lan (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6594a2168b3sm163968a12.20.2026.02.03.09.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 09:42:45 -0800 (PST) From: =?UTF-8?q?Tomasz=20Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org, sashal@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, tomasz.pakula.oficjalny@gmail.com Subject: [PATCH] HID: pidff: Fix condition effect bit clearing Date: Tue, 3 Feb 2026 18:42:41 +0100 Message-ID: <20260203174241.2863219-1-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable As reported by MPDarkGuy on discord, NULL pointer dereferences were happening because not all the conditional effects bits were cleared. Properly clear all conditional effect bits from ffbit Signed-off-by: Tomasz Paku=C5=82a --- Urgent for 6.19 rc period and backports for 6.18 drivers/hid/usbhid/hid-pidff.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index a4e700b40ba9..56d6af39ba81 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1452,10 +1452,13 @@ static int pidff_init_fields(struct pidff_device *p= idff, struct input_dev *dev) hid_warn(pidff->hid, "unknown ramp effect layout\n"); =20 if (PIDFF_FIND_FIELDS(set_condition, PID_SET_CONDITION, 1)) { - if (test_and_clear_bit(FF_SPRING, dev->ffbit) || - test_and_clear_bit(FF_DAMPER, dev->ffbit) || - test_and_clear_bit(FF_FRICTION, dev->ffbit) || - test_and_clear_bit(FF_INERTIA, dev->ffbit)) + bool test =3D false; + + test |=3D test_and_clear_bit(FF_SPRING, dev->ffbit); + test |=3D test_and_clear_bit(FF_DAMPER, dev->ffbit); + test |=3D test_and_clear_bit(FF_FRICTION, dev->ffbit); + test |=3D test_and_clear_bit(FF_INERTIA, dev->ffbit); + if (test) hid_warn(pidff->hid, "unknown condition effect layout\n"); } =20 --=20 2.52.0