From nobody Sat Feb 7 16:39:20 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FF72D130C for ; Tue, 3 Feb 2026 17:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770139465; cv=none; b=EeLssGgVob7KsxmjvGfIQ+dUdiqxYjZ0PZx7Xo1MC0LiqBjPi3VPtLfzsPlLEBkCDFJb7SlaadXdleRvzvnciG2N6yBshxvEh1cNyxnCSCfotB1qdw2MQwkKuBK1wJZzyrT7n/L7uwCQtksktRW9tEdNH6YBAHByuVTuJc+iExc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770139465; c=relaxed/simple; bh=0pDadfXZD2BD20L2lYJnlOl+5a7N3k4V6nBAQaGTeG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cU5MdfDYV0ltvU9xkV9DhaVb84jF63ZWnOyFAySFQp0dssSFG14TwVHk2ATszuv8QuQNrtQDJKrEZd6tX19gA4VPxuwKS4M/syS6zRGCJU5qmyxGaba4URVqIoorXyVO/lQ2pnRHUwygurpbMC+dy4NiN5Vr0+yQV02q3OOlLwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iei0sEHn; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iei0sEHn" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-81f4f4d4822so3014949b3a.3 for ; Tue, 03 Feb 2026 09:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770139464; x=1770744264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dH64yHIZX3KkZaMyb1NeM5197qBECCBgD9Lqqh1xbWk=; b=iei0sEHng27v/y7zabiBmu85SS5klDr1K5vSsKhDB3CXCJdF0PwZdGpI5LGVgdUANK wszrOgVam1ynH4t+ufHRPKcwU/UT536PTuRFlEpPtxmtuqMx+yt9S20jQ15naAhbukg9 Eg4joz0HGV3x3kpyhqWDQ+gng0wmuR7k9jw4KN1ZNXlC7Ndq62qdK+IiDYgRDLGwLqTO N/WPKi8R1yMaJe61Sp2lIlOpf00JcO9wNKnQIjZmqqqarXxqAGIKubBUTkcwNXILQC8W +1SeePpMKYN/4QEnxR1DHGZlRnMK1F2iUNK5tCa+ixPQ+tymXtrV4grQGFKnEopx7nNB v5Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770139464; x=1770744264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dH64yHIZX3KkZaMyb1NeM5197qBECCBgD9Lqqh1xbWk=; b=KZAc9NSm8K/H2H61NZCeD35COVzLgckKx2uo4coiggn2PiYrvMt1a7VI+O4ehTncl0 x+y/lk+LSU9usmTWyFNkOjzO+ggXzN423kFxOFYos0yzcmiJ0e6Yuvd0mUVGYdV8Uh+y lLsNFVPDlh6ewhE3qtOwLCCiBXoeMKHiZdaG6Rp8niJlbmMhpUMxjjarSmrq4vd7YlA8 Nl44cfJVOIX8WF8xSfIHc0BD4Aa8PEjxJvb1Aacv3TfP/fbjdZ/EXplj13RNK+P7kRTu q2WUFIa0L6yPy0k2E7vTdnoBp4lsCpuCdRvCJQLO80si9ZW+joFgy7FNI6fj75ePJa/D y1iw== X-Forwarded-Encrypted: i=1; AJvYcCW+1oAEu151+OCyMnr8Z+6XeK4oYJ2eQ/jJkWrlom+STg/a0xyRd8CO2lnAQox2PYCQC/eETHX7QtQ8c5g=@vger.kernel.org X-Gm-Message-State: AOJu0YyyfgfSQIpVcP7qeXaYd62xkOtzt0SkS3wKPoEXexTURwbwY9ze LmhjfyM07Z7zdK/3XsiwTt/dw08U7E9nnt2cQtoO7xYNZ+bfgF2pOvif X-Gm-Gg: AZuq6aIlISPqgCwnyB0757BsSIEfY/T8BzInhcpSWtzaNz+RvPgZOhVTfg4ZkTOkXcR naDZ4ijlGlQOWZvL45CdN7a7ZyXpDS6CC+8OhmZfQ7UMmnVRMeZWjH3tBLVnuy+lOR73AjJt6sD IbsR0eTd/kYYy5PgnakB62CH1cE+aJKAD8q7zzZx1AbKMbkjwqEJvBxYtFBwqih6u13uFcW0wMM qm/mhkjIsZ0eUYF+dHxeIwucmLIgwpxQLf02HGztBeg3UVnZpSdb0xcnU2F1ItoJnhm/+/X/q1S MHWRdctVkIvylAYqQjnsU7ocwpgY21nm9NjM8dV4XH6uVBE9tCSF2UhGDYbRD3PAV5UFSAS6+4D utz9h4ZVQKopGIi6cEFaaga9pL1Csj6Y4k+R3dI59Oi4A70/03jk+GyfDxM9TOjNiHhA3MgEBvL dyIpaCs6HA X-Received: by 2002:a05:6a21:104:b0:38d:e674:b5ef with SMTP id adf61e73a8af0-393724c9047mr117902637.75.1770139463978; Tue, 03 Feb 2026 09:24:23 -0800 (PST) Received: from archlinux ([45.119.31.7]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642a9f70fesm17099299a12.25.2026.02.03.09.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 09:24:23 -0800 (PST) From: Adarsh Das To: Chris Mason , David Sterba Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Adarsh Das Subject: [PATCH 1/2] btrfs: handle unexpected exact match in btrfs_set_inode_index_count() Date: Tue, 3 Feb 2026 22:53:56 +0530 Message-ID: <20260203172357.65383-2-adarshdas950@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260203172357.65383-1-adarshdas950@gmail.com> References: <20260203172357.65383-1-adarshdas950@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We search with offset (u64)-1 which should never match exactly. Previously the code silently returned success without setting the index count. Now logs an error and return -EUCLEAN instead. Signed-off-by: Adarsh Das Reviewed-by: Qu Wenruo --- fs/btrfs/inode.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index a2b5b440637e..9f46bfff1e4b 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -6105,9 +6105,18 @@ static int btrfs_set_inode_index_count(struct btrfs_= inode *inode) ret =3D btrfs_search_slot(NULL, root, &key, path, 0, 0); if (ret < 0) return ret; - /* FIXME: we should be able to handle this */ - if (ret =3D=3D 0) - return ret; + + if (unlikely(ret =3D=3D 0)) { + /* + * Key with offset -1 found, there would have to exist a dir + * index item with such offset, but this is out of the valid + * range. + */ + btrfs_err(root->fs_info, + "unexpected exact match for dir index key, inode %llu", + btrfs_ino(inode)); + return -EUCLEAN; + } =20 if (path->slots[0] =3D=3D 0) { inode->index_cnt =3D BTRFS_DIR_START_INDEX; --=20 2.53.0 From nobody Sat Feb 7 16:39:20 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43FF71D5ABA for ; Tue, 3 Feb 2026 17:24:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770139470; cv=none; b=LCQpb/CoXL5bkOpqrD7dUJWbUnlAiWmK5l2gpqFrJv6D4jJQltqv5KUXCql1vESwbNK4XegtT0tyeNWthHRFy59ggP5KEAonnwaKetd3tp4rpCHVjMlsfhkmfsimFE8vy39qL2eHpa7dscFdFh+qlwbyEKiB+ADqwTWOw5NN5aE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770139470; c=relaxed/simple; bh=kbyVj4lwhApgmqGuF6dylK4z1Fx4XpeR+OlUZ2PLW74=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dml6dNCROANtQtgbwEheFlnU5GAoRJYZBPDs9CskYJj4KXfloODYWczFEESsMmF7ZGo/BIws6pwM8FhE24qkNwIFklfONAkbNsf8xTBZta8S55QPY6Od2esES9Tu2XvWjYbq7vfdv0RbRomho3atvBC8Tn1KHh68O2SDuIInwmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WZ3+KAN1; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WZ3+KAN1" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-81f4ba336b4so4902065b3a.1 for ; Tue, 03 Feb 2026 09:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770139469; x=1770744269; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G/clOlONdUzzZ9F3OiJkkdaeVsbNNXE/fWddlZBfOB8=; b=WZ3+KAN1ZukpGxiUn2o1XQ+sJuWFMJzDBONGuHZn3Qicbo4EEp8bMshcaDrvMq/c2S IvskHC0Yo2pMDg6Qm4sTXgfrLmG0tCLnWolYn6sRSS0CYml9tA74uLGK3iKNGYd+Fuzs VMUcoX1bLmaaN4VhXbi2X4kwPtKBDP6BbjM1QU0pvsgaCkVb6MT9vUw1rcLYHv+eH65k vMW+OwlfLFP8UrbSGiMj64E2BNrRQ7xmuTVXW67mC1QfPB5QYrfY/7G37Y9gQ7K1eF+U n1DFyB+Sqk0lIHdHrxWIfdH44j9zT+DGOYpFrwUwtDtFj62kLEnUFye7pL9ayFGE9xmJ dQdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770139469; x=1770744269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G/clOlONdUzzZ9F3OiJkkdaeVsbNNXE/fWddlZBfOB8=; b=LvenDqVPx2RTVU1KYW1A9LC6BZSBSjRB1nctm/EW0zIYuMLpV1LPOkB/7HiRRPnTQ4 Gb+4+VDIac4IituWqrlxTkY2Kto3YstmafMEerTmAjdP8Xbiifvj1JTPKX6vEPXBC57S bQYEOB0IZq7S6S58EF7XxnU8kALEUC9pMj5nty/58++BNYZ91996skI+NyvgjK2FM9Qa LVeqPN/kBTRjpGvOiqLPSWrVfB2vNrvySphVIMOR+/OVKDgfK7WjYPp8uDigsL3e1kIU JNROivuJ1P2s1W9p5ADC1rjfUSodbci+/xDidRKtvAbrGzAJI7h7v4WPIXkyYR/VauEI ybaw== X-Forwarded-Encrypted: i=1; AJvYcCXa9LbjHf/npePNPLPd6sN+55awE55dS0PiEn6BbUpFz9Dn/W+NgzOJwYKZELQJtw5rwHW5fk8+E+xt8pU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1wL1hHVGj7GMalD2cc/qeJZ9NNYERQeZh6/XJ0Mm87BZ9PnYn rptm+ROdQx6g41m1KRFlzRKxSV0Lz1x9FMcz5GppkCDeBAx0XyJvoGZr X-Gm-Gg: AZuq6aLBscVve1pcGyqfyBfLjSj6Il5I/imxxAfLgNTT9l6dxIyg/JalwhCJeUgQime wP1a9/QFjKUGK8Fv/8tTj2efIR56LnFO/1r/N5C/JpC9peunpw5sYdQKhlwiPCiNkZTitrUSWlP 5Z3m+fKVjJb6mqlC3e882ViPQeW/1DVivDUpGFLM8qrRMsqx+fxU0q5bRRmhQHvf1RJNdR+J5/E yIBy1lqorU8ih4xLxvQckIu5LPUeSG8GN4a1tNQ2x+AsCF+SeBSv/o5L1CLx+CT/aALVMmmbzcm 31A94wB0MlnHw4ZdNf69S5lmeoFKvtQnVWCYPNSB3/HQY7x0X1bex25du3NGA6D3tvhCn5SDYiZ Mr+sV3zyTFJCxOzLva1GbzCSYvXvwheD/bJlzbC6tCa+8WJZvZIECNS5VZkBMmXEjS1IvbDBKWi X+AzNmWNZM X-Received: by 2002:a05:6a21:6f09:b0:38b:e9eb:b12c with SMTP id adf61e73a8af0-39372106aacmr170625637.31.1770139468639; Tue, 03 Feb 2026 09:24:28 -0800 (PST) Received: from archlinux ([45.119.31.7]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642a9f70fesm17099299a12.25.2026.02.03.09.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 09:24:28 -0800 (PST) From: Adarsh Das To: Chris Mason , David Sterba Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Adarsh Das Subject: [PATCH 2/2] btrfs: replace BUG() with error handling in __btrfs_balance() Date: Tue, 3 Feb 2026 22:53:57 +0530 Message-ID: <20260203172357.65383-3-adarshdas950@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260203172357.65383-1-adarshdas950@gmail.com> References: <20260203172357.65383-1-adarshdas950@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We search with offset (u64)-1 which should never match exactly. Previously this was handled with BUG(). Now logs an error and return -EUCLEAN. Signed-off-by: Adarsh Das Reviewed-by: Qu Wenruo --- fs/btrfs/volumes.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 8a08412f3529..0e1cc0c4ce68 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -4112,8 +4112,14 @@ static int __btrfs_balance(struct btrfs_fs_info *fs_= info) * this shouldn't happen, it means the last relocate * failed */ - if (ret =3D=3D 0) - BUG(); /* FIXME break ? */ + if (unlikely(ret =3D=3D 0)) { + btrfs_err(fs_info, + "unexpected exact match in chunk tree search, offset 0x%llx", + key.offset); + mutex_unlock(&fs_info->reclaim_bgs_lock); + ret =3D -EUCLEAN; + goto error; + } =20 ret =3D btrfs_previous_item(chunk_root, path, 0, BTRFS_CHUNK_ITEM_KEY); --=20 2.53.0