From nobody Sun Feb 8 23:19:13 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B663A4F58 for ; Tue, 3 Feb 2026 14:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770127918; cv=none; b=MI3DzF8DhRmtTeV+ilqFQZAVzcqjzAeagzTxftFKMDeIklWQJXGFYzgoG7TgaueGFpCK4zpzLAGZhPLjcsoc6bjxeCSxum3u8jdt+GN30Cu2m3X7lHuphAHRIyhfgLm8MEg/TcO7x7AwsNFOVfPHaAmDABRhuviEE938ldphcF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770127918; c=relaxed/simple; bh=TX/BuBNdfcXbY7I6FBnyQtnO2IYNCp9D92IFrM4t4Rs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=F2lLt8c2l1WnbeX7dj+OWjkO23cemaLsaMQWspQqxXaliE4x8nBtVJP/JJEDUxPmAzLlDZA4OLcBAks0WTgrVswKvu/mT9iD2Qr25MzLXsiXQNkzCF61glRzUcQeEmI1VAQlFNZcOjFozY0YtQS23H0Jq0fGp4/cogIWaZhyk2w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Xx2/mPu2; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6pbbJOQn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Xx2/mPu2; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6pbbJOQn; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Xx2/mPu2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6pbbJOQn"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Xx2/mPu2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6pbbJOQn" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 17EDF3E6C3; Tue, 3 Feb 2026 14:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770127915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0RMzXHsPQlgkeAYbDLGcLFgF5Ph+Gtc4fbF+WDWzyf0=; b=Xx2/mPu2ak55Dbxq6DT8bviMY+MDKO0Nxzn2YiGxDj2MozgmuOK77lQqD13RroYFH6EOkj vQs4YqOER2OUumuTTVS4vaY9KRgs8+6ttHD0hslG95zjDEyLa3wwGUTi53j3PIyd8eqO6I yLaO0Q3qLo0sjlsGTsU1S0dFTBgxpM0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770127915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0RMzXHsPQlgkeAYbDLGcLFgF5Ph+Gtc4fbF+WDWzyf0=; b=6pbbJOQntLAl8IkzFpb4gogbh01ipertL8l3EIZLfLBBuT32b4ISt+gf3/yVuCCEFx/74C Gi8+3c9GU28ZpUAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Xx2/mPu2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6pbbJOQn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770127915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0RMzXHsPQlgkeAYbDLGcLFgF5Ph+Gtc4fbF+WDWzyf0=; b=Xx2/mPu2ak55Dbxq6DT8bviMY+MDKO0Nxzn2YiGxDj2MozgmuOK77lQqD13RroYFH6EOkj vQs4YqOER2OUumuTTVS4vaY9KRgs8+6ttHD0hslG95zjDEyLa3wwGUTi53j3PIyd8eqO6I yLaO0Q3qLo0sjlsGTsU1S0dFTBgxpM0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770127915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0RMzXHsPQlgkeAYbDLGcLFgF5Ph+Gtc4fbF+WDWzyf0=; b=6pbbJOQntLAl8IkzFpb4gogbh01ipertL8l3EIZLfLBBuT32b4ISt+gf3/yVuCCEFx/74C Gi8+3c9GU28ZpUAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ED71C3EA62; Tue, 3 Feb 2026 14:11:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Yw7cOSoCgmkSGQAAD6G6ig (envelope-from ); Tue, 03 Feb 2026 14:11:54 +0000 From: Thomas Bogendoerfer To: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Weiping Pan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 net] bonding: only set speed/duplex to unknown, if getting speed failed Date: Tue, 3 Feb 2026 15:11:52 +0100 Message-ID: <20260203141153.51581-1-tbogendoerfer@suse.de> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.51 X-Spamd-Result: default: False [-1.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TAGGED_RCPT(0.00)[netdev]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Rspamd-Action: no action X-Rspamd-Queue-Id: 17EDF3E6C3 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" bond_update_speed_duplex() first set speed/duplex to unknown and then asks slave driver for current speed/duplex. Since getting speed/duplex might take longer there is a race, where this false state is visible by /proc/net/bonding. With commit 691b2bf14946 ("bonding: update port speed when getting bond speed") this race gets more visible, if user space is calling ethtool on a regular base. Fix this by only setting speed/duplex to unknown, if link speed is really unknown/unusable. Fixes: 98f41f694f46 ("bonding:update speed/duplex for NETDEV_CHANGE") Signed-off-by: Thomas Bogendoerfer Acked-by: Jay Vosburgh Reviewed-by: Hangbin Liu Reviewed-by: Nikolay Aleksandrov --- v2: corrected fixes tag v1: https://lore.kernel.org/all/20260130111904.144024-1-tbogendoerfer@suse.= de/ drivers/net/bonding/bond_main.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_mai= n.c index e7caf400a59c..4cdf89b21ca0 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -791,26 +791,29 @@ static int bond_update_speed_duplex(struct slave *sla= ve) struct ethtool_link_ksettings ecmd; int res; =20 - slave->speed =3D SPEED_UNKNOWN; - slave->duplex =3D DUPLEX_UNKNOWN; - res =3D __ethtool_get_link_ksettings(slave_dev, &ecmd); if (res < 0) - return 1; + goto speed_duplex_unknown; if (ecmd.base.speed =3D=3D 0 || ecmd.base.speed =3D=3D ((__u32)-1)) - return 1; + goto speed_duplex_unknown; switch (ecmd.base.duplex) { case DUPLEX_FULL: case DUPLEX_HALF: break; default: - return 1; + goto speed_duplex_unknown; } =20 slave->speed =3D ecmd.base.speed; slave->duplex =3D ecmd.base.duplex; =20 return 0; + +speed_duplex_unknown: + slave->speed =3D SPEED_UNKNOWN; + slave->duplex =3D DUPLEX_UNKNOWN; + + return 1; } =20 const char *bond_slave_link_status(s8 link) --=20 2.43.0