From nobody Mon Feb 9 05:00:12 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0787B285C91; Tue, 3 Feb 2026 12:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121285; cv=none; b=IFptc8Xcw8oIHMsXZvtPTIQqIVQ/Sv2E51My54Ku22Mky/UQzCtGSDGfqcFEtJUtGAe4CIqXMyl3VYZx9rCJkB3b32Hqe0L+MIZNQxjieKMkSQlnU94wCZFnQaUCAVjQXJ3TJtt2WRFZbTGfv/He3bFpgFgRWnTyjBGHyywyHsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121285; c=relaxed/simple; bh=ig3tvpX7Zq83AA9nPx2GueGpHttdynJ7XkDjmZhhGzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CUW/VyOmblhcBn8V6Cvdx8Dz9LbHukk5LebB5npnZEL6djZ95WaAWkY9wUWjBbrJUsoK5pO0BtYcX36vYgd/vrr5mCRof7UnCxL4WY2e8dhDH3W2nm4k4caJZlC196EB5xI0QmQjmyOCLyvS8OFw3QhB2L8DPFShjI5gOeS3HQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=nIKd3vcK; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="nIKd3vcK" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6138vQ1O3652502; Tue, 3 Feb 2026 12:21:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=z4TlZ grxT3F/Y9JlB0VH0FzR30TxpQpktQA7ifB2h8A=; b=nIKd3vcK4FcYjv2Vuxkxy fuyRU6Owr+HPKaFYElPvUPogPRGdRVG5W8RO89WWcvVZ3Scn8WimXLDuvn+3LcAm eKK0I3t6V4Gp/YULtEUOhUPfbfmF89mXZetIvGqx8sx1E16ttzZx5D32YTBufCiv PNNXKNNDmYG82TgivZZ78Gg75gXFIpOYM/LmoAUuxzA376AppMnlhAuhqii3WFMB e4Q0t218/TWiGYY35/ileBmDauSHKs5v6pnCF/n4N/aF48RYkjYRRbp/6NhjJ7a3 pxbra0hjLYWAFtnY9SpxbLGY44vtt/VBWt1vygCn3fvjM83o0s7G3ml+q/EkrrbR w== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1as3bxd6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:18 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 613ARP6R025931; Tue, 3 Feb 2026 12:21:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c2578c760-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:18 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 613CLCVH024167; Tue, 3 Feb 2026 12:21:17 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c2578c70s-2; Tue, 03 Feb 2026 12:21:17 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v3 next 1/6] iio: sca3000: cache SPI device ID in probe Date: Tue, 3 Feb 2026 04:20:45 -0800 Message-ID: <20260203122109.689669-2-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> References: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602030098 X-Proofpoint-ORIG-GUID: tI3dUEKLJwfNcj9mSsve5zanBzsLn6fR X-Authority-Analysis: v=2.4 cv=Sq6dKfO0 c=1 sm=1 tr=0 ts=6981e83e b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=eY56iXQc7nrdnX74TsgA:9 cc=ntf awl=host:13644 X-Proofpoint-GUID: tI3dUEKLJwfNcj9mSsve5zanBzsLn6fR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfX+wwU+VT0CFUi eT2eyZ7de9ZM1h7N/gZpbQ8KxVJBBD1t1nR6fFijAiaq12MbkOAGbA4zSLC/EBHahkzQLhxe6kM Tx3tYfamRz8h44SdNk9YYw9RkESkFgqioIc4wvnZCa/ddxZKliq4hevbC88lTwe0luqVT+OYpIi 25HYzWOgSPvo2VpyNkyWjgZpwaY2FxV3TjIatnQ/J5W5eVmt5MOhaBQH3Axwtzzp+fUAsamUAhn nKGIDgcsTVnxNk+sYh7bCYRjK/kmvEqsAeXLtDQOZ0s4T4wzHrQE2Dfq+8qvLc86EVHk9Lbr/kX ncuDTvTi2gD0A9fWrTYIv+0sAipClhx2i9EJmoyYdpUJ18noBlceVD9XpkST3bCKirLbh3oHg22 5AGiwYqsPJtoz5IoEAnHefo7RJlDHlk9PlgUHRaa87SSm9AqxzLlkZDkaw4dDXTYXutvrA452+J +JluhYuUIg7D/m5eh31KIaAN0IqF9VtH+B+uB4ME= Content-Type: text/plain; charset="utf-8" Store the spi_device_id at probe entry and reuse it for the name and chip info instead of calling spi_get_device_id() repeatedly. While at it, reshuffle variable list in a reverse Christmas tree order. No functional change intended. Suggested-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- v2->v3: Split cachine spi device id patch from the dev cleanup. --- drivers/iio/accel/sca3000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 9ef4d6e27466..a0b431aff024 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1439,9 +1439,10 @@ static const struct iio_info sca3000_info =3D { =20 static int sca3000_probe(struct spi_device *spi) { - int ret; + const struct spi_device_id *id =3D spi_get_device_id(spi); struct sca3000_state *st; struct iio_dev *indio_dev; + int ret; =20 indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) @@ -1451,10 +1452,9 @@ static int sca3000_probe(struct spi_device *spi) spi_set_drvdata(spi, indio_dev); st->us =3D spi; mutex_init(&st->lock); - st->info =3D &sca3000_spi_chip_info_tbl[spi_get_device_id(spi) - ->driver_data]; + st->info =3D &sca3000_spi_chip_info_tbl[id->driver_data]; =20 - indio_dev->name =3D spi_get_device_id(spi)->name; + indio_dev->name =3D id->name; indio_dev->info =3D &sca3000_info; if (st->info->temp_output) { indio_dev->channels =3D sca3000_channels_with_temp; --=20 2.47.3 From nobody Mon Feb 9 05:00:12 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E297B285C91; Tue, 3 Feb 2026 12:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121293; cv=none; b=BbAQHkCMQQDRtSjzrpCEzQXtFwQt/7vKVQIDg2OiNAwf4JHxLMPLiLXpOu8uQ5SSOW9zehj0NTL5SC4QG13Zr/WwCjkmkstN0pSXvB3d7tdGocldRufMknwkIkxSy2ewb8NAjirTuLLb1e7g6LE6Bj+MzL2nFJx+FatbXNwreOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121293; c=relaxed/simple; bh=pf6YelN+DiZvBnhT4iVHHPIoeEjb3hn4oN8dCd0wxYk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=olazFH42KmPDXNKrYWA01LcV1OKo6TfncVQ/+P/tQqTmt8+YtPoJs4Heoe6psew0rI86pFwzn10kP9NX5Ua9JX7bLQbgk8iC4kTXiQ631wUOHYtSEQkntnodeO4U94v+LSIIBoJpYBp4Dl5p1NTIijFyYWIEJjWogEhGCBrv+W4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=nuiuyRFw; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="nuiuyRFw" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6138vIX23502497; Tue, 3 Feb 2026 12:21:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=2OUj0 AdwgtJhPeo1iNKZGuP6jpYnAFJRg5DLiL2QpXs=; b=nuiuyRFwedh19cTxHxbEe l8eFWx3KAnax6q3rGfsWRuGpT2ne4tsWAEgNDHGOELfrlxyNPQg+RH8Iw1OnIKZW CJyRH9avSwrM1GTehRzKvU4HGqQ+RkhcSeO3scu1KaECbkSkAPuS8oBlX7sAd1jA vKcUFRAPMmxQdBJJIClJ4YVjwh3zEZv2ovzJP2xBCc+LcjD47g0YqmEqf8Y7Eb6a i8of+pGYYZNFCyleY7IeSufkeEt3ZKCZEeEMvZkuvs1hJbzW1CIfZHC/jN/ttTf5 FIS3gj2nofbiZD/BUd4mlKY4iLy8l/cvd3G0Ige/Li00Oy1cRUWSLJnOgiaJapwS A== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1avj3xwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:24 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 613CEt7S025754; Tue, 3 Feb 2026 12:21:23 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c2578c79u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:23 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 613CLCVJ024167; Tue, 3 Feb 2026 12:21:23 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c2578c70s-3; Tue, 03 Feb 2026 12:21:22 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm helpers Date: Tue, 3 Feb 2026 04:20:46 -0800 Message-ID: <20260203122109.689669-3-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> References: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602030098 X-Authority-Analysis: v=2.4 cv=C5DkCAP+ c=1 sm=1 tr=0 ts=6981e844 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=NZMciLIDH-VbqtUZaRYA:9 cc=ntf awl=host:13644 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfXxyWrqqAMl8Ki T8t3f0tANEqnIj/KHWIrh8WFf2aFqOlqgZEe6Lvp77jes8GqJbFszkW1w5JFd8VB02HEt4/lt5h EeXGe/jFLE6uSZM8IZcdqZINdaXYLRSfm6KjDaPtTaL556UzoBZ9tbB8YxcqtmX7ZcNOMnhSIsL SBLYCI83buu0KKF0zvZ4r2EAfCXFqnSaNQ05MBCOBNRjSTKTCFCiZ1PdgzQEPsrhfrHv5QVsg0n wZpQNOEDzmPsZPnQRc6cPD6Za6bRTox5Ae0GLg28XVwWfUlb8JGe/7oheU5gZ2RBapRKctxfpv2 k0/NMmVdW/Q/feg9HhS2v5IpN941zFFrd5umyvYWuSwpdsucSsrh6DrX/KTEt8B2w+00qK80ST3 bQx+U4v1YZKFLZVoCFM+6GukHzmwUGdEPyRjjsGBlPx8QkVlLvdKM66TPUlUTGfVGLWSp5gw6n5 Pw/czLlRAAz8JyCzQdbajT2CNtfB4uYTST5Ps/7k= X-Proofpoint-GUID: gopoOb_shr5zmGQhcM6CvFGyxw1FICYj X-Proofpoint-ORIG-GUID: gopoOb_shr5zmGQhcM6CvFGyxw1FICYj Content-Type: text/plain; charset="utf-8" Cache struct device *dev and feed it to the devm helpers to simplify the probe function. No functional changes. Suggested-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- v2 -> v3: Split this dev caching into a separate patch [Thanks David for the suggestion ] --- drivers/iio/accel/sca3000.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index a0b431aff024..afe6ef61a53b 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1440,11 +1440,12 @@ static const struct iio_info sca3000_info =3D { static int sca3000_probe(struct spi_device *spi) { const struct spi_device_id *id =3D spi_get_device_id(spi); + struct device *dev =3D &spi->dev; struct sca3000_state *st; struct iio_dev *indio_dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -1466,7 +1467,7 @@ static int sca3000_probe(struct spi_device *spi) } indio_dev->modes =3D INDIO_DIRECT_MODE; =20 - ret =3D devm_iio_kfifo_buffer_setup(&spi->dev, indio_dev, + ret =3D devm_iio_kfifo_buffer_setup(dev, indio_dev, &sca3000_ring_setup_ops); if (ret) return ret; --=20 2.47.3 From nobody Mon Feb 9 05:00:12 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570163128C9; Tue, 3 Feb 2026 12:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121297; cv=none; b=CcS7jcwPklJ7cVJu6OUcShFq1CsABmacu6d7/9oZSv1e7wXfXb3tAHjVd9UNDwWgG6jmCsvCMGqYWMl0lbOtjzmXbU7NV+daATkUIUcXxvPCeNNQrCB/XK7ew91aGs0L9N7mcX7U6Mhgyvoc9Opy+L0KflY8+IpR5F2xRKMeJoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121297; c=relaxed/simple; bh=ztMNIx0tvqvr+UipuEEePalN7odo3KxrT9pZ5vfHGDg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KgkTp46UZqDYaambg64TqkxmLNXW6nPJHGC798Ekbacrp0aIdb7GG/VDoqc/2DQiOf72JdsFK/v3GMk4KzqYSf4gccntM1WpcmhUPcxA9r40m7EYj6sdwz070SoZctMIr3JiWdFGU851nQb8J0VRE4eX8ZhmRQghY9FCPdakduQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Dj0XOpxx; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Dj0XOpxx" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6138vYqT3151849; Tue, 3 Feb 2026 12:21:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=RoscS LfSDcO5bXaHcwQKGUUuXlJWouZZWarpSw87qwI=; b=Dj0XOpxx9yxvmbWA27Juh GwfCQptY013+tN+/PjZL8HKVkpXG1qMh8lFV9p3jTKwLvyERlNlNsu7x8iRUaBuK j4VKsNg8Xy8RvlSDXp48W6qWJQ/3MAhQ60ehpg1YcmOy6UG1j1G8gnb/DhJXS98O HRlgzIuLVNblPkfx2A6NUldX52ZvOChNlP6SjI8ZILOFMiReOG6Qzbdo0iFlo4dd cxHprdSI4BPdleo8UBLTjlvb9G570PW/qlH7v96yVM0m3ODqXOqEigiIztdyWRaG mDzkbCyC76Qsr2C9TT+/MPURshezNvzfWg945MbNs/LXkpj6qtlTWNZcupvbI19j Q== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1atakyhy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:29 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 613AfkFV025863; Tue, 3 Feb 2026 12:21:28 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c2578c7d3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:28 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 613CLCVL024167; Tue, 3 Feb 2026 12:21:28 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c2578c70s-4; Tue, 03 Feb 2026 12:21:27 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com, David Lechner Subject: [PATCH v3 next 3/6] iio: sca3000: switch IRQ handling to devm helpers Date: Tue, 3 Feb 2026 04:20:47 -0800 Message-ID: <20260203122109.689669-4-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> References: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602030098 X-Proofpoint-GUID: Jz1ov77U2e9AnV36r31UOpQ1E5gfYiG0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfXx2L+u7YfL93Z C9rNpph7DlM9Co9tJy17IjhYEMIz0rD8tMNQditNM3H+8IrdD1oUvD4EmchnWNMuedZIDxM8+QK Qp6ww4eOOh6YWnRRnjOnluihur83DFDlOHk1thz1W8Gjj0M3QrOhjJ1WNvGrmtvAJA5eNkYQRQ4 AVovaPgBPY1uodaG1AlEiwJFHTVuju2KNIAgJAhSIPJXWHcF7OYvaJKE75A/nD73pVQllAh45F6 NiVeggNdKGZoPAKp/bXswSNcPrhy91SAdjoCpjbZ6wWANmh9j6gkmFFLESmMXe6sC8NsWT0lVXz dwjFV8edZK55RF6yK3cO/gJaA1OuOFlsJ0ZeMgdfwYDFqiTsHcYW93WaVK48BU3yLUx1rGVcEWe bAUFWsjGZ4XV8JKxEC9/I02d1jQNGecF14ddWsmF+EpLXZ5nEbRb9qHq241sxcJYIr9R2YYED68 tc6jvZcPCfMkdIbpmrcOc6c39SQZX1NMt08t1rac= X-Proofpoint-ORIG-GUID: Jz1ov77U2e9AnV36r31UOpQ1E5gfYiG0 X-Authority-Analysis: v=2.4 cv=IaqKmGqa c=1 sm=1 tr=0 ts=6981e84a b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=AKfxoly6AAAA:8 a=yPCof4ZbAAAA:8 a=JC2FEIXQ5Z9dJjKm5LkA:9 a=4Q71d_afUUiBcdzZNBSr:22 cc=ntf awl=host:13644 Content-Type: text/plain; charset="utf-8" Convert the threaded IRQ registration to devm_request_threaded_irq() so that the probe and remove paths can drop manual freeing of irqs. No functionality change. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- v2->v3: No changes, add RB from David. --- drivers/iio/accel/sca3000.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index afe6ef61a53b..37ef724d5dc5 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1473,34 +1473,27 @@ static int sca3000_probe(struct spi_device *spi) return ret; =20 if (spi->irq) { - ret =3D request_threaded_irq(spi->irq, - NULL, - &sca3000_event_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - "sca3000", - indio_dev); + ret =3D devm_request_threaded_irq(dev, spi->irq, NULL, + &sca3000_event_handler, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "sca3000", + indio_dev); if (ret) return ret; } ret =3D sca3000_clean_setup(st); if (ret) - goto error_free_irq; + return ret; =20 ret =3D sca3000_print_rev(indio_dev); if (ret) - goto error_free_irq; + return ret; =20 ret =3D iio_device_register(indio_dev); if (ret) - goto error_free_irq; + return ret; =20 return 0; - -error_free_irq: - if (spi->irq) - free_irq(spi->irq, indio_dev); - - return ret; } =20 static int sca3000_stop_all_interrupts(struct sca3000_state *st) @@ -1530,8 +1523,6 @@ static void sca3000_remove(struct spi_device *spi) =20 /* Must ensure no interrupts can be generated after this! */ sca3000_stop_all_interrupts(st); - if (spi->irq) - free_irq(spi->irq, indio_dev); } =20 static const struct spi_device_id sca3000_id[] =3D { --=20 2.47.3 From nobody Mon Feb 9 05:00:12 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59ADD3128C9; Tue, 3 Feb 2026 12:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121302; cv=none; b=snXZFJP6ja/BrVUV4COLnbPA3h1IYHwEQ+/iFKTCCeUEAaVVQqqMfuDrtVZ4/p9gbFfGGmiqu8NvH/tid0FJJtjF1HKErdNM5u6I4czIVZZO6f00UHhp3rcYOW3qmvhkt7hXPgq9CzOQ6gmQnGlcCI2eKZKeCuEpEPKFf9E26oQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121302; c=relaxed/simple; bh=MLe9QcZxMq1fbuIvVEetAas28vucNQHvlwRamg9cKY0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=feFwXG7I7/iDnmVesV7ySt7sbuiPykg6LDisSrUhJFvfOj1upngtgn3t3sVK36wvPE2GqhF/aJlSG732AfrLN/afz+NgTY9XazjcyQQ58Kdf1sQDgoFKWX3Im7WVCkM3HkFzxeGiKgqymW7EN3f55b+rV9WulNbE5wdHCsAHs1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=qzeQzQzC; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qzeQzQzC" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6138vHmg3502475; Tue, 3 Feb 2026 12:21:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=LoglM UjcJvILlwBybRqSYvWchUorTjZaJQYjTdFo/8E=; b=qzeQzQzC4O+ctsb+Csaq+ iUZ9Z/WiurXkuO8KPrby75rHgZh3DymtgAVvviej5YmraJiYulze36JYGjEn04uI hqiM7mC/fGnEZ9gdvWr2MEnjC5avgz2UaI0HNf8eUB2V0JzgtNJ6a2rAOsY3p7C/ BTDQ95WKnq9IMeBvidMTgVul0eFv8RsvoOQTUBQ2NZWp2N2FN0hDfsurXPIoWvOb lmQ6Loc9NXMb0P4Dog7LuEM8meplFdT4J5E3G1YUqTSjC7XKP5eJ+z3GgUWpbH5U uqK1fF9+edUpU5nMnTXKEii74/xWQnpR7GrbOOlZbqMJRqm4th9KnXB8/tbGxBFs w== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1avj3xwr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:35 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 613AtI5w025715; Tue, 3 Feb 2026 12:21:34 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c2578c7gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:34 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 613CLCVN024167; Tue, 3 Feb 2026 12:21:33 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c2578c70s-5; Tue, 03 Feb 2026 12:21:33 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com, David Lechner Subject: [PATCH v3 next 4/6] iio: sca3000: stop interrupts via devm_add_action_or_reset() Date: Tue, 3 Feb 2026 04:20:48 -0800 Message-ID: <20260203122109.689669-5-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> References: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602030098 X-Authority-Analysis: v=2.4 cv=C5DkCAP+ c=1 sm=1 tr=0 ts=6981e84f b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=AKfxoly6AAAA:8 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=hD3i4eV5otfxJbFHET8A:9 a=4Q71d_afUUiBcdzZNBSr:22 cc=ntf awl=host:13644 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfXyNik+ZISLJAQ 3ulD/WdmgsCfBirLczZej12dAG+OW5vtOqS+pRp4PbfEU6pjNw4KZ8NzHQEKdU+eVxEARHjOIOh ZY1FrwecS0dvfvAla3zoebeMJT2Dr2auQGz55LowZkJ/F910vRZafYnVIQYHd8X+WKxXFnFKctA I/NY9ZP3/+LjpKbhoFhyYuGqnBpGO76L/Lmf1reKeY5I3csXJC/ddkuX1eyE0Fj1YJj6YaFVR3f GkMuGJXhHUsZKOJ56ua4+17a7VzhoGL0RtBAKOS7VdTZsg+1yXhlgEpzwiEm8lRekIDqc7XXjNc kIkSDWWWLz8i232/29tsllqfKalFwfl4H5f1d3VXPic3R6AD2ULU9RdEQs+1oRKLRSGlWYqKRyA Sf5lhMNcllrg23iANk7Hw0JDDV4oLgPISMmCKWy7OYajWyF76L64PNxQZBtHKInUWX/ViIqFhQx euIrM5w28ll4dgdUIB2NHqEZJW/mzdUzkpMXUqnY= X-Proofpoint-GUID: NASh0IjLcecdykPAybRyc2vHiYNuevJE X-Proofpoint-ORIG-GUID: NASh0IjLcecdykPAybRyc2vHiYNuevJE Content-Type: text/plain; charset="utf-8" sca3000_stop_all_interrupts() is moved above the probe routine so the new function sca3000_disable_interrupts() used in probe can directly call it without additional declaration. Used devm_add_action_or_reset() for shutting down the interrupts. Make sca3000_stop_all_interrupts() return void now that it always hooks into devm cleanup. No functional change intended. Suggested-by: David Lechner Suggested-by: Andy Shevchenko Signed-off-by: Harshit Mogalapalli --- v2->v3: Don't add a new unneeded wrapper around sca3000_stop_all_interrupts() and make it a void function. --- drivers/iio/accel/sca3000.c | 46 +++++++++++++++++++------------------ 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 37ef724d5dc5..b89439756eda 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1437,6 +1437,25 @@ static const struct iio_info sca3000_info =3D { .write_event_config =3D &sca3000_write_event_config, }; =20 +static void sca3000_stop_all_interrupts(void *data) +{ + struct iio_dev *indio_dev =3D data; + struct sca3000_state *st =3D iio_priv(indio_dev); + int ret; + + mutex_lock(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); + if (ret) + goto out_unlock; + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); +out_unlock: + mutex_unlock(&st->lock); +} + static int sca3000_probe(struct spi_device *spi) { const struct spi_device_id *id =3D spi_get_device_id(spi); @@ -1489,6 +1508,11 @@ static int sca3000_probe(struct spi_device *spi) if (ret) return ret; =20 + ret =3D devm_add_action_or_reset(dev, sca3000_stop_all_interrupts, + indio_dev); + if (ret) + return ret; + ret =3D iio_device_register(indio_dev); if (ret) return ret; @@ -1496,33 +1520,11 @@ static int sca3000_probe(struct spi_device *spi) return 0; } =20 -static int sca3000_stop_all_interrupts(struct sca3000_state *st) -{ - int ret; - - mutex_lock(&st->lock); - ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); - if (ret) - goto error_ret; - ret =3D sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); -error_ret: - mutex_unlock(&st->lock); - return ret; -} - static void sca3000_remove(struct spi_device *spi) { struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - struct sca3000_state *st =3D iio_priv(indio_dev); =20 iio_device_unregister(indio_dev); - - /* Must ensure no interrupts can be generated after this! */ - sca3000_stop_all_interrupts(st); } =20 static const struct spi_device_id sca3000_id[] =3D { --=20 2.47.3 From nobody Mon Feb 9 05:00:12 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9122C340260; Tue, 3 Feb 2026 12:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121307; cv=none; b=fLvMqbxxMUnzph9VQHXzVbuKdwPQDmRS0lhmyF94Xxh/5E4/BRCmBGYryjtHHRY2r5/2zOTT/H8y2u1HaWumWhPUibChURdSrbDEdY7+F6tsf+zHGzKchJUZtzolB6hQnPfVGHt/2VfLuBZ53Q5+rrsxanR9JWBLAsdKd8gvejM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121307; c=relaxed/simple; bh=euZ6aA5KaZG4ZNnU99hJ1Z+PyEZxL2Rl193wCsx8o6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ezCqGn6zDIJ4i8fXhKqcr5pz5GwTLWjXoOc+CGwL77KdyG/TlTIkvGCKB5o0rs0WrFVb81nLMKKCQsTxB6jTPklpd6ZDhhtN493aI91PwmQIg//6iIeadb3cCItWvpPKJ9SFM+3rTgKAnpNZlKl97eT5lHXfAaRdva4habpuu44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=qqH4KLrs; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qqH4KLrs" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6138vI7j3652180; Tue, 3 Feb 2026 12:21:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=6a5xp UUJiqwl77+bCTkDynAEy3biBrrr7vNEAzZ/O5g=; b=qqH4KLrsO47yVjq9m0UGv peudQ5O2ffM4gV8Iw+hm7F+ClZJTr8nfxbR1yfmQKaTjSj/cakkd3713ahilhW9+ cOktdP11qVO/EI3l+zF9mWbnrsZboWo47kGBKoifT72tkqjo/QeVIopRqyJvMMAt w2NQTmv4b8J2mn24yi/nFzeHLRqPmhRzadDFsEZXYLkDcyQ6l4Xas9qBRG0dkLkb aW2Tt1IpRqsn3WHBfBdf5OyCfJFbPafncP99rUiqVIy5S8fqH2yACZtfoL2usrv1 V8mgqeCOoNSuIcJffZNG9C4CFxvwVRS6/OqCccMtpXeRXIL8Z65JPAUXNmPYF52F A== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1as3bxdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:39 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 613CKAHq025619; Tue, 3 Feb 2026 12:21:39 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c2578c7ka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:39 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 613CLCVP024167; Tue, 3 Feb 2026 12:21:38 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c2578c70s-6; Tue, 03 Feb 2026 12:21:38 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Antoniu Miclaus , Andrew Ijano , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com, David Lechner Subject: [PATCH v3 next 5/6] iio: sca3000: manage device registration with devm helper Date: Tue, 3 Feb 2026 04:20:49 -0800 Message-ID: <20260203122109.689669-6-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> References: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602030098 X-Proofpoint-ORIG-GUID: qmz79wo84GpJND0luVZE-IA_KYQXdpAh X-Authority-Analysis: v=2.4 cv=Sq6dKfO0 c=1 sm=1 tr=0 ts=6981e853 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=AKfxoly6AAAA:8 a=yPCof4ZbAAAA:8 a=TX5tIiqRz0IEpTnFED8A:9 a=4Q71d_afUUiBcdzZNBSr:22 cc=ntf awl=host:13644 X-Proofpoint-GUID: qmz79wo84GpJND0luVZE-IA_KYQXdpAh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfX8q0di+liu39r OGYee4ox6YpMKb6KN0xzNJYiwmN11j1y9mD4nSQaubv712J4cEDMRudwaXIBvm2mJuil8/NGvSX HpWtQRrI6OnEgTZ4RDsVQt0YBgVwYxfZNh1wnGd6doXZVr4ZyujDhgeB027sJv0Ku6P0dFvan9/ KBIGSkEAT9svoWZ1FJaiQwOkU0HjmDfpMgL8xjOqtstWQRsrr+P8ky6MxgKtrrIqyUhwBmi82EK kCQqQ8sJ5AsSStmE2OsAUD3G3bOOiWp+tcatnSzCHIPwBosI7JSYve8ZMB1/ZbxFyFFR1hqF/f/ gJex/u30m4Q8HvB2HwocyRFTpPvFqa6OZc9nsvn9hJRSWQuV9nfmS/qFsCgBvadKZLMJHjwlNJc k+scovqU0/Pjm/2JLR7JbXIfW55ph80b0P5xVz34Q0rIlXUZXh34kD/wvyXCVHMnfgYCASECT8p K7qFfkM1fxIg+668lltStsM8orICry4HdqqhEUdw= Content-Type: text/plain; charset="utf-8" Convert the iio registration to use devm_* helpers so the probe no longer needs a separate cleanup path and remove callback can also drop the unregister. After this there is no need for having a remove callback, so remote it. No functional change intended. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Signed-off-by: Harshit Mogalapalli Reviewed-by: Andy Shevchenko --- v2->v3: No changes, add RB from David. --- drivers/iio/accel/sca3000.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index b89439756eda..419c30453805 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1513,18 +1513,7 @@ static int sca3000_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D iio_device_register(indio_dev); - if (ret) - return ret; - - return 0; -} - -static void sca3000_remove(struct spi_device *spi) -{ - struct iio_dev *indio_dev =3D spi_get_drvdata(spi); - - iio_device_unregister(indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id sca3000_id[] =3D { @@ -1541,7 +1530,6 @@ static struct spi_driver sca3000_driver =3D { .name =3D "sca3000", }, .probe =3D sca3000_probe, - .remove =3D sca3000_remove, .id_table =3D sca3000_id, }; module_spi_driver(sca3000_driver); --=20 2.47.3 From nobody Mon Feb 9 05:00:12 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71357340260; Tue, 3 Feb 2026 12:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121311; cv=none; b=tKnC/8d0fv/2CWGcRNsbIq1GV71FUzmc09DQVkPbmlY9Ajr56Cw9rYPyJy8ON4tCvS1gziV3Jglsu2M2shZUtO86i4qwBFKhg8eKWd0BmEMimgMFF24oeJO0wLN82KLZ+It3eprfnm3T7nKywojghplXFk7Qqi5La/LYC3uozeY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121311; c=relaxed/simple; bh=AHn1T0h9AlDT9ZjNbLSIAf6/10nKBYK471R/fQzK6b4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ri7UdwKn3VYga9TyqDqFuobT+G/PyUirNXfvbciv9DpUXFqMsEAOA34ZLbSOzJJg/t7sRey7yewkE8A6kLABCEVFwrhaX5ywcIJirRNwxVCYfSQ88O6G8nueF6yXqXSJdKfFOAN1he/oaKdw9ZWvRaP3/eMfxdke7W7LdRAiPP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=TtSKYNso; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="TtSKYNso" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6138vFpm3765849; Tue, 3 Feb 2026 12:21:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=KMqjR EqVc0bVJnnFgsqhJuHDUPxDk+ExKpMUFEyzbZg=; b=TtSKYNsowK0shBWZyvpQr bXEjJnwXk5acPESRBiFQoGtqoUAsW7zgwC06kmbUhlRTh6P36bgaIkxuj7cMxwYB fS+kv7ScNjnVTZrj1WUTmf1CFGayX+xL5z5W25H4OFl1hS2Y8O1J6GBHDYVGgn2q aV8UTk/pd8Md9UNuliWpKlU3F30jczdEc/K6SAgraEU9RY9czSQcFacRKEn0wztg fxHCvTqJ/tii97ZpZl9O7UAAdXEI2MmIdsqfcdsTT+cUttE3YEJhmjqzMj/7jQ1T vX7cD7ueZCU5YAf9BtpCy3Q4Qb2qiO/w1TmxDQWyrtpMTutZpOzEAKpV2kSl4AC4 A== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4c1arhkwsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:44 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 613C16Wn025691; Tue, 3 Feb 2026 12:21:44 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4c2578c7nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Feb 2026 12:21:44 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 613CLCVR024167; Tue, 3 Feb 2026 12:21:43 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 4c2578c70s-7; Tue, 03 Feb 2026 12:21:43 +0000 From: Harshit Mogalapalli To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Harshit Mogalapalli , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com Subject: [PATCH v3 next 6/6] iio: sca3000: use guard(mutex) to simplify return paths Date: Tue, 3 Feb 2026 04:20:50 -0800 Message-ID: <20260203122109.689669-7-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> References: <20260203122109.689669-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2602030098 X-Proofpoint-ORIG-GUID: rlMIRkHzUoexBGaq3p9QgOieW-z7uZYq X-Proofpoint-GUID: rlMIRkHzUoexBGaq3p9QgOieW-z7uZYq X-Authority-Analysis: v=2.4 cv=fdmgCkQF c=1 sm=1 tr=0 ts=6981e858 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=Fb_YtQGqNHn76Ybc1w8A:9 cc=ntf awl=host:13644 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfX8RgFDg3yRRe3 8naB9mZR84h8DFQiQ/xmcVzXysC3JaTUC7tLdYdU6jHBIPNnw1fU/yvfKUS67vwzLVOLX6YtSbP BYnUAJW6Y0UdCdWshvFR0H4JwRvvFpZR3KdlnlIYjRFbxU8Ne1m2e8CroRrEc0Y9zQMZRFATh19 m+kLlajM+ZjJTuyzce4WS1HMcHpxw96BOWaj3GenEDCOen+f48kVl5pq5kddnfKJqUz14Q6qBXW 3Md9tpBoGV8mDKXVQpAZjg9fddm3T9zYvR5qqIPBJWwZoMK+qINjRpLCer5bLzNd7Bdq6gclmRW GgNBAGH8wYsW3JOkMPDSpw0ty6X29LYaX361iGwsDLfMo29xRblYr8FN8F0HSPa0M/cKLsyjM8d ewaLePgYAnpk/nP810XER3uckkOag/36pILggx03qp22BP2oU/bQf0fp9WlvFKy17CV+K3V7bkx Zd+WTa9QiZrS83KBc9R7Ludl/WJ19Br4BW9WiThU= Content-Type: text/plain; charset="utf-8" Switch sca3000_stop_all_interrupts() to use guard(mutex) to simplify the error paths without needing a goto. Suggested-by: Jonathan Cameron Signed-off-by: Harshit Mogalapalli --- v2->v3: Had to rewrite this patch as we have changes in patch3, Also mention using guard() based auto cleanup simplifies error path( Thanks to David for the suggestion ) -- didn't include RB of David from v2 as the code is slightly different now. --- drivers/iio/accel/sca3000.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 419c30453805..307e51279cb6 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -7,6 +7,7 @@ * See industrialio/accels/sca3000.h for comments. */ =20 +#include #include #include #include @@ -1443,17 +1444,15 @@ static void sca3000_stop_all_interrupts(void *data) struct sca3000_state *st =3D iio_priv(indio_dev); int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); + ret =3D sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1); - if (ret) - goto out_unlock; - sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, - (st->rx[0] & - ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | - SCA3000_REG_INT_MASK_RING_HALF | - SCA3000_REG_INT_MASK_ALL_INTS))); -out_unlock: - mutex_unlock(&st->lock); + if (!ret) + sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, + (st->rx[0] & + ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | + SCA3000_REG_INT_MASK_RING_HALF | + SCA3000_REG_INT_MASK_ALL_INTS))); } =20 static int sca3000_probe(struct spi_device *spi) --=20 2.47.3