From nobody Sun Feb 8 20:33:03 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FDA2D94AF for ; Tue, 3 Feb 2026 11:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119345; cv=none; b=Ry+0JJ1JhBaPF2brcNG1kSq3x4FK2Uz7h0SN4aGUpVa81RRF5gWEzKj5A6dLngU6YhSWxwaGHDxx+8Gkb0GqzUxI1JdSnX+PHiQmDPD2TMi1Zhrr4VyDalapHGqPmXzy/Bl0MtROBON2oKg2hvEqai+cOg08rEG7/DtyvQmH3mM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119345; c=relaxed/simple; bh=IqMRuouYKplCpuBL4+LEX/kT9JKSXiQib3OML5jseRI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ncohojJeI3kiPZmto0enWknduPwviySqQRK4t3dYCjY/kt+cKOAMABmgoxWczL5P0fCfXqYdHAoxHNBRz9W43nhn/XhFbwYrSP8uX6zw2mS/vESxM/KnbBvafuteSWEqmgRRuo4Vy4tL1I+OHrxu/QsiV4lo2F/m8uso6zj/6vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GzXeBY7v; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GzXeBY7v" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so44940745e9.1 for ; Tue, 03 Feb 2026 03:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770119343; x=1770724143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z4FvJLpGt0rg4WG2VihKDDJ7LuQY5vf0sYtnb+B7S6Q=; b=GzXeBY7v4zl8+e5t9mOOdmXUTMqU4yVISRFeDPz3XZPD+jgVsdIoqZi6vRi7amUXxx /f74+PR1g20affA9ZKUX4rXRcoPq6EgfD4208lAI4ojYeGnsKu038aEscYdhsGyFzy0e fYWiQz7jd4KNM6PFbeirmSn9rHlAE/Pc5xL9inR/XC+BBgN/ovGImbs0xZ4xmCwZ8atx 463S3LOEyQ3ldGoYLaM8SPrJgASMRahOSmkL6iqYxaaESWj2AJhfHP5sGfbjnjkVO8FV koU0ONXXed7gLFAFenNQ1WbpcXVvNS/iLQ1PopSpXF94OnWSXBAhgEbbCkHF6icITxpq 5GHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119343; x=1770724143; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z4FvJLpGt0rg4WG2VihKDDJ7LuQY5vf0sYtnb+B7S6Q=; b=aoioMFrYkIKbCDK3DVGUZT70yTQee44YFGzXDoRxTT7m76BjeE0iYJkCRWy2dDROLK c8k89KspTofv7yM5OIj9wB8+tNId2zbwLbjlRxvztmsPC5OxXrvj0EqsUDiLrB3KieFB JFOGYpVzwb97hmnyQ1YLnG5GtmOGPFfxoqJvA1J7msCZEZnIRGx0+CjwTDiBjKv36ych Uy0UIqc92ISazmgzkuu36pdoc2sgPFYx3Fq1wBmciAoxRepJOJVdLORY2WeOd6KBY3Xi kC/lDrbrUbC2bbXwDfipl6xc3428KdJcoEE3ZlwyzVxKBA3HAb1qgddKuS7F8YzP9kwO sLXg== X-Forwarded-Encrypted: i=1; AJvYcCWC7vZ4vwu9qmKZAGGHVG3phn6uAeNDFuTpk44IsZGawQB1B/4kU53sDFPy3EMOgoIqAXIcE3CvGka6P3E=@vger.kernel.org X-Gm-Message-State: AOJu0YzczI8Z6SegRaZVnEfxypOke7kcfZhVgYL/y8eQPPdL6a7ZsEOT KJ1hYnkh9dSlv/S0GfaEOo1di1HuN/sXT7QSmAYvmraDrgxwW6Waf8KP X-Gm-Gg: AZuq6aI+ECuRAY6jxts8sl4BnRbF6iJE5mj07f5pm8TKHEXCojiqppTp2JgmLYbCibj QZ/ssPMLdR3rJE4oigU3OmBHfXm1CFDC3r569SrU1sWkPJIW0vHUSPUjScLeRsaCYUo6/QS+kW/ pjCASk7zfnfBZssobOApl4/dHZhZ5LxUoeuEVY59ryPCdwyb/y3PtyQ+S8vfEiss0Ve6RlsHp0n QUnP4xoKLk8zeeHyCsQcsxGeQFMshBfKVr0q/iohGL4dDLyYUIE3NkZfSqbB2Vpk8lzUkVIiykW Vvd6114RJ6CDSKTxFYEjNkcbGx22cm3u4mpdVF1TdNuAS8B/08lunSrX6OAHw7qx0PI2XWxjeNy 05x58kLvl5nqQm41x6vJd89KwVUjau1OCSSgoOZ4vRkvm2sDL3/NCHKWlG3SuRpvQPhlzr38hwa zuUr+QFs7YjFxxv+w5GqMLxE5umTliAjmcBZ+8LKC4CloUuAGiF2FFlyvB+ck2+X5ePB1GvhbRb DvaHDWH/98= X-Received: by 2002:a05:6000:1868:b0:429:c851:69ab with SMTP id ffacd0b85a97d-435f3ab2d43mr19870372f8f.55.1770119342363; Tue, 03 Feb 2026 03:49:02 -0800 (PST) Received: from localhost.localdomain ([31.206.212.157]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e13235f5sm48418880f8f.29.2026.02.03.03.49.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 03:49:01 -0800 (PST) From: Baran Arda To: gregkh@linuxfoundation.org Cc: ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, baran9arda@gmail.com Subject: [PATCH v2] staging: axis-fifo: fix sleep while holding mutex Date: Tue, 3 Feb 2026 14:48:58 +0300 Message-Id: <20260203114858.28278-1-baran9arda@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver calls wait_event_interruptible_timeout() while holding a mutex. = This can lead to a deadlock or poor performance as the mutex is held while = the process is sleeping, preventing other processes from accessing the devi= ce. This patch moves the wait_event call outside of the mutex lock in both = read and write operations. Signed-off-by: Baran Arda --- drivers/staging/axis-fifo/axis-fifo.c | 30 +++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-f= ifo/axis-fifo.c index 509d620d6ce7..a651c59a80ea 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -197,11 +197,10 @@ static ssize_t axis_fifo_read(struct file *f, char __= user *buf, goto end_unlock; } } else { - /* opened in blocking mode - * wait for a packet available interrupt (or timeout) - * if nothing is currently available + /* + * Opened in blocking mode. Wait for a packet available + * interrupt (or timeout) before acquiring the lock. */ - mutex_lock(&fifo->read_lock); ret =3D wait_event_interruptible_timeout(fifo->read_queue, ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), read_timeout); @@ -214,8 +213,10 @@ static ssize_t axis_fifo_read(struct file *f, char __u= ser *buf, ret); } =20 - goto end_unlock; + return ret; } + + mutex_lock(&fifo->read_lock); } =20 bytes_available =3D ioread32(fifo->base_addr + XLLF_RLR_OFFSET); @@ -340,27 +341,26 @@ static ssize_t axis_fifo_write(struct file *f, const = char __user *buf, goto end_unlock; } } else { - /* opened in blocking mode */ - - /* wait for an interrupt (or timeout) if there isn't - * currently enough room in the fifo + /* + * Opened in blocking mode. Wait for enough room in the FIFO + * (or timeout) before acquiring the lock. */ - mutex_lock(&fifo->write_lock); ret =3D wait_event_interruptible_timeout(fifo->write_queue, ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) - >=3D words_to_write, + >=3D words_to_write, write_timeout); =20 if (ret <=3D 0) { - if (ret =3D=3D 0) { + if (ret =3D=3D 0) ret =3D -EAGAIN; - } else if (ret !=3D -ERESTARTSYS) { + else if (ret !=3D -ERESTARTSYS) dev_err(fifo->dt_device, "wait_event_interruptible_timeout() error in = write (ret=3D%i)\n", ret); - } =20 - goto end_unlock; + return ret; } + + mutex_lock(&fifo->write_lock); } =20 txbuf =3D vmemdup_user(buf, len); --=20 2.39.5 (Apple Git-154)