From nobody Sat Feb 7 18:15:41 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DECD39A806 for ; Tue, 3 Feb 2026 10:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770113228; cv=none; b=L/I2O/ue6Qbfm32DqxXE4WeKckA4fwGMpseGyALQ+VhXXZmNNrBk7JFLrLZs5jVjB8rrUgMMJBCnNX36bNuWG0luMRWJ0Ez8gcxYgivB+Rn8OidmswbUtwboBuMBbxIegfXsDm6RRHR/e1uy31/qW9Dr/dcs58if/16uY/j1oVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770113228; c=relaxed/simple; bh=riJvnc+Unu3IXdR4AYqpnasGE/IHX7nt/XAtS81ytzU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RCl/VV4SpsBU2WcRiI04DMfeusNCiVo+6HeqatTcUiO5h1x/3KeIDqZavdfd4x2ju2TPWuvw1aO7eAcRQeaKw7HWTejcHHZa+jZUUHt+6AEglurhFxnM9U6kPpKpDf6dr16PsFkbW1v8DuETDwvWj76cblloP7AVoUUcqdjva6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zfs4ucb+; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zfs4ucb+" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-81f4e136481so2699373b3a.3 for ; Tue, 03 Feb 2026 02:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770113226; x=1770718026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ytu8gh/aYEOZ6u1ee0366c19xW+ZKOkFx/f9DalfebM=; b=Zfs4ucb+6jfbhkytTRf/beXOQvUOucf3D85VojngF4qF7zIRZ+AxoTeJH3KP4TRpEd 5p5cIycM308zUIzYTPtcJdCM2OFAZ80Keo136FpWVKH+MNeBf29wUaDKZH+8KKtMmd7V R2xesC2ooRykVb6DqmVQmkuTcLxQqeh4h3wP9X+5LyKwhwZFppu689QerPnGWO7GAv1+ gE1nbHV/1IPUwIE2cTPNyi7M31Rwb6MTeIcgERfw2uEsfjOBKLCtn6cRcIANeeOaWFPv DkKhTCBeqd3h5cnRmlRmZQz4y18CnqD0zjBZGjHWZM5Q8i40FZOiQRv4MegtRRUcWjJs avQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770113226; x=1770718026; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ytu8gh/aYEOZ6u1ee0366c19xW+ZKOkFx/f9DalfebM=; b=qPwXPEyB9RJDUOZehGaWERZnul2eiRpWn9+K1xvzouTSAHe9YVpNW4TyNetsimIxG1 EBFCj7oZOhtnNrTXcLf6tPc545H4HwxWQ9tcuhdqeSRhxmWaiyFapj8Dn1YSs/+eJWU3 UpjklygTNFHQPWuutVC6zUmO7p9zgFZtcjULhXj0DSp76SIztU8ezdJuEfQgDQMNlSqL QwyfzkVamzbGemvYLPGDhwiHGE2b9duXO5e9HV6IdyBq95TW8tJCCrxhswCyc3lTw8Ej Zwv/yT39B8ep79orhx266cwukOozLEOx37DBI/o5XKRpu1Ig7RlQkKsYcJzP71F2MgTH P2SQ== X-Forwarded-Encrypted: i=1; AJvYcCXyImArWxD90Lmp+2cbQzvpDwMHCL2JTLghwjq+mYJSRBHluUNQ3NIzeTBAgrG+INRk+uNBV6gUyiyNJ9Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzrBQBxh8HWza4lMB1b1iQPqn3Ib8jZWqATDhtpclxh4Lv5c0Mm 4zOJOZO6IpV514TI5VZ29SZ891K2qKe35e+r5g089u7HqH8UI0cuumo9mGpaBLM= X-Gm-Gg: AZuq6aKO4HMMkaEaT/saDCXNrYkTiyiJ808ugQp67rilwg5QUJtUPVxZFnPa5oi7ypv DsNClAN2j4a2N3YKbgQsR3heCW1c4Ea8BvMXGmGU4GplBkJ9LkqMmWBEQjUWZK2PV5PUdiMfAks ROqbW4LByeYNnYmiaKX5o5DT34vEmGyroV9xv+TxCUgcXZ9G91yZJWZkvFJF0f9wKuNC+PLFaq1 dR8FOF2ux/BKHA/QxaEk+d2w2xQVMDXiaLKNgqySik4r9e6YczN92+BFncsGQGoFmFGY8vVKUUk YZazy0NI2vb9eGeWpMUnqRAga72qZuXkOFcX+LEF4hh8mHxZCiFCQ3LLMd1LnOCif13vyKnPqbv 84WXd/GmKbc6kSfTtoWsohAPQrYc75IAAbmSnWY1mo40ahPYNcqvRG3cvQExfKTQ4ybe3uFqXK/ gu7iFw4XM3C+mocmM= X-Received: by 2002:a05:6a20:72a2:b0:361:63eb:d024 with SMTP id adf61e73a8af0-392e003b230mr14730514637.23.1770113226424; Tue, 03 Feb 2026 02:07:06 -0800 (PST) Received: from at.. ([171.61.162.208]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642add5199sm15814180a12.31.2026.02.03.02.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 02:07:06 -0800 (PST) From: Atharva Tiwari To: Cc: Atharva Tiwari , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] apple-gmux: preserve brightness using EFI Date: Tue, 3 Feb 2026 10:06:58 +0000 Message-ID: <20260203100700.2223-1-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make apple-gmux save the current backlight brightness to EFI on shutdown, so the brightness level is preserved across reboots. EFI Code inspired from drivers/input/keyboard/applespi.c:1589 (tested on iMac20,1) Signed-off-by: Atharva Tiwari --- v2: - Used correct size for efi_data drivers/platform/x86/apple-gmux.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple= -gmux.c index 1417e230edbd..20fdebdf3c58 100644 --- a/drivers/platform/x86/apple-gmux.c +++ b/drivers/platform/x86/apple-gmux.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include =20 @@ -107,6 +108,9 @@ struct apple_gmux_config { =20 # define MMIO_GMUX_MAX_BRIGHTNESS 0xffff =20 +#define EFI_BRIGHTNESS_NAME L"backlight-level" +#define EFI_BRIGHTNESS_GUID EFI_GUID(0x7c436110, 0xab2a, 0x4bbb, 0xa8, 0x= 80, 0xfe, 0x41, 0x99, 0x5c, 0x9f, 0x82) + static u8 gmux_pio_read8(struct apple_gmux_data *gmux_data, int port) { return inb(gmux_data->iostart + port); @@ -1012,6 +1016,27 @@ static void gmux_remove(struct pnp_dev *pnp) kfree(gmux_data); } =20 +static void gmux_shutdown(struct pnp_dev *pnp) +{ + struct apple_gmux_data *gmux_data =3D pnp_get_drvdata(pnp); + efi_status_t status =3D EFI_UNSUPPORTED; + u32 efi_attr; + u16 efi_data; + + gmux_remove(pnp); + + efi_data =3D (u16)gmux_get_brightness(gmux_data->bdev); + efi_attr =3D EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | + EFI_VARIABLE_RUNTIME_ACCESS; + + if (efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE)) + status =3D efi.set_variable(EFI_BRIGHTNESS_NAME, &EFI_BRIGHTNESS_GUID, + efi_attr, sizeof(efi_data), &efi_data); + + if (status !=3D EFI_SUCCESS) + pr_warn("Unable to save brightness to EFI: 0x%lx\n", status); + +} static const struct pnp_device_id gmux_device_ids[] =3D { {GMUX_ACPI_HID, 0}, {"", 0} @@ -1026,6 +1051,7 @@ static struct pnp_driver gmux_pnp_driver =3D { .name =3D "apple-gmux", .probe =3D gmux_probe, .remove =3D gmux_remove, + .shutdown =3D gmux_shutdown, .id_table =3D gmux_device_ids, .driver =3D { .pm =3D &gmux_dev_pm_ops, --=20 2.43.0