From nobody Sun Feb 8 13:53:42 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF9638F24B for ; Tue, 3 Feb 2026 07:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770104299; cv=none; b=oTD/OtWezYA1mRDOaMWaI7WY5z+2xHrWpdKrndP9fr3TZf0PrKgD6QgD3fs9XECyGbgZsOFe/Jx2i+iiRuzG+f3VjdZ46rsFI23ZN1bRNtaLP3JEsq7wHj5QLgo0JvqpOlO3s4ErP2/jcAPRVvv5GvX+8wgz+ffWs0nbJAwwnlM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770104299; c=relaxed/simple; bh=EuNsIZAZDJIiEUR+UVFXz0/7IV49tdQ0vLj8jcDYzHI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KZKQ3i4/ygGYAqZkR34OvK9p1j6407S2WnvoI6U0wLBE6LQ0NAOq5U3LP9ZGzYvdUx/EoeBRprabVOCYHJYYBoYaLtYFzwonaP8qNHXYHoDohYjAOovYVwa4WJ/qIWbR1Zy+ruNIYENQyIKaNGLJsz+AUGHhZ3dCWPYqmUZEg9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nJqKq3v0; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJqKq3v0" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42fbb061a08so408844f8f.2 for ; Mon, 02 Feb 2026 23:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770104296; x=1770709096; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wpdgeRL7F9zo0n1i2+iruTJGYYg1hxclEOCr/JSZKig=; b=nJqKq3v0bmnqv0qBKa2DO3Q8CwFnsQfI0THjoehIQd70MJAY+Tjzbue7AdOyz8J2ae BJfmLZg6A7QAaEyaOXXkBZH2SGFTvDJV5rCVGPlwiOmMnyfvQE8jDw4XKG+o2OFLOhup uOJflKAphYkgNle+/n7IrWSwkafynTIeT/TorDHXHYuxlJNP0Mm96dsJV8ikoa7EHiQt 3rsAW6nTCpLiV1TldKZ9xiiKfmrljqhuw/sVOkpSIhFr6G2SrwAfkzqNS7JRczSjOBA+ fxj/Qs4Gk4bM2QyRJN015a9kApAnSPv0BrVwatnz7nPj9DmH+d01V4fCWQKWuaj8RVyN /GyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770104296; x=1770709096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wpdgeRL7F9zo0n1i2+iruTJGYYg1hxclEOCr/JSZKig=; b=JV4NGzZTQejAlZ3cuWko8Rpmxt8ljSYpbvMANxCglc7WqP5cUupavngMFDyhI5rJjd c5udH1deGoyjiV/DivnaDO+6kbnjcZ4cZPQJYltM2T78z78v+jJ7zo3jxOIioZ9ijTcT Sd/mZdHVTVD6cRGZTDej/x19Qvt+X2lXFIXwzmI89FHb/fKathI48YLjskWurcEe6aP/ NQiJTd8rJK0gCVNhL8L+LqSi8gwdz11M2MpF3z2DwsodX1xGdXUGlS0cBjAvAR3+6NWd GTocqz06KHXIFsyExAi1D+Rrpyn/ouBd9RXjfvXWoEYehafQ7johBGCOpfuePlveE6jI lgkw== X-Forwarded-Encrypted: i=1; AJvYcCW/dq7uJyyq9qbLvO+78yBTN6NbHb+MQq4+rlWHfTMBlbDDOqfrQ0SGNOyYiWUgxXj7a+4S9HVsnuhAT90=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2lbsuM/aXAiXq1BKZQK68R3qUepsS86Pf/CGFFXuSF4slCPT8 dSvuW09/zXmvufhCem1vLNd4W0cg4tpFVv2rPIQOsDE5SpD0u+o6D8dc X-Gm-Gg: AZuq6aKeMAgAhMqh8sGbtCL61t6qA/a8mU1053lA90h73RXRrKt4ol7oGlzSlOz7KR3 qtU1w/04N9tfw/MolNAgLCTYOs5l88cC3dJA+Y3058SK+0L7dhrs7h+hyKO7u97xDJax2Yq+mpo 1DxXibPbtWakHVEKM3IYCkdQyQoennzX0RCS321SDUsvOsTgtOHVOXl6ui5U7JIleVR0fceaMKc fSD5uYwOq1V17pNdQC45zvZtsolBnueYtBXKep7eMceTR55xMCqXYsfyi39AGeM4GpplB/Vjoly +kQhm+pLDvqfa2uuguSDl5Od0/5Bv7uDIUFa16MkK34h3Qx3NocHeAhjPtVBCd15flGjfM7QnoM BJoCYc7KrES9Tfj/+dsAKWl+Dzd/FjEW4Iw/+jiJKyvI1ZhZw3J78QZiPYvRHkxbHDjFmugoQDu deVY9bdb7Kii8y9eeNhXljryp9PfShuWtJ1nt/8WrKpMmWcFQdKnE= X-Received: by 2002:a05:6000:4305:b0:432:dfea:1faf with SMTP id ffacd0b85a97d-435f3a745e6mr12908383f8f.1.1770104295993; Mon, 02 Feb 2026 23:38:15 -0800 (PST) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm49530496f8f.16.2026.02.02.23.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 23:38:15 -0800 (PST) From: Giorgi Tchankvetadze To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH] staging: rtl8723bs: Remove Yoda conditions in rtw_get_cipher_info() Date: Tue, 3 Feb 2026 11:35:18 +0400 Message-ID: <20260203073516.20175-3-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert comparisons from CONSTANT =3D=3D variable to variable =3D=3D CONSTA= NT to follow modern kernel coding style and improve readability. Signed-off-by: Giorgi Tchankvetadze --- Note: checkpatch reports line length and "spaces preferred around that "+" warnings. These are pre-existing and I figured fixing them was beyond the scope of this particular fix. =20 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 8fdeeda88a6d..92b12a13d27c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1009,7 +1009,7 @@ static int rtw_get_cipher_info(struct wlan_network *p= network) pbuf =3D rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork-= >network.ie_length-12); =20 if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS =3D=3D rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &= pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher,= &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; @@ -1019,7 +1019,7 @@ static int rtw_get_cipher_info(struct wlan_network *p= network) pbuf =3D rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwor= k->network.ie_length-12); =20 if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS =3D=3D rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher,= &pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_ciphe= r, &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; --=20 2.52.0