From nobody Sat Feb 7 21:15:26 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A5F33E7 for ; Tue, 3 Feb 2026 04:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770093977; cv=none; b=kt9yzShezi6GfvDODRElQ4yeYMOpw2HYoF7qPdgAR+QYrBfeqy1MhqlQPlqrCMvkYNlj0EghvzJAGai6I68UOaN6ayOvqeHV9pLZWYUdCYe++jrIeu0VFNoT8SJpwcSEDvtVIO2EQbQAYQrIBB8hYXwlZffk+PCbBigtxT+vtnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770093977; c=relaxed/simple; bh=L5mRtZCNTw/pb/LuU3ijjoDu0j8XJnsha/nFP9FcTSM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cnhuwNo0uBwHkgtrP1jJYj/JnkLUongcfe/rD7RtwrJbXMb1OSTZmWXYaB9nU7cbxs7AJ/UTxUqWracxEMzfi7izAygzeDBhGlhiopE/RU4/cuOrWyc95vBxwodsvuJJ0i6isgsxYZkD0gHkqw+ooV/zJaX5ZoweHYdb1uFQ8CU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I6tNDTBk; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I6tNDTBk" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-34c21417781so2710318a91.3 for ; Mon, 02 Feb 2026 20:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770093976; x=1770698776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZobJJVk0tGhhuV5Q0krVd0tD0RSKYKDKRZ6H7tjSRA0=; b=I6tNDTBkRDAQTpX7hyIo4KFykP2WlgWnBsJiOZTzK8Kf/fSag4mXk5bPYYEwmkJdcm Kxtp1cB2B9Pf3hoakspI/UN8SK+UXRDPbSka2Vc0QGidXMx3WPFMxV80CEA8cXHoiV0n c8ePF5HH7A2c0JfbX/tVSe4m7dTbKbXzlMXcZrwQ9W0YTpB/BKTL1CXvmEUo3VumYLQB liE6txCseMO4W2h9b5uBvV3F/cRjF6xeFFosk8/iM4Ch+JEdTY7bbNz7gEBiQFnIFKud cn4E8Zna558o50SiwB7NkGPXdIhgbY4TDuoNG1N2uK1MiFv/9DJT4FTNozelJ/JHHm4m tu8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770093976; x=1770698776; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZobJJVk0tGhhuV5Q0krVd0tD0RSKYKDKRZ6H7tjSRA0=; b=Cffbx3pb5/Af/LGVUB4RMrJq5cch61yGRXCpQxmCldYqsVcK2Y3lV6zmacABuYMSUq mCnOlObHLf8sLnui/mV9YWLWwZUhpsE28/IQR55BPCHzbWG2ki0X3HRFHBLFo3khrODt DkZRF3NGirNe4O8436My/A+x26UvluEeuqZA2r3x8P09CMWZvM96GybC5C2WlRU9m7xA rRPBuYrT89PPtJ/gTKF2yvnrW8r1mmbOMa/lAfzieSW1cZOPw5NIKlOCpD34FJU/S87n jM1hLSmQWQxrtl9vXTAyJXXij4Ocm0EQxETSC2QuYIUf4oFhjaIi6kTM4oFyVP/LIp8S k5/Q== X-Forwarded-Encrypted: i=1; AJvYcCWMF8cEHPhy3bWNnlH9pluHwQ9CGDXcepLPgWEssLCerbXx4gnMK/0MVS6Sh+sQL9KFbpB/6q+Yc1q1QPY=@vger.kernel.org X-Gm-Message-State: AOJu0YwsgKHpmh/1eb1sEEHlID2Io5SFJ51UuXOeFnG7eOmltMXJpBQo sBMQt+PqZ2U3x5gpVMbrugejxebbOVRHOM4/FnG99Zdto2z+Lw6Po6/F X-Gm-Gg: AZuq6aJO6+qgBO8yc7fP8x8lPjE2ohtb68CLzVhmQM51140w8ZXlsapZjZZfjtTT28X TfbGL22lnKlky3WnVVOQ6VkEkrLodMRvOmkiJPIoJnM67zBD6A4IP3rK6OZOv0K2yGH9JRCQLlU ibK6ZHz4SfYoWGdGuEEQe0Qvt/iNvhJmfq6koEsKGpy/27m2ItlhgcJNnF2NSqLR5m+FNusmjFt WO+wmFlg+fG2PUtkcaZYv8zf6XZ06Upnq9uz/Ih4npvjOXM9FczIm81MNqvwATt6llS89V6a8Lz Cx0b5N8/8xwt7eiTjJFeuZFOFi4C/xSbPYszFh6VS0ymLeXHVaoZhtHKM8r3ALjpRjCh3ZK5YNj rOEH55wBeN6yqIhSLonMWeiKrnRm/QrHF4MTb0lL27V5DpxNoyh3pVw1VIY2wNQ8ZqbUKXqxN75 aN3scYbGo/u2s/0qLO1SIzLxpN4fKrXxT07g2Emanw8Uo= X-Received: by 2002:a17:90b:3f85:b0:341:8b2b:43c with SMTP id 98e67ed59e1d1-3543b3d65e2mr13610103a91.18.1770093975751; Mon, 02 Feb 2026 20:46:15 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:e2db:5e08:8a06:99b5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfd8b7sm16029409b3a.31.2026.02.02.20.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 20:46:15 -0800 (PST) From: Chintan Patel To: neil.armstrong@linaro.org Cc: dianders@chromium.org, jesszhan0024@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chintan Patel Subject: [PATCH v2] drm/panel: jdi-lt070me05000: Use MIPI DSI multi functions Date: Mon, 2 Feb 2026 20:46:04 -0800 Message-ID: <20260203044605.5890-1-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert to the non-deprecated mipi_dsi_*_multi() helpers per the TODO list. This reduces boilerplate error checking while providing proper error accumulation. Use mipi_dsi_msleep() and mipi_dsi_usleep_range() macros for delays. Replace mdelay(10) and mdelay(20) with mipi_dsi_usleep_range() calls using tighter slop (10-11ms and 20-21ms respectively) since these functions aren't run often and don't need large timing windows. In jdi_panel_off(), reset the error context between display_off and enter_sleep_mode to preserve the original behavior of continuing power-down even if display_off fails. This ensures enter_sleep_mode executes before GPIO/regulator control, which is critical for proper power sequencing. Signed-off-by: Chintan Patel Reviewed-by: Douglas Anderson --- Changes in v2: - Replaced mdelay() with mipi_dsi_usleep_range() for timing (tighter bounds= per review) - Switched to mipi_dsi_generic_write_seq_multi() for cleaner varargs syntax - Applied lowercase hex notation per kernel style guide - Added error accumulator reset in jdi_panel_off() to preserve power-down b= ehavior - Kept final msleep(100) outside multi context for safety=20 .../gpu/drm/panel/panel-jdi-lt070me05000.c | 105 ++++-------------- 1 file changed, 24 insertions(+), 81 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/d= rm/panel/panel-jdi-lt070me05000.c index 3513e5c4dd8c..01bd748aecec 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -48,34 +48,16 @@ static inline struct jdi_panel *to_jdi_panel(struct drm= _panel *panel) static int jdi_panel_init(struct jdi_panel *jdi) { struct mipi_dsi_device *dsi =3D jdi->dsi; - struct device *dev =3D &jdi->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_soft_reset(dsi); - if (ret < 0) - return ret; - - usleep_range(10000, 20000); - - ret =3D mipi_dsi_dcs_set_pixel_format(dsi, MIPI_DCS_PIXEL_FMT_24BIT << 4); - if (ret < 0) { - dev_err(dev, "failed to set pixel format: %d\n", ret); - return ret; - } - - ret =3D mipi_dsi_dcs_set_column_address(dsi, 0, jdi->mode->hdisplay - 1); - if (ret < 0) { - dev_err(dev, "failed to set column address: %d\n", ret); - return ret; - } + mipi_dsi_dcs_soft_reset_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 10000, 20000); =20 - ret =3D mipi_dsi_dcs_set_page_address(dsi, 0, jdi->mode->vdisplay - 1); - if (ret < 0) { - dev_err(dev, "failed to set page address: %d\n", ret); - return ret; - } + mipi_dsi_dcs_set_pixel_format_multi(&dsi_ctx, MIPI_DCS_PIXEL_FMT_24BIT <<= 4); + mipi_dsi_dcs_set_column_address_multi(&dsi_ctx, 0, jdi->mode->hdisplay - = 1); + mipi_dsi_dcs_set_page_address_multi(&dsi_ctx, 0, jdi->mode->vdisplay - 1); =20 /* * BIT(5) BCTRL =3D 1 Backlight Control Block On, Brightness registers @@ -83,88 +65,49 @@ static int jdi_panel_init(struct jdi_panel *jdi) * BIT(3) BL =3D 1 Backlight Control On * BIT(2) DD =3D 0 Display Dimming is Off */ - ret =3D mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, - (u8[]){ 0x24 }, 1); - if (ret < 0) { - dev_err(dev, "failed to write control display: %d\n", ret); - return ret; - } + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 24); =20 /* CABC off */ - ret =3D mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_POWER_SAVE, - (u8[]){ 0x00 }, 1); - if (ret < 0) { - dev_err(dev, "failed to set cabc off: %d\n", ret); - return ret; - } + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 - ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi); - if (ret < 0) { - dev_err(dev, "failed to set exit sleep mode: %d\n", ret); - return ret; - } - - msleep(120); - - ret =3D mipi_dsi_generic_write(dsi, (u8[]){0xB0, 0x00}, 2); - if (ret < 0) { - dev_err(dev, "failed to set mcap: %d\n", ret); - return ret; - } + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - mdelay(10); + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x00); + mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); =20 /* Interface setting, video mode */ - ret =3D mipi_dsi_generic_write(dsi, (u8[]) - {0xB3, 0x26, 0x08, 0x00, 0x20, 0x00}, 6); - if (ret < 0) { - dev_err(dev, "failed to set display interface setting: %d\n" - , ret); - return ret; - } + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb3, 0x26, 0x08, 0x00, 0x20, = 0x00); + mipi_dsi_usleep_range(&dsi_ctx, 20000, 21000); =20 - mdelay(20); + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x03); =20 - ret =3D mipi_dsi_generic_write(dsi, (u8[]){0xB0, 0x03}, 2); - if (ret < 0) { - dev_err(dev, "failed to set default values for mcap: %d\n" - , ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } =20 static int jdi_panel_on(struct jdi_panel *jdi) { struct mipi_dsi_device *dsi =3D jdi->dsi; - struct device *dev =3D &jdi->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_on(dsi); - if (ret < 0) - dev_err(dev, "failed to set display on: %d\n", ret); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 - return ret; + return dsi_ctx.accum_err; } =20 static void jdi_panel_off(struct jdi_panel *jdi) { struct mipi_dsi_device *dsi =3D jdi->dsi; - struct device *dev =3D &jdi->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_off(dsi); - if (ret < 0) - dev_err(dev, "failed to set display off: %d\n", ret); - - ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi); - if (ret < 0) - dev_err(dev, "failed to enter sleep mode: %d\n", ret); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + /* Reset error to continue power-down even if display off failed */ + dsi_ctx.accum_err =3D 0; + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 msleep(100); } --=20 2.43.0