From nobody Sun Feb 8 04:30:52 2026 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970DB1DA23 for ; Tue, 3 Feb 2026 02:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770085871; cv=none; b=ETqc6eFWtQBCJRjZ7DHJVEKO3wPNqMwRh8+2v6Xgm3X37w+ylxapMhXbvh5Xhe7XZFEgRnfkblcNGjJHnQD/RM7oQNTmbE0L2t/arUIJ5dUhYlLIgx+hJAHihCJxtYMxGZj2dxFePynrwu9wrP+vp+vXKOWw/4hDyPzsyOklaYQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770085871; c=relaxed/simple; bh=j6LWf+0MXIjCfBKV4r6kpsoWtvKk71KwpFRmmyQhh8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hf+zzCT+11LjsLmUbV3OJYKOjO1cHLqkB0PA1lYtW0GgzCJSdUPXsm3JfOYxJRVx5siI8RXgzXm4IFboh1VpPPt7EIHmhdGdwthbu6/efpe2K9kIrOlup48RYWkfLFSsBIpBWb4m6fSIDBt53hG/Yo9P40uec2K+gZxDpnnrtgo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=I4aCH9Wy; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="I4aCH9Wy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1770085866; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=tbQPoE2XVu/mvdozBIom1TdUmcw2L7XVOJPqi8xiYqk=; b=I4aCH9WyH/uWAzOvvOEG5tCY+hCGhdgScmXexGsxOJYxAZPFgS9uaUFzVcjm9KF4/AxoO2HjxIJWwH7XsnUZELvJAspJYhqUtJ7US9tEFPvmjfQ1LA+l3wQ7fHAk78Twy3ojXW3yNgiNVAG/SqstbilfEA/BInhUj1YOyqwZpqE= Received: from x31i01179.sqa.na131.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WyRLuYU_1770085861 cluster:ay36) by smtp.aliyun-inc.com; Tue, 03 Feb 2026 10:31:05 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Cc: LKML , oliver.yang@linux.alibaba.com, Gao Xiang Subject: [PATCH v2] erofs: use inode_set_cached_link() Date: Tue, 3 Feb 2026 10:31:00 +0800 Message-ID: <20260203023100.459027-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20260128045854.2266287-1-hsiangkao@linux.alibaba.com> References: <20260128045854.2266287-1-hsiangkao@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Symlink lengths are now cached in in-memory inodes directly so that readlink can be sped up. Signed-off-by: Gao Xiang --- v2: - fix syzbot reports: https://syzkaller.appspot.com/bug?extid=3Dc2dd47dc153320cc4692 fs/erofs/inode.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index 2ecc28abd6cd..294f66376825 100644 --- a/fs/erofs/inode.c +++ b/fs/erofs/inode.c @@ -8,21 +8,29 @@ #include #include =20 -static int erofs_fill_symlink(struct inode *inode, void *kaddr, - unsigned int m_pofs) +static int erofs_fill_symlink(struct inode *inode, void *bptr, unsigned in= t ofs) { struct erofs_inode *vi =3D EROFS_I(inode); - loff_t off; - - m_pofs +=3D vi->xattr_isize; - /* check if it cannot be handled with fast symlink scheme */ - if (vi->datalayout !=3D EROFS_INODE_FLAT_INLINE || - check_add_overflow(m_pofs, inode->i_size, &off) || - off > i_blocksize(inode)) - return 0; - - inode->i_link =3D kmemdup_nul(kaddr + m_pofs, inode->i_size, GFP_KERNEL); - return inode->i_link ? 0 : -ENOMEM; + char *link; + loff_t end; + + ofs +=3D vi->xattr_isize; + /* check whether the symlink data is small enough to be inlined */ + if (vi->datalayout =3D=3D EROFS_INODE_FLAT_INLINE && + !check_add_overflow(ofs, inode->i_size, &end) && + end <=3D i_blocksize(inode)) { + link =3D kmemdup_nul(bptr + ofs, inode->i_size, GFP_KERNEL); + if (!link) + return -ENOMEM; + if (unlikely(!inode->i_size || strlen(link) !=3D inode->i_size)) { + erofs_err(inode->i_sb, "invalid fast symlink size %llu @ nid %llu", + inode->i_size | 0ULL, vi->nid); + kfree(link); + return -EFSCORRUPTED; + } + inode_set_cached_link(inode, link, inode->i_size); + } + return 0; } =20 static int erofs_read_inode(struct inode *inode) --=20 2.43.5