From nobody Sat Feb 7 05:44:08 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1602F29ACDB for ; Tue, 3 Feb 2026 02:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770085667; cv=none; b=C0Ue1OeCVC5Yib70HYyjeb7Gk2ubSDFtCo/AR3ang/UhLkrXkl1BxS4gQvOFfCltmUwNPWiJaV06ky0Qsd2bTTZMUdRxQ7Sd+jNAFB0TmDh5ibycjAFFJZJ55pnA00GJIA/OZ5paa6OvxmXz+/mXt6Mvk0swOkyxONUcBTqKL8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770085667; c=relaxed/simple; bh=iDp5mMQgomUSRM/dl6unR+hbY+tl/eiQXHNaSYMScqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FdXYcBYLGTkV4GnXPI+MEXPwGhdWo3wjx8FPuKIPrIoovWYuV6JJ/un923uj00RrGsvSJ+YFR7/7xvxarNVMtsi+oi6tclhWhDDIfnkldxKs6EKRt6JwhX3jsPkX/NP3fHI/nHqRg6pn31Ya3NvitbBf4P66aJSnUJV6+49xz+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AsQEScCG; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AsQEScCG" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8231061d234so4321037b3a.1 for ; Mon, 02 Feb 2026 18:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770085664; x=1770690464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UlSRLcIcWpZcJLzhBXNRpZvhO9QHJ8h5Vtb0I9fjCFA=; b=AsQEScCGz7dVyq6v6YvPhz8lXT35fZ/6g2l1/gVB+qLERMh884EDlP9YfhWqrbTyJV 5N7zL1TRuh8JI9VqBCk8W7TqZVfdSKpVO/YAdEmgS4NxDg/bR9McyP/Bl+BU9NlBKpQP it/q1WPAGfi4sx7BObReo/zwVMVfbtOLQyz/3eu3ireV/9Akc1UKMjsTAkat800xMpIL iycVV44QgULIYbEppljzQtR3Qhs9RLCxcwmquVEm+KRD8L27F15Ul8w2gNROs1C+CmAu L1kkIwH1y47wQsaI7WbQYgAo/GcVBE81pZHE/FXoeznTVkqnbnbf4AuMvabqlMwg309+ cQ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770085664; x=1770690464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UlSRLcIcWpZcJLzhBXNRpZvhO9QHJ8h5Vtb0I9fjCFA=; b=mwKgj+Z3dbVtKk0kQmpcSNoFXgvNzMlrPEnpbP8cYiG/vX1OplbXeJCWBOhsNWOfw9 NtTybZwOkdwxgtnt4CniVy3NEzpq1GPdZJJO7LZ34vUKH2cnLPYzIZuYdw9+soWBvXJV U8/n2j61cJQQcYfPf/I4vOuFFQodZLob4nZpk3izNt3kccq0HDMqXoQSwu3So7hxju4E 6zouG9SBcoMfkaQNOB5tbbv9OTgkfQEEzC1cGyfkImNK/Yo0HrroVozPyPcHMsW29ix5 PSVL7mGbN4yN9AE7tJjsa+bP7s5fmldOrIykUGH/uvl53MC5G+hArU9gLZXoiXXdHWw4 jnDQ== X-Gm-Message-State: AOJu0YzDEjNg/yvWFeX3mvjcD0qvF1ZlcRMEhKuTYdJc179rj1YSWW7e aCxaf53bDmNTpeT54iGdUR5TzrDwjD5D/R0+4Z185MrlPLq3rglNGqdP X-Gm-Gg: AZuq6aL4eQ964ufSAxJH4J7cK1/gRRDnz+LvyOs/F1/8wxeoHqUKTORe/iZUhDM9A3C usqXEMDlC+8coIh20mETFuYMtHiuqPbwnfxb4TKd7Y2NQMvMOKJOCnKHQyr7kZqLJFgv7nfvBLn SRTbRsneDZEOY7rRKd3euAtSnK4cHWVuUKNflNG7W2rvpbdvK17pDhGajlFMWuukNyeOXc1a0do Q62E8dw2QKyyM/Tu36qPk0cvmtkOxOuJAdaBeV2Qi2BFkvxXI7MA+3YHrk8ATFQEqmoLVTUznqB vAumaF+9uFYAozs7msvhoFIjAUsffv+JN+8GExjOkHnHMs55pJYarvzd3D/uuenbCdN/9CjyFIg iKadGwdahQi9Iw31CDTxTm1sxvvk0m9ibpsRV0j9TMq++9vOkfkPFJar8faNz3HkhXu53rgyTpo k8zd7ixKAF7nla1XpIyEzBKNvGGDwotNqg5kT4C7hxag== X-Received: by 2002:a05:6a00:4144:b0:81f:3eda:9d65 with SMTP id d2e1a72fcca58-823ab673221mr11716726b3a.18.1770085664078; Mon, 02 Feb 2026 18:27:44 -0800 (PST) Received: from localhost.localdomain ([116.128.244.171]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379b58f38sm17803073b3a.24.2026.02.02.18.27.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 02 Feb 2026 18:27:43 -0800 (PST) From: Chengkaitao To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, yangfeng@kylinos.cn, alexei.starovoitov@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Chengkaitao Com Subject: [PATCH v5 2/3] bpf/verifier: allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set Date: Tue, 3 Feb 2026 10:27:11 +0800 Message-ID: <20260203022712.99347-3-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260203022712.99347-1-pilgrimtao@gmail.com> References: <20260203022712.99347-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chengkaitao Com When traversing an rbtree using bpf_rbtree_left/right, if bpf_kptr_xchg is used to access the __kptr pointer contained in a node, it currently requires first removing the node with bpf_rbtree_remove and clearing the NON_OWN_REF flag, then re-adding the node to the original rbtree with bpf_rbtree_add after usage. This process significantly degrades rbtree traversal performance. The patch enables accessing __kptr pointers with the NON_OWN_REF flag set while holding the lock, eliminating the need for this remove-read-readd sequence. Signed-off-by: Chengkaitao Com Signed-off-by: Feng Yang --- kernel/bpf/verifier.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 05a6a6606b6c..bb3ff4bbb3a2 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9260,7 +9260,8 @@ static const struct bpf_reg_types timer_types =3D { .= types =3D { PTR_TO_MAP_VALUE } static const struct bpf_reg_types kptr_xchg_dest_types =3D { .types =3D { PTR_TO_MAP_VALUE, - PTR_TO_BTF_ID | MEM_ALLOC + PTR_TO_BTF_ID | MEM_ALLOC, + PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF } }; static const struct bpf_reg_types dynptr_types =3D { @@ -9420,6 +9421,7 @@ static int check_reg_type(struct bpf_verifier_env *en= v, u32 regno, } case PTR_TO_BTF_ID | MEM_ALLOC: case PTR_TO_BTF_ID | MEM_PERCPU | MEM_ALLOC: + case PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF: if (meta->func_id !=3D BPF_FUNC_spin_lock && meta->func_id !=3D BPF_FUNC= _spin_unlock && meta->func_id !=3D BPF_FUNC_kptr_xchg) { verifier_bug(env, "unimplemented handling of MEM_ALLOC"); --=20 2.50.1 (Apple Git-155)