From nobody Mon Feb 9 14:03:24 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6792F1FFE for ; Tue, 3 Feb 2026 02:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770084916; cv=none; b=h0jQsZ5R5YGdooc3QGJ7VtRdUfsMZg7CkkULzyBYigNsTjGyhCEXhEZ0qAQnE1fRJMNz/CiYjTykUiMCScH9KsAfnP85MaXFEwzsi7Qoc53BBXz5lWuB0zxv90CYPkCmCSaV0MSymryHjPFHaTrqjrC8u+wZmnk8mFaIEkl0f4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770084916; c=relaxed/simple; bh=v4uvtN3kEtHaSGwIA/Ac6etILfAKnwUA6PVgLjXtGSE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V6Yiu83k6GwcJY8IOKf/f6uQEdAz0XjTbHpj8RDEJzPLwsiUyCgV1iN2M5JETNDjO8Bvspt6Be1se1J3onfxToi4IN+hdwyx3iH4FBLwzVqtLnUaYJdqDSiHkd3kLNhSUV+1hif+t3bvqBzxhOH7kEJRyrHzP1glzMgzCLD6+Wo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dsE/FuiT; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dsE/FuiT" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8220bd582ddso2964200b3a.2 for ; Mon, 02 Feb 2026 18:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770084915; x=1770689715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KvpJFnejTXh/YO8agJdfgwPv43+krClG8TqDCYLuRPA=; b=dsE/FuiTlum5jFyZ1SxGzSS0hjsFUwygUw28x8IKXt1QqpGThjlodfZP6PFH88wS9q Z1dJa62ze1G7JSBtgB257ofGqjl7b6/wiEElDUkBIQWEW2+53PNuZxmq8Y3CVKtVpHHK f9y0b9xpMorXpD7ua0D1urGoifz2B0uhWsxCLcYveewQqsFeyQqcdPHgTsduTmwbIodV uIwcfmH1j2fasKcMXUt1ZyMcY3Fbcq8Q+9WrOzSq6OUDUZvQz+169RyBxOER+gBC35Np mCYlxfV9wUo+n5nqUQuEHS7hiieVOHZe+vTbCM4Gv3zm6VGYUURiw5//bzJLrLe/Ezo4 mK1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770084915; x=1770689715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KvpJFnejTXh/YO8agJdfgwPv43+krClG8TqDCYLuRPA=; b=p95iDjCrMZRYSOSqn562S+FCHj8fVWxMwuykolKlb99BWB8cj7Jd1GBXm5WxSZSmx5 b60mDIQJQ0M7Z6dpjZDBMQ5xsw5aUZB4YZKSX+mgeUpf42OssPxtSUrA+PZYg11MMrwX BNFQFU098WjbBsmZ/0EgAnSDL2c+M7hLS9Sg7WZ0k4nUvXhE3R7FFFkaJ/g6NgutDfxN E3kmAIv4sapZnzGshBF7PIw+xcUA9rFCpspbLoGGFvHdfcuJeJaj3XLMiWYssBbVp3FB dVDZQ7ZPqJxzAfEwjNeTlObbsfxb8r+4OoM7Y4HEP9puBDQ8ENwlxkVay7UQcChcdTBz pJmQ== X-Forwarded-Encrypted: i=1; AJvYcCVk3N4WQfMDoRHLNjvRyJUgtpe6ckFYE0ksFqdy7Fp6Mcy3M2rdrv8gZWx86SDqjYYz7zvLBx7jHXDXYPY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxse+ccX6o0lXs7sBy03wGzxbLSsgm3fQ5Fj/V4vvC7DrAVEQsc 6LINPdMPEjKNVjJ7U1+BIbdP8OjMSVbo7AReo2tsr4uXEV5/Yv9OSrcz X-Gm-Gg: AZuq6aJKvoFQKWDuCsF9r4NG17LryRM3QLmdxEoRI2AAjbc9lTWmaM3whh0nbrUqbI/ PbHUzRrsFmylIIkPPNAJez2DgTZkhNmmN+cf4JzgYv63w5hNjUnXyKqMo69BiCj8TGfMcfsM3PX 7dm4YerZ4vguce5tyL30e0Q/ih3gSkN5HkfFVfWukQdjbTpdLs5JEeBUA12n7tXtun6IC2axJcK 5p/rXSw+fd5BS/5EDvUyLHYr8f/Bz+NlZ8BedMdKoQ+cMdPbiPK6Qm3M88qfbez5e+OBZKDnjii PetGDcfsKCU8pHuxhVhz5im95VwcL9lKlIQIGUZAu3UxGvz6hf8bIPtG25Ku3RUbC4hykdVRDyl bvawsG19n1LFrrOmRxKlCbi7ecRIP1OOZDpVt1wYyhsMkSsW4+XTVa2uoiBPzTTj9Qaqi1wp2Qt FI/GmtM2eKXy1PydF24QrHBc/qcgMlpg7iFQ== X-Received: by 2002:a05:6a00:3d4f:b0:7ff:ecbb:1c28 with SMTP id d2e1a72fcca58-823aa6aaae6mr12964262b3a.16.1770084914665; Mon, 02 Feb 2026 18:15:14 -0800 (PST) Received: from twhmp6px (mxsmtp211.mxic.com.tw. [211.75.127.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379b4a29esm22368170b3a.17.2026.02.02.18.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 18:15:14 -0800 (PST) Received: from hqs-appsw-a2o.mp600.macronix.com (unknown [172.17.236.67]) by twhmp6px (Postfix) with ESMTPS id 306FF4136075; Tue, 3 Feb 2026 10:15:12 +0800 (CST) From: Cheng Ming Lin To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , Tudor Ambarus , Martin Kurbanov , Mikhail Kshevetskiy , Pratyush Yadav , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, Cheng Ming Lin Subject: [PATCH v4 2/2] mtd: spi-nand: macronix: Enable randomizer support Date: Tue, 3 Feb 2026 10:13:58 +0800 Message-Id: <20260203021358.693291-3-linchengming884@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260203021358.693291-1-linchengming884@gmail.com> References: <20260203021358.693291-1-linchengming884@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cheng Ming Lin Implement the 'set_randomizer' callback for Macronix SPI NAND chips. This feature is controlled via the "mxic,randomizer-enable" device tree property. The randomizer is enabled by setting bit 1 of the Configuration Register (address 0x10). This patch adds support for the following chips: - MX35LFxG24AD series - MX35UFxG24AD series When the randomizer is enabled, data is scrambled internally during program operations and automatically descrambled during read operations. This helps reduce bit errors caused by program disturbance. Signed-off-by: Cheng Ming Lin --- drivers/mtd/nand/spi/macronix.c | 47 ++++++++++++++++++++++++++------- 1 file changed, 37 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macroni= x.c index edf63b9996cf..0212d44b1a3f 100644 --- a/drivers/mtd/nand/spi/macronix.c +++ b/drivers/mtd/nand/spi/macronix.c @@ -14,6 +14,8 @@ #define MACRONIX_ECCSR_BF_LAST_PAGE(eccsr) FIELD_GET(GENMASK(3, 0), eccsr) #define MACRONIX_ECCSR_BF_ACCUMULATED_PAGES(eccsr) FIELD_GET(GENMASK(7, 4)= , eccsr) #define MACRONIX_CFG_CONT_READ BIT(2) +#define MACRONIX_CFG_RANDOMIZER_EN BIT(1) +#define MACRONIX_FEATURE_ADDR_RANDOMIZER 0x10 #define MACRONIX_FEATURE_ADDR_READ_RETRY 0x70 #define MACRONIX_NUM_READ_RETRY_MODES 5 =20 @@ -155,6 +157,21 @@ static int macronix_set_read_retry(struct spinand_devi= ce *spinand, return spi_mem_exec_op(spinand->spimem, &op); } =20 +static int macronix_set_randomizer(struct spinand_device *spinand, bool en= able) +{ + struct device_node *np =3D spinand->spimem->spi->dev.of_node; + int ret; + + if (of_property_read_bool(np, "mxic,randomizer-enable")) { + ret =3D spinand_write_reg_op(spinand, MACRONIX_FEATURE_ADDR_RANDOMIZER, + enable ? MACRONIX_CFG_RANDOMIZER_EN : 0); + if (ret) + return ret; + } + + return 0; +} + static const struct spinand_info macronix_spinand_table[] =3D { SPINAND_INFO("MX35LF1GE4AB", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x12), @@ -213,7 +230,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_QE_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF2G24AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x24, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), @@ -225,7 +243,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_PROG_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF2G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x64, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), @@ -236,7 +255,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_QE_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF4G24AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x35, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 2, 1, 1), @@ -248,7 +268,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_PROG_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF4G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x75, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), @@ -259,7 +280,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_QE_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX31LF1GE4BC", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e), NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1), @@ -305,7 +327,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF4G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xf5, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), @@ -317,7 +340,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF4GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xb7, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), @@ -355,7 +379,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF2G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xe4, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), @@ -367,7 +392,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF2GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xa6, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), @@ -413,7 +439,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF1GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x96, 0x03), NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1), --=20 2.25.1