From nobody Tue Feb 10 03:37:55 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ABCF366803 for ; Tue, 3 Feb 2026 18:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770144132; cv=none; b=H692LwOD69fpgKa7q/N9xxCE4va4zCPD5CABQLGs2ywrn50zWFWIZKyKmTgzsB5WCljXP1Jnfb0TgyMT/wsca1irnyUFOF/zhQzkr/lh903XtIdHJctz0Sw+Z4wx779PZPsHTzwZsFWarvcsrkW9+0YpnjqkW1qziI6xD8lMaP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770144132; c=relaxed/simple; bh=BLWs61GCfo1s83BYplKIk5R6XzcPP/MZOpccHPKGpKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=drJhZSfy7q2wYc9lfENyzXrx2BoYPw0z5szq9MuGr22KUC+Ll0mwPi4z2plmAGs0hH+tQDkx5uaWBPbSgjyR8C33Yp0/S8p21YnjjeJ8026/uctUWSS5MPDLmdBiHhAk9cs0nEtYIavWSemue3vvLaKJWv1eCR1Fp0sNDLauZ1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=TmLiUMq0; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="TmLiUMq0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770144126; bh=BLWs61GCfo1s83BYplKIk5R6XzcPP/MZOpccHPKGpKE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TmLiUMq0xWsF0E9+PlQjpTeSBVcfz2AR/Z5G2scYYALnGwZWRbF3NDCkmvXkTvkDo QlSp4nIxoxlhdjpGLAw5yJrUcnoXB4UYvydpbn5NfTzvLtijbGNVEmvLsxnfzUlbD6 2aFzva97+X2xEpUx80XYuBf6HwWRqd7+yeJGdogyNBWL6mAtmdDfBQjE+MdDYJ0qvi ZgnFuPTj0anBcf1/8YyNEnskJ44VY3QmWlsGBUDDvjkzszOeruNFeTKgyt4oEj848H SC1phQ19TgdcdA4HfZG27kYTUBcWt1djSrqmcuKa2EAR6nDJjsI0DrxrLIZyVzcEIJ wN3QKevK6qHhg== Received: from jupiter.universe (dyndsl-091-248-189-143.ewe-ip-backbone.de [91.248.189.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id D5C2817E14F2; Tue, 3 Feb 2026 19:42:05 +0100 (CET) Received: by jupiter.universe (Postfix, from userid 1000) id 50CAC48002B; Tue, 03 Feb 2026 19:42:05 +0100 (CET) From: Sebastian Reichel Date: Tue, 03 Feb 2026 19:41:32 +0100 Subject: [PATCH 6/7] phy: rockchip: usbdp: Use FIELD_PREP_WM16_CONST Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260203-rockchip-usbdp-cleanup-v1-6-16a6f92ed176@collabora.com> References: <20260203-rockchip-usbdp-cleanup-v1-0-16a6f92ed176@collabora.com> In-Reply-To: <20260203-rockchip-usbdp-cleanup-v1-0-16a6f92ed176@collabora.com> To: Vinod Koul , Neil Armstrong , Heiko Stuebner Cc: Andy Yan , Yubing Zhang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1489; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=BLWs61GCfo1s83BYplKIk5R6XzcPP/MZOpccHPKGpKE=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGmCQX3MUc2X1aPba3TUi9akL8o1eyn++X8TZ sB4R0CPwVLu/YkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJpgkF9AAoJENju1/PI O/qaSc0QAJ2khlQq0jpo1gYronwaW4JYd4EpzVPJ4b+2HnQkpKvbgjABBbm/zmh61n8+aPvCh+i PfmE9NY8o1/PIOy2Cy0P3qoa/ZBkvMpGVWP0AZBCaX1SRJH9HBVgKEXzbPIoVUJQbGWNwTrH/SP iC1R1jDQzWWhlfMR2hYLbigEIYDpjmG8G2lf6ceNOG95OvQggazuOWJSXRwVIqnfg68tdmRchxX 8JfCZbtx3AKW7KZpeD3ijJI0UzTS9e6aBwExKcWhhyPgY0TrfDpLEGTZEuq8XCBnVlGohgvBnFw XV7SzzAcV7CxcDUJWMsl7g+Ci5/IuMr7oaCKNpxHZ3yBqmDoXQcu6MQWhBtksleN29zgN4pFNod RX60BISHWIQdQsiZHbYT7bGDiEM/MK7rdiYmEFw5U7PjnNLadeZRbXpjq/EtrsgO7+y6QLY0NHG sscrrCrx3uX0n7pGgyS1c3FO4wpYlqVsDB9km7JcYxcGhSoMd9RAQ6sqOSV5uWBJ3zR362xOPuC 78Esf8oCc1IjD/lqjPxOeAckwJtpknHfdzsx9vKXQq8tDkuMiiSob9Stj0PuJind045uKz/IXAQ nxhsJ4SATg4+q5+uyKFGFJUudEmRhtM1qEdhgIl9gvVxJOfHlFdlRRtnxGC4IraS3/T31NVAbwq 5JlUeO/0ljMMcvLt5OfsoQQ== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A Cleanup code by replacing open-coded version of FIELD_PREP_WM16_CONST with the existing helper macro. Signed-off-by: Sebastian Reichel --- drivers/phy/rockchip/phy-rockchip-usbdp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockch= ip/phy-rockchip-usbdp.c index 4388105dd8ce..9291f56120f1 100644 --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -75,7 +76,6 @@ #define TRSV_LN2_MON_RX_CDR_DONE_OFFSET 0x1b84 /* trsv_reg06E1 */ #define TRSV_LN2_MON_RX_CDR_LOCK_DONE BIT(0) =20 -#define BIT_WRITEABLE_SHIFT 16 #define PHY_AUX_DP_DATA_POL_NORMAL 0 #define PHY_AUX_DP_DATA_POL_INVERT 1 #define PHY_LANE_MUX_USB 0 @@ -104,8 +104,8 @@ struct rk_udphy_grf_reg { #define _RK_UDPHY_GEN_GRF_REG(offset, mask, disable, enable) \ {\ offset, \ - FIELD_PREP_CONST(mask, disable) | (mask << BIT_WRITEABLE_SHIFT), \ - FIELD_PREP_CONST(mask, enable) | (mask << BIT_WRITEABLE_SHIFT), \ + FIELD_PREP_WM16_CONST(mask, disable), \ + FIELD_PREP_WM16_CONST(mask, enable), \ } =20 #define RK_UDPHY_GEN_GRF_REG(offset, bitend, bitstart, disable, enable) \ --=20 2.51.0